From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 64BA5C369D5 for ; Mon, 28 Apr 2025 23:08:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0AAFD6B000A; Mon, 28 Apr 2025 19:08:19 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 030FC6B000C; Mon, 28 Apr 2025 19:08:18 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E14DD6B000E; Mon, 28 Apr 2025 19:08:18 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id BDBEA6B000A for ; Mon, 28 Apr 2025 19:08:18 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id E11AFBCE96 for ; Mon, 28 Apr 2025 23:08:19 +0000 (UTC) X-FDA: 83384993118.07.39E9BBE Received: from tor.source.kernel.org (tor.source.kernel.org [172.105.4.254]) by imf28.hostedemail.com (Postfix) with ESMTP id 2F61EC0007 for ; Mon, 28 Apr 2025 23:08:18 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=KhpSKhcJ; dmarc=none; spf=pass (imf28.hostedemail.com: domain of akpm@linux-foundation.org designates 172.105.4.254 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1745881698; a=rsa-sha256; cv=none; b=HLvRP7WXL1vSGzW9C1yhSo7HAUqXZrvYU/GM/XijkLXv0nhMEmFxr/2dALREufTofvF2ok ozFIXEd2G5T93MbCjgWtkh+w6dmxCkX+G7sdZ92n0LhtF4fwTte3yhhv114Goa2j0atppu OA9WQ4qyvRm8r0NtAuodsyIuDbL8dVY= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=KhpSKhcJ; dmarc=none; spf=pass (imf28.hostedemail.com: domain of akpm@linux-foundation.org designates 172.105.4.254 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1745881698; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=S8gZFJ7FEtjIPhQpM0u/gbLJzJBg7+IoysYLoqSKzLg=; b=ilmOIUX4XVI0d7CLIpr43stbQwCfX/W7fQJ+EMEbcwjSfqlvdNiIu3m6X6rt+lULMopmGf AtNFCmbMGq6WKLJl3TI/tbLUoqnW9TY8TP40GaieZKNd108pRMDHoNbN+9kNLgm8jZdC12 emaLlw7eAJ4LrqOE8fE2Uqd5fmEkhYM= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by tor.source.kernel.org (Postfix) with ESMTP id 29831614AE; Mon, 28 Apr 2025 23:07:52 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B5C0FC4CEE4; Mon, 28 Apr 2025 23:08:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1745881697; bh=cyGaRLUbBPhSr+SqUrBD2v7h/JKFq6eNGXZvwINMlNU=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=KhpSKhcJ6mRifNfGmUMNN/Xv9rawRjL5CiC/TvEkCv8U99vzeBex+4s2mQR+qoxmt U7dE1FpvJ+Ue2kF5pT0SQOA6MBjVt3Ygzy1TuhnITVV26a6PjFCRT5nxdwyj2ynMYy jdsHtR7f0vVJIXPsR5wxrxqNrsl620eSlGQssI9g= Date: Mon, 28 Apr 2025 16:08:16 -0700 From: Andrew Morton To: Lorenzo Stoakes Cc: Suren Baghdasaryan , "Liam R. Howlett" , Vlastimil Babka , Jann Horn , Pedro Falcato , David Hildenbrand , Kees Cook , Alexander Viro , Christian Brauner , Jan Kara , linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 1/4] mm: establish mm/vma_exec.c for shared exec/mm VMA functionality Message-Id: <20250428160816.3a22676dacd34055fd2568b7@linux-foundation.org> In-Reply-To: <80f0d0c6-0b68-47f9-ab78-0ab7f74677fc@lucifer.local> References: <91f2cee8f17d65214a9d83abb7011aa15f1ea690.1745853549.git.lorenzo.stoakes@oracle.com> <80f0d0c6-0b68-47f9-ab78-0ab7f74677fc@lucifer.local> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: 2F61EC0007 X-Stat-Signature: yq1tocp6qmmmp7qdwwk34adytf4wq1yp X-Rspam-User: X-HE-Tag: 1745881698-914795 X-HE-Meta: U2FsdGVkX19uufQSiufJC0iJp5R6Lzv/kSUV6AFXS2YKYKXSlgWDp9x1J9fi8C5I7MPCDrnOHB957muO3/oNur86/JY8ZVrQTfFRetTx1Ai5Prh3YNMPCe8RCjL7lC6au+5NyL5ABjUWzjCiVyQvCCLekQ25OB1E9jEAf4BtN4IXNNsZU+vwli3h/Wm3kgbmr8FB4E8mCNpf/ZskD9J20/e/0FSraj2GOcVG3C/ry7qt8tMOg26ilIKqZ/N/T2fr4bI+UKOp98XsVxjXj/E0qbjagR+hrQLtTGp1XJiPcYqTz4QQFJFQErHNhzMeIvrN/scDsIWdbdzYbeVfyanejFjLLfjC8cDP/5nULynno4m5CazPLhuVNFeY6+ygeCvJq1xPR9Gb3C8WNrYP41Bpjh5zPQrbPsaUzcfykTtek3IfTu+LgGc/4txOqHKXW1Yw07zo3ZIAAbqE7TUQhDPCKdprRwZMlF2NAgJa6MuutF1FA6zO09IQIwn6ulue3dNfxUyGhvMOnP0LOuu6TS/5NZrhOwcc1+/2TIgfHXrXSQXd2mZjOqXmT/xbnDs4NltJHDbXwSLXDHmvh75+p3ubW7Ct0SWLVTWpilcJ94/HyPKlOBVO466tk2ZeaHa4DZGmLkzLJcBvDjm2+KgkEIKuXbiV5i/+yNCxLzYdY25B58AqeBejylLUzW/fkbNNUFEijnEIcGltBhKM5ieVVCraGrawBwY3N7fuPYDTvP0Bss2ort2TYlgN9E9rTQCe9+lor8AIAW94CalEFQOYMvFkLxx0ViUGCi/3JbzckqMNbDUg+iiBdUO5KBxISaugWrWWLFECsMmlytDPDnFoPYXsJnd8WVW6fYp0+3ITBg8u4q9HfW6kZnHheLoqXxGrJGmnn6uG/mXB6F6jnW7znVQ9Rn6CnalUUBp1d76UOqwzl5mIy5y5roTVpzkokWA2KFdHgSBHIJgYTBw57NCnbZU pQ/DS/f7 u8ZXH+t5TYBRmJJ6kEaF6oU41S1MnU/nn2qoGOc4Hqay6UPy60HPB9cFrOQwFDsxyB41uib//4dqFXKqK4tIfZrWgFeTI20zKQ+h+lAPO/zp1J60FxEvW61Xv6voFOL+p1CUIYC6Mw1p8Swghr2nRcozpcJ4OEYv1mYeTl4XBCwLmoM36Qk0p1ZfNSEstu+B74RQwF6ejjZSYnP+4O8USCjoumUbw+cgl6oq2YFFnQ+HalJ5bRyvyZOrp+H4OI66bncG7uUnfFxTAwdveK4979GY6GsgoRhneLXeK8srOLwSamce9lRHISkzxjktyJzG+Nu3S X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, 28 Apr 2025 21:26:29 +0100 Lorenzo Stoakes wrote: > Andrew - I typo'd /* vma_exec.h */ below in the change to mm/vma.h - would it be > possible to correct to vma_exec.c, or would a fixpatch make life easier? > I did this: --- a/mm/vma.h~mm-establish-mm-vma_execc-for-shared-exec-mm-vma-functionality-fix +++ a/mm/vma.h @@ -548,7 +548,7 @@ int expand_downwards(struct vm_area_stru int __vm_munmap(unsigned long start, size_t len, bool unlock); -/* vma_exec.h */ +/* vma_exec.c */ #ifdef CONFIG_MMU int relocate_vma_down(struct vm_area_struct *vma, unsigned long shift); #endif _