From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AD738C369C2 for ; Mon, 28 Apr 2025 03:36:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 961A16B000A; Sun, 27 Apr 2025 23:36:42 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 909206B000C; Sun, 27 Apr 2025 23:36:42 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 781A46B000D; Sun, 27 Apr 2025 23:36:42 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 55AA66B000A for ; Sun, 27 Apr 2025 23:36:42 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 13135BC08A for ; Mon, 28 Apr 2025 03:36:42 +0000 (UTC) X-FDA: 83382040644.24.D770CE9 Received: from out-189.mta1.migadu.com (out-189.mta1.migadu.com [95.215.58.189]) by imf29.hostedemail.com (Postfix) with ESMTP id 616DD120003 for ; Mon, 28 Apr 2025 03:36:40 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=dygpIniM; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf29.hostedemail.com: domain of roman.gushchin@linux.dev designates 95.215.58.189 as permitted sender) smtp.mailfrom=roman.gushchin@linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1745811400; a=rsa-sha256; cv=none; b=8IiaXfsvAdK52ZUMkq5p72dl5hyT9BCuOWSCXEdJmrqBkNClO7mqYOwKxcKbsBbDfz5YL4 76WyXjtDgkODPVZroT0EPKqOtok7n8KP7SKtQZrSjcvvsI/zm4lRQ8RBq5VSENvg+kyLWa PXNRBWLA96W2xvN8QBGtEpQfvNy2nuU= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=dygpIniM; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf29.hostedemail.com: domain of roman.gushchin@linux.dev designates 95.215.58.189 as permitted sender) smtp.mailfrom=roman.gushchin@linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1745811400; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=dQGxdvGT6JUQEBkk90cx9D02VWeJqf+rh/ZdIhrKaXY=; b=be8Fwx6SRKkzzJKQPGEontZuQq5ELPq5MeTmQRFi8KlaH69waaFA2t8VHcar6qiUPZ5/6j am6HthY6CNQatyTmKa6uABGMEDXzBQhhm7g0AGRdfQuJbNg6UL1UZ3EcdGhKftmlcTnO9T zPJLuVCzuBRP+2Y0z7qMnFq2+ss7o2E= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1745811398; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=dQGxdvGT6JUQEBkk90cx9D02VWeJqf+rh/ZdIhrKaXY=; b=dygpIniMefoq4jZCfd010aoExiKB9GnWfMLUmOO4XeAp2wa9ymmL7HiLJo0/JdjtYNsIss +dcL75/+JuBbYlv56lbx/GalFSwZGuY/9SY2yPHoXok1nJgtRmCFY3836KmJ1HRQg76nkO CgIlBVTGbZHsNtf3WEx0fJZw2Ayn4QY= From: Roman Gushchin To: linux-kernel@vger.kernel.org Cc: Andrew Morton , Alexei Starovoitov , Johannes Weiner , Michal Hocko , Shakeel Butt , Suren Baghdasaryan , David Rientjes , Josh Don , Chuyi Zhou , cgroups@vger.kernel.org, linux-mm@kvack.org, bpf@vger.kernel.org, Roman Gushchin Subject: [PATCH rfc 02/12] bpf: mark struct oom_control's memcg field as TRUSTED_OR_NULL Date: Mon, 28 Apr 2025 03:36:07 +0000 Message-ID: <20250428033617.3797686-3-roman.gushchin@linux.dev> In-Reply-To: <20250428033617.3797686-1-roman.gushchin@linux.dev> References: <20250428033617.3797686-1-roman.gushchin@linux.dev> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Migadu-Flow: FLOW_OUT X-Rspamd-Queue-Id: 616DD120003 X-Rspam-User: X-Rspamd-Server: rspam07 X-Stat-Signature: fcgr8ngnb5djebkmtymegt9cmcgkpkjq X-HE-Tag: 1745811400-217400 X-HE-Meta: U2FsdGVkX18IOohnlC3KDrChbjEZp7QdPaPcHv/g+ejiW8yfUvhn8lYWeumXXJKS+RlXcoXS6EgwBzy011cn5/uA5P04zs/EZxyGgh5aQq/beTyB2dBMktc6BozfkeoX9tTtZV1h4E/jGkfmlHExsR103VPwXgFyMOgfxHVrtCSnXDz9MZx9rHdwHg14RnfgZkVe3/VFUqfs70AY7Mkgq+8DFw7FrmR75WnnBXzXp1aEYSPz3oRVL7HQYyGqCrkXGGeYt4FdcK8RK7V0FWnz8DQxKstQ7FEyQZaGxfC37CyfFtFNg0ysL0hl7qVw61ymj2dWIdcBBjxb5rW/kbJrVVaEE69drnIU5Z3fUEoKwChwBh/24TIp7IGgmJpFljMwZdyhAzOCfZ5dcGbQCjyQK4alxEsUmKmfTqUkSfEhdtemOIGrNFIPrc7EcyG3LFXVEqAO8wt9bXlVSlQKuM2Up7+bmv0QG3Fu8RHb2nWzZYqycG49HYWiJU0YHE+t/wrw3bB63VW1B8lM6jfdcuhtaCajUM7+c7cAwUin/ADhrdSz17nVyxd8+etKkvCY2Lkjm2wk8jYRY5nhFJdRfkpXa2+MPjtx1+P+aNrwIuV/cT6k5pZzrnRTjOL61tSIgbhrXKWc9xqjF4Iz4sQu6d6ys85i0zXrRCUjL/lQLH4RMtnOokVBY5ir1L6TrKSmK+qeZicucFCoC/1H+o+6iMJ9JDKVe3WQkTiw++eKexVgzo7P/itZSOu+G8mdjoEW7x0vxl7s1ZTOYwDyhY08hajyCfY/7id+FPEjNnnHYXm/YUeq0frPQhtiSXGE6to0DduDFrVWWyX1Wkmj3Fci4TMLx0PGhDSiHUZ+wiIhKYdV94fY2O/cOpyVy4cH9Z/kbNFb+MWRwQwcwOoh+aDGq8DmF+6gqaq/qVfyAz7qpc7o6cgG3G/IVDZIAXYzbnQ3u06ltu1ggk+7XBydGbr+7YM +DuBJmqS mlih9XHY9BZvQfSq34ChZFCAUpoP5n44qQdbndhWmC/L/odxF9Vp/h2XP/dFCNRZAdq9t9kmUoXloNdoX6Knqad6DF3wOjsZQB69My3yTV0CgCKGWtlwZD/aQwnjDNedjUXAUMsLP1NCm2AAU59BLoiUzA4gnoxWqGx9szq7vSmunuDCGlBOp7W9giFvun56idR6kltw32Jq9H5uQlcE0jDQtUwpN0pqr3wUg X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Struct oom_control is used to describe the OOM context. It's memcg field defines the scope of OOM: it's NULL for global OOMs and a valid memcg pointer for memcg-scoped OOMs. Teach bpf verifier to recognize it as trusted or NULL pointer. It will provide the bpf OOM handler a trusted memcg pointer, which for example is required for iterating the memcg's subtree. Signed-off-by: Roman Gushchin --- kernel/bpf/verifier.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/kernel/bpf/verifier.c b/kernel/bpf/verifier.c index 54c6953a8b84..d2d9f9b87065 100644 --- a/kernel/bpf/verifier.c +++ b/kernel/bpf/verifier.c @@ -7047,6 +7047,10 @@ BTF_TYPE_SAFE_TRUSTED_OR_NULL(struct socket) { struct sock *sk; }; +BTF_TYPE_SAFE_TRUSTED_OR_NULL(struct oom_control) { + struct mem_cgroup *memcg; +}; + static bool type_is_rcu(struct bpf_verifier_env *env, struct bpf_reg_state *reg, const char *field_name, u32 btf_id) @@ -7087,6 +7091,7 @@ static bool type_is_trusted_or_null(struct bpf_verifier_env *env, const char *field_name, u32 btf_id) { BTF_TYPE_EMIT(BTF_TYPE_SAFE_TRUSTED_OR_NULL(struct socket)); + BTF_TYPE_EMIT(BTF_TYPE_SAFE_TRUSTED_OR_NULL(struct oom_control)); return btf_nested_type_is_trusted(&env->log, reg, field_name, btf_id, "__safe_trusted_or_null"); -- 2.49.0.901.g37484f566f-goog