From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 61346C36005 for ; Mon, 28 Apr 2025 09:27:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6E7346B00A9; Mon, 28 Apr 2025 05:27:20 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 66DD96B00AC; Mon, 28 Apr 2025 05:27:20 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4E9406B00B0; Mon, 28 Apr 2025 05:27:20 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 2FD7E6B00A9 for ; Mon, 28 Apr 2025 05:27:20 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 3099E1CB11A for ; Mon, 28 Apr 2025 09:27:20 +0000 (UTC) X-FDA: 83382924240.21.6659A74 Received: from sea.source.kernel.org (sea.source.kernel.org [172.234.252.31]) by imf11.hostedemail.com (Postfix) with ESMTP id 7641040003 for ; Mon, 28 Apr 2025 09:27:18 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=pgW8Tc3B; dmarc=none; spf=pass (imf11.hostedemail.com: domain of akpm@linux-foundation.org designates 172.234.252.31 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1745832438; a=rsa-sha256; cv=none; b=wUsfuosABaeiyyBcWbeOtzxEJXmOLKk8vCC1UQw1cupDnrf/ihpt4+VgqzTOc+gRUvo9aO Qd2CqzxpV5vw2meyQaIxMYy4Z1RX1PC2y0Qh3pLGbsZqhF6qPxGX6xf4zSCYZEGXFES/OO zgNRY0KmbJ13cZr531zGRzz8ajwBQgE= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=pgW8Tc3B; dmarc=none; spf=pass (imf11.hostedemail.com: domain of akpm@linux-foundation.org designates 172.234.252.31 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1745832438; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=yLkfnghZW73yJavgBtMOXGnuaNSCu8IMukLTl6Ksc/Y=; b=TPeBo/3rd62/+RqCOyRsA7a7HMlh+1ZIJLy+zdZs6wSi5kVFG4/psZ+vqVIriMk+tvtQZ9 Bni684z12mkJ2MD1D+pZ44mMo5XKxnhqyT0Q++zsCWKz4p/s2kjMUCyqgQ/nqf0rhqbkz4 wD121fK0B8XwUe37xtV+poDdy+oWEs0= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id 37F2D44790; Mon, 28 Apr 2025 09:27:15 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D4123C4CEE9; Mon, 28 Apr 2025 09:27:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1745832437; bh=UVd/rZR8AOYdXyQtZJAfNFYpT83jERDleZoZwn1jpHI=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=pgW8Tc3Blxaz/ouF3jFGGuHxZnfmv5VdmsIFhZq7gRB/LI9sACW5nzH4FwIpgNAUc cLeQv6K4j+6zt45EM7nSYHaVUKyROi5gR/MiMvNrEbsU8OjEIP1DlQEEDdDYg2Rftj 1qaIWmKL1X+NcIPg/8HrWBjXNFgVNzD/uXTmo+gs= Date: Mon, 28 Apr 2025 02:27:16 -0700 From: Andrew Morton To: Igor Belousov Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, hannes@cmpxchg.org, minchan@kernel.org, nphamcs@gmail.com, senozhatsky@chromium.org, shakeel.butt@linux.dev, yosry.ahmed@linux.dev Subject: Re: [PATCH mm-new] mm/zblock: avoid failing the build Message-Id: <20250428022716.99ee57590fe7878dccfaa6a0@linux-foundation.org> In-Reply-To: <20250428065727.57990-1-igor.b@beldev.am> References: <20250428065727.57990-1-igor.b@beldev.am> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Queue-Id: 7641040003 X-Rspamd-Server: rspam04 X-Stat-Signature: 9jnftifcwb8rtzmskq3jgho1q69sp3jo X-HE-Tag: 1745832438-610157 X-HE-Meta: U2FsdGVkX1//6nyHHnMMMmTWwZXq7zOM36REwSQMHtspc77ljCv+pBLgEFRFj3hCE1mrnUELa1QNcE6Z9doP/MIkLUXWSS2ZIAHZs4gISAo3QULoMN56HKrTCnNx06j1xOTHQ/FFUuk++FrkgxC4g4w7QFhXC/nZtfTDeUSckFGBGxQUM4EwBnmwrjtFkToyMFRKdUnMt0JnbnZsnWZ1YK8s4yWB5Q4ptjOUiOAfVDfeJEiGIaDJqq7qcgTdgyivvBULTJVGQecMtFSqaAWf2C/WI4I7cCTfpUROA8hr7pE10M08H39u6VJtVfedy77ToX0NSn7cDyF859c/8xTYjDm/ZtusZfeQIOqLJxBDi05QWtujx6EiCfsiUDytDG2c9jgOlbZd3FzY+eyyEXDciwu0YcuAwAdNxI3OQ5QZ+Z/2KR9EwJz4rF7mgUIpf0eqW06fEtg2rFExWQRGQqnHLEgzSDWLnRvAZs5yhbRDY4YcrlcTUPdIJCRSd39HYth6ZyKgmRhh8GYLh2739V5osY36WhALI7BtgWiXomthebF/Wqb/AGRjWi2ckWtkVYSwRVfM6OlDbVzygFa+2B4WB6vN54KSpmUSckfJC8g4aw8vv4zmWzZsUX7cf+oWbpxRC0zoA0yNQCHpzuDIacgGkqkLyxnbrwZuWl2ZChLdX0ghAg/RUqMdTvjCNyMsXkakWi3EWUj/AoXIwHsjqF6NF+Vk1alr/6+zih1ZQ/Mm5soW9CnF9gLfKwURWh3HXlw9XlVfQKFobH2bu0baNarSWOpjojJtiblYJPI2IucRpcSGtaW7YzAlO1+5ruU/DdOlTtbCYxmY6aPIL/LAqA9I4OD6OfH2sTZof0wRyygCJXDT2mXTZib+rdTDlj22rfcZK+AbwJoDT0RcW9wn5ulDfT3U0UlQFG39FeUQYRaAQQ0= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, 28 Apr 2025 08:57:27 +0200 Igor Belousov wrote: > Don't break the build for a PAGE_SIZE that is not fully supported, > just print out a warning in that case. > I queued these two patches and this fix: --- a/mm/zblock.h~mm-zblock-avoid-failing-the-build-fix +++ a/mm/zblock.h @@ -21,7 +21,7 @@ /* max 256 slots per block, max table size 64 */ #define SLOT_BITS 8 #else -#warn This PAGE_SIZE is not quite supported yet +#warning This PAGE_SIZE is not quite supported yet #define SLOT_BITS 8 #endif But please be aware that I consider the zblock zeries to be stuck until there is clarity that zblock is something we should add to Linux. Let's continue to address this in the main thread(s), please. Or perhaps to restart things, do a full resend after having reworked the [0/N] changelog to fully address the issues which have thus far been raised. And Cc'ing the various individuals who have thus far commented. Thanks.