From: Andrew Morton <akpm@linux-foundation.org>
To: Igor Belousov <igor.b@beldev.am>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
hannes@cmpxchg.org, minchan@kernel.org, nphamcs@gmail.com,
senozhatsky@chromium.org, shakeel.butt@linux.dev,
yosry.ahmed@linux.dev
Subject: Re: [PATCH mm-new] mm/zblock: avoid failing the build
Date: Mon, 28 Apr 2025 02:27:16 -0700 [thread overview]
Message-ID: <20250428022716.99ee57590fe7878dccfaa6a0@linux-foundation.org> (raw)
In-Reply-To: <20250428065727.57990-1-igor.b@beldev.am>
On Mon, 28 Apr 2025 08:57:27 +0200 Igor Belousov <igor.b@beldev.am> wrote:
> Don't break the build for a PAGE_SIZE that is not fully supported,
> just print out a warning in that case.
>
I queued these two patches and this fix:
--- a/mm/zblock.h~mm-zblock-avoid-failing-the-build-fix
+++ a/mm/zblock.h
@@ -21,7 +21,7 @@
/* max 256 slots per block, max table size 64 */
#define SLOT_BITS 8
#else
-#warn This PAGE_SIZE is not quite supported yet
+#warning This PAGE_SIZE is not quite supported yet
#define SLOT_BITS 8
#endif
But please be aware that I consider the zblock zeries to be stuck until
there is clarity that zblock is something we should add to Linux.
Let's continue to address this in the main thread(s), please.
Or perhaps to restart things, do a full resend after having reworked
the [0/N] changelog to fully address the issues which have thus far
been raised. And Cc'ing the various individuals who have thus far
commented.
Thanks.
prev parent reply other threads:[~2025-04-28 9:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-28 6:57 Igor Belousov
2025-04-28 8:46 ` kernel test robot
2025-04-28 9:27 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250428022716.99ee57590fe7878dccfaa6a0@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=hannes@cmpxchg.org \
--cc=igor.b@beldev.am \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=minchan@kernel.org \
--cc=nphamcs@gmail.com \
--cc=senozhatsky@chromium.org \
--cc=shakeel.butt@linux.dev \
--cc=yosry.ahmed@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox