From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BBBAAC369D1 for ; Sun, 27 Apr 2025 23:07:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F298C6B0005; Sun, 27 Apr 2025 19:07:49 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id EBC7E6B0006; Sun, 27 Apr 2025 19:07:49 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D79746B0007; Sun, 27 Apr 2025 19:07:49 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id B38D06B0005 for ; Sun, 27 Apr 2025 19:07:49 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id B20081202F8 for ; Sun, 27 Apr 2025 23:07:50 +0000 (UTC) X-FDA: 83381363100.07.3CDF204 Received: from tor.source.kernel.org (tor.source.kernel.org [172.105.4.254]) by imf04.hostedemail.com (Postfix) with ESMTP id 0A6A140004 for ; Sun, 27 Apr 2025 23:07:48 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=lmomKp6H; dmarc=none; spf=pass (imf04.hostedemail.com: domain of akpm@linux-foundation.org designates 172.105.4.254 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1745795269; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Tw4mMdPKkZhiB9WCuXB6jhjMwgKF3WY9lTBU3wZMXiE=; b=54jF6qbxvzAhm3Uzrrw3zI8ZtBV+1yUIGTxPnLp4OefnmCDBRkp7TiNgTtDJloWDJ5eoYU jHKjspLfceeLPXK+19M0eENy1NetzAF5WQXvVO7rjqtzcpCt0TjoJozP+ClMlLA6xeoxmO Lymecqpq7fj6A4OtTQZ4ega28GPmbHM= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1745795269; a=rsa-sha256; cv=none; b=OC1WJS4NZ1+TSxbiYWACBHKfodYjZwGjowh3Y0hRMWXRcx4AsZIQO1waUzriXSBJa1s86W lOEWFpi++5Z7mshj5Rx7A6ofn4JTLWkuXa7JsEjVUTqjz5Wfg3JtQF+NWFn8BYm05Jvrrt efNyHuqzLakAFYd5CoqUhNDpiU9VPfE= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=lmomKp6H; dmarc=none; spf=pass (imf04.hostedemail.com: domain of akpm@linux-foundation.org designates 172.105.4.254 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by tor.source.kernel.org (Postfix) with ESMTP id EBE4A61126; Sun, 27 Apr 2025 23:07:23 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5C04DC4CEE3; Sun, 27 Apr 2025 23:07:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1745795267; bh=tT1ToXBHwKrWkNCx4aAzO7gnt63zYs1WN6coWvYxIAs=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=lmomKp6H+Z5yPVT9yORPYvCT+AEUZgKZQEVE44c1cE1vaJTgybO2JT9SQS63XTBBU a05feXjoXxpbHDOtXEZUYWOLwzLO38mBm6eXCBLgKyy7IlhOH1vgkmG1QEC3/DPMAd EQ902A6TjoVIMR4JUKWFjVKfO7GfT5r9XgeZ0obQ= Date: Sun, 27 Apr 2025 16:07:46 -0700 From: Andrew Morton To: David Woodhouse Cc: Lorenzo Stoakes , Mike Rapoport , "Sauerwein, David" , Anshuman Khandual , Ard Biesheuvel , Catalin Marinas , David Hildenbrand , Marc Zyngier , Mark Rutland , Mike Rapoport , Will Deacon , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Ruihan Li Subject: Re: [PATCH v4 7/7] mm/mm_init: Use for_each_valid_pfn() in init_unavailable_range() Message-Id: <20250427160746.13040000164752386b936be8@linux-foundation.org> In-Reply-To: References: <20250423133821.789413-1-dwmw2@infradead.org> <20250423133821.789413-8-dwmw2@infradead.org> <20250425163813.58b72a3aa2d3ebbd96d1929e@linux-foundation.org> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 0A6A140004 X-Rspam-User: X-Stat-Signature: 4undu4x465jhcbgs1o414royb6txsf5s X-HE-Tag: 1745795268-725732 X-HE-Meta: U2FsdGVkX196XNm/4GRSFhm8qGb9tXRQMa/gXUDC69p7NDVlQTccJVAFQS5wH430fk0jVwuGEFkYR2ym8avukVpbm/tpB0dCCJ5Jp1Ipzn+sRaw9vmD+8RzKRuPH3IkglfNQ8lRe7RMgRjm6tLjNx6f0yM3JpvJol2XlINa5K/S3PPGZVyIjdwK40hJ6c72qhRaXc5pCw2dzM4UM6TdYagv4H2Hkhfyaeow3pP4L6yRfw8OhNfulm5NJlEq7tAQy/OEDjaScan1HHNa6lUiJkRUtbzn3eMJ/msywk0hkNigtIHsuDnLUW/E/I5NDUc5IvvAuIRS3H+ODOIKPAlly2Lc0/Q/xIE5sLaQufYBocAKXmL4hoQ7jjoQZhTl/MPPjWQkncMjQsxcA/udtw1c8Z4GFaZ7dqSiys5yOHzaxUC11C0HVZ+iPnkxTtnvmQ8jPbEo717zh3hc49HSsrUgoeioeQhzDuHiTHNj4K5tCEGLGzgjyrzwP+hs6Ymx0sqkqhZgiodQ+WVBv7mkNNYAt6C36Jdtr+cCUl591QzLwMcy9ruB+4LWXyAj3eGZZ+rr/hI657a7Hour9aqhwzApUU4SKazjN71hivZqqMTVxxk/KLu0EkSu7zOJ/UaYCabhr/wqoC72e6JL1O1szYQ2B5xVz/yte4f49Tlas0YcLvhqi//coqm+KGxBBHLIHgCqlZe9s7sfOl53wPJSuRtM9ajgZMcBKaDEhTg5PHpLlxRx2ZwntuxhgrcNCfzcO+uDrXIICrSt8cwQ0OEmeBPzC27TRRLE1SKr/qmzSQ40nH43I6JHaUWRQwkgnJ9G4Q7HVd+R9SizgvXEi+H+sl5NoAIlqKUyZoQkY5IMRMcdzKGEKN/PlUwBOgX7SF+uR3Ryi+r3xqZdNcD765V9CSc43NWev99AffmlNPKJ++CBvyFV02/bwFlLbzYiM3sDV73lGuqCz2zky9JZgzE7gBFL iKL723VX 67H7hIDavvFFplxA/HEMBiirxnTZ/e2fPuXzWQKzoqrH5al8yyE7HxT7UgvQ8j7fkjPMkskJY4s5O/i+oNnYWtBvsvEMZSuNR62lKvDLIBjQY/BT2bpXPmoybeAnZ86gE0yoG2L+RaA6qNh8DkeGMGqkJf34ibP1HD2ZHmI682vJcvxtTAhvm8adShuGuZ5DuSRxWbjurLZp6kjbrsVHBHEkP6B2iK8x52VrMPB+aiZGNiHGgO/feIDnvbGaIlKn52iY6B639X0HnEE5gzqaSmUFzVR4sog3bFTmqnR4INmO1DfCpCyW/9MTIAg/dvVrJMDpzsz61Znh2p9F/MkLvDN+5BsFSwLf3dwO1m0Wqx1tLOFx6hRBOZHFLE9CRItZNGjDwFHmnRfdVzYAFvPK2Cmstjg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sat, 26 Apr 2025 09:30:50 +0100 David Woodhouse wrote: > On Fri, 2025-04-25 at 16:38 -0700, Andrew Morton wrote: > > On Fri, 25 Apr 2025 17:11:10 +0100 Lorenzo Stoakes wrote: > > > > > Andrew - can we drop this from mm-new? It's breaking it. > > > > I almost did, but David seems to have a fix. > > > > --- a/include/linux/mmzone.h~mm-mm_init-use-for_each_valid_pfn-in-init_unavailable_range-fix > > The symptoms only manifested when it got used in > init_unavailable_range() but that's actually a fix for the sparsemem > implementation of for_each_valid_pfn(), as David H surmised. > > Please could the fix be folded into > mm-implement-for_each_valid_pfn-for-config_sparsemem.patch ? yep, that's why I named the patch file "mm-mm_init-use-for_each_valid_pfn-in-init_unavailable_range-fix.patch". To tell myself to fold it into mm-mm_init-use-for_each_valid_pfn-in-init_unavailable_range.patch. > This is what it should look like with the fix: > https://git.infradead.org/?p=users/dwmw2/linux.git;a=commitdiff;h=55bebbb093 We're good. > If you want to keep the fix separate, then that's the patch that it > fixes. Do you want a commit message? I'll certainly give you a proper > SoB: > > Signed-off-by: David Woodhouse I already unauthorisedly added that so I don't get grumpygrams from Stephen ;) > Happy to resend the fixed series if it helps; it looks like you've > already basically sorted it though? THanks, it doesn't appear necessary at this time.