From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A0270C369D1 for ; Sun, 27 Apr 2025 11:46:16 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E7BB06B0005; Sun, 27 Apr 2025 07:46:13 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E28606B0006; Sun, 27 Apr 2025 07:46:13 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CEFD26B0007; Sun, 27 Apr 2025 07:46:13 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id AB3DE6B0005 for ; Sun, 27 Apr 2025 07:46:13 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 809A8BC94F for ; Sun, 27 Apr 2025 11:46:14 +0000 (UTC) X-FDA: 83379645468.16.89DCD56 Received: from mail-qv1-f41.google.com (mail-qv1-f41.google.com [209.85.219.41]) by imf06.hostedemail.com (Postfix) with ESMTP id 5FCCC18000B for ; Sun, 27 Apr 2025 11:46:12 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=cmpxchg-org.20230601.gappssmtp.com header.s=20230601 header.b=EQiLqkoo; dmarc=pass (policy=none) header.from=cmpxchg.org; spf=pass (imf06.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.219.41 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1745754372; a=rsa-sha256; cv=none; b=c7/R0vwzsYJGNQviTy0juAVHOok0jvJNxP11WaCZkisjTvPoyQDO5y5PZutnbGu8dLn777 94sypKD38auKqz8A79CY1dPHfek974w9KpCIfv0t7yxqVeDgxx+hxKI247PLVpwacXmZmJ Ymu923yShX4M+pO7mpMAkA0yyAx5eZg= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=cmpxchg-org.20230601.gappssmtp.com header.s=20230601 header.b=EQiLqkoo; dmarc=pass (policy=none) header.from=cmpxchg.org; spf=pass (imf06.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.219.41 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1745754372; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=iZGJbKlltLESsmy2RtQuwiQRyRDouUOJMZvq+iV0S+c=; b=Fshus2nt9m07mny+uawBW8F7zKN5c7CA9LfNzzuV3QPkWAF1AXZTl+HlHqob32dZ2nNISM WPS1/75ERn2u+U6MXTW+E7IyguEVDp4xmAf5fp6bmDlUKBOjlR5x/jskWC3vzh4cdJQCkg C8s3Y7R7jNtsl/i8tmW4IPdZMlrfWcg= Received: by mail-qv1-f41.google.com with SMTP id 6a1803df08f44-6ecfc7ed0c1so39190396d6.3 for ; Sun, 27 Apr 2025 04:46:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20230601.gappssmtp.com; s=20230601; t=1745754371; x=1746359171; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=iZGJbKlltLESsmy2RtQuwiQRyRDouUOJMZvq+iV0S+c=; b=EQiLqkoo70/cYDaY6fmdH6qlIJT9oNLpZ2W6HvUJLCYhp192tKE/71H0tmle90M8z/ PERRxJBusVfyTvMpizlCBChaDl9cIohjVPcT7ko7VgLvFAFoHZp1yzR12s6CzWUKAfos 4vjKupSa22jZMWwdUqyWhuLH9havoFQSoZRlw6MVxDYYOSMrAWWTGBuuJpufGYQJFIEE nNRDS81984JTECbzD5dFVfHjswVUOlDEGsQw9o3AUK13+hyfNIsjLO1WTPLXDIsHqCib f/2g4JNsovwJvKUe1yTVZvtNzqavmG/wn7nYMR3Xwopz57F43jZ9mCj02UCJnSzu1LtW fK5A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745754371; x=1746359171; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=iZGJbKlltLESsmy2RtQuwiQRyRDouUOJMZvq+iV0S+c=; b=cDL9EmaTx5DXsGnMaV2BwyEbKVCpfEwRG9qHigNyLUPGYTzZ5ui5RiNHlPKmnZWfQw Zt3HjW5znbk4p8COo1Ky4Tr6L8jHUzjthskoqhQrUaT3h9JSZik2szlbz8a0lUWHALfv 8CF+YBRNKv/SbNP9fN7KGH/XAf1pOvCfMRk1J7BQ0i9nR7UVoR5Yp4I3pOIP1AqxX/kW B0CSN4qSZQ3RKYE7iX2+DH/qLPNnvUOKRjgAthWOesaBELoZyyk4cP1oY6RrR+WmfMmy Yzmy/rUC+whYD7DST230QKZP4XYwsCrxGUfRA03BTUVBkAW+jtRj/CFn/ZKdVUbQIpru aWlg== X-Forwarded-Encrypted: i=1; AJvYcCWLTnivPMKDtHQz+C5en0FzsTRwV2GcAu4viUN3B6dKC0rCGQFyh42bS2gMiG+rBpurVKcw7zPOZQ==@kvack.org X-Gm-Message-State: AOJu0YxWSR72T6W9DMlBHfx0hnDgBdb37UVCqp5r4wCsRAAfWLvxosYE tzxVFChdo8bB7eLC6GWwEt01laiCBm/DZAfHvuORcHfl/g25xmZVs0z1j56K6L4= X-Gm-Gg: ASbGncuvjkRRjm9L564Ks1a1WjRsaysNb5+CzNZvIAPWzAFG+/9xQ5h4NXD1P31z7du iygtZ+UaR048ZclSJL7LZcGrlddwsFDI7uBS5tu6Vv/ZumifhopZxNtLgIoAsRXh+rkZnWBqeXV Fx3FXcuL7H4G1kAOG6KUtGGtAG0Cjd3a6eU6K9tPZNBs0XrfB0G0jYRIQl2nIRuxDOAM5b4rThE mLWHMLSySzlvpbWlzJjaiccITn1sB8A4R101t2EPD/gQyT+3MeAxFKtevqMI4vNEDw6JSmYgF0M jDtgzQOVpzBQgYgmgrT1OgjH/C4sSnVMnp0s9Qg= X-Google-Smtp-Source: AGHT+IGYlNv9jjm589wH0WvcGrTx5hwBX5PzvIp+I5YJ3ZPlUly+7OZNNemuhxWqi75Nw+gnuzcHFw== X-Received: by 2002:a05:6214:2aab:b0:6e4:4331:aae0 with SMTP id 6a1803df08f44-6f4cb9ba3a9mr120420376d6.1.1745754371307; Sun, 27 Apr 2025 04:46:11 -0700 (PDT) Received: from localhost ([2603:7000:c01:2716:365a:60ff:fe62:ff29]) by smtp.gmail.com with UTF8SMTPSA id 6a1803df08f44-6f4c0aaf98dsm43731706d6.108.2025.04.27.04.46.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 27 Apr 2025 04:46:10 -0700 (PDT) Date: Sun, 27 Apr 2025 07:46:09 -0400 From: Johannes Weiner To: Huan Yang Cc: Michal Hocko , Roman Gushchin , Shakeel Butt , Muchun Song , Andrew Morton , Petr Mladek , Vlastimil Babka , Rasmus Villemoes , Francesco Valla , Raul E Rangel , "Paul E. McKenney" , Huang Shijie , Guo Weikang , "Uladzislau Rezki (Sony)" , KP Singh , cgroups@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Alexander Gordeev , Boqun Feng , opensource.kernel@vivo.com Subject: Re: [PATCH v3 1/3] mm/memcg: move mem_cgroup_init() ahead of cgroup_init() Message-ID: <20250427114609.GA116315@cmpxchg.org> References: <20250425031935.76411-1-link@vivo.com> <20250425031935.76411-2-link@vivo.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250425031935.76411-2-link@vivo.com> X-Rspamd-Queue-Id: 5FCCC18000B X-Rspam-User: X-Rspamd-Server: rspam07 X-Stat-Signature: tcx7xnynuxo7hbzjdtsb9p5ifqtabhwi X-HE-Tag: 1745754372-704852 X-HE-Meta: U2FsdGVkX18KMvmuf5ikc6ws/ApDTIwpaHtmTzErFj0CzWiLylDsPeHsDVGyw/MwIloenkPHCE4DcsvwXdlHlM8ifGOgAQNNtya2plmtXdnwSZLhuF+LynFrzMyrkrOH7BtXxaZJEhI4A1AwmT+JDtW0IF1v8UKGtvmtBHzCWJvwR1vsNbAV46+0NHXv7ov1f/rGVhCrm6dTvUFWbi862/LVi2YJaW3OFt3tGxOskRsvL2kp6mzLp/UK6ZusGgD2wqOWvFDkhVTwVHd11HyZ6UUAIiMh9H+hhToa5cjLzEphMBjnlksNeJytcdY8NmLWlDVUivXGhReY60m1iz8JURAPZwqZWDBS893IlpXXwLlMam/mw8jen43vnqe7fcT44FybmrapMqEyXd81A+b6c5qHAImBBCthhJqAGVph+mkqoZ/Ka4VFI9SeDc1jr0aunDTQzLbO1nSkuuh+v6hm4K80msPGQN2bmTmwzHwG5LOq+VbNTYDdHicLUzx+0H4Q0u0EvEbDFgU9GZLHbqBqjokyFhNjk/2rwC+g0QL3oQ0E08Fqj7cIqp8uMV9pSUSIIpajPMH5uauYUzHXB52ezDwjY6V4DmAzmhho2yzoGaJttgeeB7QF2p+fZjYEAB4Zn1BH/LpKx5j7FjLE9o/Wj1c36iq4lBvOIQokUlOmiVFqFrEMNUFepvEOaf43OMHWgjWJYMvNZSxrTSYgIK51YbK4bHTXPlFwjhAwXDOUECAv8kqMX4y6v1vzezX7SWNqWjc67EayZEsaQiG0UrxiZrJt8kuQX6IWYX9NC+69bbAMp7itOUcpe0lZfP35AY9ejQ6kZCyXUo8hiraWBCQp3i6a3UwVNHtb4Hw47pheGk/GR8LSiUyqs9OstCHV2UxJUbjcAwD7hDVgESJOyPDkkT3gqigkTBUK3kJ6hVDCLQTcSByF1oFa9rWIsrZl2ci9wdy/yJ6P5EFfmWOGBWM E+l7rIrT KUKsV0JoJJMAceMUji9f+phgGm+ewy5Tf/pTWKkAAw5TNTUFmyX1frKN3+WDYxrWrACM0TIMWbmF71NNVuBssB07ISyfzDpdsBQgjkxEubIh4UMj5iSXaHY0xOlkFCw2U9gMBdFNPeIna/ue6KPJiByVr8o+iWC51TBBueOCqmNUcwMWHJzQ6gZCrZW8ftpykhbm95OxAvkGZGRwdI1WptcG54nO74zKifYpqUqIxlJJR+1JbOAbh+0F14Tp8Pxc3/YWYxGvdRWVMpYCnOAC6DwWsd2O+Tgms04YGIiNELTh0t6IkUgpXSwWcGvkL8gHTbFZHgCH8jSdyxhAOdzqsdvirC1wg2nyS0trq1Ega25FCivSvw/CTrSCtpoJULu/HGQRSARcFTKNLJcmIYiD0xrY2VHUWUzoNDYjXOlmcVfMRR5x1VYCJvB5LlNtTKa8A9pIZLZrr3h9lX9BL3uysZoLrbVvb3UK5v3ywnocd2CD+G/czI6yM1/Q/DUifAnC5Mh4/hj78RzDqJiNwzNUR1zPPZlkghVRQEIKUolA/QEMuB+jjwEDxCQtkz+kFRfXTML9XSXHHJ8eNx0l+UsgDb1HlCpfX4ueRLONwUTYb2IBXK+qJ8zJh4dY0bMyahY9IFzlc X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Apr 25, 2025 at 11:19:23AM +0800, Huan Yang wrote: > When cgroup_init() creates root_mem_cgroup through css_alloc callback, > some critical resources might not be fully initialized, forcing later > operations to perform conditional checks for resource availability. > > This patch move mem_cgroup_init() to address the init order, it invoke > before cgroup_init, so, compare to subsys_initcall, it can use to prepare > some key resources before root_mem_cgroup alloc. > > Signed-off-by: Huan Yang > Suggested-by: Shakeel Butt Acked-by: Johannes Weiner