From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B97AFC369D5 for ; Sun, 27 Apr 2025 10:05:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B142D6B000E; Sun, 27 Apr 2025 06:05:03 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id AC51A6B0010; Sun, 27 Apr 2025 06:05:03 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8CAB06B0011; Sun, 27 Apr 2025 06:05:03 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 6BFD16B000E for ; Sun, 27 Apr 2025 06:05:03 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 961841405D2 for ; Sun, 27 Apr 2025 10:05:03 +0000 (UTC) X-FDA: 83379390486.05.4B9B232 Received: from out-181.mta1.migadu.com (out-181.mta1.migadu.com [95.215.58.181]) by imf24.hostedemail.com (Postfix) with ESMTP id F0DB9180007 for ; Sun, 27 Apr 2025 10:05:01 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=ZmqKWeE8; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf24.hostedemail.com: domain of ye.liu@linux.dev designates 95.215.58.181 as permitted sender) smtp.mailfrom=ye.liu@linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1745748302; a=rsa-sha256; cv=none; b=ApDVH92dG1YhX773F1ksCqKa2wL5QfomLAsAQIvNV1cq+NH3Gy100G+RnBexHEkVPeqVxM sxxzSPHD5qQQXjf6hENCGij8cUXLHQgABV18633NozlybKfv6T4D36uJqT/FkBMNDWFyrU wJwTfpCQehb8CBvSwpkwJZGWKryu3ao= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=ZmqKWeE8; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf24.hostedemail.com: domain of ye.liu@linux.dev designates 95.215.58.181 as permitted sender) smtp.mailfrom=ye.liu@linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1745748302; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=HsxLrijwsdqk8P5G6bYDVUq36qmeIQy/hfJ4ADbTjxc=; b=yYz+WpRMngtxczDa284HCoHLVfxNvVznmj2Ik23zhoiW8N/Fk8roq02URrv3BPz+o2cnnq nhmROZYTPPDYSHu3zxwFSZvz3ohBwLMIh49fGG/yMPleitx8rsAn71GX3X5x6H6xVbgsTV g0ASBNOQd3RYhgPfJ7mX37lue1cxSpc= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1745748300; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=HsxLrijwsdqk8P5G6bYDVUq36qmeIQy/hfJ4ADbTjxc=; b=ZmqKWeE8OudYZ5p9qrIgipYIvk7iwNTk/A/H7mQF4eVBqxTzSr2F4vhBj4LN4UjHMNAXG5 lCoVsUJRHtsl5k2rNujBS52tYzykC0xmzwB8QFgdaOfOFIy5OJ+t53xzd4EPTqQKbHHZ1K CvH37RClbzMLNHxilh3iS08TUhuRIpk= From: Ye Liu To: akpm@linux-foundation.org Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, rppt@kernel.org, lorenzo.stoakes@oracle.com, Liam.Howlett@oracle.com, david@redhat.com, harry.yoo@oracle.com, riel@surriel.com, vbabka@suse.cz, liuye@kylinos.cn, ye.liu@linux.dev Subject: [PATCH 3/3] mm/numa: remove unnecessary local variable in alloc_node_data() Date: Sun, 27 Apr 2025 18:04:42 +0800 Message-Id: <20250427100442.958352-4-ye.liu@linux.dev> In-Reply-To: <20250427100442.958352-1-ye.liu@linux.dev> References: <20250427100442.958352-1-ye.liu@linux.dev> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Migadu-Flow: FLOW_OUT X-Rspam-User: X-Rspamd-Queue-Id: F0DB9180007 X-Rspamd-Server: rspam04 X-Stat-Signature: xfm5nusaz38jwhiotofchgujazdyom4j X-HE-Tag: 1745748301-25531 X-HE-Meta: U2FsdGVkX194K77ul0GJWa2rUlzT4Adqn8tylpiEdq7eFPXMi+RxK66wltmbR82kDDp2VKi2RCPbpI3MgsVFVUMiy7361QJ2d7qLXykzLxIRUf450Q8uJXFByOUYAI+lBTW1ovKs4JU/V3ie9D9RIfR+FcocBX8MtGAjR//4nIGJQ3lw/V4coXqPb/ymrs9Mri55RrdGcw88P9TzuYa6T7NCcb0ZrcPQBeALagD68a3Zg22QSYpcKiUysaqWkD1jX2MiMlMFCADXgqDylWfSobUp/4tM0pSJwj95hv5blOy4rdyO9poC7+rg4HJ1HU4JU7OWgaGdhGkNE1XAVaUfpZRA70Imu9+dlsDmqNieC8Lj8IRLRUNBFm5rHuCiTeIjZgmPjGUfGeFMe/Nwti9YrtQn4DMAE7FBdkc32MT8A6GmPEN+6RIgLfnw2SksM/b+RDJ29ZA6lzYqKHNYzEjGRtWqgyy6xQZ1tGQvOrgmyoUbyBfnZIc9gqjK3NRRsYCfeU5RGH2+Slyq3wT5nF7qnHeMQ25yv7mxFtifaLYPQJAtDn0e5jxx9grYz3M1zGI0c8XC9cYCjzX89pxkBhdnSOvJJw/BLrbYO0vzCcO2Ap+Kh0AgO42rJWn9iZSdzz0V+5KlnhylNsR8+nDldO1aEHGz5bhltnx+GVf3EfTM/rS65uYrqgx54pAAU7gOVyignqSz7WyIrWxsWTs5fxKtG8phPahrbkAW0s7lmq1O9u9VNdDkQwO17kHrVrxlRV1QcRjcRmURJlh1yFv6UkMmaCv490fEZqWSs/nMKcIRK3yV3rDCVBSMf73u2O5GMlALpWhA3V35YER7k/bC1sOBD8lHTXk4FABNp/7Te4pXcz2ffjZq8M/CK1EtiaSS1A2RnMWMqbT9j9jAblxEN7iMcZWDovnoSPmjZQIz4YAmnrIXVm9NqMFHYL0KmUnlOMnX2i8DzBLtrNpHcyW3MGe VhkR3kYS CQ6MuflbkxBBNxPRD0SF5Ri3Soh1HvVvjCXtU21vmNtHvwSSqzBstN57Nos2NLJriZqZ3HG5NXY7MIO8qdQcjwT44yfTWsy8U8XAT4JuYUL0rfYWDxsmUUF1Q4QCZ2Xk6deUJNhEPihAVV4qAkpNokN78sS68frHNMbl2m6aR4zgAFb4qXD/yP8qql0YEbqs2WoVrKTuSJ/ilDWOUXdG/TuWVFA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: From: Ye Liu The temporary local variable 'nd' is redundant. Directly assign the virtual address to node_data[nid] to simplify the code. No functional change. Signed-off-by: Ye Liu --- mm/numa.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/mm/numa.c b/mm/numa.c index f1787d7713a6..7d5e06fe5bd4 100644 --- a/mm/numa.c +++ b/mm/numa.c @@ -13,7 +13,6 @@ void __init alloc_node_data(int nid) { const size_t nd_size = roundup(sizeof(pg_data_t), SMP_CACHE_BYTES); u64 nd_pa; - void *nd; int tnid; /* Allocate node data. Try node-local memory and then any node. */ @@ -21,7 +20,6 @@ void __init alloc_node_data(int nid) if (!nd_pa) panic("Cannot allocate %zu bytes for node %d data\n", nd_size, nid); - nd = __va(nd_pa); /* report and initialize */ pr_info("NODE_DATA(%d) allocated [mem %#010Lx-%#010Lx]\n", nid, @@ -30,7 +28,7 @@ void __init alloc_node_data(int nid) if (tnid != nid) pr_info(" NODE_DATA(%d) on node %d\n", nid, tnid); - node_data[nid] = nd; + node_data[nid] = __va(nd_pa); memset(NODE_DATA(nid), 0, sizeof(pg_data_t)); } -- 2.25.1