From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 26C25C369D5 for ; Sun, 27 Apr 2025 07:53:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2163F6B0005; Sun, 27 Apr 2025 03:53:41 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1C5D16B0006; Sun, 27 Apr 2025 03:53:41 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 091F86B0007; Sun, 27 Apr 2025 03:53:41 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id D80D66B0005 for ; Sun, 27 Apr 2025 03:53:40 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 9135DC1105 for ; Sun, 27 Apr 2025 07:53:41 +0000 (UTC) X-FDA: 83379059442.25.876DE7A Received: from tor.source.kernel.org (tor.source.kernel.org [172.105.4.254]) by imf14.hostedemail.com (Postfix) with ESMTP id 034E0100009 for ; Sun, 27 Apr 2025 07:53:39 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=OmokyrrK; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf14.hostedemail.com: domain of leon@kernel.org designates 172.105.4.254 as permitted sender) smtp.mailfrom=leon@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1745740420; a=rsa-sha256; cv=none; b=XsW8GPh9rEMfEU1mbVq9zMFAF+LaTVAWR1GI1OmROjWInPZwXLaDj9wzP5LHXzB02hVLBe KyfyF/VN6gz82Fhb+npaWq/ksCC83h/8UqyU/hYPmcgzEMUmiyXCqZI3C/3M66/69FZrKa eH+Oemu2uWRc4BOay5i+Y0INZLmV/iw= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=OmokyrrK; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf14.hostedemail.com: domain of leon@kernel.org designates 172.105.4.254 as permitted sender) smtp.mailfrom=leon@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1745740420; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=KuxxJHp390FlsAEnJEhHlKbgyQwkcp7dCcj24iOjCQA=; b=7tMZNicukwAka5mbU86DfZS9ALeQEFHNkF+GpcrT7SJ5HMhBr5KK8oMQln9KoZPgmEdhlZ 3vh8XY9bxDtGINNopaaM6XsnO0DWksG/s5GjqkKf8a2qYOWyOA+xXaND4hCzlKVETfjoof tCnpBRotU9KZz/nNSXoVkRn1Pa7yZpE= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by tor.source.kernel.org (Postfix) with ESMTP id 8259061166; Sun, 27 Apr 2025 07:53:15 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B9CD1C4CEE3; Sun, 27 Apr 2025 07:53:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1745740418; bh=iKyTQwydNmAM/0HcUlde1DtC+bZbAuPZo0BeWV99Sn0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=OmokyrrKogcvAy75PZnoqbf/SV/3tN6a/jr9gHE56cV2aAUja1b1vR87w7sFYp9SM 2MTW/5zl9jZEDztFGGMRMoytnKxQ/fH3Nx6Llyyms85hrYsAaXPnI47FYKgA+tncyk mkQJNR/IXAW+albRz+ErujsbIoPBM+w7flk409Lh3ddIk6MNaLOs5tByMzgIIbhf5K jRQYMV0yr7lWDCaipx7Aq5g43zt2+567TjgKvYuKc8lxRSBlEQo2Qk0Kj38yk4NdCj I1x37331Ys/wwpuT1EUyEcmT/tN7FXyY29DcKZ5RlQ/ztukgb7skj9uPZ3RY+pbnTx CTtopc3JapJnQ== Date: Sun, 27 Apr 2025 10:53:32 +0300 From: Leon Romanovsky To: Luis Chamberlain Cc: Marek Szyprowski , Jens Axboe , Christoph Hellwig , Keith Busch , Jake Edge , Jonathan Corbet , Jason Gunthorpe , Zhu Yanjun , Robin Murphy , Joerg Roedel , Will Deacon , Sagi Grimberg , Bjorn Helgaas , Logan Gunthorpe , Yishai Hadas , Shameer Kolothum , Kevin Tian , Alex Williamson , =?iso-8859-1?B?Suly9G1l?= Glisse , Andrew Morton , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-block@vger.kernel.org, linux-rdma@vger.kernel.org, iommu@lists.linux.dev, linux-nvme@lists.infradead.org, linux-pci@vger.kernel.org, kvm@vger.kernel.org, linux-mm@kvack.org, Niklas Schnelle , Chuck Lever , Matthew Wilcox , Dan Williams , Kanchan Joshi , Chaitanya Kulkarni Subject: Re: [PATCH v9 02/24] dma-mapping: move the PCI P2PDMA mapping helpers to pci-p2pdma.h Message-ID: <20250427075332.GC5848@unreal> References: <493a6ab31fdd73e84e16662578858f194e9f87b9.1745394536.git.leon@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspam-User: X-Rspamd-Queue-Id: 034E0100009 X-Rspamd-Server: rspam04 X-Stat-Signature: gxfqnmxpp4wq8buziu6y3jf9yf5thxcj X-HE-Tag: 1745740419-572870 X-HE-Meta: U2FsdGVkX19Pk1vN5Qw6yboGjkJTH8ovM6vsHNzXrkfTtMnDEbVifjtqemvgBiM2MWvgfN/uydfCjHvHojW5bt+5RoEkmx/Faj/co1KJvtdLKgESIZHecgwtboPXPFK77ADzARt1vAhJVgNbwYTskf3jeDocdFG/HbrLstEjD5lMFxejBFl4ByOlkj8lAJT//rKjd8Bc3MulzryVDEKIYYuv/3njBzUSvTdlDH8Y1CMwXpw5Z4CcFe/7fRH8YJ6OmM9qJsVZH/LWN38OxKgJuZf6W2hnz3VLWWcB/yCV8uiSipMgefcz+rgqXG2stL+UXIrvtJdyhc9XvJLPXZ8ucmIZrbCSxcW34nkRXAKVW72SWFR2XOWeBOY0xBjg1zPFfzu7Y0A0xkOzeharO+lc9+JurEVDomeGiIKBWVm4QT3P9qi0KYy3BHzJbh09ufxcc4TysRjOXaJWf2E8an3nBiU4TM9Pqxco2vKSKSwXMPw9TBxXE/IFMej9Kd/sIxLaAl63eLp/NlVT54gfqfLBo3HmAPOb67nflgrXc+hQV5QEXr9sPCXtembP04BUvkVDkmukMIpZG9bR5xotecDTOfq26wOByXLWHPN4KH6Dx6Tj93v0LvoeLlwnJZYhs92BFtZKcgY5tQ28JqepYHHVfTK7gXlcvGO4AjF9aK1AVRmFFQnh2HQEUukmo5n1x9ZvUd8fnaUTZjztOTtPKrUi5wYJq+OorUIVHIIL9BAGVFZJWoWpr0kiTBtbTz7KI0PJgVUcNv98OsvCWc9i3Zq8IBLlQx+GNWtTz7AIpdOFdQwq2jnP3/IscOtTEaSkngGzFXeFStkuIJmU/jVxPsHeoS6Pa7M41XG0eAgub3edwI7yrThzjtipPVXvTmruf91Jvddu8DVcWvo2jBvV18cao1iXKRplTcRNZ6NR3xO1gbgQ8o38r8T1oidASDXXs0WTwxW+anfYbXpIeQMI1m9 COSKtTO6 WMk6JqBJm75FYc2Rr51N7tSaCW2Dg9X7v2LdxF6eFVjduRTxL28AO07NmK0TRB4stJPNBVF9Ssx5SQfyvBYcnhY87b+82T2uy/mkIzydzYrYEu6Qj9OItUsk8FdnNdQ5ncWO9sA+ALjhI9EnNw5gWaaSG4HAoKSMJencTmDldUDmDnqbn4lQRlUm6ZvwT0fmBw7Hex5F/u1C3xNH5LYSdWaRpzsLQJ3xrE7alloLc5J16yC3prEaE20M/aATImslJWHxwOEtpQ8ee+XsoHDy7zhSacw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Apr 25, 2025 at 05:34:14PM -0700, Luis Chamberlain wrote: > On Wed, Apr 23, 2025 at 11:12:53AM +0300, Leon Romanovsky wrote: > > From: Christoph Hellwig > > +enum pci_p2pdma_map_type { > > + /* > > + * PCI_P2PDMA_MAP_UNKNOWN: Used internally for indicating the mapping > > + * type hasn't been calculated yet. Functions that return this enum > > + * never return this value. > > + */ > > This last sentence is confusing. How about: > > * PCI_P2PDMA_MAP_UNKNOWN: Used internally as an initial state before > * the mapping type has been calculated. Exported routines for the API > * will never return this value. This patch moved code as is, but sure, let's update the comments. > > > + PCI_P2PDMA_MAP_UNKNOWN = 0, > > + > > + /* > > + * Not a PCI P2PDMA transfer. > > + */ > > + PCI_P2PDMA_MAP_NONE, > > + > > + /* > > + * PCI_P2PDMA_MAP_NOT_SUPPORTED: Indicates the transaction will > > + * traverse the host bridge and the host bridge is not in the > > + * allowlist. DMA Mapping routines should return an error when > > + * this is returned. > > + */ > > + PCI_P2PDMA_MAP_NOT_SUPPORTED, > > + > > + /* > > + * PCI_P2PDMA_BUS_ADDR: Indicates that two devices can talk to > > You mean PCI_P2PDMA_MAP_BUS_ADDR done > > > + * pci_p2pdma_bus_addr_map - map a PCI_P2PDMA_MAP_BUS_ADDR P2P transfer > > Hrm, maybe with a bit more clarity: > > Translate a physical address to a bus address for a PCI_P2PDMA_MAP_BUS_ADDR > transfer. > > > Other than that. > > Reviewed-by: Luis Chamberlain Thanks > > Luis >