From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 73189C369C2 for ; Sat, 26 Apr 2025 02:05:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 138A36B0005; Fri, 25 Apr 2025 22:05:25 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0E6526B0007; Fri, 25 Apr 2025 22:05:25 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F16716B0008; Fri, 25 Apr 2025 22:05:24 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id D3D306B0005 for ; Fri, 25 Apr 2025 22:05:24 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id DF149C1309 for ; Sat, 26 Apr 2025 02:05:24 +0000 (UTC) X-FDA: 83374552968.28.E585FF3 Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by imf10.hostedemail.com (Postfix) with ESMTP id 2D866C0005 for ; Sat, 26 Apr 2025 02:05:23 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=JlQuz80c; dmarc=none; spf=pass (imf10.hostedemail.com: domain of akpm@linux-foundation.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1745633123; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=m1yZMDGgiudxt8Pv/nW4f9/SBEXSJAn4YfMB6shYEk0=; b=jaHX2YphR+ng745Bkxi0bYEOXbn+DeV6QV0mxgGYIIhvkAcB2Yj4sBqhGh688ndEJAxUin 5G3lKo4URGjYnQEWu86QPuTngkAWmf+IXmcelsWznXNgBidvWbpuBrq3/uLEwadw6IhGjM JD0XClIiSmPEtMj10YacJg0O53/bA7o= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1745633123; a=rsa-sha256; cv=none; b=ScFsewU5DuC+W6gzZLmi49etKn0HW2lQoRP73kI5rodGBFBkfcSTDxqpsOGtOq3QFKx6V+ X/PS1NyAyqdP4wYMnJeZTeMnlNqsc9dc4y9U2D28ocn7Y6E2InR9yvgukW2fYbzJYwsk9F Kbjb0/JoTUW5A9GTnQHHbYzDPyXahQE= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=JlQuz80c; dmarc=none; spf=pass (imf10.hostedemail.com: domain of akpm@linux-foundation.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id 6BDABA4D59E; Sat, 26 Apr 2025 01:59:54 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E22DEC4CEE4; Sat, 26 Apr 2025 02:05:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1745633122; bh=+MYToG7EccjfFHrEZpf+eIg2lqSQxzzC4596A+uDudg=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=JlQuz80cv10Y3QL76aIeeLqpD+uU9jubW7G68l6Dq6e5KcEyNvZ/9HwMjup1VqJcq 0l0++/wEpJt74biPZNL4CWOpSJEGQN7vL5bWc9Dc7H+rrtJKNRo7KqLOvAyxvwosmt d9cqpSSCz0wohmIkDTBdb9yMLc5qmzAzx6Na6IRs= Date: Fri, 25 Apr 2025 19:05:21 -0700 From: Andrew Morton To: Koichiro Den Cc: linux-mm@kvack.org, yuzhao@google.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm: vmscan: apply proportional reclaim pressure for memcg when MGLRU is enabled Message-Id: <20250425190521.63ba5b25afcb938102b69335@linux-foundation.org> In-Reply-To: <20250404141118.3895592-1-koichiro.den@canonical.com> References: <20250404141118.3895592-1-koichiro.den@canonical.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 2D866C0005 X-Rspam-User: X-Stat-Signature: pbgmzk4kobpgpbk4d4rzzpjouny6akmw X-HE-Tag: 1745633123-715209 X-HE-Meta: U2FsdGVkX1+4/wcnIVrCvXX/t25aq+YsprFhSCNuslLL7wdLYT+bU9iqBZyi8w/h930h5fb0RDIQLVcP4N6D3+ItstCWFv8ocj71Fb3BjSDmryyeCMBQHyFj4Bi+hCjyCjg5ysg4f3UjOUWn07VGR3FTV0XuCEJwZo9faFa5glfuhldp85sZzv9HZet2ORYg0f8fwnczCP+KoSHMgHc3ze40Fg98XOjUatoSmpWs0zGmRcQvnRWnubisx5x20UXNQHyyQzApdHv5mg9KJUoYa5xcA6QMEjXXvpgm32U7KYF639s+C2hfYOWCt0bpBJAfwpmN9HUbxE92Oi7hpeSLeq2gpqXxiI9HlRJa4zMHKaP0ej0rIbaP/prBCNxSvzNWmXe5f4qz3YbGdR+lJWadmcZHsIOs49aRd5dbeO9RvbSsRsF9Yk9Q9ksxmGE9x+JNi/W6QhQgrT0xjc+5bT5APnod6W/dWm8+In6roUu4zElnFWS8nBaMRtIFhVz1xjDuuU6gGeIjHmJSe9xJRI570AUJRHcjVF8o31yA/xRiC10PaYrGwK5Wjaxrks737I4c+HgENSz98KJ0var56f7jyExa0kOC+Q6S1Xv6z7RjISQz0Lj0OOL183LYaKM8ORY0bZwXqsKl1amZg0b4l6PBIVR2Cg4Lj2SxCrVLQso43W4YV6OPanoeU5J2x3AtU0v6RdcHfi+DvnrI/8jSZWEhjlfjP2wR93UyGGdp9xrA1yjwRLXG26xax3ZonW1esmpe/AQ5CO5QfxxPkRywZ+OaWClIkWfRqe0CAVy0kOieA+ZL+MlpFHdRE2RiE35R+y5aIgjg0m8d4PkUQ77UfTTSA+C9KJDx+Zj8lbXnXgT0VSJaccT5dDkStNtJTqwJk5FDZCfjBs5AnG04F0endeTZklWZLZibPxLpcOJHiI6Ec8s9So63u2BOx3XSm1Z/2ZXvPcry3A+/kPb3irBp8Ap cPojb0BV esMMmLo49esjO+AFpvlN1XAcQHStRCykGGaKWHKdpUDIEig8ix7yGffBb5kok3DlvOGj2v7rM7PIsi3FbnDB7R/kDIOxK6qdbC41leJOvEMGAi/lrsqqVfUmvxDou7NbP7mJFr/bS/O1Hrh8WRYji2mUjCwfJAww1PQ5GlKzlt7yyY86d6v+Ek86EthdSeJFY22TgYiznB91Utk6BU6H4XmywOUFYkD/Cvs171SETHlnecPTK5CbC15g0pSHTNOMftDoJU0PgrYfUsrNIzr/KdSlFnj0eRb+HFcGWupjEfPp+Sunu5CXNHw+U6A== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, 4 Apr 2025 23:11:18 +0900 Koichiro Den wrote: > The scan implementation for MGLRU was missing proportional reclaim > pressure for memcg, which contradicts the description in > Documentation/admin-guide/cgroup-v2.rst (memory.{low,min} section). > > ... > Could we please have some review of this proposal? Thanks.