From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 162DEC369C2 for ; Sat, 26 Apr 2025 01:05:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 397416B0006; Fri, 25 Apr 2025 21:05:43 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 346116B0007; Fri, 25 Apr 2025 21:05:43 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 235196B0008; Fri, 25 Apr 2025 21:05:43 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 056896B0006 for ; Fri, 25 Apr 2025 21:05:42 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id D4193C0FE0 for ; Sat, 26 Apr 2025 01:05:42 +0000 (UTC) X-FDA: 83374402524.04.F084AC5 Received: from tor.source.kernel.org (tor.source.kernel.org [172.105.4.254]) by imf30.hostedemail.com (Postfix) with ESMTP id 1860380010 for ; Sat, 26 Apr 2025 01:05:40 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=dNd1PisT; dmarc=none; spf=pass (imf30.hostedemail.com: domain of akpm@linux-foundation.org designates 172.105.4.254 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1745629541; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=2TokmGEnaMCk+McgCJ9pNPBEqBTyIIBUStQI4hsuxP0=; b=SQx+AU1+H4paUraWEL3/iNddrAVsNHKPY/e6MIQOK368s9YnYKaOPEBxNkXW13QUQcixv9 YinGiD/bglwsesKXSuWqpKc6+RMY1csByG+V+h0EaiUE7uWCqbhCnjH3Ato7k7iCti1MXF iFAZmFAujI3/Px4SwRhU15eHscLvuLE= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=dNd1PisT; dmarc=none; spf=pass (imf30.hostedemail.com: domain of akpm@linux-foundation.org designates 172.105.4.254 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1745629541; a=rsa-sha256; cv=none; b=hH6UgZnWwOOXrkbVyjpKjYBLqDjladdxnFJ65i+qxasElDWkynxJPQsh64RCVTBHxZc2RL 4fbwFjiJQ5RGdDo/VBm/S7T+9iKMNSnxFDiz+yD4sq7ZbZ1PmlJ/Kfc2/7vV1zgGpcXj4W bJ+YroJnjkkf08HLLIm4/XQYkL5r42M= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by tor.source.kernel.org (Postfix) with ESMTP id E27B961127; Sat, 26 Apr 2025 01:05:17 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id F0284C4CEE4; Sat, 26 Apr 2025 01:05:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1745629540; bh=yRkkSopWJBJ2Bj5q9h+LnLhTYo69bmvHBvjCNpIHSMo=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=dNd1PisT9Z2inqRSOaf++3O+j3G8lSR90Ugh9+x8FPGbLpod0FyGWl9bDZyfIOsX1 cgZ48RcefaV1fdsdkTsz59lFUR2utD/US/vQklmdrJaxQEJdqmZxOA2HkvXaaJ1Slq lLitP9QhEdRnsQNspsu+MrVoEiOgZZ1ct+S+qP4s= Date: Fri, 25 Apr 2025 18:05:39 -0700 From: Andrew Morton To: "Bernardo C. Gutierrez Cantu" Cc: , , , , , Subject: Re: [PATCH] mm: memblock: Fix arguments passed to memblock_set_node() Message-Id: <20250425180539.2b780a8b3d0958fcc2e8a500@linux-foundation.org> In-Reply-To: <20250425102003.64122-1-bercantu@amazon.de> References: <20250425102003.64122-1-bercantu@amazon.de> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Stat-Signature: 51jepq5s184r58nmeo744iqtg7h4nqup X-Rspamd-Queue-Id: 1860380010 X-Rspam-User: X-Rspamd-Server: rspam05 X-HE-Tag: 1745629540-856672 X-HE-Meta: U2FsdGVkX19JTNoSlucknEhZFqe+oKX7Jp7Apr8aa4xOyTvM7PyhtrYU4uo+JWSOBLLsqk2VeuIk7MDMatxoJlie3BEbxNGf+a8dXg1/TCVT7KRNoJOBF1q8OUXFf/reE8mpAc1VT2YFplfXuEmJhnJkLcnNBBLVOop4ZvisdMC8/uiLStqPKIaCFUDK/iYDDh/oO5eVX5HssgpzNmmgiSK7EEpXTUBUoWzg3Rq+hElZGnDEydbrq6G5nOglAHFVqipd5VMi4mwLOSVDiIN3YtQiabdl0zPDFWa7eaBiBrAPvwgrL65Utfp0MWdLU0JoTb1Nh/es09y/UIMmTrbvjBKSQBk3M6E57feSGkx+9t6MHE1T93OVeDmJTyTxu6mDttZUbcyzH175n2zZPwK6Yj7RTAG5lfA4DDIxtgbbMQcWNX8iyW9Ue3j3tEgXocIpYZzVLfjdx814aTicWsNanmj1UUrCg5Kv5r4eO81OpE9kJgF25nDIOZARCf5LGwi3Y5RbK9C+dYB5TBolYJMQ5/Z/pA97VRcw8MVp/zxKcqAiGXFmYvrHj9figtorgQZ1dyqRYwcL7TuMZuHbF50DCsM9uP2Sum2bNkC8kKWWwNRStTxVnv9l8v6UnNc44p+Ev4XJJnrnipTW15mplWXczbfG3Mw4DAnArWaEmfzl0Z9Nmg7bvDUMsaZoWV9w/Cq60PhcZFtw9cnBM+pMdVJJCO+vD4uL0S/hO5KL2EVIvCSSOvEvwLLx5bYhfkcTg/9hiLsnRjBw3z9q1fDIeGyxOzcCUHgTxSOzpYf/sfONMPyhMDuA0dQvJ/detTb+XKCaNBiznIs6vVJVpvRpgs0wvPa6siFdKORixIicQcU68e8wZ4ghzZ+kbwrCXP/r+2DcNlYgyUakhECXHvdNl0ocKiNsYZ4L3ofCDeAFiiv4Hpl58ElotFMEYHOpTDFZbKSe3YCg8xxD3CqeFmvlHRJ 0HqZsUBP 6pxi4AjSRPNPll1Q0ycq8TNPMrf03Vkh231v3Nbg2zxqUEJHpx6IulQuHHEbW0rlT32/OcNJn9PKTNFU2+m+CHpEptNjg85zGF1//jynr4sE4VlKZta+F9a3Wf9D//8n4Wzq0HDxSy4wziU6WVX2dRdElcx+a3X8ur6fcHfk5ZE8w8I8xCKHK0ayMc7Mr+387Kr64bs1dJIOMZW7Y+KNUELjI60pYJb0HkNUVvE4nEGVz/136qr0WPgNl5ud1KVZc2f7YUi+oZhWe4yTKS4TJlG3mVKVWXdh7WNdYt9kijypX7AY= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, 25 Apr 2025 10:20:03 +0000 "Bernardo C. Gutierrez Cantu" wrote: > memblock_set_node() receives a `base` and a `size` arguments, but we are > passing the `start` and `end` of the memory regions when iterating over > them in memmap_init_reserved_pages() to set their node ids. > > This results in the function setting the node ids for the reserved memory > regions in `[base, base + base + size)` instead of `[base, base + size)`. > > Pass `start` and `size`, so that we iterate over the correct range. > > Fixes: 61167ad5fecd ("mm: pass nid to reserve_bootmem_region()") > > ... > > --- a/mm/memblock.c > +++ b/mm/memblock.c > @@ -2196,7 +2196,7 @@ static void __init memmap_init_reserved_pages(void) > if (memblock_is_nomap(region)) > reserve_bootmem_region(start, end, nid); > > - memblock_set_node(start, end, &memblock.reserved, nid); > + memblock_set_node(start, region->size, &memblock.reserved, nid); > } > > /* What were the runtime effects of this bug?