From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BACB2C369C2 for ; Fri, 25 Apr 2025 23:38:18 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7561B6B0005; Fri, 25 Apr 2025 19:38:17 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6DF076B0007; Fri, 25 Apr 2025 19:38:17 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5A6846B0008; Fri, 25 Apr 2025 19:38:17 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 3894B6B0005 for ; Fri, 25 Apr 2025 19:38:17 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 730CC120D3D for ; Fri, 25 Apr 2025 23:38:17 +0000 (UTC) X-FDA: 83374182234.27.A7E5AA7 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf03.hostedemail.com (Postfix) with ESMTP id A9D4D20002 for ; Fri, 25 Apr 2025 23:38:15 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=votz5VzM; spf=pass (imf03.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1745624295; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=6M4TeuUAfyAB5cwdrPHhzwOi481NScimK7wq3WYEIE4=; b=U6ONAJmLFfWygppMN4t6t056oqUpqe/+lRwkvVL4tB/sDs1CIR+maOPm8Xka29Lr8oTfAR PWW3OiHfMK+J8GLX95jyDTtv4q/sEXyuVfJukT0HXmUtqGGPwLlQM5iBDuQ+GV/u7IFmDD 0CiJqxaa/O2hQJ1a3XAPRP6mMce0z0c= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=votz5VzM; spf=pass (imf03.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1745624295; a=rsa-sha256; cv=none; b=iY/Pp2wGHYF+eF3r/CoPxZrvhMH6ercQwW8Nq72TjeX9xihyXQ6L3Rxaf9yKQEdzPGNTwN mYaewFV02UVfXF0YH84kaCFfX2Qece3/lEUSWggbos8EA+cxz2g5XPv7wKfaomwJ+ZWSvg QPtzgYWKMj3S11BgIRScoCst2zAj2Bw= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 9E3435C6936; Fri, 25 Apr 2025 23:35:57 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E1087C4CEE4; Fri, 25 Apr 2025 23:38:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1745624294; bh=bBXE0S+pNXENLTt4NEY1ZrmeTvHC4VQlLdkgbGsAHQw=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=votz5VzMXsI/gGUGcBTOD4PPK/SqxvOT6jZ1lIrQE51GryTcYvzs9KfudOJPDFYBj 75zQs86G0NaBmP8Hj+6YL90BRsSHcM/ICGNXMs7v711+KwUIL31EcbIizsMkjU/Uql kK2RN9ofdQIhJAtwm6lV9ngyGFdOEhsvR7JqY2BQ= Date: Fri, 25 Apr 2025 16:38:13 -0700 From: Andrew Morton To: Lorenzo Stoakes Cc: David Woodhouse , Mike Rapoport , "Sauerwein, David" , Anshuman Khandual , Ard Biesheuvel , Catalin Marinas , David Hildenbrand , Marc Zyngier , Mark Rutland , Mike Rapoport , Will Deacon , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Ruihan Li Subject: Re: [PATCH v4 7/7] mm/mm_init: Use for_each_valid_pfn() in init_unavailable_range() Message-Id: <20250425163813.58b72a3aa2d3ebbd96d1929e@linux-foundation.org> In-Reply-To: References: <20250423133821.789413-1-dwmw2@infradead.org> <20250423133821.789413-8-dwmw2@infradead.org> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Stat-Signature: zss3x5tdkgig6k9twxdk5ad1apzte6qx X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: A9D4D20002 X-Rspam-User: X-HE-Tag: 1745624295-471109 X-HE-Meta: U2FsdGVkX1+atSsglqqG+eA17oNPG7gATsbTHs7YZFdTAQOuwOEnXXqTtdSVWui5S2YB5HyaJbEI6vcT5MraSYjGZrg7w4s72AH9FL9uT1D0Wp3xjmxoRrM/HMeKdUBOFnwcxxe17vcjTIJQEBw5mVOJHLrYGqAAHDwdOcWX3l88rEbghPtfyIOHYuNPxOE0xfbHBodYWH+RV2JS4DgM9JuWvLZ51vupZCLRzfIwlYFKKH8c8sHfqAgbULSogn8Bp4hXPt5vG5uziBnypv6ufLCYkq9QVs8zvyeYAKeQlY5EktDCJmwnTSn3RVdoqj4E+ekQ8G+jes1yNZnygWSWLSkiq6On3um/TLt9fgNDCVKewVmvaDwbFYUvltkcomXujSUY2dPmi8uxDXHQuI99kZ2htnohzyT44Chq+3Q693/Ghlz9oGzLJZo2u8aMxFEhFbL86UCwZziMaXq6l/pBDJfCbFnWXX6SOJFUtDf31wj8WF9qL6x1O3HuAM9Ie3UsADJdJ4MB8wZB3kdeDY79awBqreYURxIfeNZufJDqeBMemX6Nu8pCiI0qDDMQPLez0xCCMxOizC3ud9R4t0F1Z00RydIqqAxMIe+B9GU7nPKpJ9bJ1KpmPjHfvwQkLrYarmdm8NFU4KiX+v1eJc56jK4qAq7N/+EmJ1GS4cCW91GBOASyKfN/6RoOTh/iRKjXesWde9hLEqUmQ8KPGtcRk6FjVr+DdN+W1sJBmG/07QEaaboMQx70TttLQFV1P+3dIh80eZlrfcWCJhNqRltCvKOu8Wj4j0K8HUihDDssMfW+MSNNyVVra3EjGpaS2K87ppYjnnf1Y59FAimMjm4VcwGEktiph5H9b0ox/tRJfaVkMlePHssckRhyrtvW5WIgpZEP4dm6Sd/AvAs68qBLd3ypp6yltUymhazkoxtPgLYOxlZZigboeM8MPR4DbY1nk7gBB7PVPbacgCZVEG5 OcYXBr6N 4TyhKM7sajyXKIs9sgnvTwMKrUCPAVkiirb/gwmV+03agt0A2GSEPeLlZbdvA5K5mk3JgOiCrhvxL5W931CDfMDsDchP5JbQ12nSV8DnO9dRTAhPreTYqwAEKdH4DnQOyCnUvGM915wvNIE8VNS2nxmTwGsQTzxsp9qdNxU/ne7rEDFdRRx2twhyy4o6qFk31wMqObeozACztgf8zjp3Slu925XPzqUw8Udw5jrV3P/Sbdxx9VFz67N0RCs2hD0KeLipZCs2oYUdpvelOnv0xaMQFCwB5V9P8G8tEJs83FDNHMZ92tsL/gGN6/OnYTDUubij7 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, 25 Apr 2025 17:11:10 +0100 Lorenzo Stoakes wrote: > Andrew - can we drop this from mm-new? It's breaking it. I almost did, but David seems to have a fix. --- a/include/linux/mmzone.h~mm-mm_init-use-for_each_valid_pfn-in-init_unavailable_range-fix +++ a/include/linux/mmzone.h @@ -2190,10 +2190,10 @@ static inline unsigned long next_valid_p /* * Either every PFN within the section (or subsection for VMEMMAP) is * valid, or none of them are. So there's no point repeating the check - * for every PFN; only call first_valid_pfn() the first time, and when - * crossing a (sub)section boundary (i.e. !(pfn & ~PFN_VALID_MASK)). + * for every PFN; only call first_valid_pfn() again when crossing a + * (sub)section boundary (i.e. !(pfn & ~PAGE_{SUB,}SECTION_MASK)). */ - if (pfn & (IS_ENABLED(CONFIG_SPARSEMEM_VMEMMAP) ? + if (pfn & ~(IS_ENABLED(CONFIG_SPARSEMEM_VMEMMAP) ? PAGE_SUBSECTION_MASK : PAGE_SECTION_MASK)) return pfn; _