From: Andrew Morton <akpm@linux-foundation.org>
To: Lorenzo Stoakes <lorenzo.stoakes@oracle.com>
Cc: David Woodhouse <dwmw2@infradead.org>,
Mike Rapoport <rppt@kernel.org>,
"Sauerwein, David" <dssauerw@amazon.de>,
Anshuman Khandual <anshuman.khandual@arm.com>,
Ard Biesheuvel <ardb@kernel.org>,
Catalin Marinas <catalin.marinas@arm.com>,
David Hildenbrand <david@redhat.com>,
Marc Zyngier <maz@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Mike Rapoport <rppt@linux.ibm.com>, Will Deacon <will@kernel.org>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
Ruihan Li <lrh2000@pku.edu.cn>
Subject: Re: [PATCH v4 7/7] mm/mm_init: Use for_each_valid_pfn() in init_unavailable_range()
Date: Fri, 25 Apr 2025 16:38:13 -0700 [thread overview]
Message-ID: <20250425163813.58b72a3aa2d3ebbd96d1929e@linux-foundation.org> (raw)
In-Reply-To: <e772cf66-c661-422d-911a-bc13ba4d59fb@lucifer.local>
On Fri, 25 Apr 2025 17:11:10 +0100 Lorenzo Stoakes <lorenzo.stoakes@oracle.com> wrote:
> Andrew - can we drop this from mm-new? It's breaking it.
I almost did, but David seems to have a fix.
--- a/include/linux/mmzone.h~mm-mm_init-use-for_each_valid_pfn-in-init_unavailable_range-fix
+++ a/include/linux/mmzone.h
@@ -2190,10 +2190,10 @@ static inline unsigned long next_valid_p
/*
* Either every PFN within the section (or subsection for VMEMMAP) is
* valid, or none of them are. So there's no point repeating the check
- * for every PFN; only call first_valid_pfn() the first time, and when
- * crossing a (sub)section boundary (i.e. !(pfn & ~PFN_VALID_MASK)).
+ * for every PFN; only call first_valid_pfn() again when crossing a
+ * (sub)section boundary (i.e. !(pfn & ~PAGE_{SUB,}SECTION_MASK)).
*/
- if (pfn & (IS_ENABLED(CONFIG_SPARSEMEM_VMEMMAP) ?
+ if (pfn & ~(IS_ENABLED(CONFIG_SPARSEMEM_VMEMMAP) ?
PAGE_SUBSECTION_MASK : PAGE_SECTION_MASK))
return pfn;
_
next prev parent reply other threads:[~2025-04-25 23:38 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-23 13:33 [PATCH v4 0/7] mm: Introduce for_each_valid_pfn() David Woodhouse
2025-04-23 13:33 ` [PATCH v4 1/7] mm: Introduce for_each_valid_pfn() and use it from reserve_bootmem_region() David Woodhouse
2025-04-24 21:11 ` David Hildenbrand
2025-04-25 22:01 ` David Woodhouse
2025-04-28 7:06 ` David Hildenbrand
2025-04-23 13:33 ` [PATCH v4 2/7] mm: Implement for_each_valid_pfn() for CONFIG_FLATMEM David Woodhouse
2025-04-24 21:13 ` David Hildenbrand
2025-04-23 13:33 ` [PATCH v4 3/7] mm: Implement for_each_valid_pfn() for CONFIG_SPARSEMEM David Woodhouse
2025-04-23 13:33 ` [PATCH v4 4/7] mm, PM: Use for_each_valid_pfn() in kernel/power/snapshot.c David Woodhouse
2025-04-23 13:33 ` [PATCH v4 5/7] mm, x86: Use for_each_valid_pfn() from __ioremap_check_ram() David Woodhouse
2025-04-23 13:33 ` [PATCH v4 6/7] mm: Use for_each_valid_pfn() in memory_hotplug David Woodhouse
2025-04-24 21:15 ` David Hildenbrand
2025-04-23 13:33 ` [PATCH v4 7/7] mm/mm_init: Use for_each_valid_pfn() in init_unavailable_range() David Woodhouse
2025-04-25 16:11 ` Lorenzo Stoakes
2025-04-25 23:38 ` Andrew Morton [this message]
2025-04-26 8:30 ` David Woodhouse
2025-04-27 23:07 ` Andrew Morton
2025-04-28 8:25 ` Lorenzo Stoakes
2025-04-25 16:17 ` David Hildenbrand
2025-04-25 19:08 ` David Woodhouse
2025-04-25 20:12 ` David Hildenbrand
2025-04-25 20:36 ` David Woodhouse
2025-04-25 23:04 ` David Woodhouse
2025-04-28 7:12 ` David Hildenbrand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250425163813.58b72a3aa2d3ebbd96d1929e@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=anshuman.khandual@arm.com \
--cc=ardb@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=david@redhat.com \
--cc=dssauerw@amazon.de \
--cc=dwmw2@infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lorenzo.stoakes@oracle.com \
--cc=lrh2000@pku.edu.cn \
--cc=mark.rutland@arm.com \
--cc=maz@kernel.org \
--cc=rppt@kernel.org \
--cc=rppt@linux.ibm.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox