From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AF891C369D3 for ; Fri, 25 Apr 2025 15:32:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E45D36B0007; Fri, 25 Apr 2025 11:32:35 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DF5816B0008; Fri, 25 Apr 2025 11:32:35 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CBCB46B000A; Fri, 25 Apr 2025 11:32:35 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id AEB586B0007 for ; Fri, 25 Apr 2025 11:32:35 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 82BC51A19FA for ; Fri, 25 Apr 2025 15:32:37 +0000 (UTC) X-FDA: 83372958354.26.5CC4577 Received: from mail-qk1-f177.google.com (mail-qk1-f177.google.com [209.85.222.177]) by imf08.hostedemail.com (Postfix) with ESMTP id 9A9E5160004 for ; Fri, 25 Apr 2025 15:32:35 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=cmpxchg-org.20230601.gappssmtp.com header.s=20230601 header.b=tnu94ET6; dmarc=pass (policy=none) header.from=cmpxchg.org; spf=pass (imf08.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.222.177 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1745595155; a=rsa-sha256; cv=none; b=m/oV4svMkdmmI8eelc/+cWD6zkv8W/iYFnB5w/D6teHdg8VqwLM+qqkJrw7FeqT9mtL3eh cayDWgtATkmMK0kO2nL/iOoxwJuWMBMEQfscCCNBJWvNUi65WiAr9Xh1vzTxxfKFqk/lED kgMsIVoa5H4oNNRvhGTn7F6Yo347Qtc= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=cmpxchg-org.20230601.gappssmtp.com header.s=20230601 header.b=tnu94ET6; dmarc=pass (policy=none) header.from=cmpxchg.org; spf=pass (imf08.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.222.177 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1745595155; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=2asthD55KNrhLhfjveoWXz7Lfde6+xbDsGUdy2WM9SM=; b=cVA55y+40YNxfg4uqg14YkrvQM5a4rXboJrHY5v8gGru1Aum2fn2iIT2IHHpiXnaP7AAVm ch6IjzyTLDLdQmlPsv3n/MiaPsk6XPLwQ40fHjtRQdm869PXkJxJenLGXnOcONICCAhXmr OSRrThR+D/xEX+a6vinFYVctD9WarjA= Received: by mail-qk1-f177.google.com with SMTP id af79cd13be357-7c546334bdeso224671385a.2 for ; Fri, 25 Apr 2025 08:32:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20230601.gappssmtp.com; s=20230601; t=1745595154; x=1746199954; darn=kvack.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=2asthD55KNrhLhfjveoWXz7Lfde6+xbDsGUdy2WM9SM=; b=tnu94ET6SoUmaFiCvBSo8DZkpS/OYmrJlCBsfvM01V+jKjv0EP1nfN5nSq4RmCQVmO s00ufJGQLNNd2KFZHUrF87btIyFL9IJr8NTqNit7ix6u4QES4mTaSZcpznwqrUWJisEa ATs5WhteZKU7hpC6jFiAQlAqu3D/6/7DFdkpuLk0iAmTD3p74QAxtY82Eyo1yivs20LA /yLbAK4SNm5RS37YbviOl+p+LqvMfY8Oty1WTlUTaNrzgD36b5mhEBB5TiJhsznW2oRM i8EvWu4lqB3dfU7iHD90O9QdJeZcgr+h3OM75yyxvtbZ4JAgEAyxoTlL91LYollp0kDH Xc3Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745595154; x=1746199954; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=2asthD55KNrhLhfjveoWXz7Lfde6+xbDsGUdy2WM9SM=; b=e6EJ7wN0F5VZvqO5hL+/+7t8M6qW5vzZh6Eu5cBCJiPBUIsP1L2L0yvYf++wHCWv6c 2r5RKI4ZWkSqtYIGcKeHJuv6+Gj13oPmPTwMfNdaE+hJ4SwspdZAFKvX6lWl8Nxme+FQ vgsGlKXj0PNoRwmGNZLsBLUPL38Rb7Qsaofy5SXMz0YRWcIbiFfgyvlRuAIM6VPhlJzJ 14XuO47VyMlhrprczRtck9ov3Ue4GB91hFsDQNr+3GVDOGLglu0Y66OFK3OhDRGEHoXy 2JOhXIYq4tCjzPB7GOCj3CowvrBJkgqCRAeSv/tN725DGXjxJUFi8WhHJlbBSpmmOFcF VYIw== X-Forwarded-Encrypted: i=1; AJvYcCWuN5rXg5FOk/NF/u+Hgyo7GlZ+HJrF8cwB2NWQ34XUCYaRAlcIN5kL1cNAGc/ywUVMud/oe12eiw==@kvack.org X-Gm-Message-State: AOJu0YzP8HgS3NhAgCvIzIH+MVOh3Llmxe8+exH508l5in/Bw5kK12kV XuunYmg3LgocaGhJYaAmm/25OoWQCht4OjY5d4HZRzBRu9IXBX7QPisVYoCFJ8c= X-Gm-Gg: ASbGncsRGBR5tVaZ/OeH+nijgRYfTLsf14IRRbLgSVn5vd9K/I2Qnlp/5EVWl5q3XSA tgD4wpDdGvT2vjEaJkH70fABBvmI/BJUOLyVdhCckbPN6N6WjFeK5k2wN/LGyvYPGTBHjhbyoac KlyDbJXchBJaoVNcXiI2DYwjG9FFT9j039+Qmpe+iySTGz19gDYTILln87G4gHi2BtHn/tghMig iSAB3XVEOlgg6LKBJZcvHfJA9xNSotJv6Hlw3V7GN131EHmsUoGtuYXMg4NRUVw+2zfu8CKNtjr 7fHjbgYOsTfobMvbZmijaZtV0rp4ORcnu2T3nwYSHMHS+4oAzg== X-Google-Smtp-Source: AGHT+IGGNDFMq3A/3qPkkk3vuTcBJDIniA6Zbds6BvL0JT/ppafg1A4GyBmW2YxTKwrlYEuzUJHlXA== X-Received: by 2002:a05:620a:2a0c:b0:7c5:59a6:bae2 with SMTP id af79cd13be357-7c966863bf5mr6043885a.4.1745595154670; Fri, 25 Apr 2025 08:32:34 -0700 (PDT) Received: from localhost ([2603:7000:c01:2716:365a:60ff:fe62:ff29]) by smtp.gmail.com with UTF8SMTPSA id af79cd13be357-7c958e7bdfesm231289485a.75.2025.04.25.08.32.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 25 Apr 2025 08:32:33 -0700 (PDT) Date: Fri, 25 Apr 2025 11:32:32 -0400 From: Johannes Weiner To: Wenchao Hao Cc: Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm/compaction: do not break pages whose order is larger than target order Message-ID: <20250425153232.GA108388@cmpxchg.org> References: <20250424153815.4003-1-haowenchao22@gmail.com> <20250424194200.GD840@cmpxchg.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Rspamd-Queue-Id: 9A9E5160004 X-Rspam-User: X-Rspamd-Server: rspam07 X-Stat-Signature: jhkqtffaoiog596ksi3x3xmnarwp8m47 X-HE-Tag: 1745595155-115711 X-HE-Meta: U2FsdGVkX18xM48NowRhKgEgdZk8YTIJQTKDZrqHqEVEPvCcP8SwgTTGShq7UMncYqSfmQ5dpJ8iCTEWPFlBoaUz+ru1/4NBP9LMqcKauzi6YSuLhv//KhaOf5E/SSaWgiSq2IjWW/TAWMcSQ5wgaUv801lERsAwEMs71B6HrL8uIvY8m2qmKzS4auCNSWNZUNT7QKZx/MohLxXNfn4P1Oo/NCEPFtnwDhSU4j9FFejtatwltaiSyP8eYRaqnxfOm6W5kOaXWy6tCQGZgBsndlpKHCy9hY2x28ahMUShzTiqt/qcOVvPjtoV33HYnqvwO+Lb2PgGMkF+PvoAlCUU7f91O9Ii8rG0KZ9Zzoeuh2xXPqEpIG7tt0f5OXQDMOUz3Pyzql5ZopHdcbCcQCNNl4/sZnb3m6JC2OKuU2JtGtYw3Kvj7w3CxFyKuQ76caPaRPEF9i1QxP98uDoSsbGjWbGno58aTYtf+2BBwM0YOmgrMXQ9CideA4WYb2oil8U2lfd3PHdzyJ66pZdbxd1ncBa7noK8JlBvsTQj/xaaBOduEujnumq6EUwEHHxg6+6l9cOIkSza4zQ6p4c4M/gY9f+z+wakqumRQMJzFCk3V3aawDXYOkn/8rRCA/f2D0Qu+d2iDzGOR2x1QsfX9hKZrQkaCwV+BmWleKWqoCihFcG7I7UwNO96lJ/ZPUcqhgn17+nuYOOgrsQ8LwN924GDhHc9l8rta9QMvGiBlkp2mj9XuB6RsBZQKPzPmiMa0//+kBvHYROAOjQaeG2hNL9bmRekkK+UmpJ9qfgWDs1KaTin5muBRsQlaz5EWvxB1GBp6skCPzGJF6+sxdx201ug6AEoXYClUMPn4RXTADIx9X7F34eQLY2F1vOxnYwsqSRHCAYzswKDkBW+z1uuB9/9X41GMEpprJKTna7lXKuhIPncNaP+uxJwyANX0fVCQareSyaCSfTBkK+YkQBbM3p 7xa8G66i v2Wf4IAyjPozzxJc62UXdnSoajQRdaadF/wySlfY1sGFHiFeUm3CzQREvY5Jcb+wkRzbNydZ8XSnBG9I5sYy9r1rm2w== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Apr 25, 2025 at 10:28:42PM +0800, Wenchao Hao wrote: > On Fri, Apr 25, 2025 at 3:42 AM Johannes Weiner wrote: > > > > On Thu, Apr 24, 2025 at 11:38:15PM +0800, Wenchao Hao wrote: > > > When scanning free pages for memory compaction, if the compaction target > > > order is explicitly specified, do not split pages in buddy whose order > > > are larger than compaction target order. > > > > Have you observed this to be an issue in practice? > > > > compact_finished() would have bailed if such a page had existed. > > > > Yes, when proactive memory compaction is enabled, there may be situations > where the order of isolated free pages is greater than the compaction > requested order, and compact_finished() will return continue. proactive compaction has an order of -1?