From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2C95FC369D1 for ; Fri, 25 Apr 2025 10:20:24 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8EF0F6B0008; Fri, 25 Apr 2025 06:20:23 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 89DF46B000C; Fri, 25 Apr 2025 06:20:23 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7666E6B0012; Fri, 25 Apr 2025 06:20:23 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 589EC6B0008 for ; Fri, 25 Apr 2025 06:20:23 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 4FBC3801B3 for ; Fri, 25 Apr 2025 10:20:23 +0000 (UTC) X-FDA: 83372171526.07.934F90E Received: from smtp-fw-80009.amazon.com (smtp-fw-80009.amazon.com [99.78.197.220]) by imf06.hostedemail.com (Postfix) with ESMTP id 3DD3B18000A for ; Fri, 25 Apr 2025 10:20:21 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=amazon.de header.s=amazon201209 header.b=Wo4XMpKT; dmarc=pass (policy=quarantine) header.from=amazon.de; spf=pass (imf06.hostedemail.com: domain of "prvs=203115a60=bercantu@amazon.de" designates 99.78.197.220 as permitted sender) smtp.mailfrom="prvs=203115a60=bercantu@amazon.de" ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1745576421; a=rsa-sha256; cv=none; b=0V162H9vTocu656Rb2HDpRQMTOVKzPj8CYjFddRkrp5cHuE47sYjehQRk7pNHk6JgGqTYM 9dqgjH46iWoQdbx0gbm4HvC0gVapdxVywADW+BmFhZV4EF+SqS7qEtpR7pbNyAc670zQjW rHpKDCIfYlx37ByzzONcIJqSWyl0Tlw= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=amazon.de header.s=amazon201209 header.b=Wo4XMpKT; dmarc=pass (policy=quarantine) header.from=amazon.de; spf=pass (imf06.hostedemail.com: domain of "prvs=203115a60=bercantu@amazon.de" designates 99.78.197.220 as permitted sender) smtp.mailfrom="prvs=203115a60=bercantu@amazon.de" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1745576421; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=9MCmXbidRkR+q6lK/LlO8ENPf08O7LIBh2qUjZeb8xU=; b=26WwgS9AW5KGdjcL58ORMzfTQj66x1poD589Z5P+NZpaosfsBCYADLpgpr5fzoYjf7lakt BIWkU1q1dQfNairunbShiThJceZpxqzDMqSBq/n/jcQsyGgWaGNcUarEfxtxELdyv4IflM orURkGq65F9dDt9P/ydiqx8FWjAZzFk= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amazon.de; i=@amazon.de; q=dns/txt; s=amazon201209; t=1745576421; x=1777112421; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=9MCmXbidRkR+q6lK/LlO8ENPf08O7LIBh2qUjZeb8xU=; b=Wo4XMpKTD76hivi+A8iEArVNBM+v1eBY8JvTHM8XGo6t7pbypDSUAku2 1ntnD2dd0uixxlFI46/7RKlqR3UHqw7mO6s1cAqhV2KqZyC0SQ2ocRzxJ P3ZcFcO5StjenTulQbC/p3VbzehLw/SY4mB2fGADcSYGnBVEMmtBdhTcN U=; X-IronPort-AV: E=Sophos;i="6.15,238,1739836800"; d="scan'208";a="194318961" Received: from pdx4-co-svc-p1-lb2-vlan2.amazon.com (HELO smtpout.prod.us-east-1.prod.farcaster.email.amazon.dev) ([10.25.36.210]) by smtp-border-fw-80009.pdx80.corp.amazon.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Apr 2025 10:20:18 +0000 Received: from EX19MTAEUA001.ant.amazon.com [10.0.10.100:12409] by smtpin.naws.eu-west-1.prod.farcaster.email.amazon.dev [10.0.15.207:2525] with esmtp (Farcaster) id b95b1a64-d152-4f5f-9220-4bcba3fe2c21; Fri, 25 Apr 2025 10:20:17 +0000 (UTC) X-Farcaster-Flow-ID: b95b1a64-d152-4f5f-9220-4bcba3fe2c21 Received: from EX19D014EUC004.ant.amazon.com (10.252.51.182) by EX19MTAEUA001.ant.amazon.com (10.252.50.223) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA) id 15.2.1544.14; Fri, 25 Apr 2025 10:20:17 +0000 Received: from dev-dsk-bercantu-1c-725598d7.eu-west-1.amazon.com (10.253.100.253) by EX19D014EUC004.ant.amazon.com (10.252.51.182) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA) id 15.2.1544.14; Fri, 25 Apr 2025 10:20:14 +0000 From: "Bernardo C. Gutierrez Cantu" To: CC: , , , , , , Subject: [PATCH] mm: memblock: Fix arguments passed to memblock_set_node() Date: Fri, 25 Apr 2025 10:20:03 +0000 Message-ID: <20250425102003.64122-1-bercantu@amazon.de> X-Mailer: git-send-email 2.47.1 In-Reply-To: References: MIME-Version: 1.0 X-Originating-IP: [10.253.100.253] X-ClientProxiedBy: EX19D038UWB001.ant.amazon.com (10.13.139.148) To EX19D014EUC004.ant.amazon.com (10.252.51.182) Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 3DD3B18000A X-Rspam-User: X-Rspamd-Server: rspam07 X-Stat-Signature: e4g8x73fmc1u48k7zy59wf7sa9pkcwxi X-HE-Tag: 1745576421-4384 X-HE-Meta: U2FsdGVkX1/Vtse9/0zTIFTiKDWtE2Lzqvn6p8BXhVUwdlLmpejU3fOtwC2XWBqFcC9YJFU+M9GygK0t3GOSN4/It8F6sdANH7z3SLS+56YkXjb0DSkJwBQ9fAeM+pkgeb2Lsa6S1Bxr9jq1qw0zQPbTE857FBHuy7YoVzxHGnooLFHpoKE2pSwignWrbp8KKr44HqtKczwb80AFYgN36hqkaT+av+bOoPT/YKizQMpLHPNBXrdrsFOeZ7UtIRw6c7fYVMdsJLgXdpF4xFNDw/FwA/xCL8wwPGIiT2wZjnlBFbR7wii9gV2WKH+4y2t6nomTyyTEGfMdks+0Parj4C9FNBZqxdnvR3DOJDXzcI02PuCdOVjYkTDmU6U9uRGzwur47OoGgx1iMmkXpBqnsctuAFWyVToOG6ynsyLAdRQAHXjS5tqE9PNI0FTt2kpkTQnS/6xBTYvN9MbWbIsQGKVQ3NUZMTqy7TRrV5HLMYI4HYUDuj5bJIpaxxp1D+0vyZOqEzbZSQGzZNSHjizumMEi13a+LMYPP/Mh/z1MOM862wQ04IOhu+vsRhUZ4EdWsKbBFuBpnhtPy7UQXxodFGG8za4zHwuUY7yR3uAKvFg6M5GeluJveS042HDOQgC+uq4YUzfP8kFcuhAP2cfDHXq0+F5J7xNbR4KvVqENVGSA7DE9pRt78fIb/UWRMwSPuRSZbPKLvMlJ1KPfe9KrO3syqPY+efHdjC5sKi22WkBtL7AQrsQ7OEok1jqIzMLKtze0Id6MXIShhGh1BDKYSfR0VDD2CHHaaJ0WNdmcDVnWHmIyObRh/+lhzt8NYq7u6WvNts38eZZEF/xqlaFF5v6MMZajOwRjM4w1Dbqd7Xa4dLPvnUGbFKYh/gxHoMv/l99E+vNtaWvojdfWOhVMnp1Bymuew+gEDM6grodSgDq9H0QsenzP4nxuFPvYSN5NZKvVA+nsbzIovqjiwMp YWaRah/3 3y0xquMNrOTp2YQ5aJK4EEadm41VYNLsrvStAKLw82GFZzKSdHMr+oO0cmYQO4gLVlftLznFAgqQ2txqP3L4pJPnwK2Uo/V9rltEZ4yGkgc4L6SAlvVfnFupieGCO907762yI3COiXV9PO9zxJ5xN+EeztN2xtAoN0hap2cOtEcKWU+gBgT2fyl6ziAnD2CdDxnyxJNKTmyhxGcPzIUOe2Y7NalzkNqHb7VdGHfkBOyjAWPf3D3Zy/U0I6ry2XhvtbhsoikfJA6zkZ7KhlVeGpdNchTe1Ey2+KrimREt7S3B0EgwO7HM0mUGVbXqXTDwLJWZ4ha4UNq833MlZYc3CM6mJS2Hh6+5rWu067znkxPqAIUhsawxaGpsK7vOJI/WAAkddXPSFgo1HjanV3dsXT0Dd2BsmyveClGctVcVteVtnDSRKESghG2PfQK/mDhknANiRGvq7s1vFmAocy8za/vJNQqHgAUQystfnw5jWaLu1MDKA8Vuvo3o60w== X-Bogosity: Ham, tests=bogofilter, spamicity=0.099797, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: memblock_set_node() receives a `base` and a `size` arguments, but we are passing the `start` and `end` of the memory regions when iterating over them in memmap_init_reserved_pages() to set their node ids. This results in the function setting the node ids for the reserved memory regions in `[base, base + base + size)` instead of `[base, base + size)`. Pass `start` and `size`, so that we iterate over the correct range. Fixes: 61167ad5fecd ("mm: pass nid to reserve_bootmem_region()") Signed-off-by: Bernardo C. Gutierrez Cantu --- mm/memblock.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/memblock.c b/mm/memblock.c index 0a53db4d9f7b..9639f04b4fdf 100644 --- a/mm/memblock.c +++ b/mm/memblock.c @@ -2196,7 +2196,7 @@ static void __init memmap_init_reserved_pages(void) if (memblock_is_nomap(region)) reserve_bootmem_region(start, end, nid); - memblock_set_node(start, end, &memblock.reserved, nid); + memblock_set_node(start, region->size, &memblock.reserved, nid); } /* -- 2.47.1 Amazon Web Services Development Center Germany GmbH Krausenstr. 38 10117 Berlin Geschaeftsfuehrung: Christian Schlaeger, Jonathan Weiss Eingetragen am Amtsgericht Charlottenburg unter HRB 257764 B Sitz: Berlin Ust-ID: DE 365 538 597