linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Vlastimil Babka <vbabka@suse.cz>,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	llvm@lists.linux.dev
Cc: oe-kbuild-all@lists.linux.dev,
	Christoph Lameter <cl@linux-foundation.org>,
	David Rientjes <rientjes@google.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Linux Memory Management List <linux-mm@kvack.org>,
	Roman Gushchin <roman.gushchin@linux.dev>,
	Harry Yoo <harry.yoo@oracle.com>,
	Nathan Chancellor <nathan@kernel.org>,
	Nick Desaulniers <nick.desaulniers+lkml@gmail.com>,
	Bill Wendling <morbo@google.com>,
	Justin Stitt <justinstitt@google.com>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Subject: Re: [PATCH v1 1/1] mm, slab: fold need_slab_obj_ext() into its only user
Date: Fri, 25 Apr 2025 04:35:54 +0800	[thread overview]
Message-ID: <202504250400.BLLCAX1T-lkp@intel.com> (raw)
In-Reply-To: <20250424164800.2658961-1-andriy.shevchenko@linux.intel.com>

Hi Andy,

kernel test robot noticed the following build errors:

[auto build test ERROR on akpm-mm/mm-everything]

url:    https://github.com/intel-lab-lkp/linux/commits/Andy-Shevchenko/mm-slab-fold-need_slab_obj_ext-into-its-only-user/20250425-004842
base:   https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-everything
patch link:    https://lore.kernel.org/r/20250424164800.2658961-1-andriy.shevchenko%40linux.intel.com
patch subject: [PATCH v1 1/1] mm, slab: fold need_slab_obj_ext() into its only user
config: i386-buildonly-randconfig-001-20250425 (https://download.01.org/0day-ci/archive/20250425/202504250400.BLLCAX1T-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250425/202504250400.BLLCAX1T-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202504250400.BLLCAX1T-lkp@intel.com/

All errors (new ones prefixed by >>):

   mm/slub.c: In function 'unaccount_slab':
>> mm/slub.c:2591:36: error: implicit declaration of function 'need_slab_obj_ext'; did you mean 'free_slab_obj_exts'? [-Werror=implicit-function-declaration]
    2591 |         if (memcg_kmem_online() || need_slab_obj_ext())
         |                                    ^~~~~~~~~~~~~~~~~
         |                                    free_slab_obj_exts
   cc1: some warnings being treated as errors


vim +2591 mm/slub.c

0bedcc66d2a43a5 Vlastimil Babka    2023-10-03  2587  
0bedcc66d2a43a5 Vlastimil Babka    2023-10-03  2588  static __always_inline void unaccount_slab(struct slab *slab, int order,
0bedcc66d2a43a5 Vlastimil Babka    2023-10-03  2589  					   struct kmem_cache *s)
0bedcc66d2a43a5 Vlastimil Babka    2023-10-03  2590  {
4b8736964640fe1 Suren Baghdasaryan 2024-03-21 @2591  	if (memcg_kmem_online() || need_slab_obj_ext())
21c690a349baab8 Suren Baghdasaryan 2024-03-21  2592  		free_slab_obj_exts(slab);
0bedcc66d2a43a5 Vlastimil Babka    2023-10-03  2593  
0bedcc66d2a43a5 Vlastimil Babka    2023-10-03  2594  	mod_node_page_state(slab_pgdat(slab), cache_vmstat_idx(s),
0bedcc66d2a43a5 Vlastimil Babka    2023-10-03  2595  			    -(PAGE_SIZE << order));
0bedcc66d2a43a5 Vlastimil Babka    2023-10-03  2596  }
0bedcc66d2a43a5 Vlastimil Babka    2023-10-03  2597  

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki


      parent reply	other threads:[~2025-04-24 20:36 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-24 16:48 Andy Shevchenko
2025-04-24 17:15 ` Vlastimil Babka
2025-04-24 17:22   ` Andy Shevchenko
2025-04-24 19:41 ` kernel test robot
2025-04-25 17:07   ` Andy Shevchenko
2025-04-24 20:35 ` kernel test robot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202504250400.BLLCAX1T-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=akpm@linux-foundation.org \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=cl@linux-foundation.org \
    --cc=harry.yoo@oracle.com \
    --cc=justinstitt@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=llvm@lists.linux.dev \
    --cc=morbo@google.com \
    --cc=nathan@kernel.org \
    --cc=nick.desaulniers+lkml@gmail.com \
    --cc=oe-kbuild-all@lists.linux.dev \
    --cc=rientjes@google.com \
    --cc=roman.gushchin@linux.dev \
    --cc=vbabka@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox