From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 93581C369C2 for ; Thu, 24 Apr 2025 13:12:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CE7C76B0096; Thu, 24 Apr 2025 09:12:07 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C6C7D6B00AE; Thu, 24 Apr 2025 09:12:07 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B0ED06B00AF; Thu, 24 Apr 2025 09:12:07 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 8E24C6B0096 for ; Thu, 24 Apr 2025 09:12:07 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 18C1B120391 for ; Thu, 24 Apr 2025 13:12:08 +0000 (UTC) X-FDA: 83368975536.30.CD631FB Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by imf17.hostedemail.com (Postfix) with ESMTP id 1C45D4000C for ; Thu, 24 Apr 2025 13:12:05 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=korg header.b=aZbBSCNm; dmarc=pass (policy=none) header.from=linuxfoundation.org; spf=pass (imf17.hostedemail.com: domain of gregkh@linuxfoundation.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=gregkh@linuxfoundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1745500326; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=848uxP1KuuBWZzpHI4+1SU2ITUeHZOrVkE5Dt68NCF0=; b=IM7n52hcV3y4eKGJP975NhQoMDCGhEkKNxRZX0U8o4qtVAl7XkT+uUwn6hzIYdqoLltqrE AUbCp0rTUJKYl9x5XYtC4v9tljaGsaL5QA4XS8oaYWiaJKkLVsZtCHSh7OdCt365lE4Nv5 5veAjQucSI68KVRkHzFZLqDsPCBk6/g= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=korg header.b=aZbBSCNm; dmarc=pass (policy=none) header.from=linuxfoundation.org; spf=pass (imf17.hostedemail.com: domain of gregkh@linuxfoundation.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=gregkh@linuxfoundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1745500326; a=rsa-sha256; cv=none; b=UL11THlR/tF/XP3SbicM6H9buSOuRxgqjXbozygPIBdS3Zasc0O0frV6+6vaj6c2lNs1CR +lYaTtvfV1TdK88DVMR99iYzpNqYqup4+KXOVUatulLWVSuqgl3e5Vr3MbqinLOW3ea2cF M1vibYeNP/WiTF+QR2KnMgzgPh5xUHE= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id 319A1A4CD5C; Thu, 24 Apr 2025 13:06:37 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5E35AC4CEE3; Thu, 24 Apr 2025 13:12:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1745500324; bh=4cvuzHcmHrwa785PAn6weho6zU3Lk00QP2t5Neo56Rg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=aZbBSCNmLH4viOCChkBsuLlguE6dtJB0G2K9cC0usOI1PKUGrCDJwQwU3SWPFUL33 R65w6nXourbz1aa70I21U+di6kSvmxqF54iX9Lkx9XOKqOjTb3fANiWmSYq+c+UWL5 I3uYWEvMGHw27lsitsRLn514qiByywTncJJURXcQ= Date: Thu, 24 Apr 2025 15:12:02 +0200 From: Greg Kroah-Hartman To: Stephen Smalley Cc: paul@paul-moore.com, omosnace@redhat.com, linux-security-module@vger.kernel.org, selinux@vger.kernel.org, Tejun Heo , Alexander Viro , Christian Brauner , Jan Kara , Hugh Dickins , Baolin Wang , Andrew Morton , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH] vfs,shmem,kernfs: fix listxattr to include security.* xattrs Message-ID: <2025042427-hardship-captive-4d7b@gregkh> References: <20250424124644.4413-1-stephen.smalley.work@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250424124644.4413-1-stephen.smalley.work@gmail.com> X-Stat-Signature: cjencxsi4p4fh5krcj39zewoaubwon6i X-Rspamd-Queue-Id: 1C45D4000C X-Rspam-User: X-Rspamd-Server: rspam05 X-HE-Tag: 1745500325-370413 X-HE-Meta: U2FsdGVkX1+iDYOQMp0+IHuA5pgrlOblpeeV0CPch8DjiktlEHqTNVBOkFTgikcChpAdkh2S3HxRR4zab+V0kpHmIDxMxCifytiDxgynTS0haZooGIykPYWx1MBlYm8FQeP1C6DaNgFwv0iS6CkHO2gYnXIKWCUiF9UUqNE19RWbwCL2hdGNeGtj8xbBObBGNtdYf6iSABeUgXi0VS3+/cbhB+G8oxbz+KyipbtjDWaRWckYGnBba4LkbtT4juQTsmvZ/X01Rb9MZzFMpGgy8osrDc5++/Zw52eN6PU3kqNi7Eu51ZvZA7gJaiPNLcr2FAppS0+clexOMzXrGq8Zb8wvADuLuniVyqQNrKfkASElc3sTY3HDGv3z+Z1tIM7kdwKqOvd75amk0S/Nc0iP5I2LblKHnLFr/p7iqx4DzCarfjeNh31a0UaWnCa3K1LmV50opTec4ttMSaZWGLxHgn8Y3fg8U36QxfvQskw1V2+IHREh782loDxqCPCgecKRelvHspcgHYPWPWhSNjVscH6ADXXIyKE/9d9wtPvtJLfpC4KvJGfq2MG7CSYEbhxm0TpVyheEadlkfuvNZYBbECcwQb3hiTbUmr/+GNkYO6/C8KCpipAVs9SUetzPeCyT5crPYVMn0KVW4vdUIVvQjrnD88P27O4LW/YKaVKOO/dO0ZK1Hs226Bicx6C2LNPWThA2CiElKj+5sq0mTKeSqWz05QgyIPY8gvz6NduxBdL+WG9JZFCN8r4Ea06GLvdadXb3827CCcnxjhYiGhhDy2Ij9zmBUJt+3ExlpjBx15gZyEOUSOZrRyNkMGRqoXCC3PQMe/iEgcCyGSNgTgxSfZABYULKSwwuZKz5Q828GahNtNeHzK2V673M919kFKVZLUqJAetyRjnOnkSaMmTE65FI4n9hrF9Q/IrbNFA+nmsCLya1c5ijsKaBnfnnruySun4ITJdIbJ2Wbs9mYtO BLmWYw5J wVamGinY82fSC8hOcxvAjWNxBmZLkZdO09kYnhiCgCdsz9rbOjwDkSpSIsmRH1DlJarp5He/x5Lyw5CfjKcJNhQadxrRYLscZzRuEAQEsceStpXP2MjkMfMhZx5U1TX33NCG+ByEZpF4K9bu4D4zR9HHJIerfPip8RYc8dDs6VYK81Mn0LBtiK9ZekOxn96MZgw0hpjAQp7+5+DR2w4QeQ9nu+YNkonHcP8/A50Otw66ttUx3TcK0uk1xA+Ns480wcWUv0/ie6a/rKQarq9mM7EuiQIi2b9jYx1oFp5/s/rODvmBWgR+snDn7C7elWM2UsE8xfQsHRPRsBQ7/nNFonQPT9L1tqUr7s2YnVAVeiBsSvLuGueoBwG+/iBmJfsaw5OSIHjMOkqlKf+JvdgoZ8S3wcPt6M7O5d5M67ewhhFVvs3qgLckTXxV7hg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Apr 24, 2025 at 08:46:43AM -0400, Stephen Smalley wrote: > The vfs has long had a fallback to obtain the security.* xattrs from the > LSM when the filesystem does not implement its own listxattr, but > shmem/tmpfs and kernfs later gained their own xattr handlers to support > other xattrs. Unfortunately, as a side effect, tmpfs and kernfs-based > filesystems like sysfs no longer return the synthetic security.* xattr > names via listxattr unless they are explicitly set by userspace or > initially set upon inode creation after policy load. coreutils has > recently switched from unconditionally invoking getxattr for security.* > for ls -Z via libselinux to only doing so if listxattr returns the xattr > name, breaking ls -Z of such inodes. > > Before: > $ getfattr -m.* /run/initramfs > > $ getfattr -m.* /sys/kernel/fscaps > > > After: > $ getfattr -m.* /run/initramfs > security.selinux > $ getfattr -m.* /sys/kernel/fscaps > security.selinux > > Link: https://lore.kernel.org/selinux/CAFqZXNtF8wDyQajPCdGn=iOawX4y77ph0EcfcqcUUj+T87FKyA@mail.gmail.com/ > Link: https://lore.kernel.org/selinux/20250423175728.3185-2-stephen.smalley.work@gmail.com/ > Signed-off-by: Stephen Smalley As this "changed" in the past, shouldn't it have a "Fixes:" tag? thanks, greg k-h