From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7501EC369AB for ; Thu, 24 Apr 2025 19:17:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 97D3B6B00AF; Thu, 24 Apr 2025 15:17:30 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 92B376B00B9; Thu, 24 Apr 2025 15:17:30 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7F3476B00CE; Thu, 24 Apr 2025 15:17:30 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 628CE6B00AF for ; Thu, 24 Apr 2025 15:17:30 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 2CEBE81ADC for ; Thu, 24 Apr 2025 19:17:31 +0000 (UTC) X-FDA: 83369896302.12.B16342C Received: from mail-qt1-f180.google.com (mail-qt1-f180.google.com [209.85.160.180]) by imf21.hostedemail.com (Postfix) with ESMTP id E73281C0010 for ; Thu, 24 Apr 2025 19:17:28 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=cmpxchg-org.20230601.gappssmtp.com header.s=20230601 header.b=ZbGWC8dP; dmarc=pass (policy=none) header.from=cmpxchg.org; spf=pass (imf21.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.160.180 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1745522249; a=rsa-sha256; cv=none; b=yu56lf6DtnCyCsJJZnn977TijmBYIY9q5/2ebW/TyM6igG4D1BF56KUr5rq4pLJt9hhc3D KLnciLUR3L4ReVVEDaJH0dqLfxf1vq77UuO8EPZ1C5CWwv2ewrs4xMYszdsAuQl22vDPLB 7ZvQZK0Tmlu1psJjnQjynECJ07D/Ltw= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=cmpxchg-org.20230601.gappssmtp.com header.s=20230601 header.b=ZbGWC8dP; dmarc=pass (policy=none) header.from=cmpxchg.org; spf=pass (imf21.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.160.180 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1745522249; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=WgkJ7dNx72+BXbWCJgltCrdHxMR6F5quAng7bdlmKzE=; b=QZCYoMLTqpGZ5gsK2JVTfL1qeWd0bkSKfliubjEWmT+40Z3Vk0mSdXNcH6Gn11Wnw1Nm3p /Q+pAGL5NcT0pkfYN/lnjmGaxB6LZr8xiMBSQ3DO2u9be/5dEw+sav+AxvmqHYWJFjaOwj IioVccoAdTZbVViek/y1AM4zHD0k+I0= Received: by mail-qt1-f180.google.com with SMTP id d75a77b69052e-4769aef457bso20425901cf.2 for ; Thu, 24 Apr 2025 12:17:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20230601.gappssmtp.com; s=20230601; t=1745522248; x=1746127048; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=WgkJ7dNx72+BXbWCJgltCrdHxMR6F5quAng7bdlmKzE=; b=ZbGWC8dPMKQoGjHZGZKIkk1PC6dqNndPtErszI5nDzvHWv08JdfsshaKLip9s4pYQp aFUk5nvMA0+SpS7uv7t+koPX1Xy3FPYvX1z21byXahZfrB3x1ZGlivJ+IZFOb1IayrUU CKCFF4LGP9TCRW48VmKERA+cZXOvksAnpyvhSPzYtpep3ey/ET1ZWqvN1tXKRJQzlJkZ q54dxTjNAYQ8lXslyCC23nMS9lH13ToRhn03Z1AsANa/Fcxlpp1FbNrYbiJkEPm6u5tq EdQDvRq5wgv73lxZBz9mVMMOwdVvwKT205fLwj+VOLmib5OO9Nt/oJiucrw3JFqxwCUq skIw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745522248; x=1746127048; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=WgkJ7dNx72+BXbWCJgltCrdHxMR6F5quAng7bdlmKzE=; b=q/VhD4YnEj+ep2eHxw+BTxmEMbDajg2EyhjT3AVZixv4uXa/5pe3yh4Jnoo62EwcWS pTDVgH7q0b/MFxuGRXzkMf/1mO/WauH06x5RVvnndNrELj4NY0+8LJ7KNTYLHSSekWK+ 7MF+tgOU12SbJx10U8D31/xszomXMkEZ9v1bnYz4BZ0b18/p5+8H6alAPsEtI/ObAB6W 9GPY85j/tddP3onLW1PX/VKPwmDaIUyNHl4N9xz1hgKTkjyDOdKbC9jnNBdJL26Ii21w jdgbyUYT4til99Y+v2I709RlkM8GNPBoy1us/X9JdjBvbcL9rcATraX+cuTskR7NADpW +BNQ== X-Forwarded-Encrypted: i=1; AJvYcCVsCqmDZnirkVGoEJs+nkFS1YbSLk5u7J3TsBrdJ+R4j9XegucWkcN5kgDvFqXumMmUq7yi+wv7+g==@kvack.org X-Gm-Message-State: AOJu0YzCuUQSM77bULsedZyy3nvdZWhEXlGRibDFQteDqtvA1YGIGAgF 2MyiYffK3vhciwDD+C9+gI87kNP3ovvIaQY78Igsbk6oAHsJYsXSmXgS8FKMNNtmyfCuu93pjV9 XHg4= X-Gm-Gg: ASbGncs/iCP2YSQ0+A130sefVzii+3SAW1TUiAoYU7X+Hl5MqaZ0k/Xc9gaTcl9Bg14 6zw3AFKnWWdorTX+abXTvwAVfUgA7QYSRP7Mn8Zbo03nsAco9A/zQBDf94+xYm+GjGUsNPCYzF4 X5dv3C0JKAOSvutTzqAop24no9z12ShwvWJDhqIndo+0NNuJqQa43rmNEFnfn1Bd3OYbzJaxCVU 24zveiuowLoiF4TgzIlIA6/uMUjKBzFXKEnWSLRnQWIU7gIznd4wUgHYUu3wzibA3I77kaC61wU sLT5AyEVXiDKc/ZQCxoVbdWSNbNfTijeFLKMNpE= X-Google-Smtp-Source: AGHT+IHkyRBu9V6NCZ7c0WkZtU097BjmY/ViJB8SmesavAH39ZGN0trFmtrBbF9fZcBHK3K5PdeAnA== X-Received: by 2002:a05:622a:1903:b0:476:850a:5b34 with SMTP id d75a77b69052e-47fba29aab6mr14594891cf.30.1745522246432; Thu, 24 Apr 2025 12:17:26 -0700 (PDT) Received: from localhost ([2603:7000:c01:2716:365a:60ff:fe62:ff29]) by smtp.gmail.com with UTF8SMTPSA id d75a77b69052e-47e9f7a8326sm15352661cf.37.2025.04.24.12.17.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 24 Apr 2025 12:17:25 -0700 (PDT) Date: Thu, 24 Apr 2025 15:17:22 -0400 From: Johannes Weiner To: Pedro Falcato Cc: Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm: workingset: Simplify lockdep check in update_node Message-ID: <20250424191722.GC840@cmpxchg.org> References: <20250421-workingset-simplify-v1-1-de5c40051e0e@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250421-workingset-simplify-v1-1-de5c40051e0e@suse.de> X-Rspam-User: X-Rspamd-Queue-Id: E73281C0010 X-Rspamd-Server: rspam04 X-Stat-Signature: kf8jcswj5xd3iofbex9by1sjnts65eij X-HE-Tag: 1745522248-101324 X-HE-Meta: U2FsdGVkX18MhOVB92V4nggeNAnci3feG6ue7bSB9yfwVSy1RhI0JhXD/VDnNoMRmCY6WhyMMin9APLzesP4M2amzhBFp4kEVq8CumQhEHW+KSogrJOXSKX/FuFreRyEQHjkNhZiB28tfYJdrPpf0jn/UEmMz9J4I12cUeZ7iL57gk5/p9O6rqi6ZcoGuNcNmoTmuYOfFnP1eHaFPIg/tDKjQ7h94dno8+vnAy4YgLwZPj/iTv4FbjaqFmrh8HncZxxAewfsu7jVgFPEYZft49ftQEBQUpQTcrRnAbjya8PKSqtTgDOxJlKSk5mp9DVQpqqEOGWSN9BdnEzMtegfxI9psUqnQBNmC4ncEYHDlRafcJ4uw0zZ0fJQVqqrHVxiGRsxC3IdkMS+g7b3rVhdmE8O352FleePOw0c0lpnc8j4agGda/kM+8+IIBnWi6Gm+yaLqYUukJnwquhnEPmSkD8ciuR4YEmBH2sFKU4cPqNHt2l6Xk/ckNxbSbxVxqiq0wa3BaWVMGOBqwv1UAXNrF94zojk1lk8CU6ieLpTOYTM1hzDSGcFLSjtTuSR53B2g2+DikeoF5FV+s4CXYtbJFAZjA6qSi7F5odzg1sMnvGkK/LlUUmaTS+yhGKTps6JhqigGgsWuZddOTzz0dADDqWvq14+Um5zwJSH+qP1T2Y+T9TjlPylZlU8sqItvQgcRV+IChsuWDQJ9gEEnRe+0G/CawhUpZzMo+manSr/s7RXhkmUoR6O9PBIOdo42EUKxcpWQ8J7Tq56LCgqwbnB5qb+taHFVozn1KMAwna6iDb5qVXWml8eqNw4kn5sL5VcKStTq5drEqtNf7itoFHKvTfjzc1pY/ewXXsLkQ03WSNk/EBKt/cWOFtANbgGabj3arCOA/NYVfoJy8yhWaFl5d6TlIl+Uii1htcApKps4sJ0KpTggemh3x/lbikupmZaRlPfF2TlgG6GDXuE+ab PUkTWklO sw+6PpPNRLmkfbUznSY+QZzIyIwqXSsTja+5DVsdBD5lUxXZv/zzf5eBvRi2mvG7RHHmrnstXBzsgONo+tG+5ExvVJ9LySXEu8g+iS3CSo8IKIMsKsu6oPIvVFOgr/jyKwc9fFN8hocg28EeKsnby6TBfrtsEz4mXUg9v8fh51xVoXKL1Lsy6Ir7ZqloQCEXlP5QwLVyMty67zLppKiyso7t9mqtsG4ZQ6UnahLENhStnkKDY0fgzU3oOSyOz8B3DRls+Y8n5t7HHQpNsqHy5TtkbyaZMaF+GwNy1dFT0+e5Nx3VfRIBuC2dS2siG2IZozXDN8ssO4TW7PS/Ef9XoIE1BewJ/o6lbkbMUc8wU4C0k8pvWpCyB47bhBgc5fyy13ChlKRO3Rs7uEILPtJzWS/JiGrGI8KjZIxXTMwmenp5fGqyPT6Rl2P4ybH5x0mnCxvIpEidYnxr2Se07VvBQ4Vl+nDmdbpzSCioAjp6EMRZR7mmJi5eCljNsYn3W1C2Qq72eRb9u2ijgUOByRlk1WHPvKK5SVT4Jjph1+DV5QAIEIBq6WbwVVsAuaQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Apr 21, 2025 at 06:16:28PM +0100, Pedro Falcato wrote: > container_of(node->array, ..., i_pages) just to access i_pages again > is an incredibly roundabout way of accessing node->array itself. > Simplify it. Agreed. The other side is shadow_lru_isolate() which goes also goes through mapping->i_pages. That's probably how it came to be. But your patch doesn't make that relationship any harder to understand. > Signed-off-by: Pedro Falcato Acked-by: Johannes Weiner Thanks