From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 804DBC369AB for ; Thu, 24 Apr 2025 16:48:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D1D1C6B0085; Thu, 24 Apr 2025 12:48:12 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CCD856B0096; Thu, 24 Apr 2025 12:48:12 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B6F246B00A7; Thu, 24 Apr 2025 12:48:12 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 933D36B0085 for ; Thu, 24 Apr 2025 12:48:12 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 6B1A6C628B for ; Thu, 24 Apr 2025 16:48:13 +0000 (UTC) X-FDA: 83369520066.11.5706F61 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.13]) by imf25.hostedemail.com (Postfix) with ESMTP id 0CE02A000C for ; Thu, 24 Apr 2025 16:48:10 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=XjmUXmVa; dmarc=pass (policy=none) header.from=intel.com; spf=none (imf25.hostedemail.com: domain of andriy.shevchenko@linux.intel.com has no SPF policy when checking 192.198.163.13) smtp.mailfrom=andriy.shevchenko@linux.intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1745513291; a=rsa-sha256; cv=none; b=MFdmIlojFgCSL9eoz9PKelnyFR06r9BgDeLdsLSkLtyFCrRAPTCemWWgxpDqq+njckHoFX XOgR/iKP+oNmpdCSZgUKop7E4cpxMaGeNGmBVTwfi1z87bTiSbwWABqyASTPPPtBy9qnta UdvAluag6Kgf5h/1ruOb+Oe0jFNIcZs= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=XjmUXmVa; dmarc=pass (policy=none) header.from=intel.com; spf=none (imf25.hostedemail.com: domain of andriy.shevchenko@linux.intel.com has no SPF policy when checking 192.198.163.13) smtp.mailfrom=andriy.shevchenko@linux.intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1745513291; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:references:dkim-signature; bh=m8Yf9e5u25ZtgYokaMA3TiggCIqDh/uYddT+q4ZECmU=; b=FvbhrKKXCA7zHhorvr+Q3dsrsYhWB+s2+4pG5++zsZGjp7eJ7AGpYIjSeJS4/KcFT/566K B4k8z9qA83+w8pEW3918cZYmj4IURUx0z0y7YDshS8mKfDzQ+eSflq54gPWBNHaK36GMqC jRAF6gjaSUlXOOK01+Kh+jVIll3E+e0= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1745513291; x=1777049291; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=ySwKksoJVylHv17+76jDGSBW5NovddheXIa8c/3FWGc=; b=XjmUXmVavnSw4+Y96kgPHYrhHuk/1r/lF0kaptvLFcNFB06qxqcGOzx2 bWzykUOZLnSTV7uOSGTz+hxtinaaMk7AUJTshJp6W75ZICbs8TYul6FJ0 +spMVK1e9Dpp8PARGqkn0hZPXtfB53qoJ6ZZr7mNIBPDZ8K0+ALpgt3JB sufqQBko8mNEzKKggCtKypvq7u7NAeH+jmpzrHW3VZ6pC2m9cyC6sgv3q Wx6w7k5EtsLznNJqr0ZAIvluwUchCIkNdzyYnJz720+gkxqQYK1fp7rRd wgp2scjd9EihqHU74kBFbm8LYyfV9MJl/OLBDgFpXj/lpzjib4Iu6xQGO A==; X-CSE-ConnectionGUID: GGYhbY2JRRCN4OhwuCve1w== X-CSE-MsgGUID: xlzpMGinQ96bXhIAdYhlMg== X-IronPort-AV: E=McAfee;i="6700,10204,11413"; a="49816902" X-IronPort-AV: E=Sophos;i="6.15,236,1739865600"; d="scan'208";a="49816902" Received: from fmviesa007.fm.intel.com ([10.60.135.147]) by fmvoesa107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Apr 2025 09:48:09 -0700 X-CSE-ConnectionGUID: rQ1ocbUzQhuWSA1zOhprqw== X-CSE-MsgGUID: sO9y2MC2RBmDNooNgnf5Rw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.15,236,1739865600"; d="scan'208";a="132661087" Received: from black.fi.intel.com ([10.237.72.28]) by fmviesa007.fm.intel.com with ESMTP; 24 Apr 2025 09:48:06 -0700 Received: by black.fi.intel.com (Postfix, from userid 1003) id D4F221AC; Thu, 24 Apr 2025 19:48:04 +0300 (EEST) From: Andy Shevchenko To: Vlastimil Babka , linux-mm@kvack.org, linux-kernel@vger.kernel.org, llvm@lists.linux.dev Cc: Christoph Lameter , David Rientjes , Andrew Morton , Roman Gushchin , Harry Yoo , Nathan Chancellor , Nick Desaulniers , Bill Wendling , Justin Stitt , Andy Shevchenko Subject: [PATCH v1 1/1] mm, slab: fold need_slab_obj_ext() into its only user Date: Thu, 24 Apr 2025 19:48:00 +0300 Message-ID: <20250424164800.2658961-1-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.47.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 0CE02A000C X-Stat-Signature: 4e9oebx9wf8dy7jwu5i8fcf4ja5pj46g X-Rspam-User: X-HE-Tag: 1745513290-274297 X-HE-Meta: U2FsdGVkX1+ei1rDaknFERhFg9a0MAWGzoK8POYqa6fIqoh3n73HegFakQZKmQbyd+KZMSWmu+Ccp6LEUwm/K5ui4dcD5Yz39KGjwo2TdInUfnQ0NPbs4kt3XC+Zc8raVv4ejOVY0iXfBuixfHcJB5KPgsNtYZSMs3KWn03hluXFhqAe8iMQS6OGSy3YqbkpuN8x5ekgBelWEoi6eOcFGPSlEUz1sUj/rdz7GZATvV0PlE+MQh0QrRbw8wOHjTO+4qI1Wx8B0V8f19XqXBLcYnzgW3XxVMjUTlviTYkTlLWAy/IdaSVZBxmlL7onldM8z9oQw1D3oINhvQu+Gemv/QZ+jmNmKNdt2vSnE3zKkpysXNycoNoUqbQ/LuXbzJprf6/igVrb4NvnqE10Eo/+Z8lbCkh5eqIfKXgfqj/w3air0Gpq1osegNphrvS37ClcFluKfSRuYHJl05xzUzm4RCoaWlxYdZdO1To0kTe1CaCltEYabPY4GicPV/xD4PODck24kmAc8c9Y4EZIXOdV5ofy5h+bOqABBSTu34q6I+PWKqOsfuQiuVYdK0l2PIPJXWkdBsKd9oB2x0VMcChTEyAlDO4LELO0OzXaJMge+JFAF4BCg9QBN+5XOwD03yat5K4lAalzQXPlbd0f/ZG42cl0IDBxuX3UHvLkbqfNjegqfvRO+U9rSbR76hm1w48/Z+mrxXWzlwfmz+3iHLtDtcxZXcRmvTvk8dfYi4QJTDBW+Qfapdb9ADfWLkhgL23fow5cSrRxZt5AmLgOdpjRyKP/xhRmkeZUZkWYHNQ8FjZTfn2uKDTvuMdHtqd7hOu1CEKqmVqYcINbk7rDvFQp5DJMcJ1kBBubmbtvdWJhlg0G4cPmj7M9oIbW/elUL8Wo9eTqdvM8CojfaXfiHxlk0JXEKCgEz1WrqNfAjt0c0Gx0Slq4Dxse29Ir/TZVgVJSiSk22qRD6+BHBWgK9bj I+D4uNlZ iVESQ3CnlIfLjc5SQG+OKMDIh/SeIXNiCTnTE/AOexOO4TffXv1JTGTMWCwZK37oxdNCvMAuLEZmxnqXpnpEcLAu0XP315DsSy7NaoQF7Nmd0NQXVOU77H7CZBmB1PjpHf1MpnXoIh9UsKXMnWoKTUFQINakBGiXvLG/THneXtOo+1d2lxb0WITWCtT/bNzpfuaGNwR4eF6jPNi+q1tlUbs6aOZtGjNM2lpiA00SZnaK6kAEvzXxBxnjdAzMohGi7USCCcJJmP4IbsO14Btn9o8rSUbvts4NiYtiu X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: need_slab_obj_ext() is used only in one place, fold it into there. Without that, clang can't build kernel with `make W=1` when CONFIG_WERROR=y, which is default in the x86 configurations. mm/slub.c:2079:20: error: unused function 'need_slab_obj_ext' [-Werror,-Wunused-function] To solve this, fold need_slab_obj_ext() into its only user. Fixes: e33b7ae3d802 ("mm, slab: clean up slab->obj_exts always") Signed-off-by: Andy Shevchenko --- mm/slub.c | 23 +++++------------------ 1 file changed, 5 insertions(+), 18 deletions(-) diff --git a/mm/slub.c b/mm/slub.c index 966785362a62..50e9730828a6 100644 --- a/mm/slub.c +++ b/mm/slub.c @@ -2048,18 +2048,6 @@ static inline void free_slab_obj_exts(struct slab *slab) slab->obj_exts = 0; } -static inline bool need_slab_obj_ext(void) -{ - if (mem_alloc_profiling_enabled()) - return true; - - /* - * CONFIG_MEMCG creates vector of obj_cgroup objects conditionally - * inside memcg_slab_post_alloc_hook. No other users for now. - */ - return false; -} - #else /* CONFIG_SLAB_OBJ_EXT */ static inline void init_slab_obj_exts(struct slab *slab) @@ -2076,11 +2064,6 @@ static inline void free_slab_obj_exts(struct slab *slab) { } -static inline bool need_slab_obj_ext(void) -{ - return false; -} - #endif /* CONFIG_SLAB_OBJ_EXT */ #ifdef CONFIG_MEM_ALLOC_PROFILING @@ -2128,7 +2111,11 @@ __alloc_tagging_slab_alloc_hook(struct kmem_cache *s, void *object, gfp_t flags) static inline void alloc_tagging_slab_alloc_hook(struct kmem_cache *s, void *object, gfp_t flags) { - if (need_slab_obj_ext()) + /* + * CONFIG_MEMCG creates vector of obj_cgroup objects conditionally + * inside memcg_slab_post_alloc_hook(). No other users for now. + */ + if (mem_alloc_profiling_enabled()) __alloc_tagging_slab_alloc_hook(s, object, flags); } -- 2.47.2