From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 51EF2C369AB for ; Thu, 24 Apr 2025 16:01:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0353B6B00C2; Thu, 24 Apr 2025 12:01:47 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id F25046B00C3; Thu, 24 Apr 2025 12:01:46 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DC5E36B00C4; Thu, 24 Apr 2025 12:01:46 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id BB35B6B00C2 for ; Thu, 24 Apr 2025 12:01:46 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 1E4E61CF061 for ; Thu, 24 Apr 2025 16:01:48 +0000 (UTC) X-FDA: 83369403096.02.F1AFA12 Received: from sea.source.kernel.org (sea.source.kernel.org [172.234.252.31]) by imf29.hostedemail.com (Postfix) with ESMTP id 9DDEE120021 for ; Thu, 24 Apr 2025 16:01:44 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=Wm8VevHV; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf29.hostedemail.com: domain of leon@kernel.org designates 172.234.252.31 as permitted sender) smtp.mailfrom=leon@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1745510506; a=rsa-sha256; cv=none; b=ceCDPzaNjwPOqH77SVB7gwTmWHqBsNetK6xZrVcexYt67mQZ4GkuogYZpQNwXNNpZMSBVr /w5yZG2VYaAyFzXlBmMWpfvQE6q57x8zV0tF8V0YgrmJtXFoch8jrA71GNrN25WgzJ91yY ooYi0R02+HDbYpRJXpDA/v66U3EzFYg= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=Wm8VevHV; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf29.hostedemail.com: domain of leon@kernel.org designates 172.234.252.31 as permitted sender) smtp.mailfrom=leon@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1745510506; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=qrRm8Mxdx4tdb1p6pqSSEi/Z9DsYE/H91HI9oykZhnA=; b=aoWTcUYEPjhBgjhXtXILaW0xQezB8pbbtm61tjiXzyy0bnudfx1ZTkETxyfPJlYGKFvG8k Phbaqv+mN6KASywQokVjnicS77CEduFgkuo+Q94tzITggt/syi+XKjME4pIK6mDo+pK6Am XwB0QC2YOBWBIhfy+/LSR5SQO9DyqcQ= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id BBDD044074; Thu, 24 Apr 2025 16:01:41 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8C5C2C4CEE3; Thu, 24 Apr 2025 16:01:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1745510503; bh=2EsFN3KQzZNWveqPmKQ2uvMTlzDkWMvMTWZFw/RE+lA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Wm8VevHVEohfFXx1uchcfmtL+zcZ6xSp9jmMA3lzuk8AwHIyLQmcHNh0McnSrCcx3 lIkmFdP+VzpGEpwEKphWvTET5ebVyPTPFMB80cvGgeYljv5/yF/In310jRDQC6j3Xe enCjXdYVPMQ3v7aENOXrr8Z1Q/znZ+vOdsJ5KN84mcOFLlEP45lED6O7qLOvupMMaK lBtmEryEpv3oaYU2xAYKqHcEOWsb8P+1vrzSoARX2cvfIjSdXU2qZFlV+DPcWa735h beec4plnuKPHYBuMtW0ndvkO/fM+I0YWu6BDRZ5NUppB0Cqwzxtn9QVLIFtHY5tX8k eFD7fbEi5hXLw== Date: Thu, 24 Apr 2025 19:01:38 +0300 From: Leon Romanovsky To: Jason Gunthorpe Cc: Christoph Hellwig , Mika =?iso-8859-1?Q?Penttil=E4?= , Marek Szyprowski , Jens Axboe , Keith Busch , Jake Edge , Jonathan Corbet , Zhu Yanjun , Robin Murphy , Joerg Roedel , Will Deacon , Sagi Grimberg , Bjorn Helgaas , Logan Gunthorpe , Yishai Hadas , Shameer Kolothum , Kevin Tian , Alex Williamson , =?iso-8859-1?B?Suly9G1l?= Glisse , Andrew Morton , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-block@vger.kernel.org, linux-rdma@vger.kernel.org, iommu@lists.linux.dev, linux-nvme@lists.infradead.org, linux-pci@vger.kernel.org, kvm@vger.kernel.org, linux-mm@kvack.org, Niklas Schnelle , Chuck Lever , Luis Chamberlain , Matthew Wilcox , Dan Williams , Kanchan Joshi , Chaitanya Kulkarni Subject: Re: [PATCH v9 10/24] mm/hmm: let users to tag specific PFN with DMA mapped bit Message-ID: <20250424160138.GT48485@unreal> References: <0a7c1e06269eee12ff8912fe0da4b7692081fcde.1745394536.git.leon@kernel.org> <7185c055-fc9e-4510-a9bf-6245673f2f92@redhat.com> <20250423181706.GT1213339@ziepe.ca> <36891b0e-d5fa-4cf8-a181-599a20af1da3@redhat.com> <20250423233335.GW1213339@ziepe.ca> <20250424080744.GP48485@unreal> <20250424081101.GA22989@lst.de> <20250424084626.GQ48485@unreal> <20250424120703.GY1213339@ziepe.ca> <20250424125052.GS48485@unreal> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250424125052.GS48485@unreal> X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 9DDEE120021 X-Stat-Signature: y9z97kdf45hp63m35qmjwa8yztgujs8p X-Rspam-User: X-HE-Tag: 1745510504-975483 X-HE-Meta: U2FsdGVkX1+jUtKllHLjaAUYghAvzoHHJ9EMfukeTg48ERmmoM8HdogMq5byaRr1ceoX62dioLZCtHDRSkx17/uWVLEHrJiU3W1l1IEUAndwEgIkU6nrnEA6hgd+Gqkr1eU5nmMnzTovR8oh2uS0e/vmmgp/rPeFMUrt2jFtVgmTWAC4RxpdGdH44G1fXhgCJHUKiCT5z8hFLke00QIkQw37poSQjl/OEIADcEGb2bZjy0SjmxlZPaetKrA6rccEXejW0LlHFOEyfLUGwA15fBmxB/GyNAJRZqoGnO7BAFazuP3mVxtzD5cv7j6bhubmU9hGp+Af8dnH2bnShvgJGePpNrTgJY6PHi+3t/RCWGjUWYw6bYVGWsZBWI5V4Pm0rG2lZFzP5OLQrgN7P/hqwZSM2RNpEZpR+lUmLdZHASrL2c39bhf0rpZ6ag8TL9PzDGsPppNGhBLWtKcTDh7lK+q7OCeG9IdhoUiY9VWRIFS2bDYmrTyqaTu6nbw1kJM6ex87Bf7KMl6UICyKLDHT8S4zPLhCzMOi4sRcST47lnXX0tlUsUfQO/EYU83Se+LF9JspqgW9ObAlkamlIP0VODWi3bQn/dhdyxUeFY/7Vha7b83XCKQ1xhctoUlM4GJsl1/coAkmmiVw4JiUqSOV5QgvhOKX8MU9QQmMPiuHxpTZKWmlTqO/iJi/XzSYNYL17xu7Dp/DAChdr10JMPt0+rSHRpA89AtpkQYyi0GUjRK5IV6vCIYIHFv5yLtzRhbnn444FkkQmHz6ra+jheLlJ4Hmk/P7HSxJwmFpllbTTcWqjWWeC/uf4fbUQLEf02JqmKmoa3UgzRn12sSqzzEJmM/41GPJ15z2vVtTbRf/xYUs3G3Rn+LTF5UCQFge7QZubvCW3fWPkExggVw4q3rnv/kgPM885uggtkFEXCoV9/a3DCoSg4KdxgVXMQttYXguGRXu1yc9ELYgSthRYwj sVXPKi8A FKtXp9hqDExg0adu0kHmOIfaY+LFLiLVveOR0unuTSz/B3rZWDgrU03JGhPuhW0LEmJ4+KCzqEwDOZ4FeZtAVoFjghL88Tgo7DLRZE3tsJ2AHbKDjfW93BPA4o4QsXYoyQ9UANqLcBSYB7ZYVBYyjNWtnIBjbsP5ufVLhjdNyEjKXbDfSM5utAb2q5hUvyVVy6JXam3NeQhzZ+mXMakj1F+vOFRxky2vDUyhzgKRZeD2qI/NNDz3gJ7QlrCsejDqohqmN X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Apr 24, 2025 at 03:50:52PM +0300, Leon Romanovsky wrote: > On Thu, Apr 24, 2025 at 09:07:03AM -0300, Jason Gunthorpe wrote: > > On Thu, Apr 24, 2025 at 11:46:26AM +0300, Leon Romanovsky wrote: > > > On Thu, Apr 24, 2025 at 10:11:01AM +0200, Christoph Hellwig wrote: > > > > On Thu, Apr 24, 2025 at 11:07:44AM +0300, Leon Romanovsky wrote: > > > > > > I see, so yes order occupies 5 bits [-4,-5,-6,-7,-8] and the > > > > > > DMA_MAPPED overlaps, it should be 9 not 7 because of the backwardness. > > > > > > > > > > Thanks for the fix. > > > > > > > > Maybe we can use the chance to make the scheme less fragile? i.e. > > > > put flags in the high bits and derive the first valid bit from the > > > > pfn order? > > > > > > It can be done too. This is what I got: > > > > Use genmask: > > I can do it too, will change. If you don't mind, I'll stick with my previous proposal. GENMASK() alone is not enough and the best solution will include use of FIELD_GET FIELD_PREP mocros. IMHO, that will make code unreadable. The simple, clean and reliable bitfield OR operations much better fit here. Thanks > > > > > enum hmm_pfn_flags { > > HMM_FLAGS_START = BITS_PER_LONG - PAGE_SHIFT, > > HMM_PFN_FLAGS = GENMASK(BITS_PER_LONG - 1, HMM_FLAGS_START), > > > > /* Output fields and flags */ > > HMM_PFN_VALID = 1UL << HMM_FLAGS_START + 0, > > HMM_PFN_WRITE = 1UL << HMM_FLAGS_START + 1, > > HMM_PFN_ERROR = 1UL << HMM_FLAGS_START + 2, > > HMM_PFN_ORDER_MASK = GENMASK(HMM_FLAGS_START + 7, HMM_FLAGS_START + 3), > > > > /* Input flags */ > > HMM_PFN_REQ_FAULT = HMM_PFN_VALID, > > HMM_PFN_REQ_WRITE = HMM_PFN_WRITE, > > }; > > > > Jason >