From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2C467C369AB for ; Thu, 24 Apr 2025 15:11:22 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A19426B000A; Thu, 24 Apr 2025 11:11:19 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9C9256B00BB; Thu, 24 Apr 2025 11:11:19 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 86AE06B00AB; Thu, 24 Apr 2025 11:11:19 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 63B126B00BB for ; Thu, 24 Apr 2025 11:11:19 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id ECE015D682 for ; Thu, 24 Apr 2025 15:11:20 +0000 (UTC) X-FDA: 83369275920.27.56354A6 Received: from mail-qk1-f175.google.com (mail-qk1-f175.google.com [209.85.222.175]) by imf12.hostedemail.com (Postfix) with ESMTP id 0346340002 for ; Thu, 24 Apr 2025 15:11:18 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=cmpxchg-org.20230601.gappssmtp.com header.s=20230601 header.b=Oueqq0NT; dmarc=pass (policy=none) header.from=cmpxchg.org; spf=pass (imf12.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.222.175 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1745507479; a=rsa-sha256; cv=none; b=iPXUlCoeDyrWppfyf4DhV9pRVhlZvZ+TUjn55+6oYarzT0QIwlL/p9PtHIg3yLVupjLMGo Lb8xtIsQu3g+vW1CIEhRoNpXKc2puE2aC+ZK189HIA4sFqDbXhqpGojwd+oWxWzgDm04tK SUsJH8wOR2V1+sHTmdC2tfgWI2KXJyk= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=cmpxchg-org.20230601.gappssmtp.com header.s=20230601 header.b=Oueqq0NT; dmarc=pass (policy=none) header.from=cmpxchg.org; spf=pass (imf12.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.222.175 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1745507479; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=nffPhy7+/1fHzsvZGaqtOAHSR9jHbQYk5b0XbZQ1C2E=; b=WS4rNQyQ46y6v2nbNQvWj6mNOShLZHEU+KMylQ6to7xHVPm4ECXb7oOUoMTsnnJizeoojr Svns+Id8OwRoM6W/GPwi+GxcIMTFGjxkoWVBnuka4qsSXk1vk78b81ggHPvL3ZDdKkpebH ytBBhwHY4OaJEs49YYlaSrWOPdQRHKI= Received: by mail-qk1-f175.google.com with SMTP id af79cd13be357-7c08fc20194so254115085a.2 for ; Thu, 24 Apr 2025 08:11:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20230601.gappssmtp.com; s=20230601; t=1745507478; x=1746112278; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=nffPhy7+/1fHzsvZGaqtOAHSR9jHbQYk5b0XbZQ1C2E=; b=Oueqq0NTVy3i1fTOhWdw/X0BAz1RItACGvYdOPkB59Oem36tB6ociFQ9jcJaGZllYk afGDGAWNGU9FyJQFnLXBw/AOUsG3CY6d91SgEe5RpN/brtN6CtqhY5veUs3D4nUE/Lnz sLoCbhE8oWpq/9IHIB6j/EdUWMSEEO4nVEd35zkN/UeaWTqi0AkN5HMvbaMCEmRNq0tI Mg883Hj9nhe7LhK+7VbmHhtFu9PF8T0AD8RJyXeTP5f/QbqKJHbG9ahxWjLaSHsq07Bt O+J+JVPOMoD3c6jEEqZyGYIFBnsw1ezw4o+wN8avbAkdiEqhuuDZpnv2we4LJz/i0t/5 p7NA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745507478; x=1746112278; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=nffPhy7+/1fHzsvZGaqtOAHSR9jHbQYk5b0XbZQ1C2E=; b=R26zJqSOcuwBA/zBPEYtLCQ3hjPQ61jUCbbai0Iv4bqDwF2EDpoNspNrZBwGk+QYVz dV0Xg65Vv4eK/5oFHu3iVI+1k1Nl8nkw5+Kx2A2z3/GpFkZ724JqrwrgdYiJIzbux+FK eYGxuLUXvzViGmuWaiGtUleHp+O2zqEsJXj9Ed6oRYv6+2xLp8D2rLEsR/3rOfBi8obl ra6yuiW3ucSWlbYdOSPujoD6esh+waF9GRxha3LG6XhuJGwTdCD+CHRenaK0miVTY695 +3PaJDoOPFbylm8GuZy3lg7k9W2bYMy6nIiirfKjIaCEHM0ayy8dNB44x6sGpdkOSR0b 4sUA== X-Forwarded-Encrypted: i=1; AJvYcCWQq2gaCgqFtTOufe25gO713XnanoJsaM/JPQ8bWkKQLSBr2Q1ylyJWQ407oIh7qIyndgIoJtKkQQ==@kvack.org X-Gm-Message-State: AOJu0YxUbO9UeXsw07rS/7PTe14L3FtIiT64ZQ/tp0yac4NL3qyBG2p3 dTSqWLqnHkZHikPRbYl1kUkVwIU598iKA9xPu8yQGARQa0A8EduuMW15l5sxJKg= X-Gm-Gg: ASbGncskTo874wF7IG9yzo43+LCCii4A23NDc2Jse8ELSNeh+8JIFTO4tnuwAJEsJnz 2ze9jCw/eAytorVUoqYb3DpVr56tCJT/dxH6qXZ2rLI0zV74mA/c1ff1Q7fTh7bIPzKVddc6aTt 58dpzTg+hASnP5XI7RqACWbzIw45z2yIi7IbQB6xD8SKSJvQRLCA8atQWP6eyKW/EoF5Etil043 cpCGEgz1UbazmcptVpMcS3GF67gboHYdeDwGnXE51l6I7HVijDb8pO+xxbMGGzb/r1QE1hT2f5Y cVLBSAx5k/Tn5RhKhIJUokcrovEhn5QKpMAqrs0= X-Google-Smtp-Source: AGHT+IGugZ4dF2360yKjAcGWiDkcFFtJjxjGhEjgxriLCMHcwp/Y1qZjg2WQK27E+f+8geSIHYcM/A== X-Received: by 2002:a05:620a:f15:b0:7c5:97ca:3ea0 with SMTP id af79cd13be357-7c956da4cdbmr405074285a.0.1745507477917; Thu, 24 Apr 2025 08:11:17 -0700 (PDT) Received: from localhost ([2603:7000:c01:2716:365a:60ff:fe62:ff29]) by smtp.gmail.com with UTF8SMTPSA id d75a77b69052e-47e9efdad60sm12934791cf.28.2025.04.24.08.11.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 24 Apr 2025 08:11:17 -0700 (PDT) Date: Thu, 24 Apr 2025 11:11:13 -0400 From: Johannes Weiner To: Jens Axboe Cc: Andrew Morton , Peter Xu , "linux-fsdevel@vger.kernel.org" , Linux-MM Subject: Re: [PATCH] mm/userfaultfd: prevent busy looping for tasks with signals pending Message-ID: <20250424151113.GB840@cmpxchg.org> References: <27c3a7f5-aad8-4f2a-a66e-ff5ae98f31eb@kernel.dk> <20250424140344.GA840@cmpxchg.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 0346340002 X-Stat-Signature: mk6bdnmu58sgp97b8g1cnxzngw8b9qw7 X-Rspam-User: X-HE-Tag: 1745507478-245854 X-HE-Meta: U2FsdGVkX1/MXjDEbHk7bBcVagGC8jBYj/6AbNJrxdQFBvc+5NHgNUAUYCihYSc6VXEhMiKeDx1nzKLZZX3RVwHNHHISRWmpXy4QOcp2FrZfT36XEvCKsBczIhDxSZOKEE1yOm/OaQeHmewKLCClM/Q/x1knWvaNrCZyNViawe16AA+SIzjQSrUkwWFUjZSccldGuuJgAP6rNniK3StdOwbWY17vxYbTSCw9/L+4u0e8Xcl5FDh5UwABw8/rWQrsSBDULW9GGHGKb1OsBqPw6tB4a/2QtbyIEBnGp7U32Cwz1JxVXS3XUv/t0i5ZxhZpoX7LDrCrxLacTPdwJV9yPupPHpeNZqg9Thozo0KfswnYlwiHGTCmpWUEu1xj7rXjwYifQo0W/qfXYYbaGNer3u1SYtD0G0OHBoIeSCEAv9DR440CZ49BjOxVvQT1zF9rkrVDS8Z6tqlRL/v9MS0CCTjVecdsoFDC06XSbWOP5s1LkjPudKdnAecxgApZMbebuxLrHmbu6uPiBHiq5q4wWgyuMpFDcTbnPOvCK9dvA1FSbMBNItvHC+UNH7eAuKgP2rgYDHYSe9IN19KvzZhktVTp3wN6cbd9bbsseaE9c7mCRkA3p5lcAyAC6IkNo6YkgE0rs8qzNI54kPahswWXqpdDvOyj/ptD2XNMbKOQibS4bG2Fx/sYy8UrdMu9vdubWihDXYiqbiZ9f7G5DxkscX+QSsqUH4OQhZ3i/cIQFNi8b4IrAxQKKOqZPuntz2FwhKRnh1BNGCLY4agMToZ89ME8uBr4je/FtR83abFR+w2a1tDhFfAYI4DevmYzUL+WNgU1zRNh0qqZcQAMZzifM0VIpkjT49MkznLUQqry2dheUDEhGvpQz6QiTNAoBtyoBbdTXcH9RcZFY9jBUAfLZwZz0GOEtgt8r8Wu0jjxmcFMWTSZcr0mw0KRn9FUkxFvf9jx/cfkRnsNsok8yAL raFimSdQ I0d0kMsp5rm7Z/BiL8sXZ7/xYTbfNBv3dZoTBjWDDJCnASYdGYAl1RZKXUwTgxPD3IlZWocPs+c4nazhk0MjcyKQeAsgO8yExbJp3k7GowXMqwAR3PvzqXVRaWj7qVLRcQK/6 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Apr 24, 2025 at 08:54:40AM -0600, Jens Axboe wrote: > On 4/24/25 8:03 AM, Johannes Weiner wrote: > > On Wed, Apr 23, 2025 at 05:37:06PM -0600, Jens Axboe wrote: > >> userfaultfd may use interruptible sleeps to wait on userspace filling > >> a page fault, which works fine if the task can be reliably put to > >> sleeping waiting for that. However, if the task has a normal (ie > >> non-fatal) signal pending, then TASK_INTERRUPTIBLE sleep will simply > >> cause schedule() to be a no-op. > >> > >> For a task that registers a page with userfaultfd and then proceeds > >> to do a write from it, if that task also has a signal pending then > >> it'll essentially busy loop from do_page_fault() -> handle_userfault() > >> until that fault has been filled. Normally it'd be expected that the > >> task would sleep until that happens. Here's a trace from an application > >> doing just that: > >> > >> handle_userfault+0x4b8/0xa00 (P) > >> hugetlb_fault+0xe24/0x1060 > >> handle_mm_fault+0x2bc/0x318 > >> do_page_fault+0x1e8/0x6f0 > > > > Makes sense. There is a fault_signal_pending() check before retrying: > > > > static inline bool fault_signal_pending(vm_fault_t fault_flags, > > struct pt_regs *regs) > > { > > return unlikely((fault_flags & VM_FAULT_RETRY) && > > (fatal_signal_pending(current) || > > (user_mode(regs) && signal_pending(current)))); > > } > > > > Since it's an in-kernel fault, and the signal is non-fatal, it won't > > stop looping until the fault is handled. > > > > This in itself seems a bit sketchy. You have to hope there is no > > dependency between handling the signal -> handling the fault inside > > the userspace components. > > Indeed... But that's generic userfaultfd sketchiness, not really related > to this patch. Definitely, it wasn't meant as an objection to the patch. The bug just highlights a fairly subtle dependency chain between signals and userfault handling that users of the feature might not be aware of. Sorry if I was being unclear.