From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 69690C369AB for ; Thu, 24 Apr 2025 08:46:36 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5E2026B0008; Thu, 24 Apr 2025 04:46:34 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 590BC6B0082; Thu, 24 Apr 2025 04:46:34 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 432D56B00AB; Thu, 24 Apr 2025 04:46:34 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 1E9C96B0008 for ; Thu, 24 Apr 2025 04:46:34 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 55E45C0DB5 for ; Thu, 24 Apr 2025 08:46:35 +0000 (UTC) X-FDA: 83368306350.01.D536DE8 Received: from sea.source.kernel.org (sea.source.kernel.org [172.234.252.31]) by imf29.hostedemail.com (Postfix) with ESMTP id 9A66812000A for ; Thu, 24 Apr 2025 08:46:33 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=uSR+lBTu; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf29.hostedemail.com: domain of leon@kernel.org designates 172.234.252.31 as permitted sender) smtp.mailfrom=leon@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1745484393; a=rsa-sha256; cv=none; b=GiET+T2i6QZwMOaQyrXJSVqI2fxjzukzrQi3+PIrCsu4vKmGNo7VALca2GcL0IG9t9b/rI NloQBo5NlwpT6z0cNfgoMsGBY/eHjaE8CCVxKQO2feGs0HnL2kCVVvvYxLxbrzdkoUdL9f tYlBBwLvNz1a0C/dmbqfeWUOetc3T90= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=uSR+lBTu; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf29.hostedemail.com: domain of leon@kernel.org designates 172.234.252.31 as permitted sender) smtp.mailfrom=leon@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1745484393; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=JBNjeFWNj+l9ru6mCK7IYz7qgtgjTXYNZBHsQZntGsQ=; b=bvDmqVR/0h0eDZGqoSnTNmdLz0M+LQyh1CUC10lY8aOc+afx8D8iGTyc2QbiHZkRvlYGh3 M5wwdrpEJJXa7N+u7c5L/uJGBpUqeItIFDugjQcEumMvC1Si1osx7sw08gE1qKcNIet8+Q Fu5dWBz6gvZBpWdvJDbZhBwLeP2zWTo= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id AF4F04A162; Thu, 24 Apr 2025 08:46:30 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6F4A0C4CEED; Thu, 24 Apr 2025 08:46:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1745484392; bh=ki3q6dIyPVLY9OlwYT9gx2mvHOve0ih8UQqOIXQy4sw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=uSR+lBTuzs9lAfUp6ETUwd/e83HDQBPN+bi2x6d+WcXRuXqISLxR1KnZmPcANDNPl XcusVwWrcgl5ZwxaQMTClZZp6wv04VyBadsXr0ChBep2yGTn0yT6aRBkv0qe3YHnsu Xbfy/GOWPkZiF5ouAX9EAiGXmE23jYsBtArkcpCT8edU46pm2SHyttUmmiowtlF9le jBdsLZ0dV8tCc+abgC1OkQo4yqWtl296bgiFLL3P131EcMwOFukXU6T1YRIKWY0DCS vfhRiecYS5EGzJ47VScGPAGcWrDrAIXqhECCrbNzQ/i5dx+Y8dYPFcg8gKvkI2s3k1 MO9hwaOX8jurQ== Date: Thu, 24 Apr 2025 11:46:26 +0300 From: Leon Romanovsky To: Christoph Hellwig Cc: Jason Gunthorpe , Mika =?iso-8859-1?Q?Penttil=E4?= , Marek Szyprowski , Jens Axboe , Keith Busch , Jake Edge , Jonathan Corbet , Zhu Yanjun , Robin Murphy , Joerg Roedel , Will Deacon , Sagi Grimberg , Bjorn Helgaas , Logan Gunthorpe , Yishai Hadas , Shameer Kolothum , Kevin Tian , Alex Williamson , =?iso-8859-1?B?Suly9G1l?= Glisse , Andrew Morton , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-block@vger.kernel.org, linux-rdma@vger.kernel.org, iommu@lists.linux.dev, linux-nvme@lists.infradead.org, linux-pci@vger.kernel.org, kvm@vger.kernel.org, linux-mm@kvack.org, Niklas Schnelle , Chuck Lever , Luis Chamberlain , Matthew Wilcox , Dan Williams , Kanchan Joshi , Chaitanya Kulkarni Subject: Re: [PATCH v9 10/24] mm/hmm: let users to tag specific PFN with DMA mapped bit Message-ID: <20250424084626.GQ48485@unreal> References: <0a7c1e06269eee12ff8912fe0da4b7692081fcde.1745394536.git.leon@kernel.org> <7185c055-fc9e-4510-a9bf-6245673f2f92@redhat.com> <20250423181706.GT1213339@ziepe.ca> <36891b0e-d5fa-4cf8-a181-599a20af1da3@redhat.com> <20250423233335.GW1213339@ziepe.ca> <20250424080744.GP48485@unreal> <20250424081101.GA22989@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250424081101.GA22989@lst.de> X-Rspamd-Queue-Id: 9A66812000A X-Stat-Signature: zwnznapsn3pa6fnrrda3qpzi3j6g7wc1 X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1745484393-543321 X-HE-Meta: U2FsdGVkX19YPp32rhA9BKNLoa0qAcJmb1bGJypTHduEKnKkk9FdzYdW/ECKrUyglbV7D0EX5DPgRLsMpREwxMcjOasYWkBA+lVG1vabvMrAG/OXlxkZApPwDbiyFF7vXOuEKN+FCn9Rolsz77kXj5hX1voBndSjp8QsDmEf2JcgSnHyI6U0hH3kaUHwF1PWez80gBS/nopPCM8piBJ0Rd4HE5Zigloc+hUZ8MJKbLsU97h20uCiYQApyM+vpyQMWKjJnQ0+Ss5dNULFhMkLklGt9R2APIG16Iv8M1izpS0v/00AvaFUEdo8dQO7J5z/Qa8q6Eq5U8qYiD2tUQKwC+DRdPEuL7tZCb/y5FWtTCKW0TOM3frOJaJM5roG0t7c9U/uIbzKlNJO/Ba303tEDKyPedlMu7zsNtFfC+m0GzaTX3sR2flbnGVLgp95Pt2GAROQgHWlcAXPE9yYtCG5QXhPy+SSHJE61V9alifIxu1z1RG5DbE/jWjDhzjDUVD6utRVxGtlYEFTK1agYWzaYZ1UoALDGmXDt3lbedm7LWJ0PVFPP1/tgMLL654d7dRZYNLmYEIHDV73V4Ajs+rXqWzN8FHG6hRG/KKwPKRHV/OD75rdZgek59aNOxVwq6Ds2/kG7hVp4xPPsNRbm+TsRMMLBXs4TxGNOeSz5UHsMtNLrdt/9JODmyDI/vIuikwgp3f041xe0hdAYm8mufp/8p7s6EGuLiOwoWstSFUz0XfeiNII+edU4GBaCs1GMTVoGGtS9dxtRhja1ok8ZHQx0w0qALM5TujVN+vNywgbQcMqcEvEJAQVSVZr3HP3IWSkzVwpqnQU2buBpJlVaoEqOlY2maxuczckkwXGPmgPApDsHKFxMRlJVGpgukgeJSbrSIhhDIr3n8x53y5FfnoxUsqaoN5kbFPFkbhYH8h1K60fAxlBY1ESIkxupoRdyM8AwqR8AGjO72vkro3pAgs t9Eg2Zpe 7VWOLGdt4gPS8yG2U+KiKHN4n5K8x1keor3m4AWmufPf0SclWpFzvhWrtJqdj0orW3V9RIzH3dUD8icdIxsh39VAcxhmtU8r7y4OZv8q/Pg8A0Hh+rN63gF022THZ7mGfuDdvrX9EngsTd32lRlxiFpjqNnJ3x6WIUw6XdB8m8NiIefuSbQTW7EyeeGZnAda1MEVZk60gAqWErV4OHHxf8i7FLry1Ykf9up/iZhaEfN28EHfiBC1zaXKHsvngvkAISNeZ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Apr 24, 2025 at 10:11:01AM +0200, Christoph Hellwig wrote: > On Thu, Apr 24, 2025 at 11:07:44AM +0300, Leon Romanovsky wrote: > > > I see, so yes order occupies 5 bits [-4,-5,-6,-7,-8] and the > > > DMA_MAPPED overlaps, it should be 9 not 7 because of the backwardness. > > > > Thanks for the fix. > > Maybe we can use the chance to make the scheme less fragile? i.e. > put flags in the high bits and derive the first valid bit from the > pfn order? > It can be done too. This is what I got: 38 enum hmm_pfn_flags { 39 /* Output fields and flags */ 40 HMM_PFN_VALID = 1UL << (BITS_PER_LONG - 1), 41 HMM_PFN_WRITE = 1UL << (BITS_PER_LONG - 2), 42 HMM_PFN_ERROR = 1UL << (BITS_PER_LONG - 3), 43 /* 44 * Sticky flags, carried from input to output, 45 * don't forget to update HMM_PFN_INOUT_FLAGS 46 */ 47 HMM_PFN_DMA_MAPPED = 1UL << (BITS_PER_LONG - 4), 48 HMM_PFN_P2PDMA = 1UL << (BITS_PER_LONG - 5), 49 HMM_PFN_P2PDMA_BUS = 1UL << (BITS_PER_LONG - 6), 50 51 HMM_PFN_ORDER_SHIFT = (BITS_PER_LONG - 11), 52 53 /* Input flags */ 54 HMM_PFN_REQ_FAULT = HMM_PFN_VALID, 55 HMM_PFN_REQ_WRITE = HMM_PFN_WRITE, 56 57 HMM_PFN_FLAGS = ~((1UL << HMM_PFN_ORDER_SHIFT) - 1), 58 }; So now, we just need to move HMM_PFN_ORDER_SHIFT if we add new flags and HMM_PFN_FLAGS will be updated automatically. Thanks