From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E8E50C369AB for ; Thu, 24 Apr 2025 08:07:53 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DF7D86B002E; Thu, 24 Apr 2025 04:07:51 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DA8C56B0031; Thu, 24 Apr 2025 04:07:51 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C45146B0082; Thu, 24 Apr 2025 04:07:51 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id A27946B002E for ; Thu, 24 Apr 2025 04:07:51 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id D698FC0B9A for ; Thu, 24 Apr 2025 08:07:52 +0000 (UTC) X-FDA: 83368208784.04.50CBB37 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf26.hostedemail.com (Postfix) with ESMTP id 2228E140011 for ; Thu, 24 Apr 2025 08:07:50 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=ODyOD7bZ; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf26.hostedemail.com: domain of leon@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=leon@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1745482071; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=EsiBb2Ci+XsuTB/2BgrSnjUWCz2t1GZNQ6Z1M0C6om8=; b=vIT3rrxA6GoI3HKOxD1sra/Ix5SRlDl6z24WobWLyaVl1O8fLu1oSuOb9M8cbXvY7rqg3m 0zXlpuYk71xaz65yacC+GxU9toG/YU3M+cdEK4JaYsVglKOjbBcYBAjxW0vD1RQEJstpQ6 QnWjS5RaYnxpVgocMj2DMIYZfz6BBbM= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1745482071; a=rsa-sha256; cv=none; b=fufPPaU/VwYXuXu2NpWUXH4Gi8NCW7jfCaYMX+BU7xX5O56B4oNeljT0hgXzpgizmjvvMU i1D+L02WVsW6cbiVpTi4jhMOmgNo8/oDCBAnq8wIqwziH8qSq0uLJbU04qEkoW1chs7hKd jMA/7/W9HYabBFwnALzyBHzh64ul930= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=ODyOD7bZ; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf26.hostedemail.com: domain of leon@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=leon@kernel.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 269065C62FF; Thu, 24 Apr 2025 08:05:33 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0ED08C4CEEB; Thu, 24 Apr 2025 08:07:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1745482069; bh=gQ9J0xOhC6db6xC9+l1fS/rU8P/+uRvFwj9Ophiqh+Q=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ODyOD7bZFe6psyTBbbqHrGyTN9bbO06+mLsjpOZpZAtyeVZhSMtIzzHp4uk/bPwRF Fg+5AuYPCHFaO1iJ7AZ0hnuzbSatu3RKpWWB0igu+ysf5GxyCdAj0/zoHi8abPgms6 UyWqrFeuVLz7KWExbAlMl6sGk3pIBXhjJdgkeyS5U7v4meyETDlnI/bCnajjhgK5ip tIFTA4qEdRjUs4v9+5Yqy4cTSqzgz9evKITnLdxHo0yebJZSxHX+clynB3yYqiaA9g TAOPbev3sVV+FH5Ob1WbUIU/+f8jJU3YQkiM1kHRm7HKmFAywX5r91KPZh1EV5IySo WbMrUBYNBAOvw== Date: Thu, 24 Apr 2025 11:07:44 +0300 From: Leon Romanovsky To: Jason Gunthorpe Cc: Mika =?iso-8859-1?Q?Penttil=E4?= , Marek Szyprowski , Jens Axboe , Christoph Hellwig , Keith Busch , Jake Edge , Jonathan Corbet , Zhu Yanjun , Robin Murphy , Joerg Roedel , Will Deacon , Sagi Grimberg , Bjorn Helgaas , Logan Gunthorpe , Yishai Hadas , Shameer Kolothum , Kevin Tian , Alex Williamson , =?iso-8859-1?B?Suly9G1l?= Glisse , Andrew Morton , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-block@vger.kernel.org, linux-rdma@vger.kernel.org, iommu@lists.linux.dev, linux-nvme@lists.infradead.org, linux-pci@vger.kernel.org, kvm@vger.kernel.org, linux-mm@kvack.org, Niklas Schnelle , Chuck Lever , Luis Chamberlain , Matthew Wilcox , Dan Williams , Kanchan Joshi , Chaitanya Kulkarni Subject: Re: [PATCH v9 10/24] mm/hmm: let users to tag specific PFN with DMA mapped bit Message-ID: <20250424080744.GP48485@unreal> References: <0a7c1e06269eee12ff8912fe0da4b7692081fcde.1745394536.git.leon@kernel.org> <7185c055-fc9e-4510-a9bf-6245673f2f92@redhat.com> <20250423181706.GT1213339@ziepe.ca> <36891b0e-d5fa-4cf8-a181-599a20af1da3@redhat.com> <20250423233335.GW1213339@ziepe.ca> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20250423233335.GW1213339@ziepe.ca> X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 2228E140011 X-Rspam-User: X-Stat-Signature: eyqpmokakphyq8acwrki8fx3q3uoozo7 X-HE-Tag: 1745482070-402815 X-HE-Meta: U2FsdGVkX19bMDulo+sT5h4LoYaUbvmm33Hg6BCVYvBJ6c/0YTD7KaRxjexbHawdQZ0/5P8eJ47h0U3ar6nEElSrLfQFX/bvjCDQqVujOq9pntcloqMBguQE2E5xY/x9tziICGqEkbCBUmSUZmYkQ1psidNdL+fwm02fOwJb1YOg3BCiZ8wz7CcY0I4LVoa3FmrD5dZ6ziLDLvxxnaCG1nMA4mgvKWX3CXYxmVSAFkyN4b+4E7Zq1FPAhXsf8v7Vid5s725wgOUc2eykoqgj25AZjOjoIaZBihINhltBSValfKWNHgplSUHtHifxUMIJW6HacvZWQ6o01V5XvM6rfmUHMzUbsyLKaOo27CnHWriQwgDn781ojVYBwwQ8AGQFAq079fASTLXuPpAymHE4kLAmhN67LAWwKVOEsDgo2XNKDcPT3rkLFKQRoGq0ay1854hhcjLidXvteJD+pg49MJx2niHxVbXgVZRd6QtJaF5G3hldFjhUJHi+C6tCRP/NKeFj3lhdQ2MC41GoHR24+wMmBFn8SHAupD8EtxBzufMcPhIPFKe6mzM7RRI8Mf7vOxlZIlvlUtXccw/eLkypNVRaKXXK/ov6XFfNkExgyCE9gqa0ZBZrLdY4WR6+88qlItm4cLZ08MMwcuJSd6njnmDDlhrUKYaGFU0nXHovTHyCPR5BauD9z1nq08BPnE/P1NsUrbEpTEiXLUt2N4eXtXljWBcPSDPwOtcOU1QW5pdxln+OwWBNntjJnMViVWtp0ZAGOzWFL7iUlL4kqgm7f8yh923KMWjgFNHj67rA9mkX1ma2T8/AigJKMWyJ/DEDpeI/p7EKZ1Svw8DJyJA4/aXrkwz9xn6IzbG7gJdhblBvmLMmuzH5apZ+wt03K2SE1KRyxDxKlMxRQLl7RH3xUYZaRWZXYyeIVX5ExhKBZJihvEaI3gX22dQYRJENDtuD72sH6pXf4jD0LApq1/h 5Nkav1vj yIUQxF7M9oK8APc117z1G8DNXlADNObDuYamPH8vNdou2MTZAZHe2cXIDEsd92j9LK7SHcFamq8w4eVxeiWUoFfWfhlZ5UU5Nr3A+Od0t3CmgDZZB3A568FvIZHmBGZBrLI6Z9DnojhH3qHedcqsbuL1KQta/7GUgO0+Lue6fWZjkBGwyxhY7Ix12W5IYjlc2vndhcszckzphDPllMIsLLmkV4xhuEVl+Fllg4ooZ9tKxGKA76BvGii/CGzkIuLkZ17KpPtWXlEQg2l0V2A7jYZpCrA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Apr 23, 2025 at 08:33:35PM -0300, Jason Gunthorpe wrote: > On Wed, Apr 23, 2025 at 09:37:24PM +0300, Mika Penttilä wrote: > > > > On 4/23/25 21:17, Jason Gunthorpe wrote: > > > On Wed, Apr 23, 2025 at 08:54:05PM +0300, Mika Penttilä wrote: > > >>> @@ -36,6 +38,13 @@ enum hmm_pfn_flags { > > >>> HMM_PFN_VALID = 1UL << (BITS_PER_LONG - 1), > > >>> HMM_PFN_WRITE = 1UL << (BITS_PER_LONG - 2), > > >>> HMM_PFN_ERROR = 1UL << (BITS_PER_LONG - 3), > > >>> + > > >>> + /* > > >>> + * Sticky flags, carried from input to output, > > >>> + * don't forget to update HMM_PFN_INOUT_FLAGS > > >>> + */ > > >>> + HMM_PFN_DMA_MAPPED = 1UL << (BITS_PER_LONG - 7), > > >>> + > > >> How is this playing together with the mapped order usage? > > > Order shift starts at bit 8, DMA_MAPPED is at bit 7 > > > > hmm bits are the high bits, and order is 5 bits starting from > > (BITS_PER_LONG - 8) > > I see, so yes order occupies 5 bits [-4,-5,-6,-7,-8] and the > DMA_MAPPED overlaps, it should be 9 not 7 because of the backwardness. Thanks for the fix.