From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 57FA1C369D1 for ; Thu, 24 Apr 2025 07:22:42 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 675EE6B0010; Thu, 24 Apr 2025 03:22:41 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 62EEB6B0022; Thu, 24 Apr 2025 03:22:41 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 49E476B0024; Thu, 24 Apr 2025 03:22:41 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 284966B0010 for ; Thu, 24 Apr 2025 03:22:41 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 62EB41A0B56 for ; Thu, 24 Apr 2025 07:22:41 +0000 (UTC) X-FDA: 83368094922.01.EB88982 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf18.hostedemail.com (Postfix) with ESMTP id B8A9A1C0004 for ; Thu, 24 Apr 2025 07:22:39 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=WoDzuOVN; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf18.hostedemail.com: domain of leon@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=leon@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1745479359; a=rsa-sha256; cv=none; b=zeUoLOXa2DNb11xPFkeM8bX+mBKQnlR7aqLP48HdFiF2ezg6D5VU6WoVMiUVffN6SgtObA G+m3T6CJ6enSzXMYE+7Wmif0RWnz/7uE1TsP40svr2LJ0fpHzGAx+WdIJjbleZAsQ7qpYl 1BsiY4wMUAnL8REh3kEQkfhCINkHq4s= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=WoDzuOVN; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf18.hostedemail.com: domain of leon@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=leon@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1745479359; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=dt9fduLH9NEHHaOhhRr4oEvzLy9Mdk820DitIcXke4k=; b=SPVUH7o7ms/M6LGe+sBDZlJsMZD03bL/prpNOKSOIFjyC0i6VqBv2bx1qC9ffPkwfYfyY/ k/EXzG9cGoPb4JmZKT01wPEACgNHADfdIH1ocUJoCI0Zom0rz4a70yZbJ6nUfSUOCv+C3Y bTcZl9LHb561VPgiPCREgUKShYoNBvo= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 9D1EA5C5F18; Thu, 24 Apr 2025 07:20:21 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6D07BC4CEEC; Thu, 24 Apr 2025 07:22:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1745479358; bh=pkWE6sGGOL/lS7z2PofBZdgR94MWvVoyVMrCsfmGWMk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=WoDzuOVNM5Th9/6MPQtwK/rt0LHybLoQmVej7xUL7pi/+grRTLzz3YO22zNR2UUpv L0Bn1mEP+wHrMmXMnVi+xdnrx+pb56/i+NwcME8rl7+krJ8X06sAa4KiT0AJGFeGhO zvG4gVJvRX6aT9o2FnS7IA1RJT+icqhZ42NzdhXqk+vXT48zoVpYbdHXg/hsIbpVVW mb5tmX1IUQBMyuSJU93RCrakk1F6JJ/M7rFzDCbJQt3wrlrbWfV338F+OcjU+P+e3j bzNLphJk97vP+hv977iF8cPx4g8hsnK1XXRSn4AkJbQ0zy97kvPiSWubQUhNoqskr/ o45akYSgJ5EsQ== Date: Thu, 24 Apr 2025 10:22:34 +0300 From: Leon Romanovsky To: Jason Gunthorpe Cc: Marek Szyprowski , Jens Axboe , Christoph Hellwig , Keith Busch , Jake Edge , Jonathan Corbet , Zhu Yanjun , Robin Murphy , Joerg Roedel , Will Deacon , Sagi Grimberg , Bjorn Helgaas , Logan Gunthorpe , Yishai Hadas , Shameer Kolothum , Kevin Tian , Alex Williamson , =?iso-8859-1?B?Suly9G1l?= Glisse , Andrew Morton , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-block@vger.kernel.org, linux-rdma@vger.kernel.org, iommu@lists.linux.dev, linux-nvme@lists.infradead.org, linux-pci@vger.kernel.org, kvm@vger.kernel.org, linux-mm@kvack.org, Niklas Schnelle , Chuck Lever , Luis Chamberlain , Matthew Wilcox , Dan Williams , Kanchan Joshi , Chaitanya Kulkarni Subject: Re: [PATCH v9 11/24] mm/hmm: provide generic DMA managing logic Message-ID: <20250424072234.GN48485@unreal> References: <3abc42885831f841dd5dfe78d7c4e56c620670ea.1745394536.git.leon@kernel.org> <20250423172856.GM1213339@ziepe.ca> <20250424071545.GM48485@unreal> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250424071545.GM48485@unreal> X-Rspamd-Queue-Id: B8A9A1C0004 X-Stat-Signature: 8gw6qqiqhwn4rfmz5ozrfqk1jpween7g X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1745479359-531137 X-HE-Meta: U2FsdGVkX186D0f7x/phByEN8pwxWXu7BZ7vue7MfVhpe15wSMuuTP2k48ndK+3+/sznsDqEA6mgrvLaCGLToL4BqqoiSey/s3+rRI3epAe4XkiXicSg+PInFYEWbTMgGuKVOBGDXI1RW92yNTfyPcvXJfyUkPhVbT+JqvIBmJxY4dQeKj8ds57+b3gXbz7Bk4WOSRtsANrWcPMRaEv3ZyszZWJQkR/QReZKQZxualrbQhg8CsO30jar8DhumuydeDzBnA1PRL/ajOsVkuADxq3ANPcNib5tqwyRA6ylM6kEpSck2SmXGN0dc8FDpImgctNFd6QJYl662j2U4DQz+yGT8KtAHXkimrXYcgWNt4M3xL8uA3e9iK0m2B6qY+uxugai4iUE+e/Z38h2VBfLhyyy9TKV+PUx3rlmwjnF5fc7cHPXffEsjhZVaHcvMYeOMnwSg0rCvZ4u9RQA9/fhFFQkXxaW1H4utKz0ITRLHEiD29vVIHKfTx5Bu07v+uPTfnD2lH4Ylo9E1+sitxchuSLNELWIUcyVyfukR4S0y8cg+iD0/rT91ZEmcjD4Oc0NIstxX0U1G4HdgVM6dcC4utT1eSIXnF++gPj+WCOAMNT0mcoUraNqz1lr+u8NoJRjyyuPduodILxLNs3I+JXYp8mOWJok1gs8tN7eYuehWzwBOHzQzGc0jOaB+9qbSzLejJd6A26zdcqO/oTb7HL4f9aonB4NKegjYlcls0ssxlbIqtCPpy9qvnvPKvAJelD7a8a+0yOgRr4otqW+NhUHFkwKYBPfyDzQ2Z2XshOqP6xqS68bVA9k8i79tqfUJI+V7iwPzfgsKLx0Z++e454WgKh/uZpY1nGNsCrrq1v2UfXxf8yni+2PaSa8sM6sOU1Ch9RI8YVF/UzsxyET5mOqwj6VVNRGozmREA/zgOyjBHxi7iFxKKtxqbFanwgaTAqYm3AqQ44ZM//1KqNkfFm 2QJ9qiA2 3zXAtDtEwCBIIr9pfnEAJSgzzwwpJqefcjdDyMXG8Hs3aRxesEpLO76m09mBl4jcjsZmUi0CmNfK00bM8GYnVzmGoSNhOvt9zf8jnTaISUpvZv1Kecrt/sLmIzcjmBIxT4r8dbHxb1XxC2sdymK3lYEYTFLTMLMVfyEYhwk3/qM5ArLmzwL5DBaoioujJ3V6G7867QN/nc1TVW00+jVHwbM5k7llXTe7woae11YoosVjgzx+JfZiSiiy7mHV63A57SpuDjV5PKCyv90PRCWbO1rgByQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Apr 24, 2025 at 10:15:45AM +0300, Leon Romanovsky wrote: > On Wed, Apr 23, 2025 at 02:28:56PM -0300, Jason Gunthorpe wrote: > > On Wed, Apr 23, 2025 at 11:13:02AM +0300, Leon Romanovsky wrote: > > > From: Leon Romanovsky <...> > > > +bool hmm_dma_unmap_pfn(struct device *dev, struct hmm_dma_map *map, size_t idx) > > > +{ > > > + struct dma_iova_state *state = &map->state; > > > + dma_addr_t *dma_addrs = map->dma_list; > > > + unsigned long *pfns = map->pfn_list; > > > + unsigned long attrs = 0; > > > + > > > +#define HMM_PFN_VALID_DMA (HMM_PFN_VALID | HMM_PFN_DMA_MAPPED) > > > + if ((pfns[idx] & HMM_PFN_VALID_DMA) != HMM_PFN_VALID_DMA) > > > + return false; > > > +#undef HMM_PFN_VALID_DMA > > > > If a v10 comes I'd put this in a const function level variable: > > > > const unsigned int HMM_PFN_VALID_DMA = HMM_PFN_VALID | HMM_PFN_DMA_MAPPED; diff --git a/mm/hmm.c b/mm/hmm.c index c0bee5aa00fc..a8bf097677f3 100644 --- a/mm/hmm.c +++ b/mm/hmm.c @@ -807,15 +807,14 @@ EXPORT_SYMBOL_GPL(hmm_dma_map_pfn); */ bool hmm_dma_unmap_pfn(struct device *dev, struct hmm_dma_map *map, size_t idx) { + const unsigned long valid_dma = HMM_PFN_VALID | HMM_PFN_DMA_MAPPED; struct dma_iova_state *state = &map->state; dma_addr_t *dma_addrs = map->dma_list; unsigned long *pfns = map->pfn_list; unsigned long attrs = 0; -#define HMM_PFN_VALID_DMA (HMM_PFN_VALID | HMM_PFN_DMA_MAPPED) - if ((pfns[idx] & HMM_PFN_VALID_DMA) != HMM_PFN_VALID_DMA) + if ((pfns[idx] & valid_dma) != valid_dma) return false; -#undef HMM_PFN_VALID_DMA if (pfns[idx] & HMM_PFN_P2PDMA_BUS) ; /* no need to unmap bus address P2P mappings */