From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D559BC369D7 for ; Thu, 24 Apr 2025 02:45:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AA7FA6B000C; Wed, 23 Apr 2025 22:45:42 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A54E86B000E; Wed, 23 Apr 2025 22:45:42 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 832526B000D; Wed, 23 Apr 2025 22:45:42 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 65BA66B000A for ; Wed, 23 Apr 2025 22:45:42 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id A489E1CDB7D for ; Thu, 24 Apr 2025 02:45:42 +0000 (UTC) X-FDA: 83367396924.21.FAF6947 Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) by imf07.hostedemail.com (Postfix) with ESMTP id A735440004 for ; Thu, 24 Apr 2025 02:45:40 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2023-11-20 header.b=AT40zU61; dmarc=pass (policy=reject) header.from=oracle.com; spf=pass (imf07.hostedemail.com: domain of libo.chen@oracle.com designates 205.220.165.32 as permitted sender) smtp.mailfrom=libo.chen@oracle.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1745462740; a=rsa-sha256; cv=none; b=NQAOmpL5VwTEXzotilcbdEl1lNC+XRY9BYepkyR412AHvZyedY/e2VK+mkjQgFSVYD1IzH li2HmANgyoj2C26i1+W+BJrAqOWVBdYE4oy31+2bpxMqjR/K/oYyYVvL3bbnlXWEdvL3MV xVsPmwkLozFa3gVm5vj3erufX+yYGj0= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2023-11-20 header.b=AT40zU61; dmarc=pass (policy=reject) header.from=oracle.com; spf=pass (imf07.hostedemail.com: domain of libo.chen@oracle.com designates 205.220.165.32 as permitted sender) smtp.mailfrom=libo.chen@oracle.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1745462740; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Jfi9WscH0qLUANjDVKHfTqmq+k7m7mKeWTnbq5WqGO8=; b=4w1Z25IzOem2UELaHHY4FdXncMuQN0gSvWtEIDu0awVI5g6RAH3exzmXcGeJdoRFNfTdcs ipkRSm+z/5fWl5oeVfZz8t039MSymr1bz8kqG0CYBIByW/iwObrWA9dF5D6UPwrAzvlYZu pYuxJ46vLhuWxjqG5v1jOC0Iqrux3vk= Received: from pps.filterd (m0246617.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 53NLNA0C018126; Thu, 24 Apr 2025 02:45:33 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=cc :content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=corp-2023-11-20; bh=Jfi9W scH0qLUANjDVKHfTqmq+k7m7mKeWTnbq5WqGO8=; b=AT40zU610csFqG+AzOG2D p8gCLX9z6uShmEYlLRJJ7P/h+pg1oACEXNoValFx0lVdhL897NCl2HB7a7Rdg4Ks rxNmxJFIvzS5WeUF0Pjm2i1/OQdoClzsCmnhs7tlaPIny0Nd1ZWG91no6Y33OXYR 01QRxTFa8VtmpUq7EfrbC2DofXK/9lMJ1EDdB1zu5y6RVjq2n3NhM4LCBNEf/jsA hQNiWuCobwMYJsn66FCL8I7KN4dkw4HIncQ6fTzhO2RZzHMDB8JfpJ/oSqrGe+nZ vyTd+zkkx9JgqxLZdlsjp67z601AQoINOqKeKOBWkjWsaUbVgV3W/xLDKlFaVumP Q== Received: from phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta03.appoci.oracle.com [138.1.37.129]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 466jkjjx76-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 24 Apr 2025 02:45:33 +0000 (GMT) Received: from pps.filterd (phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com (8.18.1.2/8.18.1.2) with ESMTP id 53O0PRJO028392; Thu, 24 Apr 2025 02:45:32 GMT Received: from pps.reinject (localhost [127.0.0.1]) by phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id 466jx6xs1m-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 24 Apr 2025 02:45:32 +0000 Received: from phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 53O2jQBJ033048; Thu, 24 Apr 2025 02:45:31 GMT Received: from clb-2-bm-ad2.osdevelopmeniad.oraclevcn.com (clb-2-bm-ad2.allregionaliads.osdevelopmeniad.oraclevcn.com [100.100.254.172]) by phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTP id 466jx6xrxs-3; Thu, 24 Apr 2025 02:45:31 +0000 From: Libo Chen To: akpm@linux-foundation.org, rostedt@goodmis.org, peterz@infradead.org, mgorman@suse.de, mingo@redhat.com, juri.lelli@redhat.com, vincent.guittot@linaro.org, tj@kernel.org, llong@redhat.com Cc: sraithal@amd.com, venkat88@linux.ibm.com, kprateek.nayak@amd.com, raghavendra.kt@amd.com, yu.c.chen@intel.com, tim.c.chen@intel.com, vineethr@linux.ibm.com, chris.hyser@oracle.com, daniel.m.jordan@oracle.com, lorenzo.stoakes@oracle.com, mkoutny@suse.com, linux-mm@kvack.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v5 2/2] sched/numa: Add tracepoint that tracks the skipping of numa balancing due to cpuset memory pinning Date: Wed, 23 Apr 2025 19:45:23 -0700 Message-ID: <20250424024523.2298272-3-libo.chen@oracle.com> X-Mailer: git-send-email 2.43.5 In-Reply-To: <20250424024523.2298272-1-libo.chen@oracle.com> References: <20250424024523.2298272-1-libo.chen@oracle.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.0.680,FMLib:17.12.80.40 definitions=2025-04-24_01,2025-04-22_01,2025-02-21_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 malwarescore=0 phishscore=0 suspectscore=0 mlxlogscore=999 adultscore=0 mlxscore=0 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2504070000 definitions=main-2504240015 X-Proofpoint-GUID: YrgbO1E1Q_jUOnOXG6PcmF1dYKwo32ZK X-Proofpoint-ORIG-GUID: YrgbO1E1Q_jUOnOXG6PcmF1dYKwo32ZK X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNDI0MDAxNSBTYWx0ZWRfX8dIR9yw8bpy9 c0LC0QHXzTrdODkEDOAKnqPISHngM5Fsg4AHxbfBQl6TF60xJqJInowMf4R6VyB2f07NYwmXNj4 ncH34QhqenxIDY/YF8ACC5CdE2bRAm2WOu2EU857V7uy7ENICejPwsjMsWlsyH9W0HEX2+sltkH wapMiAoWX+bhNvRDSVIbamcyoWAdPbLIDlqEONuo1zpR/fXYUVeFKk2vZ1HObbvy0/EdlFF6Mck dlGLxmGUR/iwloRqZOz6hvMyeVdHj8Hf8zrDP9sSR88NTwzXlx9EErA+kfr+3YVo45p0ZxkCSGB sX1CdCrOMgMUNArI2Q58htmmQyb458EyOWqhI8kIBC0hEcz/p035ToUSXBoS0A7vSKqz6p49+1w 0XbuUUqs X-Rspam-User: X-Rspamd-Queue-Id: A735440004 X-Rspamd-Server: rspam04 X-Stat-Signature: k41tez8xpdf9of73u4zn336jn1bpn6qx X-HE-Tag: 1745462740-133375 X-HE-Meta: U2FsdGVkX19/94VRYGSTG3XJhI/+P945116p26+0W0C8BdaqmGjsYCjF/VvRN+8mf7V/of25tq52D4+UfjFtwsTT7I2mY9ntPHTncYSvyNDccVFKHuIppNp1VbZIGYW8QrqiYMkC2OHdas1u9M+EifDhLfGiu9Zf6BB48707uqdKxApYnpKJhE6YA0a9kG8FSzbFxN41LHlwCry8q69UaAAY65R+W2RBaUwh/C2v/h4NnWcikO1d4wjwm3eK1T5yrnZWemk7nQdvaZS9CUgM0YfVWp09YoFrx8fwac7dGMgnFvA91MqUqCML8E4mdommc9LYS6FRvd1w7INpKkVP2r+lNCANXZEkhbwZWdec8ONkQDnFIwVmU2q4nJ5E2Wy3Y9TZoRswYPx3coGrqvGLQC4/AyHW6mzqtDlfc89kS6FK81QjBJMYotJvwaSq0mNtRKwfhuISOCpV83Ql2m2xA2MFujUUbjWmAhKJZwPmwKnNoKKU3AnUV2H60frv+RkedF4q/v1cFp5fHdcPXD9Pq/a05lDASQzO+rI5BsSsiVL+/KktMAcReZW/CN/QzUkJQ+j6A6fL8SkmiXf18qZ3j2zKr3kfG0Pby/e5X7F738xzw6fnYz1IMz5a+v3QY29LjECPT59GAl5WZKbsGD3rYLqBL7ghTYNltB++5sk6qDzv7LmPSX1NwPpuSBwPSR4pCkOwTrt6mFUsvGk7igCRdjrULd+I6vWuj/DQvLJiwAMcLP6I/PMGVnOe0SoMMwR4ueqw9B2FqNfr066nQ+W7LKSLEkoMJKIgZp6RoX3Z35LhwTrFgyidjHXCxh+ESrtrFKK97CRfnviJ2BRCITCS1S43qmNIVKYlB+wTchVwsmd+X1wFZZzYBQIu8qiBB2F9W5ZH9rtHZlwsW8oLlxiVJw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Unlike sched_skip_vma_numa tracepoint which tracks skipped VMAs, this tracks the task subjected to cpuset.mems pinning and prints out its allowed memory node mask. Signed-off-by: Libo Chen --- include/trace/events/sched.h | 33 +++++++++++++++++++++++++++++++++ kernel/sched/fair.c | 4 +++- 2 files changed, 36 insertions(+), 1 deletion(-) diff --git a/include/trace/events/sched.h b/include/trace/events/sched.h index 8994e97d86c1..ff3990318aec 100644 --- a/include/trace/events/sched.h +++ b/include/trace/events/sched.h @@ -745,6 +745,39 @@ TRACE_EVENT(sched_skip_vma_numa, __entry->vm_end, __print_symbolic(__entry->reason, NUMAB_SKIP_REASON)) ); + +TRACE_EVENT(sched_skip_cpuset_numa, + + TP_PROTO(struct task_struct *tsk, nodemask_t *mem_allowed_ptr), + + TP_ARGS(tsk, mem_allowed_ptr), + + TP_STRUCT__entry( + __array( char, comm, TASK_COMM_LEN ) + __field( pid_t, pid ) + __field( pid_t, tgid ) + __field( pid_t, ngid ) + __array( unsigned long, mem_allowed, BITS_TO_LONGS(MAX_NUMNODES)) + ), + + TP_fast_assign( + memcpy(__entry->comm, tsk->comm, TASK_COMM_LEN); + __entry->pid = task_pid_nr(tsk); + __entry->tgid = task_tgid_nr(tsk); + __entry->ngid = task_numa_group_id(tsk); + BUILD_BUG_ON(sizeof(nodemask_t) != \ + BITS_TO_LONGS(MAX_NUMNODES) * sizeof(long)); + memcpy(__entry->mem_allowed, mem_allowed_ptr->bits, + sizeof(__entry->mem_allowed)); + ), + + TP_printk("comm=%s pid=%d tgid=%d ngid=%d mem_nodes_allowed=%*pbl", + __entry->comm, + __entry->pid, + __entry->tgid, + __entry->ngid, + MAX_NUMNODES, __entry->mem_allowed) +); #endif /* CONFIG_NUMA_BALANCING */ /* diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c index c9903b1b3948..cc892961ce15 100644 --- a/kernel/sched/fair.c +++ b/kernel/sched/fair.c @@ -3333,8 +3333,10 @@ static void task_numa_work(struct callback_head *work) * Memory is pinned to only one NUMA node via cpuset.mems, naturally * no page can be migrated. */ - if (cpusets_enabled() && nodes_weight(cpuset_current_mems_allowed) == 1) + if (cpusets_enabled() && nodes_weight(cpuset_current_mems_allowed) == 1) { + trace_sched_skip_cpuset_numa(current, &cpuset_current_mems_allowed); return; + } if (!mm->numa_next_scan) { mm->numa_next_scan = now + -- 2.43.5