From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9D5E9C369CB for ; Wed, 23 Apr 2025 23:33:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B6E266B0005; Wed, 23 Apr 2025 19:33:39 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B1C276B0007; Wed, 23 Apr 2025 19:33:39 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9BEA96B0008; Wed, 23 Apr 2025 19:33:39 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 7C8BD6B0005 for ; Wed, 23 Apr 2025 19:33:39 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 84EE180237 for ; Wed, 23 Apr 2025 23:33:39 +0000 (UTC) X-FDA: 83366912958.05.635596E Received: from mail-qt1-f181.google.com (mail-qt1-f181.google.com [209.85.160.181]) by imf15.hostedemail.com (Postfix) with ESMTP id 83915A0008 for ; Wed, 23 Apr 2025 23:33:37 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=ziepe.ca header.s=google header.b=Yu0Jj7kJ; dmarc=none; spf=pass (imf15.hostedemail.com: domain of jgg@ziepe.ca designates 209.85.160.181 as permitted sender) smtp.mailfrom=jgg@ziepe.ca ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1745451217; a=rsa-sha256; cv=none; b=mum83bFpS5gwFVnWcyg2Gz0OKWSiLwHUerTVZNBJMN5fXYnva2jKoz4wQsHyg2BqckUULu 5GqnoftMvq7HX08EYulLHj1nKlM8TrioZ5/IapP5B86yMUlqMK/YsKnNh1l+9rmQHKLIhE KJ7ItWd8MqAy/rxOIKPLtbn38UN2f9o= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=ziepe.ca header.s=google header.b=Yu0Jj7kJ; dmarc=none; spf=pass (imf15.hostedemail.com: domain of jgg@ziepe.ca designates 209.85.160.181 as permitted sender) smtp.mailfrom=jgg@ziepe.ca ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1745451217; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=L7oRP2YqJwVB6GeEu4BqvXzZqclhisHpp0fN6LY14JQ=; b=wEQx1ic/B2GRdd6tsP22QEbvawAGagx48T0zVzdY5PXWcVjI9QSMF3RzUKf6ASWhHxWnLv qggp4f4PtvWFIBU9Z9qgCNHhirnTGc0ubFMxCoQ0pxzmZaBICfO3YaZi+lb7AczQeXawqy uUFIODJsw06+Yg84piaOpRpViKoB/T8= Received: by mail-qt1-f181.google.com with SMTP id d75a77b69052e-477282401b3so4518331cf.1 for ; Wed, 23 Apr 2025 16:33:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; t=1745451216; x=1746056016; darn=kvack.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=L7oRP2YqJwVB6GeEu4BqvXzZqclhisHpp0fN6LY14JQ=; b=Yu0Jj7kJYVWfDgU4Wg13uCY2YZzI1wV8d5LHOf5ALwiqgg6gv+iFMw4qu/C3ELsuXR OhL6YU0ly413kQ2E/i1TDeaUV9Jt83KdRI6zo+TirYmoT3xvcL3RTih0hi/TlOL7f/Wx FgXKURQN81vosXDuU6QN5LMKWw3ixqjyM82rNAbfA7y9f4EDEwzyFeVzxndO4OoNS+Q+ Jaunlk1km/ZUBC2iD1rRVBgHir3OP5Y4RjuZH7WFFtxXuT7scFvCmOcIF7ocEwo2Md9x hjK7ASW1z5frEsnuCtRsyDuSZL9xqG2vJAZrTiBThq11S5bMrSTq0etcTFetbbZw5mmP u8aw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745451216; x=1746056016; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=L7oRP2YqJwVB6GeEu4BqvXzZqclhisHpp0fN6LY14JQ=; b=n4TGZjrUsRrAl/qVvL6CpVQ+ZWOy2aLaZPYYXYc/WfslNBkoKVoB1KTfhJJL9F8YDA U6+2bqCo/3llX3A4clU+s2M7EQNnoo5zPLuouZCc5MAKN8WLgsEVhN1bmKCN/ohIixyI pJI+vSXM75N72OT7X2+NNwQNZo10dlXzg0nptdiyHv95TeWAhnPhbljYAh+DjRhRVqo0 gec+6XhT4unSrhGuqP+Gwv9hUZZSBx6xbY2S55e4aFEky4RvdrtWnSOzKifxF9vIIbdF b+gOcD4KJlo/peVCeq/nFeHbjjunOzHIH9HFprI6M/iUSrFcH/9xMEkoGVIkvIGLMddX jo9A== X-Forwarded-Encrypted: i=1; AJvYcCVM41jNV1L3hkSk7p5s3ZU8BGKfXcViONqRBkgqll5acJHcG0f8k3uCjppFKATDOeMrXJj53QxfJA==@kvack.org X-Gm-Message-State: AOJu0Yxi83g9MNdoPcmtEuwu0tHepRvR8hFlFOHvRYcmPnoUbJd9t5G5 nQQeqFDoPWUbKp1gSVG2oxQHutcckooxVbFIPeTSeiswQZOgJj0C8SziXoC0kBU= X-Gm-Gg: ASbGncs5Wfu+l3NfRMpIjlvP1AfvueYLWc7hNeHwWWFkZykTk+y4rys5jFfKndRHa/j 0wSN43gMGIwjRINm6m1UKPRwY8JdHvFj4i+GzpY4ttHOdw626leKp2S+jRKhYG/AHt+INiHMb1C wAJZ1neoKqL3r6jKuxf8XB6Ahn++SvLuFKmFWJ0gLFsKXV1g7aq5vaIl3MJW+2C4LVmt5hAFp1f 1TyTVmNwoYUKFg/RCBI0NJ5gd3D53pr8WVzwvOzxzxCJ5496AOIRVa4wwxfHan/N7PG5Gaj8ky9 sI5u/wtuTIsu3SEUPPIOQ+tsh424+lNIcvXF8XAhj54gPYuPl4QzVpVz50hO6ZaF/Gmye8c4uKP czAEUOgnMh/Y+Ehhhf8w= X-Google-Smtp-Source: AGHT+IHp4LWhqR/rJc6pqFU95w2BqdqjYtJ4SAe1Mvc/v+Ufccgyj7hWc7Mm96oBr3hzP4lBlnfnCQ== X-Received: by 2002:a05:622a:388:b0:476:b783:c94d with SMTP id d75a77b69052e-47eb4fbb928mr6490361cf.35.1745451216599; Wed, 23 Apr 2025 16:33:36 -0700 (PDT) Received: from ziepe.ca (hlfxns017vw-142-167-219-86.dhcp-dynamic.fibreop.ns.bellaliant.net. [142.167.219.86]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-47ea1ba154asm2538601cf.67.2025.04.23.16.33.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 23 Apr 2025 16:33:35 -0700 (PDT) Received: from jgg by wakko with local (Exim 4.97) (envelope-from ) id 1u7jax-00000007PKl-19Zx; Wed, 23 Apr 2025 20:33:35 -0300 Date: Wed, 23 Apr 2025 20:33:35 -0300 From: Jason Gunthorpe To: Mika =?utf-8?B?UGVudHRpbMOk?= Cc: Leon Romanovsky , Marek Szyprowski , Jens Axboe , Christoph Hellwig , Keith Busch , Leon Romanovsky , Jake Edge , Jonathan Corbet , Zhu Yanjun , Robin Murphy , Joerg Roedel , Will Deacon , Sagi Grimberg , Bjorn Helgaas , Logan Gunthorpe , Yishai Hadas , Shameer Kolothum , Kevin Tian , Alex Williamson , =?utf-8?B?SsOpcsO0bWU=?= Glisse , Andrew Morton , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-block@vger.kernel.org, linux-rdma@vger.kernel.org, iommu@lists.linux.dev, linux-nvme@lists.infradead.org, linux-pci@vger.kernel.org, kvm@vger.kernel.org, linux-mm@kvack.org, Niklas Schnelle , Chuck Lever , Luis Chamberlain , Matthew Wilcox , Dan Williams , Kanchan Joshi , Chaitanya Kulkarni Subject: Re: [PATCH v9 10/24] mm/hmm: let users to tag specific PFN with DMA mapped bit Message-ID: <20250423233335.GW1213339@ziepe.ca> References: <0a7c1e06269eee12ff8912fe0da4b7692081fcde.1745394536.git.leon@kernel.org> <7185c055-fc9e-4510-a9bf-6245673f2f92@redhat.com> <20250423181706.GT1213339@ziepe.ca> <36891b0e-d5fa-4cf8-a181-599a20af1da3@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <36891b0e-d5fa-4cf8-a181-599a20af1da3@redhat.com> X-Rspam-User: X-Rspamd-Queue-Id: 83915A0008 X-Rspamd-Server: rspam04 X-Stat-Signature: 4owrcfy13c9af3qjamkze1rf3ff316p4 X-HE-Tag: 1745451217-496912 X-HE-Meta: U2FsdGVkX19C1cJ5OO7SbTjwWByjb5fjqee8bFaeOPPqOlRvE7dGT5J2/BW+TlvMlSYdvLTq/88va5uPcxy7Fy1gh7o1V2nmLyZvQpPkaubBObYA+BNFmgnfDRbZfp92fPgve+zYPIIYLRZT08UH4YzsX9cmAQpnuBZUPOGT2Otj2rrMpdYsFhf147JMXpFaO7cMT+on4yZdrxbOdiw/zh+KXqUwvO8jJf2fDfPtAitwiJkdgqzHosmDrI8UU06VQSYiOdDrs+KwP0IbAnCVz4gW9qjpAqP/eEgxleFAQG8OdBHBH0gj7YLKGXOQ27osN72PC5Ss1WL1bXlup8+ztT/iNfClistG09TovjQv4/gUCDYm8naLZTPoRujT8G5SVCt4eDuLTqTpTQb2MOl39yqOArVZhiXcYpnbxTGitdKoPRNdAwSDeAoj9a7zZrdw93aVTvUd0a/TRmRpRcRz1nXLLhzdJ9mfKI2vmNqVb/lF5duhYorYPkyIowGxvzKHEB1ZpI9R4NbzU3ZLrsS0TgqVP8esNSKs8fBxeGFphN7Ttp5BotrsglKuBybIWjs868z8sfHn36pv9da+ljK736PwoYJgqo6ULDbcQcAq0oRaOW6DPQwZ5jwBOD2etIzSBrhilA9fB0bJbaVWK+wWnc0uCSDShM9syT26POSdwSiAIE9jRzcScCO2v0Zjr/ja4lvmuxAXu1LIGeonDxIz9LOZ015AO3f83I2nvjQnPcjAup8SGoe36UXfaqW9ErP1j44reav68Z6eiFTdNJR5pBtRivF8WPhzfqPNDv2v7P8ashfyKZwLm18u1Ht/Bmo+XAiRmC8PAjoVAf3LzaWRljbRtthutq3dvQIpV7fZNsDbQKtRvHw0kgOzg7p0iMbWtH7qjwfH6LsbvZwreZMy55BG7+DmNedTXKMIJf64f2b/HE9nyiIPldblvSf2qgmZdpaxJTcJRT3DfL+Dokk TB1aUslV W73As/1nKyzrcAVDtb+9P90Waw1bL6rqIDA5y12svMWbAU5iQgqtfjt5aueyXYbfp/Dsj6yvWCDLNwCWoEU4ufizQQqxZJJwuuVuAwt3BogAB4jgMyjuMrZlgiYOB/BKq+GDHWClrTxcK0dYU6VZTc0F3iZONqqQHWYlxkOWJdd+bZ8rQxNzrIW79WZhkDrdTXofWvYoG917ZvXTU6naV1c6ELs4byb6UvlUEV2h9OPTygruXhKYQ7ruihXfXH3bKd3rF9DC7yz02IU6kpSV1F6RlHhS8zH0o6kQTuHF82HUyWN3m1X7vyXpJMA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Apr 23, 2025 at 09:37:24PM +0300, Mika Penttilä wrote: > > On 4/23/25 21:17, Jason Gunthorpe wrote: > > On Wed, Apr 23, 2025 at 08:54:05PM +0300, Mika Penttilä wrote: > >>> @@ -36,6 +38,13 @@ enum hmm_pfn_flags { > >>> HMM_PFN_VALID = 1UL << (BITS_PER_LONG - 1), > >>> HMM_PFN_WRITE = 1UL << (BITS_PER_LONG - 2), > >>> HMM_PFN_ERROR = 1UL << (BITS_PER_LONG - 3), > >>> + > >>> + /* > >>> + * Sticky flags, carried from input to output, > >>> + * don't forget to update HMM_PFN_INOUT_FLAGS > >>> + */ > >>> + HMM_PFN_DMA_MAPPED = 1UL << (BITS_PER_LONG - 7), > >>> + > >> How is this playing together with the mapped order usage? > > Order shift starts at bit 8, DMA_MAPPED is at bit 7 > > hmm bits are the high bits, and order is 5 bits starting from > (BITS_PER_LONG - 8) I see, so yes order occupies 5 bits [-4,-5,-6,-7,-8] and the DMA_MAPPED overlaps, it should be 9 not 7 because of the backwardness. Probably testing didn't hit this because the usual 2M order of 9 only sets bits -4 and -8 .. The way the order works it doesn't clear the 0 bits, which I wonder if is a little bug.. Jason