From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 325D7C369CB for ; Thu, 24 Apr 2025 01:31:57 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 68E946B0006; Wed, 23 Apr 2025 21:31:56 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 616BE6B0007; Wed, 23 Apr 2025 21:31:56 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4B74A6B0008; Wed, 23 Apr 2025 21:31:56 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 2D30A6B0006 for ; Wed, 23 Apr 2025 21:31:56 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id EEF19BF8BD for ; Thu, 24 Apr 2025 01:31:55 +0000 (UTC) X-FDA: 83367210990.29.9C26511 Received: from tor.source.kernel.org (tor.source.kernel.org [172.105.4.254]) by imf09.hostedemail.com (Postfix) with ESMTP id 48DB414000B for ; Thu, 24 Apr 2025 01:31:54 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=none; spf=pass (imf09.hostedemail.com: domain of "SRS0=aaZh=XK=goodmis.org=rostedt@kernel.org" designates 172.105.4.254 as permitted sender) smtp.mailfrom="SRS0=aaZh=XK=goodmis.org=rostedt@kernel.org"; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1745458314; a=rsa-sha256; cv=none; b=btsLgO7ms0QvUfsKTUZC+27pNVkRaUAZCVRNCVRCxsjyCHXqXA+mJpwJ2jFqt3wHE1tCUf KN9lwbJ5PAfsaTkLlmOICxvys2R6y/FyB1c25I0MLf4U25QnOfEUZsYNMBHsD65/uzDrq1 H1iy1VPhP8cW9daPP+kuamaGu4qag+o= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=none; spf=pass (imf09.hostedemail.com: domain of "SRS0=aaZh=XK=goodmis.org=rostedt@kernel.org" designates 172.105.4.254 as permitted sender) smtp.mailfrom="SRS0=aaZh=XK=goodmis.org=rostedt@kernel.org"; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1745458314; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=BXPl1bLZFrVZ0xiMN75mzh6lLHMO2sSPo/C66tBixbE=; b=kTo11uwkm/MzI3IY1UPAbcBLFGqYdgfC2av/0VlU3/DEf/GMCAseFKPWoZpbQvQgdVFUC+ cVkAJEQh7GUJnpM8V5VaK9SK5ZEfgCxgfjMIEhvk0ELe6IHEqN3zIwlfDoToZRCHzuaWfe ciYSxEjUCXeM71uzl1GPgUevrC5mN+U= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by tor.source.kernel.org (Postfix) with ESMTP id 0AC7568453; Thu, 24 Apr 2025 01:31:32 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id BB3FEC4CEE2; Thu, 24 Apr 2025 01:31:50 +0000 (UTC) Date: Wed, 23 Apr 2025 21:33:43 -0400 From: Steven Rostedt To: Libo Chen Cc: akpm@linux-foundation.org, peterz@infradead.org, mgorman@suse.de, mingo@redhat.com, juri.lelli@redhat.com, vincent.guittot@linaro.org, tj@kernel.org, llong@redhat.com, sraithal@amd.com, venkat88@linux.ibm.com, kprateek.nayak@amd.com, raghavendra.kt@amd.com, yu.c.chen@intel.com, tim.c.chen@intel.com, vineethr@linux.ibm.com, chris.hyser@oracle.com, daniel.m.jordan@oracle.com, lorenzo.stoakes@oracle.com, mkoutny@suse.com, linux-mm@kvack.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 2/2] sched/numa: Add tracepoint that tracks the skipping of numa balancing due to cpuset memory pinning Message-ID: <20250423213343.6c5dd621@gandalf.local.home> In-Reply-To: <752119fe-b5fc-473e-8968-0b4a5ef34d3b@oracle.com> References: <20250424000146.1197285-1-libo.chen@oracle.com> <20250424000146.1197285-3-libo.chen@oracle.com> <20250423201829.17d4c382@gandalf.local.home> <20250423210108.5b2452ad@gandalf.local.home> <752119fe-b5fc-473e-8968-0b4a5ef34d3b@oracle.com> X-Mailer: Claws Mail 3.20.0git84 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 48DB414000B X-Stat-Signature: joypcgfxy4cofnfrhpff6h9tqmegifqo X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1745458314-486484 X-HE-Meta: U2FsdGVkX1/akx+sPywrYPwUbdbiUQ0IYhmcIS30DJXmcBvpVdNfXKmZpfemkAaRkHgJB2UU4exrfneQxfj+T92NQnCaU4ppQ3mxJzuhJysKtENSsmTvvDK6GAU/F//gN5t6y/7vTE1erib/rODoqcjxNZ+HLX75quY0doOyomLQNDdbixvTOtSQY6BXe9nwA00E7Iz1a7rJtt97abr5kdQRVHhceHEIJ9Hj4drxTfH14OG5UD/4Vasa8U8BCif45iMaWIcfrh+PtQEJwhhqrOS4Rvpty0nInwCtIUSNf9ctFyQGiaevvUZ9lEhMYJRxOjAsSD3MeYcF8+2srdFf9HF11AdhIb7bfyPPaKx/2uxTPR2m4xvZjsB9bcyhX2ObUbnv9f8HV4dzWKVfIWOXUbut9jEAfXhAlxueYzLvWRK9fwMezg1XnV2D3TwLwNB9o38dg7V6g4clDo1LvWVwYTTQpkHP0A1ez2qHJqqF9ysTq/DZWDi7ELJXyH1Rr6udFHSdAuqvQwdjnvllOQUWhW8z9hAhcW6zMNJWh+HeJKvgFZxTqE6PWmLW3mVejCtSlu22Na9gqR0AKhdBq44yM7UJ4+qzyK+2VpH/aEgIXUxhqN4AeW7IPlDLDJO4pwFrruu2w2/IeS/BWxbbHqZgBb0MQJRPMurfEEi5dlGFwbifsuWtc5jJSv3SEowUKTD0D4Mt42AXclB982OaNMrav7vRgky9zOJjP23DHBTpq3m9B8Toq13o8cvaJklLFOUmDvaYsm3MUUKwM8B129cRhr/VaoK9B7HZBvG7P4hnE4ZQe/SvrqwOq4NSqqHOjx0dIduOW1epjaDqfvhgxOobcoet+KQznbJlKKg9i/BdWON/MejdyafDzUiSe06bV44SFLmHpqKeCqEvoCgdjBnL69f8XD/yXpqqstN44optNJJxS1kPvazpCqKGTrkIjF3yGYu0t80ATgWnzokXWyp eORDbsxG dsFs1zP3JpcYxoDdlvoX5uMgSM06yLhftmdYvavyDSFEwijEU58OowQap4vgAJXyLdNC008gNoVrTSO4M/h0pFjIQs3hDGSkJvk2FXYHGNKGIUw2Y+LWzpjfc2h66TZbHVFUgS929CeyVpWv7VyUJN0HRMbYHY2+ngxqFCpaej29qeHkd09OxvL+XuM4TPVjlX8yTGJNJ6knTC4ShBf7jgZ/S4WHgHj3nbjjpFxcmnGiCWRyxs6/kktMwxPjz+sD7HKSN2+Dr2AT7Fy4tDxxqt4rHBw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, 23 Apr 2025 18:12:55 -0700 Libo Chen wrote: > > Hmm, I wonder then if we should add in TP_fast_assign(): > > > > BUILD_BUG_ON(sizeof(nodemask_t) != BITS_TO_LONGS(MAX_NUM_NODES) * sizeof(long)); > > > > to guard against potential changes in nodemask_t definition? Correct. Whenever there's an implicit dependency like this, where if something were to change it can cause a bug in the kernel, it's always better to have a build time check to catch it before it becomes an issue. -- Steve