From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 395F6C369CB for ; Thu, 24 Apr 2025 00:16:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5F99E6B0005; Wed, 23 Apr 2025 20:16:41 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 580E26B0007; Wed, 23 Apr 2025 20:16:41 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 422316B0008; Wed, 23 Apr 2025 20:16:41 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 20E686B0005 for ; Wed, 23 Apr 2025 20:16:41 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id EA9721407EA for ; Thu, 24 Apr 2025 00:16:41 +0000 (UTC) X-FDA: 83367021402.26.B667A34 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf03.hostedemail.com (Postfix) with ESMTP id 3BCEF20003 for ; Thu, 24 Apr 2025 00:16:40 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=none; spf=pass (imf03.hostedemail.com: domain of "SRS0=aaZh=XK=goodmis.org=rostedt@kernel.org" designates 139.178.84.217 as permitted sender) smtp.mailfrom="SRS0=aaZh=XK=goodmis.org=rostedt@kernel.org"; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1745453800; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=wiwpWt0GQg3WYqcvl2b+yA/CTRPmBEEIlTpmSjZjOBw=; b=1gjxVeoeGvsQBVVm1G6dILgi8JEnVZfcJTigfyvx2ROeO/ie77mIxJFCOl5ikT+MRAyTgd C5wKboJwGmOyyHHO1ELO8Fukr0k3TqRijIii9h4nNbXA23iWA68NKgFcpgg7l0QzM/lpq0 WgJUqkQFF8qqN+HXWK6TPeca+MCDzVQ= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=none; spf=pass (imf03.hostedemail.com: domain of "SRS0=aaZh=XK=goodmis.org=rostedt@kernel.org" designates 139.178.84.217 as permitted sender) smtp.mailfrom="SRS0=aaZh=XK=goodmis.org=rostedt@kernel.org"; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1745453800; a=rsa-sha256; cv=none; b=ttl/n5rlx7yEBa7eFTpYpU/sEDpgbOl0Oo9M/PyYlYvpMaaQvQmgqAhdXBe5/uPsN7IbW/ 7PPOeftvluTgU/UsT+Rov5Uyyou0c82ereL1vYJqXXEviXsrB2kfm0ea125dWWsvkXvQr4 bU92N1Adp1NyM8nA8G9yf8tI9tAT9GY= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 30C545C5400; Thu, 24 Apr 2025 00:14:22 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 95D03C4CEE2; Thu, 24 Apr 2025 00:16:36 +0000 (UTC) Date: Wed, 23 Apr 2025 20:18:29 -0400 From: Steven Rostedt To: Libo Chen Cc: akpm@linux-foundation.org, peterz@infradead.org, mgorman@suse.de, mingo@redhat.com, juri.lelli@redhat.com, vincent.guittot@linaro.org, tj@kernel.org, llong@redhat.com, sraithal@amd.com, venkat88@linux.ibm.com, kprateek.nayak@amd.com, raghavendra.kt@amd.com, yu.c.chen@intel.com, tim.c.chen@intel.com, vineethr@linux.ibm.com, chris.hyser@oracle.com, daniel.m.jordan@oracle.com, lorenzo.stoakes@oracle.com, mkoutny@suse.com, linux-mm@kvack.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 2/2] sched/numa: Add tracepoint that tracks the skipping of numa balancing due to cpuset memory pinning Message-ID: <20250423201829.17d4c382@gandalf.local.home> In-Reply-To: <20250424000146.1197285-3-libo.chen@oracle.com> References: <20250424000146.1197285-1-libo.chen@oracle.com> <20250424000146.1197285-3-libo.chen@oracle.com> X-Mailer: Claws Mail 3.20.0git84 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Stat-Signature: myxut1a8yx1mfno3gdzfn4cg5q1nibnd X-Rspamd-Queue-Id: 3BCEF20003 X-Rspam-User: X-Rspamd-Server: rspam05 X-HE-Tag: 1745453800-837359 X-HE-Meta: U2FsdGVkX18tW0iC79cjRuJAH1oULD5Ioy1Xn7Q8dgMcXxfN5GG+HTWXUmnxSbQ85d3hPLFd7M7cfinsWFB/ZECRXCK2QA7I1ggiOza+6o67KoxFj4IeMTb1ka6FKChLUJQr3AJhyB1U7mK6eJmS/sUTOAopIR2l5oTG9m58fWn0gnJgwSqeu+E8xRI++iFWPsKRwiujl4csoTSfTqfxirn7IdqOZOvaORW38ZvMW/Tm0u+pE4R2brHxOPBm7j0geZdoJCIiogqpSqKGIneoTNvjpnKmiY/P++w3jSoPelEG65p1QFqBRggBCIQcTPi9b5UlEhISOU4LH6uawWX/YHQns5OYb6Y8sEtNdpgmGAP3vSBW98Eu0RVF3+/zC39BhOvitcbn1UJTc5Bmi5hO8unyQMEQifxEWYat6cElaPFhP9q5ChorUT50PQwgE1L0nXIvPeYIkgRT2/D9AH4cMaUaYxN1RTSS4Pv76wF9mVCOwMaHTg3oTH72ULzIWknDPUbY3YQVJzOkWs674yydS4VaGRp2UKBuwAnYVgZzjTuatPP0cW24VAdsfUMmUDaCWKDMUo0tGF0sJVYURydFytKEfQU9X86RuBBqwtXsqKnvT7i6cw1sM7dSl2Kx2eL4Xqzw5/h9jMnionAdqXxUW8kQp/eWdiJclJGR/wK/LKRym4Yviv1/PUqc+M7AS1aORogPEJlhMk/jvF+Ci62/T+8HCo/wvA7mKBWXHykGoB3BbDglP3xdzsKoDfYoinbPqQZ4hudM+mWQOdUuOe4EYdkJzCA7r05uKNo8RYscLJesunbtELuBxK5WbXCIBXjV4xAlQ2OgIHpM7eDzprfkTY72hO4BL5MNUNLT4sDWxVP5wDC7MXpT+SvrcpRvErRkq3YXGMr0Xx5vuTF0iWhX8QsJGuXkqYhrWRuFQxDuW9Fs7PEH1XCkcfitCozIudRXz/KiRxux/EDslEKmMgS H5/kVcLB nGChr+4Z8eI+nrKkqlLTix0s3JipDD7f/ZrDKbFly54BBQeTs+GYzKdWtFkUW4QxZV0uAaAHH2zXCLXpwbthVYi+tdEBkVMHMeWzThxjgW/qgbaL5UUdUL4aR0LpgY+KDGbiS9p7zQiaz5OShZmPhJuM2sablJ9jfXP/SshxLRONXSi/H3ozK7XkQYXJ0O+bv9Vh9SdRmz8u9bK2mzBoggX4nRrcH7CAt+xAJfsYiTCHoCfYO2qqOf36DuzZzdmpO3zv3iRxtQJlQIoFH0Y9Cm9i7bA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, 23 Apr 2025 17:01:46 -0700 Libo Chen wrote: > +++ b/include/trace/events/sched.h > @@ -745,6 +745,37 @@ TRACE_EVENT(sched_skip_vma_numa, > __entry->vm_end, > __print_symbolic(__entry->reason, NUMAB_SKIP_REASON)) > ); > + > +TRACE_EVENT(sched_skip_cpuset_numa, > + > + TP_PROTO(struct task_struct *tsk, nodemask_t *mem_allowed_ptr), > + > + TP_ARGS(tsk, mem_allowed_ptr), > + > + TP_STRUCT__entry( > + __array( char, comm, TASK_COMM_LEN ) > + __field( pid_t, pid ) > + __field( pid_t, tgid ) > + __field( pid_t, ngid ) > + __array( unsigned long, mem_allowed, BITS_TO_LONGS(MAX_NUMNODES)) > + ), > + > + TP_fast_assign( > + memcpy(__entry->comm, tsk->comm, TASK_COMM_LEN); > + __entry->pid = task_pid_nr(tsk); > + __entry->tgid = task_tgid_nr(tsk); > + __entry->ngid = task_numa_group_id(tsk); > + memcpy(__entry->mem_allowed, mem_allowed_ptr->bits, > + sizeof(__entry->mem_allowed)); Is mem_allowed->bits guaranteed to be the size of BITS_TO_LONGS(MAX_NUM_NODES) in size? If not, then memcpy will read beyond that size. -- Steve > + ), > + > + TP_printk("comm=%s pid=%d tgid=%d ngid=%d mem_nodes_allowed=%*pbl", > + __entry->comm, > + __entry->pid, > + __entry->tgid, > + __entry->ngid, > + MAX_NUMNODES, __entry->mem_allowed) > +);