From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 953FBC369CB for ; Wed, 23 Apr 2025 18:02:24 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F389C6B0008; Wed, 23 Apr 2025 14:02:22 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id EC2096B000A; Wed, 23 Apr 2025 14:02:22 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D139E6B000C; Wed, 23 Apr 2025 14:02:22 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id AD9156B0008 for ; Wed, 23 Apr 2025 14:02:22 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 3A2191419D8 for ; Wed, 23 Apr 2025 18:02:23 +0000 (UTC) X-FDA: 83366078166.05.414294E Received: from mail-qv1-f50.google.com (mail-qv1-f50.google.com [209.85.219.50]) by imf10.hostedemail.com (Postfix) with ESMTP id 3A127C0021 for ; Wed, 23 Apr 2025 18:02:21 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=ziepe.ca header.s=google header.b=g20gfhy5; dmarc=none; spf=pass (imf10.hostedemail.com: domain of jgg@ziepe.ca designates 209.85.219.50 as permitted sender) smtp.mailfrom=jgg@ziepe.ca ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1745431341; a=rsa-sha256; cv=none; b=pPfQsI29qfAAULxyhGgvZ+pdk60hN0sG7z27EdV8SzbQAJhw/2aQeikcGhbC8J4nYT+1OG dOloJkOq3RpuJZkRFbdbxcNNzn2TlxbhLWOq3i00W+2vIkGMfZZ/zeW7J3c73hzPHShq4W QL+2ch4x3+oVFidTC9q3ve5I9ZLEjjo= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=ziepe.ca header.s=google header.b=g20gfhy5; dmarc=none; spf=pass (imf10.hostedemail.com: domain of jgg@ziepe.ca designates 209.85.219.50 as permitted sender) smtp.mailfrom=jgg@ziepe.ca ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1745431341; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=v/H5CAwHQKAGhhgyjSbvaHcVayhHkcFdusJoJuYFxH8=; b=wLfyinwzC6uBYsdNGxavUnwPCETGdgFQs+WvmFvzV2wZvK3k1sMn8zsO8rgLFxcNFx1om3 Qwis4WUSDZTlWDeEWSVkn9jAp1X+ySPluD0HQKJpODflYNpOgc44gJXwhXURW7PT60LZuy Pf8ljsx5zYn0qrEwQZ/L73cMiELKKso= Received: by mail-qv1-f50.google.com with SMTP id 6a1803df08f44-6ecf99dd567so2240626d6.0 for ; Wed, 23 Apr 2025 11:02:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; t=1745431340; x=1746036140; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=v/H5CAwHQKAGhhgyjSbvaHcVayhHkcFdusJoJuYFxH8=; b=g20gfhy5ovL45YApEsRZsGPESQa7Mul+CzpZPRgye8WTnkPf1wmH25VIymc4e9xJFP b4A/QMmaOfLn8gVeqSCATgMxLw4iWHYzaoy2VlgAry1j41G9ikmlDCHfnGBgvit9nTFZ VHDgFtru1krGtBOW8YMBzX//3quwZA8hF7WJakgvWHzby6Uc3GptJinrFgdVYefd+WaX jxSD1udsxznH2+5ev4t9r/527Js04Dv4sYYQprtgAAy2ONYSWvM80QFbkJ75nl2zb3Nu fYOX8gnUVi6c6GSaKMVDHNsDu0nscd55e1YjChpZ7O5EQOb1ZXILfvVuqroJSclhg7lb aEHg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745431340; x=1746036140; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=v/H5CAwHQKAGhhgyjSbvaHcVayhHkcFdusJoJuYFxH8=; b=cM/Oz5RB12Pju7QhTsN5Fh2cSHr3XzODuJ8TRYRqJwyt6CUo0cWM8/M7HMD3x6bR/H rjWPzt6iUDqH+OcnSwjyJm9rvfcBdjaEilj52YRErrsgjI/U0YGyYwrifcNtV+8GqFw0 NYreyIMJqNBUbEwFzmlS1Q7DDf2rjE3jlsyBOokKmLbL9PE2ooFtm5cJ2/KXux/iv+D0 z62gJ8DscqIYqVAC0esJg+3Upy7QjgMBBm5DP0kSZn3v2dpSUNde+jxzJc7SvPtrcdzE wJMYnCXc6wG2Va6ukH1vSPae2VniuEDeYOf4atob2dGlovyXYkQqI+KTqrO6R0Duto8O xV/A== X-Forwarded-Encrypted: i=1; AJvYcCWTowUvnniIOURVAW9PVLcD/0pW65pYsPk+fHpKG1KpkC8miuUULDow5QEzGY8kWl1Jpi3sH1JuAQ==@kvack.org X-Gm-Message-State: AOJu0YxHAF1WxrCwqFI0OdDwvcsU55sQZVuJaBw37p2Yp1aLxN/69Lw4 8G4CACJ8CWVNf1h0/WE2hWYg7ZGpkil/TZUZGTgvx9l38kJIF/4iy2VcTyhusLc= X-Gm-Gg: ASbGncsxBMYia0+KIEqpAHi9/k9r/cp5dP27tw8W8H//QBodFd9klSNFGGqfgS5rOyD 7hUqYqFLtt1qh4uDY8gC0E8xl5Pi7nnRYTqBbsAIQOlrq+6VUvgWoPetnMII8mGM8zMcpIAQ+QE tuoOAmxfN2YuTm3h/rT2TKghjyHv8GhT5KNaF1HDiowc5Txo1DRhFxQRKjykKH3uBt9LpixNLZO x7aTB3+/8l3TzghYTUcvOLm42cChJ3T6brXLK4MYms00psMfTkxCf0zZwt2CNJBre4VSci/aKRW mPNb/vpRtJ2k8zXBCX6lEGz7pYK9IBcBnkcY0s1CiMz5/8oHvwLeWxMOyhdYunfAltm1IFp/+XJ MiuGQI5ZAzItyjknxkQs= X-Google-Smtp-Source: AGHT+IHxXzsMEe6MN5UQygppndiI4ddaFnTKWUy8FtozhFzNSVoZsB8f3DMDl3MfRyMHEIrbMun+Mw== X-Received: by 2002:a05:6214:19c8:b0:6ee:ba58:e099 with SMTP id 6a1803df08f44-6f2c454e522mr330593466d6.15.1745431340219; Wed, 23 Apr 2025 11:02:20 -0700 (PDT) Received: from ziepe.ca (hlfxns017vw-142-167-219-86.dhcp-dynamic.fibreop.ns.bellaliant.net. [142.167.219.86]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-6f2c2c3ba3fsm73300796d6.125.2025.04.23.11.02.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 23 Apr 2025 11:02:19 -0700 (PDT) Received: from jgg by wakko with local (Exim 4.97) (envelope-from ) id 1u7eQN-00000007LrM-0sGN; Wed, 23 Apr 2025 15:02:19 -0300 Date: Wed, 23 Apr 2025 15:02:19 -0300 From: Jason Gunthorpe To: Leon Romanovsky Cc: Marek Szyprowski , Jens Axboe , Christoph Hellwig , Keith Busch , Leon Romanovsky , Jake Edge , Jonathan Corbet , Zhu Yanjun , Robin Murphy , Joerg Roedel , Will Deacon , Sagi Grimberg , Bjorn Helgaas , Logan Gunthorpe , Yishai Hadas , Shameer Kolothum , Kevin Tian , Alex Williamson , =?utf-8?B?SsOpcsO0bWU=?= Glisse , Andrew Morton , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-block@vger.kernel.org, linux-rdma@vger.kernel.org, iommu@lists.linux.dev, linux-nvme@lists.infradead.org, linux-pci@vger.kernel.org, kvm@vger.kernel.org, linux-mm@kvack.org, Niklas Schnelle , Chuck Lever , Luis Chamberlain , Matthew Wilcox , Dan Williams , Kanchan Joshi , Chaitanya Kulkarni Subject: Re: [PATCH v9 16/24] vfio/mlx5: Rewrite create mkey flow to allow better code reuse Message-ID: <20250423180219.GR1213339@ziepe.ca> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: 3A127C0021 X-Stat-Signature: 348cwx5jpmmaz4mgd4gbzx7k9u9hsx3g X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1745431341-342348 X-HE-Meta: U2FsdGVkX18NpTzaldeJYpHNpaEW84iF5/9JM1AICnGx+B1T8yusjE4gNfP00ysiSsrhIRhqfDz7iokHD8mYnujZRdMYwxLaTTr/RG8Kpr4Obi1t5casrTLUi4AeTslfoRdAAmBSp0qIeXtOjZdiBW/8jBl+uSqKZ6fssLc/U37RwWip3TnJvHeUOssf9bN6hccqs3N/SiTXhP3JzfgIEyvuteHhXAxhn+RtAWs+4OW1tEA4fU+y4BRGf3946mji/m8XW+aL753YAsHpOLh8WKShhRnfVXqquUqJNjEtXj7O4EJTji/39hGKdltINZOe+XoNF62jTljptPeo01by/XpvJkY1xBaN0KPzzBTjwO2doBn5djpAWdbZtY9cgKczx1oIPFyEiPPYRD0RIPKa15exmFDT6RbS4QL8GIeZWAGfOHbQKXjI1BqGZAupRichn3UPPwFm0cypobyPebU8qgr1ngy6My9AkaeifRNEGct4xwmKoVcupz4wGSuojbceff77hsgx7PKPKAAhCDu4/WrVObbYvHzpEyIZqWafpHH3csd4xbSHI/tKTRfnZd6DzR5ej1JaAGkZ19LFoAt+I2jSK+P1pKwFbHfOF2svf+O7hn5dhI0/fQTvYhRizzb1o25N2MrD28+mvPhkgnstLJsCdDip8oaUV7qQWWk0g4wO4j955a/ldvI6cSDO0tlsxkB6pmrogOSDrt/0GFO0MURspZrDGked46InCVqp11ibc/g6BB3hkofQfRC/IfBNbyI85COPdGWGeFFplGPPEV9zBedIQMdoltCH2T4WOEWib6nvyJg7CRt9cDOkw33L6s3/2OOnoVCvoEJsbuz44BXUBwFgq2j0to2BgJo0aOvuelkpPf9B8tdg0Gu/HwyTHiGgnT3Gg1y6htkj5yK9BRBcDQTNc3C693m8jselY8pMioSxxXnBeTMdNt4KkFFSUZtKqt285+7mSgYZLiX vQNWiXvU IaX+vQHhHl3L8seyEdlXWDVXzVG51L/dTgVPXVm1qOKD3yHtP71iT/oYHGjBR44Glg4TEd139MudZCwpzKv9lWPeYA9uBkhQF0C5EHT0iUZZ516264VTdWYCfOuyr7POaZoE56RFPXiiJ2aS0WCMZed3L/raDsgtRpFxYHwZv6kof/jxmDYfYLZEfJ7qg0oTOtBAPYoFcXzJtoEmiPn4/kkImBQevFmfQT7I95s3aLy0hry1nL6CUAs8OxLdd50TtAVjoBCEQQFHUGcQlvIVeSZpy85ytjm1APyFcSk7LqaiLLP/XJESVRwB32w== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Apr 23, 2025 at 11:13:07AM +0300, Leon Romanovsky wrote: > From: Leon Romanovsky > > Change the creation of mkey to be performed in multiple steps: > data allocation, DMA setup and actual call to HW to create that mkey. > > In this new flow, the whole input to MKEY command is saved to eliminate > the need to keep array of pointers for DMA addresses for receive list > and in the future patches for send list too. > > In addition to memory size reduce and elimination of unnecessary data > movements to set MKEY input, the code is prepared for future reuse. > > Tested-by: Jens Axboe > Signed-off-by: Leon Romanovsky > --- > drivers/vfio/pci/mlx5/cmd.c | 157 ++++++++++++++++++++---------------- > drivers/vfio/pci/mlx5/cmd.h | 4 +- > 2 files changed, 91 insertions(+), 70 deletions(-) Reviewed-by: Jason Gunthorpe Jason