From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B56FFC369D1 for ; Wed, 23 Apr 2025 17:15:42 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AFC6E6B002B; Wed, 23 Apr 2025 13:15:40 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A82B86B0030; Wed, 23 Apr 2025 13:15:40 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8FB4A6B0032; Wed, 23 Apr 2025 13:15:40 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 6FC986B002B for ; Wed, 23 Apr 2025 13:15:40 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id B4926161687 for ; Wed, 23 Apr 2025 17:15:41 +0000 (UTC) X-FDA: 83365960482.30.4BE8128 Received: from mail-ua1-f52.google.com (mail-ua1-f52.google.com [209.85.222.52]) by imf29.hostedemail.com (Postfix) with ESMTP id C1628120014 for ; Wed, 23 Apr 2025 17:15:39 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=ziepe.ca header.s=google header.b=PriISzpL; spf=pass (imf29.hostedemail.com: domain of jgg@ziepe.ca designates 209.85.222.52 as permitted sender) smtp.mailfrom=jgg@ziepe.ca; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1745428539; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=sAA3ahIS+2Nb+9ARKVTXCSjk2uwR/TOFzjA5DEQnqxg=; b=vmhRYIpNX9hcovsg0PguVWEw28AU2chZMkb8b0t3kHaixM7J5GunW/mu85sBldpkgLTk3+ hdMSYQXMAuRObTTqG9iKfw1bmPPfYPhe1oGaTON4pMnDNpOonjiPZgQAuxpgleba5PGx20 LpPMnmOHFNj5yEQHccO8b1RzX2oS3JQ= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=ziepe.ca header.s=google header.b=PriISzpL; spf=pass (imf29.hostedemail.com: domain of jgg@ziepe.ca designates 209.85.222.52 as permitted sender) smtp.mailfrom=jgg@ziepe.ca; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1745428539; a=rsa-sha256; cv=none; b=mFxEAVRVENFSeZM2XNDXleF0hACzMs47sdcRfswxgV4i6Qh43boCwnBeoLSscItHYcgxiF qWMry2OJq/5r47k7YTYAuTy9WfHge3zrKc5WfPRzg1i/O+JE+o5jiyCE/bmHhOPv6SKyLo 9cJew3BCugYSKqvRf0sMTTubpupkA0M= Received: by mail-ua1-f52.google.com with SMTP id a1e0cc1a2514c-86b9d9b02cbso65648241.1 for ; Wed, 23 Apr 2025 10:15:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; t=1745428539; x=1746033339; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=sAA3ahIS+2Nb+9ARKVTXCSjk2uwR/TOFzjA5DEQnqxg=; b=PriISzpLkbH3t/3HWRu4RD4PWtXQ4NyHqlwrGke/U2NCH54XUApdHmBAm42LrfYMBV 2e28s4vDc/1nR4VZ5J/OOI2s14GWcACBE9BXj/0b4kvpuv5BiEylex701/1HqC8bvonW 0GCH8vbneOxuJpbDTzTT8jeC97zlYdYmbzGR0a8xb9XdTzTELezEP3Xne8NQUHxwHYXW mo2khq5RpoTHKwkmobVL8+koe7I9x2WL8r/fC9X8XtbJE+jtUuq3lJLLLItH6CyRaemz SqARpvOKzfGkGt4rwxUMTAYEddpXrdb1qS/jpRN1to7Y97c8ryAOG+JaD/tvQFiZnVNm r8xg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745428539; x=1746033339; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=sAA3ahIS+2Nb+9ARKVTXCSjk2uwR/TOFzjA5DEQnqxg=; b=LEDFlx5XIXx2w1aI7KDEkyOFc2V8L4IHwvAtV9GKq8bx0+Lh/sn4cEtu85jsqhcyn4 Df5aVLfEetSrqxDuc4SsorZOxglu6rTCaXhV6e+isS9htkNq8UFcv7NsrPhMtHgwl03c Ubaxo871nbJNjfuCqQw+JNp2eagB4WXgrxpwrTN8in7oaSGB5cadHxZR6dcjAljDzmv3 /Ipras/9UPqF9kYi9Yjw1gqj/jed6vQBXdao2YbwJ689lw7zSvBe4CiBuKUrutTgcwNf PTWnoWj+XMIN9sxIWj1q0Yv4LI2wnEtL+ZfT9I7+R4kERx8LNmZJboOS3cBTDcVkpCeC qGNg== X-Forwarded-Encrypted: i=1; AJvYcCXvi08ya46IE1YMWRw329d7OK+wrEaPo+E56K4RgjQqJGItL0wLXv44Mwe/md76hAkrT5IVO+EqMQ==@kvack.org X-Gm-Message-State: AOJu0YxRf0Wjishft3qtU1SU0nGY+h3BhptonAG7pDwISUr6gYJKZFdc pC917n10ySH6y7ySJe9EASjaa91JzCgNNne/Jik+sYvCdSUJJ2Hn/y6zXVKAT1Y= X-Gm-Gg: ASbGncu9yZxKbdrw3Z38NysafEUmVkEMo8bPAnQ8BILMChPkf980H29z/QrpcSXyi9g P4urhfTgUyGpd5RDDdyItDhFupKpkQlRlPjcwGUUYK4NtMdqLc87GuyW7Tc0sSbkFj//hfUri7T 51ZFtsEUcy+a7UawCm2cwWxUv1NhVANnDdB6uScwHai2BEGcsLrayLaGWFUJZy8nT2hv2Gu9PRi QfL00bKParq5VTlPrJAj4/A9a73X1aEKHMkcSQmiNKvjLx99F22Je2JqS4IT/vPBmmu5LGAomL6 U2/gnHe+ms8fRBvL5PHFl8NQiDFkKagH9GhpT7+TAo0he5E0NN0qsCi3GRVskXVcDD8qICrdGV+ +BkqsOXin/ACrx84co6NBhQehXcMTaw== X-Google-Smtp-Source: AGHT+IG91ka296h4XrJ4QPDo73jdYlZoOj1Zkc9PInMILwbVuqXEZMd5w4C/WgEttaatAxBubBvu3Q== X-Received: by 2002:a05:6122:3c54:b0:529:24f8:dbdd with SMTP id 71dfb90a1353d-529253da601mr17813854e0c.4.1745428538734; Wed, 23 Apr 2025 10:15:38 -0700 (PDT) Received: from ziepe.ca (hlfxns017vw-142-167-219-86.dhcp-dynamic.fibreop.ns.bellaliant.net. [142.167.219.86]) by smtp.gmail.com with ESMTPSA id 71dfb90a1353d-52a74d3a2d0sm79186e0c.40.2025.04.23.10.15.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 23 Apr 2025 10:15:38 -0700 (PDT) Received: from jgg by wakko with local (Exim 4.97) (envelope-from ) id 1u7dhB-00000007LQW-2UhV; Wed, 23 Apr 2025 14:15:37 -0300 Date: Wed, 23 Apr 2025 14:15:37 -0300 From: Jason Gunthorpe To: Leon Romanovsky Cc: Marek Szyprowski , Jens Axboe , Christoph Hellwig , Keith Busch , Jake Edge , Jonathan Corbet , Zhu Yanjun , Robin Murphy , Joerg Roedel , Will Deacon , Sagi Grimberg , Bjorn Helgaas , Logan Gunthorpe , Yishai Hadas , Shameer Kolothum , Kevin Tian , Alex Williamson , =?utf-8?B?SsOpcsO0bWU=?= Glisse , Andrew Morton , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-block@vger.kernel.org, linux-rdma@vger.kernel.org, iommu@lists.linux.dev, linux-nvme@lists.infradead.org, linux-pci@vger.kernel.org, kvm@vger.kernel.org, linux-mm@kvack.org, Niklas Schnelle , Chuck Lever , Luis Chamberlain , Matthew Wilcox , Dan Williams , Kanchan Joshi , Chaitanya Kulkarni , Leon Romanovsky Subject: Re: [PATCH v9 03/24] iommu: generalize the batched sync after map interface Message-ID: <20250423171537.GJ1213339@ziepe.ca> References: <2ce6a74ddf5e13a7fdb731984aa781a15f17749d.1745394536.git.leon@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2ce6a74ddf5e13a7fdb731984aa781a15f17749d.1745394536.git.leon@kernel.org> X-Rspam-User: X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: C1628120014 X-Stat-Signature: ugw5mxqxwb73wk3mtderjnyeyuwo1etj X-HE-Tag: 1745428539-957814 X-HE-Meta: U2FsdGVkX19lWM3vZAYcg/4RmkzXBaFhHi19/3TpvKlghhW/24fLt2gAzAElgnF1Z8jDXo0cvOXamgVHIoWsTWO00Ml6T9c+K/yYYMp+pPG7IvLIf3AyzL9CxcqeAq7T1Ocu/qmpLDNlO5egbMa3Q2ayHY/qHjO4AIitgwLnELwRC6gnA5ixLW/qPXoRP5UixXpN/sRZ1Fm5PeucyG3iTWNzovVdqOEyG/d00ggnqF4dRpRroN/D458tSoppqvCiab7TBjHyfOg4PugOFRVQ1gaFQ51PGiFMSpvR60aZHnwQoRaG/iF/Ua59IxqEkllvyXt7ymLiMpcji8lefBG0f++aOHNNVLH8vaAMQH/CVBIXVQIug4TCcuOUPD0DfVlwyBd82w4yqW4UQJaaitF1aH3iI5ZIPznN4lOzyHjcGvCzY46y9zM14aeyrDggowTX9A19vMgjcK+qGraKgtkJLmrHPdvJkBTRsxFPqv1IKP2an4BTqg5LN9tFGLZB/O26Ir3dN0JMdqGhyDDH1bnEuIx060UdiHU2jxuEy6eHYq708NrkpjlFy/0PyWqD3lPlzY61pYO8V+7m4ZnZEw3SmmdNugBeFfA36h3eV85NAXfgYg91OLcDYl3Y01f9DxlIvNhjCitdGc3dGDZKPNuQhvpFavzy0aKxVgbumB3P/ySBda2BJlcci6sBHG8TyvkUJ2kdoUxlvWOOe1SZoa+NB7A3RXMLsacd3laRwk4VeSxnveJd3y2T73cgXx+8uKO2OBhIOjHmgPgdD8cXevpeWPELQyVssukFol785O8MIZZIFaobuIs0PiNP/cHAHpvhWXMPeKKvkjvYF7Np0pH+AUrbcjHo5T8/ggM0JkPwMnnZM1XCo6ahPa+vH/0QN9h7G0vEazzZpfqntMZk2szPPuPuAlhyygH1gq8L7Qx6mo6cXp5FOQfPg9l3hcBkp07AFG6yxFMX09hdZ/GXhbk gRT9xYTp yih7AOAHtpnWG64EMoi7N1DPulXGw8mCCd95Jnq4wXOUn8mm9JnRnsYEpCITsUxMbU8CWBLr+wd5QRF1oHe0KaCvCBilGBCOKL0jvdBXGPurzp33aDey98K2HvxxR7iMVvLWS8LbEZF73vj9p52Akq5uxiQPeLUPwbI5AOCpQ87t7LjUkJmtrGfKXDX83GpUH77NMAy7cSIswRMqzK83Cxq1Ou2ESrSkvrHwcRqlmrsCdIr9s+sZ54C3ZCX6EIygNr3JW8j+yFkxNEM2jtEs7NoLCKH8ZCPehh0450DltzvJu8bjYUWFM51rpoA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Apr 23, 2025 at 11:12:54AM +0300, Leon Romanovsky wrote: > From: Christoph Hellwig > > For the upcoming IOVA-based DMA API we want to use the interface batch the > sync after mapping multiple entries from dma-iommu without having a > scatterlist. Grammer: For the upcoming IOVA-based DMA API we want to batch the ops->iotlb_sync_map() call after mapping multiple IOVAs from dma-iommu without having a scatterlist. Improve the API. Add a wrapper for the map_sync as iommu_sync_map() so that callers don't need to poke into the methods directly. Formalize __iommu_map() into iommu_map_nosync() which requires the caller to call iommu_sync_map() after all maps are completed. Refactor the existing sanity checks from all the different layers into iommu_map_nosync(). > drivers/iommu/iommu.c | 65 +++++++++++++++++++------------------------ > include/linux/iommu.h | 4 +++ > 2 files changed, 33 insertions(+), 36 deletions(-) Reviewed-by: Jason Gunthorpe > + /* Discourage passing strange GFP flags */ > + if (WARN_ON_ONCE(gfp & (__GFP_COMP | __GFP_DMA | __GFP_DMA32 | > + __GFP_HIGHMEM))) > + return -EINVAL; There is some kind of overlap with the new iommu_alloc_pages_node() here that does a similar check, nothing that can be addressed in this series but maybe a TBD for later.. Jason