From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DC34AC369CB for ; Wed, 23 Apr 2025 17:11:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4D8026B0029; Wed, 23 Apr 2025 13:11:16 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 485D66B002A; Wed, 23 Apr 2025 13:11:16 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 375436B002B; Wed, 23 Apr 2025 13:11:16 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 151B76B0029 for ; Wed, 23 Apr 2025 13:11:16 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id B96DF1A1638 for ; Wed, 23 Apr 2025 17:11:16 +0000 (UTC) X-FDA: 83365949352.30.D0195D8 Received: from tor.source.kernel.org (tor.source.kernel.org [172.105.4.254]) by imf06.hostedemail.com (Postfix) with ESMTP id 096D1180011 for ; Wed, 23 Apr 2025 17:11:14 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=WKE+8APY; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf06.hostedemail.com: domain of leon@kernel.org designates 172.105.4.254 as permitted sender) smtp.mailfrom=leon@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1745428275; a=rsa-sha256; cv=none; b=QgRR7W0+vbcOlhrKjAM9otammq7kIJZ2hO1VFT+/38hC5mqQegIzNSyYYGSFnLLiynSnNb 3AnSyy3AIbhQBKxCcRsejoK1Y9+hmmDaoSPOomHtFysY7/qs/aJCaC7rqXqKhwccvdhJyk y+30VjYbSKS4aJ/p2RWyVfcVajnWkhA= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=WKE+8APY; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf06.hostedemail.com: domain of leon@kernel.org designates 172.105.4.254 as permitted sender) smtp.mailfrom=leon@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1745428275; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=/UmQUzXQimpdcBViOB+BzZ6gQqQXWVIH2aIao+hu7NI=; b=xozakE2gXy6qpqq9BXEzJGS4Y4+z9nAhatzYxmB3d6Af330RhcQbJC2J/AzJazFv6Fq/tK BKn6JU6hbPyrgQuEdjjgF6zQYwEU7PsLtRdEunuM8SLDVklOujOftv1tCKIbwLdiC5FSNt q1bLWWnhuhSa7WuuvSQ01+5EoT4oJR0= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by tor.source.kernel.org (Postfix) with ESMTP id 097E06113B; Wed, 23 Apr 2025 17:10:53 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id EEA7BC4CEE2; Wed, 23 Apr 2025 17:11:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1745428273; bh=wm5GF1+5ZhFui3p0uI/jDDATw03CDOZZzdN2e7V0TSU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=WKE+8APYL7laFptOx5V5tlTW6vx8OhdD2WZd+VGxrXtV67FrKncs+kqu+pF5u2EGG UOokgA7a2oH+932TcBKZF7az+Ped9NzAHFBaGnehVleJXvWIBUCJeL1sQ2Qmw7D00x t3RQhR9MeIT9X6K4x10h4rIx8fAT5Xzfh4DWU3ruajS1BQDApG5h93OllIWbkN2aId wdKj+YjyrKbqPlk1S3NqyKmfDMZw+PqaheehQ4VEM2e62rg2kfh4ZmgP8NXJJpagND oUgY6vbnwDC/BH3tlAmiFa7bG+aa9E3K6tCMbaiT1v0F8o94QDy3SA0813/IgeDR3G KIYJwJTivuM1w== Date: Wed, 23 Apr 2025 20:11:08 +0300 From: Leon Romanovsky To: Keith Busch Cc: Marek Szyprowski , Jens Axboe , Christoph Hellwig , Jake Edge , Jonathan Corbet , Jason Gunthorpe , Zhu Yanjun , Robin Murphy , Joerg Roedel , Will Deacon , Sagi Grimberg , Bjorn Helgaas , Logan Gunthorpe , Yishai Hadas , Shameer Kolothum , Kevin Tian , Alex Williamson , =?iso-8859-1?B?Suly9G1l?= Glisse , Andrew Morton , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-block@vger.kernel.org, linux-rdma@vger.kernel.org, iommu@lists.linux.dev, linux-nvme@lists.infradead.org, linux-pci@vger.kernel.org, kvm@vger.kernel.org, linux-mm@kvack.org, Niklas Schnelle , Chuck Lever , Luis Chamberlain , Matthew Wilcox , Dan Williams , Kanchan Joshi , Chaitanya Kulkarni , Nitesh Shetty Subject: Re: [PATCH v9 23/24] nvme-pci: convert to blk_rq_dma_map Message-ID: <20250423171108.GK48485@unreal> References: <7c5c5267cba2c03f6650444d4879ba0d13004584.1745394536.git.leon@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 096D1180011 X-Stat-Signature: 3afcwp58gjxt9ops7ebeoxnqduzt4eg5 X-HE-Tag: 1745428274-249656 X-HE-Meta: U2FsdGVkX18bheyhaaAqaUSVW6G3n4uoKIuxryyQdiuNk656E1Vg+srWiV9ROIGYeETewMkbjITaXDa7FtFU8mWD+ik4kTNMj0XUdXeiWFY2XTI89wrF03oSc+hTZ4NlpEl+1nIcLAwnmursUCpuMGb/kzhCp6QvgEk29dlP0v/iHW4ImANluEvGU2zEXVYqMMolgRRXRSwtV5cWbh4kscqjP1nnnG/VWzF+sjHy//rS0mYcqJMB+2lEZMEPu3voW8Dx2m6SRk499gC6H3UUso9MlNiA3wHh4eW2I6vzU4d7Yg0G+YXpOfHCqjnpOWkPShZMOYx1BP2ZjZIODjLzNuqn6g4QMbHGPqnCPRkMgaVszS+q8JIIbyH6N4s32CtkGRNHvYVu3FAB0dE6khCkwrWa/jVKOUHUjkJMxmkKCjwYVV0tso04p2Id8Bz48GruMnEjnVPOm0Cu+2tJWEybyC7fPliYA2+z02LRYZYLjE0o8MMM6FZ9OMni5u4sO4Zb1SPJCpr0OH2onsg3nJ6XGvW8ZqKkXPt1MGzUoe05O3nquQKr9VoGEQqzgCwnCvbGeyTKCV5NPrAIt1eeCr5KHGhMk6+ZRP+ahY0QKw1eefO5ykvz4AQLm4W9dBL3kgmK1udJ/IBJkWFtONXw4PV82IFWUdV4GVN0hchAlK1+ESUh3WgwQCyoDgYLrSR/qOPpTa+s5IJJ1oMKXV9cEUNcLSCTfk9evrhOKpHi0vZ2k7GyQYD8R6cTriauf6dkpDI3XN9PiznRse4yAhQ/mVL+pkqiLFqjinHD/Bw1MAgATUJfwyNimHBhBYAFhtMZ0cXgUCm8b3hvaWkorOmo7UhY/foNRPQf6kJYxW8ARZiOFg+LUiHf9EKp48kK13617I5dNT2qGNlYIKH65Q8ZOvXlJIz/AXJxciE4jQ0SgXdFJFw8cwGJDPGzxtEaCxPl/+cAaiHSje7EdQgHXAQHEWr Wd/fcQiK Wss1TcW+xcnsllS8me/vCSV9MP5MisZWhoHnQ62BC+wE7bhaE3dWLHdz/44Bi7W5WeSj5fUd00BG0OWSDGnIgMKUppafEGngfiaTvByoAnJ4ifuijd0wO94Z1Yxi446//DuCvjPXFOv6rplY20mUkanNvjis3xCoH5O7q+uj8yp6hSuVNJv3dl28oHL4CmgGBTkpinUBmFsSDb1wFZRQa5texyzfsDZqC9aZVFdtPYwFHqjSnfcEklKaNbXCjt2o3JRamBeFCbzg0sY9PAKWtdUMxrA5ZrKyvXEdQ81mHUa6oE0A= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Apr 23, 2025 at 08:58:51AM -0600, Keith Busch wrote: > On Wed, Apr 23, 2025 at 11:13:14AM +0300, Leon Romanovsky wrote: > > +static bool nvme_try_setup_sgl_simple(struct nvme_dev *dev, struct request *req, > > + struct nvme_rw_command *cmnd, > > + struct blk_dma_iter *iter) > > +{ > > + struct nvme_iod *iod = blk_mq_rq_to_pdu(req); > > + struct bio_vec bv = req_bvec(req); > > + > > + if (IS_ENABLED(CONFIG_PCI_P2PDMA) && (req->cmd_flags & REQ_P2PDMA)) > > + return false; > > + > > + if ((bv.bv_offset & (NVME_CTRL_PAGE_SIZE - 1)) + bv.bv_len > > > + NVME_CTRL_PAGE_SIZE * 2) > > + return false; > > We don't need this check for SGLs. If we have a single segment, we can > put it in a single SG element no matter how large it is. Absolutely, removed it and updated my dma-split-wip branch. Thanks