From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 09FB3C369D1 for ; Wed, 23 Apr 2025 15:28:11 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 288566B009A; Wed, 23 Apr 2025 11:28:10 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2379D6B009B; Wed, 23 Apr 2025 11:28:10 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 131426B009D; Wed, 23 Apr 2025 11:28:10 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id EAC476B009A for ; Wed, 23 Apr 2025 11:28:09 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id B74BE1A0F1A for ; Wed, 23 Apr 2025 15:28:10 +0000 (UTC) X-FDA: 83365689540.10.ACCE2B2 Received: from mail-yw1-f173.google.com (mail-yw1-f173.google.com [209.85.128.173]) by imf22.hostedemail.com (Postfix) with ESMTP id D8F5BC0002 for ; Wed, 23 Apr 2025 15:28:08 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=WoG3J0xQ; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf22.hostedemail.com: domain of joshua.hahnjy@gmail.com designates 209.85.128.173 as permitted sender) smtp.mailfrom=joshua.hahnjy@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1745422088; a=rsa-sha256; cv=none; b=AP6E/hTCufKS0g+uuL2mylAc+m2QGqDA5+/h42pclaQ8lwQltZlqsf8MDW0G/xWHYBcN/a U24T/gkQjZ+jvBmYA3JRxtDYxYi6JFA6qvZZVvH1S6EcepDWu1UhyWmH9451kKsR56gTN/ MwqJjx/Lk/1S+7onuubUzGn8jdEtqWE= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=WoG3J0xQ; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf22.hostedemail.com: domain of joshua.hahnjy@gmail.com designates 209.85.128.173 as permitted sender) smtp.mailfrom=joshua.hahnjy@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1745422088; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=fHVRbngq1O+ZmgUJJIDpKFCMr5eVrxZ3pEePFAGCAnc=; b=qY4evCBHO43smPw88CK1YCQFwmAgj2mLLmZu7jwLd4zNC5QY913tUhJ2uNGlwhE3rV0+XZ AL7OCGZdnEnFJ/HmzerUHYSXMmVyXJ40/pGXpJQbFu+eAecl3q6ZRq+avJojcMzIOtVxvA XRPLLm32bkTcVMhq/RnEau/Jjt+zu2k= Received: by mail-yw1-f173.google.com with SMTP id 00721157ae682-7082e46880eso504157b3.1 for ; Wed, 23 Apr 2025 08:28:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1745422088; x=1746026888; darn=kvack.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=fHVRbngq1O+ZmgUJJIDpKFCMr5eVrxZ3pEePFAGCAnc=; b=WoG3J0xQhl6jZjR8c69GaukllnFHtDvjAje1XJ7sENJc3kW/xAKgQEleu+uMOyYdBh E0DYVLg0YCKOOc8AvcfpG51VxD7E3eFZOimSa67wZ07NH+7rElL+vSOiGFC/Gr3yDCsp WpJ5Ta/nQYCuEBPaIVDTSjxd4J7KZlZoGW9qLICbfUzeMqYezah+CHgPcSRkPsWHSqlV zM91f7FJUZx4a1yWF8hs4br2DYgckFy1GmaRQHZJEFJaw5Eg6Z1+UBeTdxMJy61fMMgT E7mgPONOJCAGHSbC6u71KqpWFx2NZpXUU/eZzj9V93HB/pT58EjkN0HWg9uhc/NMlB9g q92g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745422088; x=1746026888; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=fHVRbngq1O+ZmgUJJIDpKFCMr5eVrxZ3pEePFAGCAnc=; b=rA/Wz5run4LTIaMefJkqvUi3PuD8TfWejtqauvpoRGyHqNKBlVrBze+HzBFtonVHsW pYPv3iH/OwwYCtG8DZ8b4Rgxf2lYyamAsTdYYrb5vfQ1w19Sjx6q+I4op8CUHsQ5Sc7s V6AeTUG++vRzI1xnGH5ynJW2J8y0uvSrHCmnqkBhqvBdU93S8fugbiLUV718WNbhHpGG a0buYpAaHESRB+lGyBOzmGaLJoCp3w5YjUWB5XcXDW/aZn+G0a7ZyMYXAb2OZfU9Ua9j N4Rl0KdesOv7sG8kd8WIw0wIVYj565s5eXyq2CFnO9FMbharXhDcTR81cWtYfghIZP3t R4UA== X-Forwarded-Encrypted: i=1; AJvYcCVAm5nRLSr1vzTWWFSO7ojxgo3Z3twd9CHdKWGpFOOVqGYPiErrD+PIZIDjfGUHB9MbhgsOgOfwUg==@kvack.org X-Gm-Message-State: AOJu0YyjoJwLRKZw50wj/fJHOuzkax/WY22stozDX0U1FjQ5EfatWjdp by0UD93b0OOayI7T6sGflzepOLa5JGS21slDCAr8xtHPfti+7etD X-Gm-Gg: ASbGncsoOz6WavC+Ga34dsJqOo3nt9PmX9u+bj4bL3HIzMq1sVmxZ7pou6NK/NeCckp 8BPBrrCrkyFyHi2FDT33VwCQxX4QJ7iAyP4Gcb1YLRuESsOYucSGTGsywL3bpO8S9/Lrqf/v4AJ 97pk/Nh+8M+a5tdwMS3SlC1BCY3huGzXRRTH+5qih5NMRFfTz21eikvVQyxQKvf3wqZ4LMcvmD1 JPxT7UzAcifmrd2TIVUKPgz4CIqiYUVKtmeY2DKiSsShjHq2UmS0chs7ALqmiM2TZw35jmSXu/K Y6UwH5k47KLbDSTnq2g2hHzaUGayKayVQHeTfp0+G1b6teRJ9Q== X-Google-Smtp-Source: AGHT+IHISuZsHHkHKpHC5vi+J56ww4pcJQDqy9fckV8l4A2hgMFtaimgTTejY0prWaIIVPx/6Hrefg== X-Received: by 2002:a05:690c:9:b0:705:750d:c359 with SMTP id 00721157ae682-7083c0025d3mr1114097b3.32.1745422087718; Wed, 23 Apr 2025 08:28:07 -0700 (PDT) Received: from localhost ([2a03:2880:25ff:1::]) by smtp.gmail.com with ESMTPSA id 00721157ae682-706ca53be7dsm30065797b3.84.2025.04.23.08.28.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 23 Apr 2025 08:28:07 -0700 (PDT) From: Joshua Hahn To: Dan Carpenter Cc: Rakie Kim , Andrew Morton , Honggyu Kim , Dan Williams , Gregory Price , linux-mm@kvack.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH next] mm/mempolicy: Fix error code in sysfs_wi_node_add() Date: Wed, 23 Apr 2025 08:27:33 -0700 Message-ID: <20250423152805.3356081-1-joshua.hahnjy@gmail.com> X-Mailer: git-send-email 2.47.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: D8F5BC0002 X-Stat-Signature: dcc85dkwf56aym91e5xdr1fbka4xprxt X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1745422088-904146 X-HE-Meta: U2FsdGVkX19BpGVXOiXZKZsONl/ESh8AEKvOplNFiYQJYYAVEgIcpKmou0imJAvffGi/E/Mr6DmqhnpSbaqXTMIPfKWZzyXcmklUza7Up3/pYXQKik0Qn2F36sXBAnsC0CsrXKU7pLj8Pol1a39gH2ZMB4a2OGYwrDO+fQ8U8dF4cBtn07kVh2ao4GwxjNFOpZn7Z4+ts8EV4Zw8WPPus/JUUMfMxsHe0wNNN/R2VynrYPPTdVHuYI/58sty39N6+Q3bH0dH9soYgMiJ2mGCpluWqBypB9QTB/r7FAi1/gHtvCsiM0M/SFtmfInVyCWSFakZelGBm5OliQ6NyH7LwVGhwpxf8ifZRgvS6L4Y4DEZ6HFSzlQe3f5s2m+WUxIpU6wCnbXcDo+rhwtkApDs8Bf17i/6W2bk0UBYRXlu/ZoalIsT8XPkJNxtgP7GG3WAVscJENvrJqJ90QJAcc0e9cISy0RJj5X4uzLQ96ff3c5UVP2WH1FiKNmgMMXLWTVMoZIFmeZOHw86r7ta9ghaTg1qyQZp8c6hjEdS9j28FDO5lQdYTmQoG9JM/bdYzAP4KAc0jLb0ie24oaGrlWYxTkA//yCHStJyRMIxXXYh953QEFzOTx9ZU8ErvIUe7hSXNhCpCe57Rr24QV2KdHEC3kZO9F/S15BBHGSoGawfw3P7MqQD6wmCYi1l297XVTKrw3aev1lrjGZ4iQz7cAQm2QmtBsH0RUaxpfyQYvbAryZBwt4wlPo1oUGYIi5tnho+DYFVf3xV2SX9g6bIWr+yARnLMXia8gx4niEaN38XK6kVJ+dXct95h5pWg/HH5UtlrK9nMI2eLftifv6pb5FfFo3IlXZH86/vNXulq0l49Iu0Dz0Y7HyKTdBjppJvPD9ZEJc/ml/c7VAbxvZQxD5nd8Lvyg2ge7b3ngswM2+CQor6+W0CtNOF7Nqt3OnDipCW6xhB3pomDGESdVEsT+E X0RSLL5G 16Q1ggnS5sNKGAwZ7bl7g+H2Qs90/iFgE51E5H+1HNTh5dYhBqsEz8qBlcwqU+EBZtKC5gKFgzjkDo3+UMP38vIqY+aypZ7PseWhBIl2U1JU7P9PMmzZ3GF2MybAYt7dLAF6IR/J73pdOuMupn4f8sBRKZ1kRtOeSs7cWBDaI7eiRpbDGZBBF4PUC6PTKKj68jxua+8QMEUSdH4gveycuCXXdRCxYhMpp+kSmlhqDNkFZT7YIv6fToEIadueV7I8NtnVfhoGePUvSgnY6ciddNdn2MiXSunbw1pFXGXAsoQNcD3ptkUUZKqCF5j+7NaVsT7kEncdYlj9i3Lmml1788QhIDgGFB4NTXKT+RxyEoc0kY5gaAWINZJFft/nNeWwdJYLvS8efsBe2ohC8YCSQZJ+hSzldXygfXnVBTDfvw0BQaSWcGnMVek9+71tJM3cPp7lKQFMN4v5pJibMO1SCpEh3s2N1+dfLb8BZrEYqjXXv+f1p4K62rpXlNxfZ0pqxZEVH/JVFi/yGoztvn3skFKAszVGwQWX+d/J7qIgR9QBRj3OIGZn7LwSp3dmHhnpnfWKf X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, 23 Apr 2025 11:24:58 +0300 Dan Carpenter wrote: Hi Dan, This makes sense to me! I think that the only way the node can already exist is if an offlining node didn't properly clean up its sysfs entry, which is a bug, of course. With that said, I don't think the previous state would have caused any functional problems, since the same node offlining and onlining should share the same sysfs entry anyways (unless I'm overlooking something important...) This fix will help when the cleanup does fail though, and I think that will help us assess whether a failed cleanup does indeed cause other problems. Thank you for spotting this & fixing it! I hope you have a great day : -) Reviewed-by: Joshua Hahn > Return -EEXIST if the node already exists. Don't return success. > > Fixes: 1bf270ac1b0a ("mm/mempolicy: support memory hotplug in weighted interleave") > Signed-off-by: Dan Carpenter > --- > Potentially returning success was intentional? This is from static > analysis and I can't be totally sure. > > mm/mempolicy.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/mm/mempolicy.c b/mm/mempolicy.c > index f43951668c41..0538a994440a 100644 > --- a/mm/mempolicy.c > +++ b/mm/mempolicy.c > @@ -3539,7 +3539,7 @@ static const struct kobj_type wi_ktype = { > > static int sysfs_wi_node_add(int nid) > { > - int ret = 0; > + int ret; > char *name; > struct iw_node_attr *new_attr; > > @@ -3569,6 +3569,7 @@ static int sysfs_wi_node_add(int nid) > if (wi_group->nattrs[nid]) { > mutex_unlock(&wi_group->kobj_lock); > pr_info("node%d already exists\n", nid); > + ret = -EEXIST; > goto out; > } > > -- > 2.47.2