From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4CCBCC369D5 for ; Wed, 23 Apr 2025 22:17:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4BB926B000E; Wed, 23 Apr 2025 18:17:45 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 46BE36B0010; Wed, 23 Apr 2025 18:17:45 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 35CA56B0011; Wed, 23 Apr 2025 18:17:45 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 156006B000E for ; Wed, 23 Apr 2025 18:17:45 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 2FB0C1A05D8 for ; Wed, 23 Apr 2025 22:17:45 +0000 (UTC) X-FDA: 83366721690.05.203BB24 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf30.hostedemail.com (Postfix) with ESMTP id 6B1658000B for ; Wed, 23 Apr 2025 22:17:43 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=BVhv2Xpm; spf=pass (imf30.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1745446663; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=mEVXeblS9zEPRr8U2NzTV8y5vFoaPpxEVn0lluM0wdk=; b=y2KFgFjr0psygHtYHcztyk4wJNKC4ZvX9MAEo/XDMwtcdk9K1HB+OCD0yiWS82W+ceqrJI AgGzNreqIWieaqn5W99WX152f3yzhT6LUlG8qhyjXlLVfbaQPOhgMcxiXoN/z/S0fIN90a M/cd9DwZWkn6dH5SvvtG0qN3f5HTenA= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=BVhv2Xpm; spf=pass (imf30.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1745446663; a=rsa-sha256; cv=none; b=0aah83+X5qmPwDZ2l2WG7bRETpJRpFT+77ItzjlxUJf6ErCRzRCdFarMTo2Q5NMp2FZaja iGf3Ig9snKbk3gOMlOLN2B097/mHc9t/WnnfwkFtYrhvahXbI71UQqnn4YMZ1PKvnuCvjz +xkRkS06Ddw9ysFGTxv8HmTNdMr3XbU= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 700235C55BD; Wed, 23 Apr 2025 22:15:25 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id CEEF8C4CEE2; Wed, 23 Apr 2025 22:17:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1745446662; bh=fxnFhetLKP5DZZg2Quis/n5S9PjPI9uSZ2lT/VmQBjE=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=BVhv2Xpmd6NcHhIwHCIWy74SiDi7zcF7tG9y2mRHhTqT1GZIatIolIa5ZDgCjqovu w0idS03QdFftBZb2jZAd7v1Jnu5PItpNUzYM2knF9xR3FnnHoyGPR5OCMYzVxlD1IQ EuUeOmYL0dYv30Jsx5h19KvAmAIhoSHK4rw2pZe8= Date: Wed, 23 Apr 2025 15:17:41 -0700 From: Andrew Morton To: Matthew Wilcox Cc: nifan.cxl@gmail.com, muchun.song@linux.dev, mcgrof@kernel.org, a.manzanares@samsung.com, dave@stgolabs.net, david@redhat.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Fan Ni Subject: Re: [PATCH v2 4/4] mm/hugetlb: Convert use of struct page to folio in __unmap_hugepage_range() Message-Id: <20250423151741.7e27a94abfc3b41bb659a6b2@linux-foundation.org> In-Reply-To: References: <20250418170834.248318-2-nifan.cxl@gmail.com> <20250418170834.248318-5-nifan.cxl@gmail.com> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Stat-Signature: yzcepfp813f8qsa751m8ydzuipmx5nws X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 6B1658000B X-Rspam-User: X-HE-Tag: 1745446663-442306 X-HE-Meta: U2FsdGVkX19+xPurWYwg2pGxvzjAsTxlRvkJ685pEUc2cExwAAxX7LDWIE/Au53B8DhEPh5oU/UtwlJentaashWX2Hhg4IS232cg1+ymTLAdcWJgV//FPhrxd5yQ03sZhlXozLD2q82cM3five0OUwb182PUWCiqTddaBM+WZQ/brT+Dh0aToAsvPkahTKRZ411c2pCi4iX2heVrip0q+P/jnr3IWFaNHcpRdjsgYXQQxN5I61bUOVqDMqdAcylHnmcXpLfQs5TYmYiCykRB2lEnZmv7ssHGTIjaRkgTT7fprvyPU55MDUYihPM8Dlxoy94T0t1M5zC71FXAL4fVAkuIXHlOQKifZoUPBdd33QioJzAJh6Pge71cFqLPFXeC2slvg6DwQpUoeF7Edh8kypP3r84qUBAzSqcdftAV0ko0x+E2qJ+yJ3vLWWn4aYoy9p48cytQ9VPiNnf/3LXp7umoFOsiG3Xfpr2NtCSUhr4s6GiL7XE7D77OcEjtsOL+1GnEqiHVMl1nfQkzuTf5IALBkBjgVoQRlI+MUTWom4x9Z8FYp1Z71JxqmfS8g7Qn4tNXEsgriKfJ/8PqQk/QDvHSzQGuoq3EGQdaFaJHQ0emPZQcNf7hA2lVy6e4Bib3puzMX/evamkDKeYy0VbqHO9EakVlvILkWLpR5iU+GGawM1om22LL+MqdlW+xOnR0AUPN9Avvn4hkMZxalVhKxnvmdwYr9uUsjND0bCGXJoT3zLFn3gOkY1430bXZqPiazDCNVRMKQMNkLUPEW/+mGjCSFMpWma95Z90OT6dtP+aaIUaHtLqB+XSkoLTQl4noBNZz+ieCNxQjdpWpoK1fnKLedtrBG1+P15QqRlW+7w8y2WKxliFb/LNHrp1o3a/TLAG81aurqFScYZ6NoaVGEfc5HUNX5/skbF2V3EVMyqfKcyTOmO7ChI6JmEuOelhNT8TQxZ7R1M35DZkAhVX YAJ2+Fuo Ke9HBkKkP16W4q6i4HXj/q8wtWyGNMQrd7KLy9C3Z7jj/oXqtKjd5qrSbPthmppxSDB4gjwFobU7kyvkINe8LDWQqg4Phf7swqFM2on7mgmr0MWrinr8MWD1IwCBbwzU/khkWNHwf8bzUSYQpkwFgb/zkMj2emJ7duD/V1FYnGbEHyJfdeJddcQZCsu0IdafcbY5mEd+j804NRLsk3jkKJB7opki5HaNpvXmArBPeqgKRwVOw2d/5SFxJUnoA+BALHaOCsMuIekolaNujXpsz44U601LF7IMgJVD0+vCvo+qL+4T0bJZOUElTKS26XERwelU4EmQMHUoevOXZfStZ/CYeZY6opg5pbnNKpeWHby76ZEEz3fCklD7snqOnM5y+AZefpFHneY7N4vrzAGN+kAzAthTCQar65buJCHuQ5F149mtCuX5nfnR0Y7tEQwlSojmVdpIroQlDRAA= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, 23 Apr 2025 04:22:42 +0100 Matthew Wilcox wrote: > On Fri, Apr 18, 2025 at 09:57:42AM -0700, nifan.cxl@gmail.com wrote: > > > > - tlb_remove_page_size(tlb, page, huge_page_size(h)); > > + tlb_remove_page_size(tlb, folio_page(folio, 0), huge_page_size(h)); > > Surely this should be: > tlb_remove_page_size(tlb, folio_page(folio, 0), folio_size(folio)); Thanks, I removed this version of the series from mm.git's mm-new branch.