From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3D6EEC369CB for ; Wed, 23 Apr 2025 14:56:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5673C6B0029; Wed, 23 Apr 2025 10:56:30 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 513816B002A; Wed, 23 Apr 2025 10:56:30 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3DB3B6B002D; Wed, 23 Apr 2025 10:56:30 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 1EBCC6B0029 for ; Wed, 23 Apr 2025 10:56:30 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id F0076160CEC for ; Wed, 23 Apr 2025 14:56:31 +0000 (UTC) X-FDA: 83365609782.11.BDC95E8 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf13.hostedemail.com (Postfix) with ESMTP id ADD4320017 for ; Wed, 23 Apr 2025 14:56:29 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b="vlh/zY2d"; dmarc=none; spf=none (imf13.hostedemail.com: domain of peterz@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=peterz@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1745420190; a=rsa-sha256; cv=none; b=7Bq89MKd9BC0sZi5hGNQnLwjeaIhjRBP52soPJ+M4wnvy6Z2+0w28gPEr/t6dUf35nf2Xr HslCdbDeEBw3gNDi22mCBjQIaNnxj8nekFmdtPn5jgf21YWtIPbCdG1Q7VsgZ7puIv92wD 8G+3suIrKKrC0CdREDeA+t+Nb3zkvaA= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b="vlh/zY2d"; dmarc=none; spf=none (imf13.hostedemail.com: domain of peterz@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=peterz@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1745420190; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=KB3stQEU0X68w2K3nnkTU+yNBGBekbZ+9b4b8qjTO1A=; b=YRDGDAyX9waXhyklqUSw8bgBXAHJ1sDXUcIAnxEEb29Zh4Cu5ULwJbHrAFZIdVtIzKpUN7 Ars2ZGYrHd1Blrd2xQw8kqhiYwJilNOTfx4ImZqRUClJ7tQrSNUcBdJEbxwRJvFr4z4Rp8 mS45/JVCXfcHwPlGKqZr+idPmMfaNfw= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=KB3stQEU0X68w2K3nnkTU+yNBGBekbZ+9b4b8qjTO1A=; b=vlh/zY2dHksVCqDFG+oESk1l+7 n/3x+lhL8WJS1v+CgY6bbDppE5FiLckGMfUk+zElPlbdDF8Keg469d1izaAfRTZnWTQo2CpHDunHv nPxnMnL427TyenXKqYBI39mAYVnEkez6mXEAGfSFU2OQQ3t6yVnF17jKOBLAN+8DQfLLPR2jB+jBS bzJfNpzGNGVM+5Hsz+O5YLlSFhTE8e9vxUo7BsRGgkflLhbmwOa+cVy6H64g/S+nouk/foyf0gUgn 8XPMlx53lLEoQBRa/+/eEqiCAH6AKEL70Is3cx6Ish//ck1U81neVDFYiYBezASKJ0KYuuwEzr9xM qVJbTUzA==; Received: from 77-249-17-252.cable.dynamic.v4.ziggo.nl ([77.249.17.252] helo=noisy.programming.kicks-ass.net) by casper.infradead.org with esmtpsa (Exim 4.98.2 #2 (Red Hat Linux)) id 1u7bWT-00000009OaK-3ndy; Wed, 23 Apr 2025 14:56:25 +0000 Received: by noisy.programming.kicks-ass.net (Postfix, from userid 1000) id 26EDD30057E; Wed, 23 Apr 2025 16:56:25 +0200 (CEST) Date: Wed, 23 Apr 2025 16:56:25 +0200 From: Peter Zijlstra To: Mike Rapoport Cc: Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] execmem: enforce allocation size aligment to PAGE_SIZE Message-ID: <20250423145625.GF40412@noisy.programming.kicks-ass.net> References: <20250423144808.1619863-1-rppt@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250423144808.1619863-1-rppt@kernel.org> X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: ADD4320017 X-Stat-Signature: c8edwq8meqd6c9p1kknphxj9sqpbne99 X-Rspam-User: X-HE-Tag: 1745420189-808842 X-HE-Meta: U2FsdGVkX183oXoJHsV5cNRZIjBuXkFUtJGvIcwEK5GY709UeT/e/tpfY/2lhGnZyA/MNTvXENMDBBM2niYja8dWhP0qPU45iFX40hAk8xBFAOEg2FgMXeeNfaUHpjK1Q5XtUpScYoybEF3q/06hSoCu3gMUGMFh7DAUvusBx3lwTEWMY+OfYtOoSK3C9JiT+55IuKLKaMIoSSRDJSl6uIG956lhq0XalgthoN2lRylia8/y3lRmnse2BOZQLJml6+HfpI2x1a9pvgqYqnf5bj7Vmw4nLlOOO+uGZcLr440+aHdjlIXHfrKSL+tuaaJFm6KkgZzAVA2znWRwoFNvoV9VEXD8jzwDW9clcJNax86Nts+DyD+lHd66KD5jKg4bQksHDGKuKIa9qJbSrxkTF0tt8FDtrWn/c6ESqVQn0ihfapI7PD9PWzzsYX4R6o4hs0DAzt6G9Yay2qPC9yajBXi4WH2XMQg0I5uTi9Q3A/PwT/anXAPKExAG6URt0rRIgFMLcMLoYfU3luCBaBUEq3EpfUenK3Fj2Ovm3Q43g2k2FnOVYejpO+VIFkXNujpM496LxaIbp9NHbSMJJ0myDKBQxDU6ccYZ8LntPGOGg3XtEIoVzXzYMqr3ouXOl4afMcFmuNuU12mb+zuJjIzSskXtmq891kXGHfV6m2igWKYO7rOfSZv+7IP33TbjcQHhs3Tf91F2RGVX3nQrKULz3fFAE11u6HpuRQBtAQdj4bQqVuVrrEVM4Xrkzf/cDikxmZq0jurangvw27+0H10MYfXOyMDWq1LD+3UMCxxJNGv4+JGz7bFC2MxA3PReMeNWyUGq5XRbLrJEnb74QRtFSMgpi0XX0z1wkoEr8QyQcEGr4/IdKlcI7aFyq71MqoZVNS+eRb3eIKG+7G1ba5gHdmW5DqLBeyLEtV+6DDw5LBWvQAhoJOpsVdOj21OXISNDItqSO2p0xs1ECvvhZCP XN/z50QF y5160mdi75yUvn5+aFG9OV4tpWAlQsp/8GonSEam9kzH7Xflg9aZpENUnjtJFOUg0VR5F55r/SJtAAwYpj6MynqqHV50bPmvKf6bdVYbGc15DMo/jOG4Gr0iAEwbarKu6fJhwH88YT2kIz3Mth8o4Jf2jhYrDbuzsFcZ8k+d+DNSmn4CPv13VIOlrcn3jinjpWBU8fnOLYuwp6piGrTaYRRXUsfSC7VXAinv01CBNDwx6+h8bS5RImPmPWlvPg0iR5eE4mYUvlRrH89NMT4lNRP8/QzsqufTnkqHfEKOapHhAnSqYAKZQmiLb7LF4yqiF/etG X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Apr 23, 2025 at 05:48:07PM +0300, Mike Rapoport wrote: > From: "Mike Rapoport (Microsoft)" > > Before introduction of ROX cache execmem allocation size was always > implicitly aligned to PAGE_SIZE inside vmalloc. > > However, when allocation happens from the ROX cache, this is not > enforced. > > Make sure that the allocation size is always consistently aligned to > PAGE_SIZE. > > Fixes: 2e45474ab14f ("execmem: add support for cache of large ROX pages") > Suggested-by: Peter Zijlstra (Intel) > Signed-off-by: Mike Rapoport (Microsoft) Thanks! Acked-by: Peter Zijlstra (Intel) > --- > mm/execmem.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/mm/execmem.c b/mm/execmem.c > index e6c4f5076ca8..2b683e7d864d 100644 > --- a/mm/execmem.c > +++ b/mm/execmem.c > @@ -377,6 +377,8 @@ void *execmem_alloc(enum execmem_type type, size_t size) > pgprot_t pgprot = range->pgprot; > void *p; > > + size = PAGE_ALIGN(size); > + > if (use_cache) > p = execmem_cache_alloc(range, size); > else > -- > 2.47.2 >