From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2528BC369CB for ; Wed, 23 Apr 2025 21:36:59 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 636606B0005; Wed, 23 Apr 2025 17:36:56 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5E63C6B0007; Wed, 23 Apr 2025 17:36:56 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 39CC36B0008; Wed, 23 Apr 2025 17:36:56 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 1624E6B0005 for ; Wed, 23 Apr 2025 17:36:56 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 93CFDBB24A for ; Wed, 23 Apr 2025 21:36:57 +0000 (UTC) X-FDA: 83366618874.10.42B11AA Received: from tor.source.kernel.org (tor.source.kernel.org [172.105.4.254]) by imf07.hostedemail.com (Postfix) with ESMTP id CDB0D4000C for ; Wed, 23 Apr 2025 21:36:55 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=R5vwbmrZ; dmarc=none; spf=pass (imf07.hostedemail.com: domain of akpm@linux-foundation.org designates 172.105.4.254 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1745444216; a=rsa-sha256; cv=none; b=e1bCakYBmPMGQjqxtXzyMYqdI4Tthc7GMlWOn50zsIfLJeYRGbQW2K27/fGKQ/Bym6ETqe PK59hDXuKtOqoENf6d4ABomXVH8BmrV0/cDK7TlJ0AdrNwdJhA3b+FpwN7cJL4gZIa+SDS 15e/iI4ZQ8uiCOyyWm75J1Kfv6wo4jU= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=R5vwbmrZ; dmarc=none; spf=pass (imf07.hostedemail.com: domain of akpm@linux-foundation.org designates 172.105.4.254 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1745444216; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=bSRrTNyO/e6KbNMkfKU3tMNAnvGE+OCP15Q1zh3J1Fg=; b=UJuhQPzSVcx8IQ9ZaFUHHkOAI1kzBwJkBFmQYV2jRtVjSqaa+2MJJWKAp6xO+E72BWLxEW Pbu7ZODWJznhpZsCt68TmvRl/nsu/bqTJzsNWj7euJb66OruVrlA6OItn2Lr7aDSg0CAVZ XZO6tQvnXeXhzuSfwmOFC99tAejQiuQ= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by tor.source.kernel.org (Postfix) with ESMTP id AE6D96844A; Wed, 23 Apr 2025 21:36:30 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 281C2C4CEEF; Wed, 23 Apr 2025 21:36:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1745444211; bh=IB7QAxeN++hoha3WK4pNByy5KVzecNNyrm3ulLjQnbk=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=R5vwbmrZUe0LniCicXYSr4oILDOhr2COx4MMqlARXp/nZr3HN/p7Sant5bJjmoNFZ 3yn3NPm6PdP6PlRZd4JTvr2wafHMN63KNO9TnfYowyzpnNYKkYQNlqQDMowIIXqXqa nwaq7TEeGCWzJQAty/8y99MpMFD4UEiaNkUm185g= Date: Wed, 23 Apr 2025 14:36:50 -0700 From: Andrew Morton To: Mike Rapoport Cc: Peter Zijlstra , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] execmem: enforce allocation size aligment to PAGE_SIZE Message-Id: <20250423143650.6595dcc7178351b62c31782c@linux-foundation.org> In-Reply-To: <20250423144808.1619863-1-rppt@kernel.org> References: <20250423144808.1619863-1-rppt@kernel.org> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: CDB0D4000C X-Rspam-User: X-Rspamd-Server: rspam07 X-Stat-Signature: 8jejppuc3yfgprch5dsb135djg3dhuug X-HE-Tag: 1745444215-268919 X-HE-Meta: U2FsdGVkX18D6keFNpATFYBecvF2gNOmmrzPdSjUJU4uPl1datSaggRedbmubEujZntXa0AbnKuI+UoMrMejQJ3m6vXNPHUAc0eefcM0z4929KyyMv4l6OXIqIUnyo+EsdOnbXDfrhB7oxP3RpB51p8fqtY3ykKGQmU2wBp5EkYyn9BoIwey4WcNYvhFTjcUmyDZ5a+9GK+5US2O8XzAsU2EdfZDSJhDId1bzXnsLNU2SyX8r4xJEiYyVJ6kT2J2ufTW8cp1HcwpGgNJHO+LpHYiFu6DdczBiOlEiSX7wPmON/b2fJqy/m9mRCn3K16iUOQ7JtFbPYwLMB4nm0YBExL+opv4mrzoveyc6nCcsIG8e0Tyf1w8EK3ZasCUFp+jLqpzY0+suVUyYEPJGEEsdjnrWyd5LfyJqoYvrvurvan6iNYumMUj+cexAwhPVwidMB/nVnJ6+xDM1SgUNAKwujypavgPo7PCVUh4ZwgBGOzED7dfjndLtJp2qGRvGBuS/dFYgnkgYW7tjHHuFOJzdi5tkVAnjVAT3Joh3Zuku/9XsJdDAsFlk8uvJ4rvPNaT9hVkj5VsF7LI5gT8bOimtERyByodvAPihclmW1XOhd08qejkVPbxqMdDf+cytPzTkjiOYQlJu75Sa5T5fDqCsUn3SPVfMbFa4t1E5uo1bm9g+ukpFq/IzwYe6pbMdchMKIPJ/ScmpAObiyBRJKzVRr9OZPKMdxm6bzyhZFP7LHJ1+RTPNVdOf8j/Pj3M2baJIQ5ZwLlL9xZZlNsRB6j3opZJUmQ4s+Vis4C9qhQi8KiyymMrdGfDlVs/dUopQgSgZd46RdS0ppxpzJUXKByKS9P/uUSoPwUMmK+qnR050UxR3pQMlqpWHyJ8/svu43OIXuLJ31R5Rc4sI8cOw/M7BsmM/4GeRixD6lizot7tViRKLXXjG1LrqkKuePSyK2LHLD0nPBcd62VMqYL/rhn +3St1fRP +Urvh6HKYvB1C4oUClpHMBwJmlou3HtT3s+Ah6j8DHjVkbZ+yVmsK4lPpfjMHPwhX5dK93BXMk7rSJ6GmCdu5VRpsxH7dSuYvsEiA2hxxfMojYJzT7Xqo+HwG2KDFqEEbdK8q9H3aYMuB3Q/GeWIHfVnfmXfvd1fTdLZRgGkeFfJLEdSi+KKPKxIOC9Ukz80IDYBfk3EbCP9uK//G4vYEqIyVMNAZdKOQ7YLKRoeB8jH0A41pSiuaQpCVP2rrwxzsDybhZaLQOrLpDNHuNpKMOUMZd2fgwZHVc37IZWVp0KxVZDoHbmgng9Re5niEesRMYyJa X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, 23 Apr 2025 17:48:07 +0300 Mike Rapoport wrote: > Before introduction of ROX cache execmem allocation size was always > implicitly aligned to PAGE_SIZE inside vmalloc. > > However, when allocation happens from the ROX cache, this is not > enforced. > > Make sure that the allocation size is always consistently aligned to > PAGE_SIZE. Does this have any known runtime effect?