From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7012CC369D1 for ; Wed, 23 Apr 2025 13:38:50 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 78D736B00AA; Wed, 23 Apr 2025 09:38:35 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 716DF6B00AD; Wed, 23 Apr 2025 09:38:35 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4CADA6B00AC; Wed, 23 Apr 2025 09:38:35 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 2835F6B00A7 for ; Wed, 23 Apr 2025 09:38:35 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id BF2561CAE19 for ; Wed, 23 Apr 2025 13:38:36 +0000 (UTC) X-FDA: 83365413432.25.A29E8A3 Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) by imf21.hostedemail.com (Postfix) with ESMTP id CD6811C0007 for ; Wed, 23 Apr 2025 13:38:34 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=infradead.org header.s=desiato.20200630 header.b=khrRoBgA; dmarc=none; spf=none (imf21.hostedemail.com: domain of BATV+ca0b9ff444d258c14c24+7913+infradead.org+dwmw2@desiato.srs.infradead.org has no SPF policy when checking 90.155.92.199) smtp.mailfrom=BATV+ca0b9ff444d258c14c24+7913+infradead.org+dwmw2@desiato.srs.infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1745415515; a=rsa-sha256; cv=none; b=RBosgDcKax5THV2c2921pB3OIP6yIc5aMy2Cz4NBBJpSVlpGkbOaVNkANY8WTOcCNqcG7z dXgp+FPIB6ZZEdsPRXh7xBXbUJ44jTgw/lhazrh+g+B0VPwVADx0meZxEXgaf21EThPDnS +bajAkInZFI1ZIwyglQXUp1gPfk1iVA= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=infradead.org header.s=desiato.20200630 header.b=khrRoBgA; dmarc=none; spf=none (imf21.hostedemail.com: domain of BATV+ca0b9ff444d258c14c24+7913+infradead.org+dwmw2@desiato.srs.infradead.org has no SPF policy when checking 90.155.92.199) smtp.mailfrom=BATV+ca0b9ff444d258c14c24+7913+infradead.org+dwmw2@desiato.srs.infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1745415515; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=vWWiitZaZZECB/Jffy5oKrQEuSe+N2VjDOn88LK/ojk=; b=x1gEnZbr+3PaEepLrnsJYuO53fJSddTNDme1OoVkz/42krOMn8+97pPa284/k3pMHSs76J FtCIwe+32npVtUiGdYwaAVBKzMGGOXtJVW9ZB4EAIpmronNMgG4PRMFD6nTECzKYek4Mbf nUym0KA+oAWwftESMKfsctbfGDVhMM4= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description; bh=vWWiitZaZZECB/Jffy5oKrQEuSe+N2VjDOn88LK/ojk=; b=khrRoBgAR912JtKZx0SDiQ/Dk1 CigQyhJm8UKETKIEl4tGCWkekilUJDn5ZMsl0YSRcqLaLD4aUcYJyRHpIOBhPr/L5orcNygaPQU+C db3ZbX27QnVKM9sFaqK2rjVBQATLNr1W6Qd2cSmFNwn3Iuscv0fDBxsRqfIJK8rMdJjYwc3GF03Fk 5qv0UWvCTuGMYYRI5uhAFhm1EffUvV7zM0lDVW+eqWUlr4bfQ6qr+HJ1UkKyboJGInIWFx8fPTMb/ 7qDcqP+iBjLYd4Hyai+CC7YygRWYf0swPxtoc6v0TFxnoiay9qAQnP8IN8RE0N5w8RmvDL/FhATnt 9L8l2lKQ==; Received: from [2001:8b0:10b:1::ebe] (helo=i7.infradead.org) by desiato.infradead.org with esmtpsa (Exim 4.98.1 #2 (Red Hat Linux)) id 1u7aIy-0000000BQyx-1acJ; Wed, 23 Apr 2025 13:38:24 +0000 Received: from dwoodhou by i7.infradead.org with local (Exim 4.98.1 #2 (Red Hat Linux)) id 1u7aIx-00000003JOs-19tx; Wed, 23 Apr 2025 14:38:23 +0100 From: David Woodhouse To: Mike Rapoport Cc: Andrew Morton , "Sauerwein, David" , Anshuman Khandual , Ard Biesheuvel , Catalin Marinas , David Hildenbrand , Marc Zyngier , Mark Rutland , Mike Rapoport , Will Deacon , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Ruihan Li Subject: [PATCH v4 5/7] mm, x86: Use for_each_valid_pfn() from __ioremap_check_ram() Date: Wed, 23 Apr 2025 14:33:41 +0100 Message-ID: <20250423133821.789413-6-dwmw2@infradead.org> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250423133821.789413-1-dwmw2@infradead.org> References: <20250423133821.789413-1-dwmw2@infradead.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SRS-Rewrite: SMTP reverse-path rewritten from by desiato.infradead.org. See http://www.infradead.org/rpr.html X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: CD6811C0007 X-Stat-Signature: iudqj39858ex3mzbzkmkmfen86owaqu5 X-Rspam-User: X-HE-Tag: 1745415514-56909 X-HE-Meta: U2FsdGVkX18nY8l4RAmJgahods1zIJPM6L+RjLeu38s7An1ZTBwmGbrf4jkupZ3Hupe4rg7Ik7Rpv8PCfgogWz0JJhkEqXlF7P7qlul/aZlCwEXgP6YM/FooGRmB/isF8ufaxfanxR2TkM0BRrSQL7DKqHYkc2qWgHMBnlsX4R7HZHbHe5c10rQdXd8ddXabYv0TxAV7LHpIDJXZX3qG7EeVqP7ADd0S8Nk9fgG0TRYYq5CCglKim0LY+sRkiPwBZvFXDmEY7c/ViVg1BeombOBwNn4FXIYJv9WIqxw7zLhR2gRue+eAJcjDho2YSYmZ4vbmxVU+W0xLNosz2BhBaH9buKa/Yp9KKKGRcpwUSftS2/Y2kuE08Sq1EFP0S3TuRInT9D0VpUG4CmCnURR/KI9rHSNQP6Lq8pMQEbx2YBqElA24ajB2YZ2uANixTYljnN2dhXWWlKG+boZ8kHO7UggeCYa4YtS9PdkhiH6poKSSCwD11EOURUDAuodvN9pl2Vnyc/mh1fTVJhqDHWTZ72qGala9X1XtoqAMLuBz5lc+1YjwTFsu8wHFyS2e2uGFAMEIFXIAZpEFEIrSqIKSwRgz7kgbjQw4r57LqfCZtMT8NrL+0cLvbP07rl/CGSrR20kLrv31QxjXs1uNobY/Gtj9LSuE0EnXMp7SWW6PlmhDTvHxFPGHHtqidoInOWpQ7eWzHcbbLuvcI3PI5Xt0faXpmae4RVc7Nrkcxd9TsU3p3e67JBBOX1qyOgXbsJmigEtj/IclfgSVcNZhUd7qyyvwCnyexH7KGvasT6drjRGBzm8MEG/EuC22l9e07JAujnzUIZfjzf4Mx872SJlo5taRaL1lZAQ/bZtz3feHneNFBi+HWo87BFBwnwCcUbsVrTV+N5UyHwsfnC4VNk7ZVFSFZqbPCmaUOsBbtGLaOrBIdDfW8IWorzTa+XR9FOT/Ktrxa4irTeTTt40/t6U TIunr8oX Oycmgkh6M+vw94NekzgPqrYm57W11id9twVHQQTIfQ2pl48Ofg1GhhlUzz/PPkZEgE9LwuLJICgJGTZXr4Q3gRRfSe1kKUwkWk7c4srNyfi3Xord2omc1dDN89BbZ6IhXiwzpNhnyljukHtG9Ob6p9PdxywlebhYpnJk4PnKNaP0fMcEClW92t6i4DGZ249f5VQzjI+7sSJMLVRGuAmCvhLz2l9H4uIJhAYjhY3XI1zSzeopTKPOzc42vChMYLWPqfBWJP9p1sbclLlzlwucLOrrWS7LD4/6r137MYsIJZn3JcYSY5msR26ZDsiDkoxnKSX5H2R95nTiMSwPbsc1SF4QanxghNmdz4TrwhHoQZW/OMXxNNZzUA+3PKaP1eNDaXuh0kk4lrm/E1wu2A+DOiNhoZUfVRAmqhY1GjgsjhVpWweoSWInvwBwkPX0rFoXc3vZ0N6Gg6/uT9aDETWLqNH+rg5M6igwGJJyZYvu2un+HhZeAwzsHaNOoMAOBt4fLkQSnQXfq0Rid7M6FAw+arNY0HQvZAwiRVe65VGzhmJZjh9dOY5CdgouPkg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: From: David Woodhouse Instead of calling pfn_valid() separately for every single PFN in the range, use for_each_valid_pfn() and only look at the ones which are. Signed-off-by: David Woodhouse Acked-by: Mike Rapoport (Microsoft) --- arch/x86/mm/ioremap.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/arch/x86/mm/ioremap.c b/arch/x86/mm/ioremap.c index 331e101bf801..12c8180ca1ba 100644 --- a/arch/x86/mm/ioremap.c +++ b/arch/x86/mm/ioremap.c @@ -71,7 +71,7 @@ int ioremap_change_attr(unsigned long vaddr, unsigned long size, static unsigned int __ioremap_check_ram(struct resource *res) { unsigned long start_pfn, stop_pfn; - unsigned long i; + unsigned long pfn; if ((res->flags & IORESOURCE_SYSTEM_RAM) != IORESOURCE_SYSTEM_RAM) return 0; @@ -79,9 +79,8 @@ static unsigned int __ioremap_check_ram(struct resource *res) start_pfn = (res->start + PAGE_SIZE - 1) >> PAGE_SHIFT; stop_pfn = (res->end + 1) >> PAGE_SHIFT; if (stop_pfn > start_pfn) { - for (i = 0; i < (stop_pfn - start_pfn); ++i) - if (pfn_valid(start_pfn + i) && - !PageReserved(pfn_to_page(start_pfn + i))) + for_each_valid_pfn(pfn, start_pfn, stop_pfn) + if (!PageReserved(pfn_to_page(pfn))) return IORES_MAP_SYSTEM_RAM; } -- 2.49.0