From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C5AD6C369D1 for ; Wed, 23 Apr 2025 13:38:53 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BFC7C6B00A7; Wed, 23 Apr 2025 09:38:35 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B143F6B00AC; Wed, 23 Apr 2025 09:38:35 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7898B6B00A7; Wed, 23 Apr 2025 09:38:35 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 43BAB6B00AA for ; Wed, 23 Apr 2025 09:38:35 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id C117EC0713 for ; Wed, 23 Apr 2025 13:38:36 +0000 (UTC) X-FDA: 83365413432.27.BA98EC8 Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) by imf22.hostedemail.com (Postfix) with ESMTP id 8B3CFC0002 for ; Wed, 23 Apr 2025 13:38:34 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=infradead.org header.s=desiato.20200630 header.b=daQErgwl; dmarc=none; spf=none (imf22.hostedemail.com: domain of BATV+ca0b9ff444d258c14c24+7913+infradead.org+dwmw2@desiato.srs.infradead.org has no SPF policy when checking 90.155.92.199) smtp.mailfrom=BATV+ca0b9ff444d258c14c24+7913+infradead.org+dwmw2@desiato.srs.infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1745415515; a=rsa-sha256; cv=none; b=C54NlOyNzvoMrzN5yEqRbaEVSBLgLCK8EcCI4oR0rQv9IbaFLzeEAc6iTjE7AZnNjE0Apf GvV9g2WKu6MOBmgB0vJ4H60ui0tNcmpGJz4VN0kBO++j3z7ED0KOuukJiit8N3Hmy6TsGF N7dy80uOBjbkiXu+8OuM2GbWrM6lfiA= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=infradead.org header.s=desiato.20200630 header.b=daQErgwl; dmarc=none; spf=none (imf22.hostedemail.com: domain of BATV+ca0b9ff444d258c14c24+7913+infradead.org+dwmw2@desiato.srs.infradead.org has no SPF policy when checking 90.155.92.199) smtp.mailfrom=BATV+ca0b9ff444d258c14c24+7913+infradead.org+dwmw2@desiato.srs.infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1745415515; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ZTYSHEx6XLiA0iASU1Pz3LevQrqtVvW2jP+N3hkQrcM=; b=mnoBH+q6UCD9cEUJiqZbkgbgk9glr4xS5tFAYc0r9+D+xWZWIBDrekdih0ZpULABJota6N 2MRLrYq8tNyy8c/jgZ7kJxLv9z++rqopPenXDBtHoZHMMLNOWyk74hXLFmHbamwp0sECZN SWBQv6PDu/d8woBbscbXD6cyLiR1WAM= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description; bh=ZTYSHEx6XLiA0iASU1Pz3LevQrqtVvW2jP+N3hkQrcM=; b=daQErgwliCVVE1pWR5tdvcpJ7I u/JU5Obk2cIXvRdK0lxWn+F0EkwIuL/hywusSPq1DNB/NIH6iUKFRXyTVDTkSomoxbDpsiag1TaK8 ABbYtEHnfPEXd0NPNt9ezRWdYlCJoTb5wLlt9wOZJcez8MWrR1+PEecuIWVO8pybZ5ZIhR/k9DZB4 3a7I8zxbZ7IWw/gjjUl/ShjtWxrbLy3OgexiBf8Kc232BGhf1LA+P4lZTK3d6Z8A1gSuoIapuk/zR F7itdY9J2vlLXHPhc/5jR0nM0KPfD5Tdw0qCXaCJ0xXYvakCpzazKFZ6GjGgnsfjEqNMEiR504TPX mTScgJSg==; Received: from [2001:8b0:10b:1::ebe] (helo=i7.infradead.org) by desiato.infradead.org with esmtpsa (Exim 4.98.1 #2 (Red Hat Linux)) id 1u7aIy-0000000BQyw-1aQL; Wed, 23 Apr 2025 13:38:24 +0000 Received: from dwoodhou by i7.infradead.org with local (Exim 4.98.1 #2 (Red Hat Linux)) id 1u7aIx-00000003JOo-12Ml; Wed, 23 Apr 2025 14:38:23 +0100 From: David Woodhouse To: Mike Rapoport Cc: Andrew Morton , "Sauerwein, David" , Anshuman Khandual , Ard Biesheuvel , Catalin Marinas , David Hildenbrand , Marc Zyngier , Mark Rutland , Mike Rapoport , Will Deacon , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Ruihan Li Subject: [PATCH v4 4/7] mm, PM: Use for_each_valid_pfn() in kernel/power/snapshot.c Date: Wed, 23 Apr 2025 14:33:40 +0100 Message-ID: <20250423133821.789413-5-dwmw2@infradead.org> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250423133821.789413-1-dwmw2@infradead.org> References: <20250423133821.789413-1-dwmw2@infradead.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SRS-Rewrite: SMTP reverse-path rewritten from by desiato.infradead.org. See http://www.infradead.org/rpr.html X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 8B3CFC0002 X-Stat-Signature: krbx1m9oybo9kw8ebyhn4rn9qwxbi3ys X-HE-Tag: 1745415514-46318 X-HE-Meta: U2FsdGVkX1/JjKz1J5IUt+uExImBg3XoJS/uvA+UQsVnH3Gl78I0TvwtfvWr8J8TKRo0XUPsg1GEEL4jkrWUjHs+TcvdiYf9pM5KTJDvYTzG0TQtwxLDzNGeVgTQXLkullfvU3tPuzOtnYEnEz+WIGj2pJsXDAawnKDGP+BCNfLv138PrZ5z8zFApXGaHCqCmhCU8d1vL58nSaB5ecPP5ZkYRNzeouSBJkBOSC6dHZdk1jmSJe8CWuDZ5jEd4wT7AMyjr7FhMfkJSCfFD43SS8LKcLVlTG+uipacSFhKqEldvRUDD7k6LMtsv/mHTZyTH+kHGYVe5ZZ+Wt6VTuoT8Sd/E+aYSDGhmROjCMIvgGwlq/JrK5PriAB1+vozp8fX2DLP5/N55uU731l+zS0WzdmDOx6GcArMqlcHujyW26xyiiiaLSut76WzKvLYC8uHdAEch6i8V6s8dv2HM3OwL+EYXEfRF/LYPcY7frBnwaoabwFOLtzgQxYr621Q2UeGSI9Ieaazl8Dd13qn8Ej1viPtMflgOna2jLAkW1EPH5T0LKqUn56JwtZ+tQcpRgeDhLOybJUhFta0HUAtDnfw+YoLZ/Yu+cPxZyDiHWy8sNaDJIVnaqkNDhSAVCBg53aIenPZ8WGXs2Ts8qvbzy9v9VqboLTOsNeHGlEFvwgMQwLZAD7AWCAFyPDNa4pb91DDoQQPXpvmsmRkjGuW63wmxBjMcSfl5mw0lcpZjNZHDjply3HjVr81Pw8DQXVuzhqBPAXqcMPJzB9VFjQ2R1vuNbvTdtvLkHObXEXV/Qy4YItXHsJsfYXHOD5UR6F3GHjpVDqctq3O44e47XxsWqW70Nv62IrkgGoZ1dflZnVoWCpjYKoeArQK9h8igQCrw/RcUdlJ7T6py0xYF+tV+wP1WYWxKaD/Bd+BR8vTMHzr/eL6IcdJHx0YKtrtyOYfthvh9ghDdB+muPoX6v/8oi/ pgCBuHVS UWykqIT3xzgwkiLwx8v5JufS7f9mvm4sMtOdNHFN2IjBfYF7wnonv06lRDjzc6CWuTBrQ5jM71q59NCPVtIQj/6ga8qK2ZOZRa3oSQZd3LFpoSp5kf7janB4z3ptSMmkG0KJGRqcs9+TXXBdIo5Eb4uOuYlZS4kml1IH6AIWrshjzuSZ3Ee5olCt3PcbkjhbpDwfs2fL0gitZ6UHhqx0tB3J4tPoED082hfHZmsbDh/l0SQpKR9nl2et/JFKCdjlq4SLK2aGf5uNXnGadZcujCcZX796AoVW4Q8TiEixeeDAsKKmvEE3x0U64XqNN0kdb8wHBS9l9fwniJBzu0fqwGxqt2QBIfP00E+/Bn7a16I9aFYJNVPzcWshvz1ZM2PUnFygKwsLGGua01OLQVGVvM35dd7HKCiuHCugPEPC1MsOckoz+6FVUw/ZsXrB5p8W1oGxWjRborehHShWsm9QbHM8Xy4jKwKdtlC5dz2thwyJUQit6X5Bzh8IvrfRAGbBQxcCC6YpIDWTC7y92DBQ+SvSLa7S0OQ1w2PfdRDVbbNouap9GFidEpf2oIg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: From: David Woodhouse Signed-off-by: David Woodhouse Acked-by: Mike Rapoport (Microsoft) --- kernel/power/snapshot.c | 42 ++++++++++++++++++++--------------------- 1 file changed, 20 insertions(+), 22 deletions(-) diff --git a/kernel/power/snapshot.c b/kernel/power/snapshot.c index 4e6e24e8b854..f151c7a45584 100644 --- a/kernel/power/snapshot.c +++ b/kernel/power/snapshot.c @@ -1094,16 +1094,15 @@ static void mark_nosave_pages(struct memory_bitmap *bm) ((unsigned long long) region->end_pfn << PAGE_SHIFT) - 1); - for (pfn = region->start_pfn; pfn < region->end_pfn; pfn++) - if (pfn_valid(pfn)) { - /* - * It is safe to ignore the result of - * mem_bm_set_bit_check() here, since we won't - * touch the PFNs for which the error is - * returned anyway. - */ - mem_bm_set_bit_check(bm, pfn); - } + for_each_valid_pfn (pfn, region->start_pfn, region->end_pfn) { + /* + * It is safe to ignore the result of + * mem_bm_set_bit_check() here, since we won't + * touch the PFNs for which the error is + * returned anyway. + */ + mem_bm_set_bit_check(bm, pfn); + } } } @@ -1255,21 +1254,20 @@ static void mark_free_pages(struct zone *zone) spin_lock_irqsave(&zone->lock, flags); max_zone_pfn = zone_end_pfn(zone); - for (pfn = zone->zone_start_pfn; pfn < max_zone_pfn; pfn++) - if (pfn_valid(pfn)) { - page = pfn_to_page(pfn); + for_each_valid_pfn(pfn, zone->zone_start_pfn, max_zone_pfn) { + page = pfn_to_page(pfn); - if (!--page_count) { - touch_nmi_watchdog(); - page_count = WD_PAGE_COUNT; - } + if (!--page_count) { + touch_nmi_watchdog(); + page_count = WD_PAGE_COUNT; + } - if (page_zone(page) != zone) - continue; + if (page_zone(page) != zone) + continue; - if (!swsusp_page_is_forbidden(page)) - swsusp_unset_page_free(page); - } + if (!swsusp_page_is_forbidden(page)) + swsusp_unset_page_free(page); + } for_each_migratetype_order(order, t) { list_for_each_entry(page, -- 2.49.0