From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BC000C369CB for ; Wed, 23 Apr 2025 08:18:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A6F926B00A9; Wed, 23 Apr 2025 04:18:50 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6F83B6B00AF; Wed, 23 Apr 2025 04:18:50 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4E8806B00AE; Wed, 23 Apr 2025 04:18:50 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 1C99B6B00AC for ; Wed, 23 Apr 2025 04:18:50 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 02796141732 for ; Wed, 23 Apr 2025 08:18:50 +0000 (UTC) X-FDA: 83364607662.23.EECEEDE Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) by imf17.hostedemail.com (Postfix) with ESMTP id 6E0D340003 for ; Wed, 23 Apr 2025 08:18:49 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=infradead.org header.s=desiato.20200630 header.b=ICIc2yM6; dmarc=none; spf=none (imf17.hostedemail.com: domain of BATV+ca0b9ff444d258c14c24+7913+infradead.org+dwmw2@desiato.srs.infradead.org has no SPF policy when checking 90.155.92.199) smtp.mailfrom=BATV+ca0b9ff444d258c14c24+7913+infradead.org+dwmw2@desiato.srs.infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1745396329; a=rsa-sha256; cv=none; b=MtcND7EbmekV3Bga67NwTVb9kYE4yAU++NcxtG7uxEf/f2FQsPnzyip8ERz7Af4abGEupH vGb9eZGwUWu7OBytRq0V2HJbp4c+Dqx3roDR7mzqZWYUv0R76yGNvd5T9jzsJURObav+cT l+atQwuzL/jUoFLQkweF7grCcpMcTHM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1745396329; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=cbMdDFG9P+bdaitfSB/95+V1DKWHcnUFJFkFTDn7hYM=; b=s0ez6CXS0QIsRJ8abWbDrSTCEvKIdmflN4rMTOUpKgRCydRsQr3W1qo1m1nqM5oiF3DML7 O+aHc238OoiX0RJMH/qKV87Ox0Ax1NYhFjP33V9G0CxZSn826GfQ/zg+qYmQgxwuMONf+T 8HU00YpyBG85INiinHicyVDeJVjgbWE= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=infradead.org header.s=desiato.20200630 header.b=ICIc2yM6; dmarc=none; spf=none (imf17.hostedemail.com: domain of BATV+ca0b9ff444d258c14c24+7913+infradead.org+dwmw2@desiato.srs.infradead.org has no SPF policy when checking 90.155.92.199) smtp.mailfrom=BATV+ca0b9ff444d258c14c24+7913+infradead.org+dwmw2@desiato.srs.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description; bh=cbMdDFG9P+bdaitfSB/95+V1DKWHcnUFJFkFTDn7hYM=; b=ICIc2yM6OI9RDh+NOJty3eOWUJ FgYo2iqowgJFiYjbmeBB6IulpyokzNwdkLIKrlmp25lnGlNqJTuA2fNNuiQHre8pHPLQrjmmLGnE4 M4hU22kFsneFnr8WhMTs/7G8PFgjZwwDjFR96WytCVzYxAsZiByHue6BlJjK4kQLeXJUuyQDQ1kR3 ejQdsH8GeC2avhfbiNgmQQx20r1oAhzCfbwUEJ0vbOnE1b3IKAelb/IjTxSfKUvhUe4c6RMW23P4Z D0sqNEwszCaPmeUJExBUw080o/JA3LMGMxB7T9ZYsalDsgBkoUUWGoUdL38Pknptkkcf5QSjFZyrt mkR51KVw==; Received: from [2001:8b0:10b:1::ebe] (helo=i7.infradead.org) by desiato.infradead.org with esmtpsa (Exim 4.98.1 #2 (Red Hat Linux)) id 1u7VJR-0000000BOif-1akK; Wed, 23 Apr 2025 08:18:38 +0000 Received: from dwoodhou by i7.infradead.org with local (Exim 4.98.1 #2 (Red Hat Linux)) id 1u7VJO-00000002YO5-2FrH; Wed, 23 Apr 2025 09:18:30 +0100 From: David Woodhouse To: Mike Rapoport Cc: Andrew Morton , "Sauerwein, David" , Anshuman Khandual , Ard Biesheuvel , Catalin Marinas , David Hildenbrand , Marc Zyngier , Mark Rutland , Mike Rapoport , Will Deacon , kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Ruihan Li Subject: [PATCH v3 7/7] mm/mm_init: Use for_each_valid_pfn() in init_unavailable_range() Date: Wed, 23 Apr 2025 08:52:49 +0100 Message-ID: <20250423081828.608422-8-dwmw2@infradead.org> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250423081828.608422-1-dwmw2@infradead.org> References: <20250423081828.608422-1-dwmw2@infradead.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SRS-Rewrite: SMTP reverse-path rewritten from by desiato.infradead.org. See http://www.infradead.org/rpr.html X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 6E0D340003 X-Stat-Signature: efbyffxig7q95zwxeakh1cb3nba436tr X-Rspam-User: X-HE-Tag: 1745396329-850055 X-HE-Meta: U2FsdGVkX19cnVzPEJrW4/ImyBlwv9T1Gl9k6a6ANYPpy54hNgpEVeoHeGAHlEcSCP+wZdjfQsevex3CR9OxcMLpsq8VXENaFYtUqLa41B4Hg2L6lnI2ikkLurkWOlt5GNz7+H33kIRh1LoZQsu1JmTT6PK+XNNA+ZKF+aydOTNdRdR1kF8y7ZX5f7N3I/b72Qu5NTROQdGQgb1cYWmU/enuK3J6xqZ1yfvUC80WOnL4r2WrkyzwITLnm4ipFRX2ErqdEI87Sv8vaizzHGD5l7uPpp3cRoOdFKEq0vZLgY/0Dr55fW9hS1k07Dso4BrGDRpcJBrfWiosxI8dOPmkqKqrRB/uNFm7iwPyBNV0l+rA1PDn81FKB3E+UDA0ckr1nKuRnKZN8Lzq3kQm+t1aBhG6DrGQacDL8hcQuhfYD2plSpE19XdN0vfBVCTsiC9ex9uii7vZIuyVOqTVeod57g0o8kBgGMZ9tl3j2yHbKks71S7ludPenmggfRqWBP0KUPUJMhNGcVQlxHPqwXfWpc0muut0rXDCe1mJdysX2VAcLy46zra/oWsTg/oiYpL3o9nBMpEec8rUjDq8S9fGQtpM5zo3i40JuBTkcYnfUC97QSoL3zz0VlayZjZTWeZjXm8vVnz0OfPmkDiwM00I3buxpRemqtTlUSbdgWUz7XiHpV11XEasNXzqhv8606EKYZYsBt16N2CMEMVEg+1f1o2XsgW/CSLfnJ/jK2hVbTYYV7T5RCZUvQqikJotf/LMTUvfT3qyKi8bo+KXnVxu8EZaUVz8+1NvwTLrpjtbDMoHOobSrllNszkTI+fkwANmlYbmmqYz1VKsMcFNfQfUwlCMn+UsFj5oxablKCtIZNVszaII29zsEGOTXFQTAs2Xzas+XwQz3dYx1l0+QGBlrnU45HuDI7OW5q8UP+51FdSLc9u7OdOEXskS7NC3czu+q0hoP95etHubcvwQ8ZY vwXKORCW cm6y/gn9rjUFD8nBzNKgMXyev78a4I496TFdXsWdnhKR0cru2X87vD/75EH+11K/djekNjTX1TWZ4wJ4bLC1233bqJN9chLQBmiHKid8C5CCFGeipEkPcH5EM7nL2OkW+fOL8eAzqjz/nmAS8INJHBYLSYdxsl+1AR/mmKWeyvw++BwJACL62Y2ydrKjWjnYNtZ1rRLZ5cSj3Znk2zKeJhHtG7kk9WxHDjVHRQYVyGAnRtYQ7l2wD4kJzBQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: From: David Woodhouse Currently, memmap_init initializes pfn_hole with 0 instead of ARCH_PFN_OFFSET. Then init_unavailable_range will start iterating each page from the page at address zero to the first available page, but it won't do anything for pages below ARCH_PFN_OFFSET because pfn_valid won't pass. If ARCH_PFN_OFFSET is very large (e.g., something like 2^64-2GiB if the kernel is used as a library and loaded at a very high address), the pointless iteration for pages below ARCH_PFN_OFFSET will take a very long time, and the kernel will look stuck at boot time. Use for_each_valid_pfn() to skip the pointless iterations. Reported-by: Ruihan Li Suggested-by: Mike Rapoport Signed-off-by: David Woodhouse --- mm/mm_init.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/mm/mm_init.c b/mm/mm_init.c index 41884f2155c4..0d1a4546825c 100644 --- a/mm/mm_init.c +++ b/mm/mm_init.c @@ -845,11 +845,7 @@ static void __init init_unavailable_range(unsigned long spfn, unsigned long pfn; u64 pgcnt = 0; - for (pfn = spfn; pfn < epfn; pfn++) { - if (!pfn_valid(pageblock_start_pfn(pfn))) { - pfn = pageblock_end_pfn(pfn) - 1; - continue; - } + for_each_valid_pfn(pfn, spfn, epfn) { __init_single_page(pfn_to_page(pfn), pfn, zone, node); __SetPageReserved(pfn_to_page(pfn)); pgcnt++; -- 2.49.0