From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9D6BAC369D3 for ; Wed, 23 Apr 2025 08:18:47 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id ED2A36B00AB; Wed, 23 Apr 2025 04:18:45 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E7B006B00A7; Wed, 23 Apr 2025 04:18:45 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D42576B00AB; Wed, 23 Apr 2025 04:18:45 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id B769F6B00A7 for ; Wed, 23 Apr 2025 04:18:45 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 7F0A9141765 for ; Wed, 23 Apr 2025 08:18:46 +0000 (UTC) X-FDA: 83364607452.05.A0A37BA Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf12.hostedemail.com (Postfix) with ESMTP id EA73A4000D for ; Wed, 23 Apr 2025 08:18:44 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=KWGOaFJX; dmarc=none; spf=none (imf12.hostedemail.com: domain of BATV+cfb108382ec1185fc08d+7913+infradead.org+dwmw2@casper.srs.infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=BATV+cfb108382ec1185fc08d+7913+infradead.org+dwmw2@casper.srs.infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1745396325; a=rsa-sha256; cv=none; b=X4AmRuk70kn/8fZePipvU20J00G2v4I0zKFaeJFOsuw3O8UokVkC44DADBPTF0wQRYTcdP fgJp8ylB1EI5kZR1Kt+7uRb/G76CCl9UQ1f0CzQoT6Hnkd731JfHSeDsMrK/3tMOuAUOWq Z5j0G2LtrJA1vi4p7zv/8gLoUf6t/wM= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=KWGOaFJX; dmarc=none; spf=none (imf12.hostedemail.com: domain of BATV+cfb108382ec1185fc08d+7913+infradead.org+dwmw2@casper.srs.infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=BATV+cfb108382ec1185fc08d+7913+infradead.org+dwmw2@casper.srs.infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1745396325; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=SAQbWjWGGmEWV/yrGcgLnMo50LiJ5Xc9HvWor5bjKpE=; b=SmIqHkpvWwaXc5MCLppYkz8ylGdKkP3wmcUjw4ckCyrHH6584c27aPFcN+RH4/ikEJVMX4 9w/38aj9Xql7aS2Hp+YPmXff1SPQ5wzFOSSBMI92sBYPRerzvFOXKtChO+o37bhDFYBvRM pDBztF2FRN6+fvNAZTBARkbXvTIWsaU= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Sender:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description; bh=SAQbWjWGGmEWV/yrGcgLnMo50LiJ5Xc9HvWor5bjKpE=; b=KWGOaFJXU2Zhudn7trVxYUEU0g 7QQaPkpOyTCf67dYB0FTPxHraBznEqfyf3CWdnhygxC8xk5dbP9BsRCymIsPTF4wAwP6KqFkr2FA6 FmzLrm8fgn5FNEGSPdZIG7zgut0D0wdH/1mn1S9JEK5UNaDsTXfnf9Rrdsasucwbo6CRYk20ltlub zqk/SOxkESDY8NKrxvp7RlTzavj/40AZ/QicG71H0mgMDCefzRigaplRoo9o5ZJdYGcaUnGaaogvj 80uEUTHcGn5ocHFj4LephL03r6fmWs2hRgpoez0yWwQeFioSX2KC8ThpS1JtfEfE0maumlFjzlgHM BdNg+AgA==; Received: from [2001:8b0:10b:1::ebe] (helo=i7.infradead.org) by casper.infradead.org with esmtpsa (Exim 4.98.2 #2 (Red Hat Linux)) id 1u7VJQ-000000081P3-0EV6; Wed, 23 Apr 2025 08:18:32 +0000 Received: from dwoodhou by i7.infradead.org with local (Exim 4.98.1 #2 (Red Hat Linux)) id 1u7VJO-00000002YNz-1z0F; Wed, 23 Apr 2025 09:18:30 +0100 From: David Woodhouse To: Mike Rapoport Cc: Andrew Morton , "Sauerwein, David" , Anshuman Khandual , Ard Biesheuvel , Catalin Marinas , David Hildenbrand , Marc Zyngier , Mark Rutland , Mike Rapoport , Will Deacon , kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Ruihan Li Subject: [PATCH v3 5/7] mm, x86: Use for_each_valid_pfn() from __ioremap_check_ram() Date: Wed, 23 Apr 2025 08:52:47 +0100 Message-ID: <20250423081828.608422-6-dwmw2@infradead.org> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250423081828.608422-1-dwmw2@infradead.org> References: <20250423081828.608422-1-dwmw2@infradead.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html X-Rspam-User: X-Rspamd-Queue-Id: EA73A4000D X-Rspamd-Server: rspam04 X-Stat-Signature: gids44iesk4iba979baifa6m7x31h7sb X-HE-Tag: 1745396324-690342 X-HE-Meta: U2FsdGVkX1/KUAtAToD9BGAuC/PRJ+Ix7L1+TGdxkbJTqXVS1OuYn+EUXrn+j5hqwuPWXYZ8PCd+ZlxhktCWY/Pej2BD2iwBCDVDa2ZIbzzqSzxkSQDMIZ/JFzOyEtWWtN5RFI7KcfDNIQBuhPIXuWPVKAOCWLyydKI78k4enzQP3GpvxsX7+D1NxoPBMPhnRvYkzOVxJlx9h0dOXjqjoW0mOpDJsgN29gR1Y9mbTuazqrq20XqNl4tGKjoPgQbuvsZ3KcTjckOVuPGHA8U89LKudp9mzf8JmRz6s1JHXCP5wmVyeokJPlptIGY+Q3gvSNcEoQycGABCyqlyRWJtrkS11QJLNejnVuFB+yRw9NQziXL7lqWQZYVTydGKIZyPJCfaHB0H0FW01FUKauhHSdZ65+E7cSeIhr1K1lrCAcsZVZUUCSO9KYemaiFdFFDKI9WTEgKrVZ6vdMOouwljp+x4k9KERFbYQHZ/bm9gAgHK8Cq2HKKUKNcV5P6U1UB2SppTQpZqU9eFSf0W4zGdTPHpTz+WRDee0YHM8TqzibZbdy2GSVnUOQSfc5giFsPE2uw1LsexGYWeLygwK3x+xVbonQWTb83EZXrHZTMgW+2XQJr6vsk4BlQncCbdHMzt3an2V70cO21V2VhS+q1yEcrRTOnxyeWSn1jJGxnJBgLC/DYshZp3UJywHZN3r58sXPmD9h4k3sjrCqMMELksh1vT8I2DfFTWuzp/KQmFr5ti1BZIcakP5WncAf0+IOflmFnx9NfGoxazwu+nfwu1l0evXM3gFSEbptwBNL/YLbSFA2joaICAfwrMBYDddtg1efIhYHX3LCnSReQlVED1o+C1/phiTxG20PJVs3YjW7fdn6Nv4UnHGqRkWTAtNAbJWHA7NyEUdKUvD2W1EPH0Aiz5GODZ1d4Qdp09O9d7oiSGiOZdpsRsFuNapMtqwAkloP/gqGJ+5pCpfRLpNcp lwdhEyTJ oOmf+K8kmvNocXOGRRd1OfGBMFOACyrKZR3PEif1+yIXRF5ZrPsBSy+5V6UgY7D/cM1IyO3nBRSwGq2EmBxW4l6GnLgD2zA+7AIh4xxSLMJ6/tXYU/kqCXA9gpB8tG2OwiRydkMRSAVSJhlKjd756ij3jQdW4xO1kRY6xaFUEYOgD1VA7LU3GFMWK/+yAEKDEmEjMa4/dke3113kdrd96jQz8rnJi8K/pL6igTiz50aWsw2EXMchwjKiSUQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: From: David Woodhouse Instead of calling pfn_valid() separately for every single PFN in the range, use for_each_valid_pfn() and only look at the ones which are. Signed-off-by: David Woodhouse --- arch/x86/mm/ioremap.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/arch/x86/mm/ioremap.c b/arch/x86/mm/ioremap.c index 331e101bf801..12c8180ca1ba 100644 --- a/arch/x86/mm/ioremap.c +++ b/arch/x86/mm/ioremap.c @@ -71,7 +71,7 @@ int ioremap_change_attr(unsigned long vaddr, unsigned long size, static unsigned int __ioremap_check_ram(struct resource *res) { unsigned long start_pfn, stop_pfn; - unsigned long i; + unsigned long pfn; if ((res->flags & IORESOURCE_SYSTEM_RAM) != IORESOURCE_SYSTEM_RAM) return 0; @@ -79,9 +79,8 @@ static unsigned int __ioremap_check_ram(struct resource *res) start_pfn = (res->start + PAGE_SIZE - 1) >> PAGE_SHIFT; stop_pfn = (res->end + 1) >> PAGE_SHIFT; if (stop_pfn > start_pfn) { - for (i = 0; i < (stop_pfn - start_pfn); ++i) - if (pfn_valid(start_pfn + i) && - !PageReserved(pfn_to_page(start_pfn + i))) + for_each_valid_pfn(pfn, start_pfn, stop_pfn) + if (!PageReserved(pfn_to_page(pfn))) return IORES_MAP_SYSTEM_RAM; } -- 2.49.0