From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C4DE9C369D3 for ; Wed, 23 Apr 2025 08:19:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 40B256B00AD; Wed, 23 Apr 2025 04:18:53 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3941C6B00AE; Wed, 23 Apr 2025 04:18:53 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 196986B00AF; Wed, 23 Apr 2025 04:18:53 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id E74C26B00AD for ; Wed, 23 Apr 2025 04:18:52 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id C3FFE5FC5B for ; Wed, 23 Apr 2025 08:18:53 +0000 (UTC) X-FDA: 83364607746.09.1BBF04D Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) by imf20.hostedemail.com (Postfix) with ESMTP id 0777B1C0009 for ; Wed, 23 Apr 2025 08:18:51 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=infradead.org header.s=desiato.20200630 header.b=BmKxZhxX; dmarc=none; spf=none (imf20.hostedemail.com: domain of BATV+ca0b9ff444d258c14c24+7913+infradead.org+dwmw2@desiato.srs.infradead.org has no SPF policy when checking 90.155.92.199) smtp.mailfrom=BATV+ca0b9ff444d258c14c24+7913+infradead.org+dwmw2@desiato.srs.infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1745396332; a=rsa-sha256; cv=none; b=1TdfSZOE8hIvtCRF3bNnJcUPclETbewZo52aHFpTVwlju1dSpBGAd+rK0qfZDSb5S8xbh5 xTqpAcv3n0Qxt4ltGfLTixe9ybBSSxlsrtSrFaRVJ3woB5ijSru4aGSL13B7z0gfIsiPC5 lhOsuL1iJhY2PzUWK/pFBb0X2foKP6E= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=infradead.org header.s=desiato.20200630 header.b=BmKxZhxX; dmarc=none; spf=none (imf20.hostedemail.com: domain of BATV+ca0b9ff444d258c14c24+7913+infradead.org+dwmw2@desiato.srs.infradead.org has no SPF policy when checking 90.155.92.199) smtp.mailfrom=BATV+ca0b9ff444d258c14c24+7913+infradead.org+dwmw2@desiato.srs.infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1745396332; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=EggTF7jgXyqw27ORwtXsCRX4H5aiRA/a+Rh2J8KLoHU=; b=kF42Kc4HsSPa2a7Ywe8FmGBBa13QxljSaN0M4DOltGP2KCGrFMcUv3aNT6O90Z4HJMQVfG 4jawDQ10kJXGmMMHYxGww39ehmIDSjDS3fVwfdf1ACLP2ooD1R5VWgi0FVX9PfbGwY9rBj BdI12fh8WucXLavEp1be5Ayz3gHrHcM= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description; bh=EggTF7jgXyqw27ORwtXsCRX4H5aiRA/a+Rh2J8KLoHU=; b=BmKxZhxXycayWqgY04aS3O8VDv NYYZCozxkEDA0WDmbxV1yNS3+Q5Su24QLc3YxXW2RtGx+avKO+L6seps3N2pFW+n+dP45Md+d+EfE KVkAQRs0lguySdrMhj4IgZtx8enpHxrFfqTJuEtbNoSjg/AFO/LT1EfgpxF2dwZfr0cfZPqwW8UQR AxD+az8+k4r8E6CHBDutgxCGcF6GCNYhiMQyZES6DXVH9SGioJWn1a/uyBYKFPpkeWB49WUd2ERpQ XJQ7aatcCyYdQptgYKIsMoH6jIxaSyREfjipf3GSKb6iwmkSYw7x3JUuqkLvQpJpokUl7XmJKa99h WPD88/VA==; Received: from [2001:8b0:10b:1::ebe] (helo=i7.infradead.org) by desiato.infradead.org with esmtpsa (Exim 4.98.1 #2 (Red Hat Linux)) id 1u7VJR-0000000BOid-1XFD; Wed, 23 Apr 2025 08:18:33 +0000 Received: from dwoodhou by i7.infradead.org with local (Exim 4.98.1 #2 (Red Hat Linux)) id 1u7VJO-00000002YNw-1g6W; Wed, 23 Apr 2025 09:18:30 +0100 From: David Woodhouse To: Mike Rapoport Cc: Andrew Morton , "Sauerwein, David" , Anshuman Khandual , Ard Biesheuvel , Catalin Marinas , David Hildenbrand , Marc Zyngier , Mark Rutland , Mike Rapoport , Will Deacon , kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Ruihan Li Subject: [PATCH v3 4/7] mm, PM: Use for_each_valid_pfn() in kernel/power/snapshot.c Date: Wed, 23 Apr 2025 08:52:46 +0100 Message-ID: <20250423081828.608422-5-dwmw2@infradead.org> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250423081828.608422-1-dwmw2@infradead.org> References: <20250423081828.608422-1-dwmw2@infradead.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SRS-Rewrite: SMTP reverse-path rewritten from by desiato.infradead.org. See http://www.infradead.org/rpr.html X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: 0777B1C0009 X-Stat-Signature: 64mcrrktr3zhuzcuksxt7htoagui1bf4 X-Rspam-User: X-HE-Tag: 1745396331-157019 X-HE-Meta: U2FsdGVkX18hy3f6Mh4BU0AAp9vgZj8Jvm4zpekQhb3sGDE3KV0651AjZsLEPKcffDg8g26L2MrEjQjmkKvRsAXpmmmSbBP9EZkX2ZyLERGF8N+Cd9TLhaPy4cYGnDNOV8zTXmwIVfghi4xxCYaAy2IUUPUUnFxJDsUx2/STRmY72t9+yffG+juY5ngA4vvprcMxKSL98wScrB9dEGUj6807Fwl7L6hdo4pHpabD7pzFiZDSec7ladobGjXlfo0vPS5iARyG2vdgiCkJdOCENbGwKh8XApEGkceH8+m9KFNJ7ql1dF2UcfWoJubaNseVh09bafbBPkA0WUsMBLudSiWFD+dy8w1Oy+kARnilIoLKo+z+MQ9pbuvkjdIitvEqo5bIuaRDEXWtrw4UB5RjwAWXi1WDgFQRphObsvOWULnGhXCepSZekoaNy9Mu2mPPQVFpvs7l/xrNTGTApBfR2nabLyPLFJFVYoV4yGuGqQvZXYfxGB+/j7JsI1oj3kGNk4HKB6BtaVThR5ezCmdjVEO6cdhkj0j0w7lGqXP25IggB/oBg1ZlBgk+s0z/r9VnFZXR+KDrTk60fIu9GnUpFTVJImHcnGK94uy2edJSs7GDwWnWW13dj5V5HnnvkeS4x4CS7OlpbwKR5IXo2nIbLYIN4donGDZYivYNj5d9OAkbc425CPvJPNEpmDhSLOoWzBrN8oSM0u1VfAWyKC8vBQSyZrRGJ5CpnpFxTkK1XrP9zRH0xUeihJk+lHnoROwTroCBDR299/qXk3zWB69lp3RkO8Ma+2P950+PEFosu9ZFnStJxe/xwt5nzRHigNdSuh6u8IctYajrDjyfd2ExZ0bFhUdYWQcunPVCuM550IirAEsb0wnb8dizu2pFRTu89kuQkaXccUf7GNrzGOR2+sAyckUWvU6w2+ec7b8IUZi/EeFF4nb/u0sXwUzGQxaJOuF5qsl4BcLWGY5XxK/ BWJQ54ee mqozNboiF8zAlakpQIRIU8HGMBnc0SIC3qk8n5zFOD+UEaiupTobhkMLqoLskYsn1YcwMpVHXUuW4l7ZW1VsIJDYKYFJabxymZNQEXiVtaNDNqXl91b1k5x8Lql0BbYhFHZURDeuHukyvb0oHH15PUzBgnBOH1uvklrWQrZ7w0TYSNGHyP3ZjhNZef4EspYvgN2Dc+YNYBsN3XOWoUD1pyN0iAp8dQIvyvegoMoiVZqaBz/QqQzuo2N5FZiFIdYpbLpwLXxYjETez6dOag5g8UcgGRdEOHaHCe6H3Agjr7ftZioJFKSiGqJ67KdaPc6dl36IzEsvNkINwzriUOZC0FYkEpdhz0nyow5T49dMuBB2oRH5IbA9OiQ7EsQbrNnKV6IygWLGSmSJ1MLmevNNvwuqNkgihzKXGJ1rdibA43Whe7V9LCcIiDlRj3C6dcFa6bB1fy+ei5pNubM5LH4gUob03f4p+ckrgi782BsR15sqTyFnEoE/+i2/JIVDzlcIxWDmZ1QQEYjruoAi2s1YNzdCiEOpjpT3F0sxX X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: From: David Woodhouse Signed-off-by: David Woodhouse --- kernel/power/snapshot.c | 42 ++++++++++++++++++++--------------------- 1 file changed, 20 insertions(+), 22 deletions(-) diff --git a/kernel/power/snapshot.c b/kernel/power/snapshot.c index 4e6e24e8b854..f151c7a45584 100644 --- a/kernel/power/snapshot.c +++ b/kernel/power/snapshot.c @@ -1094,16 +1094,15 @@ static void mark_nosave_pages(struct memory_bitmap *bm) ((unsigned long long) region->end_pfn << PAGE_SHIFT) - 1); - for (pfn = region->start_pfn; pfn < region->end_pfn; pfn++) - if (pfn_valid(pfn)) { - /* - * It is safe to ignore the result of - * mem_bm_set_bit_check() here, since we won't - * touch the PFNs for which the error is - * returned anyway. - */ - mem_bm_set_bit_check(bm, pfn); - } + for_each_valid_pfn (pfn, region->start_pfn, region->end_pfn) { + /* + * It is safe to ignore the result of + * mem_bm_set_bit_check() here, since we won't + * touch the PFNs for which the error is + * returned anyway. + */ + mem_bm_set_bit_check(bm, pfn); + } } } @@ -1255,21 +1254,20 @@ static void mark_free_pages(struct zone *zone) spin_lock_irqsave(&zone->lock, flags); max_zone_pfn = zone_end_pfn(zone); - for (pfn = zone->zone_start_pfn; pfn < max_zone_pfn; pfn++) - if (pfn_valid(pfn)) { - page = pfn_to_page(pfn); + for_each_valid_pfn(pfn, zone->zone_start_pfn, max_zone_pfn) { + page = pfn_to_page(pfn); - if (!--page_count) { - touch_nmi_watchdog(); - page_count = WD_PAGE_COUNT; - } + if (!--page_count) { + touch_nmi_watchdog(); + page_count = WD_PAGE_COUNT; + } - if (page_zone(page) != zone) - continue; + if (page_zone(page) != zone) + continue; - if (!swsusp_page_is_forbidden(page)) - swsusp_unset_page_free(page); - } + if (!swsusp_page_is_forbidden(page)) + swsusp_unset_page_free(page); + } for_each_migratetype_order(order, t) { list_for_each_entry(page, -- 2.49.0