From: David Woodhouse <dwmw2@infradead.org>
To: Mike Rapoport <rppt@kernel.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
"Sauerwein, David" <dssauerw@amazon.de>,
Anshuman Khandual <anshuman.khandual@arm.com>,
Ard Biesheuvel <ardb@kernel.org>,
Catalin Marinas <catalin.marinas@arm.com>,
David Hildenbrand <david@redhat.com>,
Marc Zyngier <maz@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Mike Rapoport <rppt@linux.ibm.com>, Will Deacon <will@kernel.org>,
kvmarm@lists.cs.columbia.edu,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
Ruihan Li <lrh2000@pku.edu.cn>
Subject: [PATCH v3 0/7] mm: Introduce for_each_valid_pfn()
Date: Wed, 23 Apr 2025 08:52:42 +0100 [thread overview]
Message-ID: <20250423081828.608422-1-dwmw2@infradead.org> (raw)
There are cases where a naïve loop over a PFN range, calling pfn_valid() on
each one, is horribly inefficient. Ruihan Li reported the case where
memmap_init() iterates all the way from zero to a potentially large value
of ARCH_PFN_OFFSET, and we at Amazon found the reserve_bootmem_region()
one as it affects hypervisor live update. Others are more cosmetic.
By introducing a for_each_valid_pfn() helper it can optimise away a lot
of pointless calls to pfn_valid(), skipping immediately to the next
valid PFN and also skipping *all* checks within a valid (sub)region
according to the granularity of the memory model in use.
https://git.infradead.org/users/dwmw2/linux.git/shortlog/refs/heads/for_each_valid_pfn
v3:
• Fold the 'optimised' SPARSEMEM implementation into the original patch
• Drop the use of (-1) as end marker, and use end_pfn instead.
• Drop unused first_valid_pfn() helper for FLATMEM implementation
• Add use case in memmap_init() from discussion at
https://lore.kernel.org/linux-mm/20250419122801.1752234-1-lrh2000@pku.edu.cn/
v2 [RFC]: https://lore.kernel.org/linux-mm/20250404155959.3442111-1-dwmw2@infradead.org/
• Revised implementations with feedback from Mike
• Add a few more use cases
v1 [RFC]: https://lore.kernel.org/linux-mm/20250402201841.3245371-1-dwmw2@infradead.org/
• First proof of concept
David Woodhouse (7):
mm: Introduce for_each_valid_pfn() and use it from reserve_bootmem_region()
mm: Implement for_each_valid_pfn() for CONFIG_FLATMEM
mm: Implement for_each_valid_pfn() for CONFIG_SPARSEMEM
mm, PM: Use for_each_valid_pfn() in kernel/power/snapshot.c
mm, x86: Use for_each_valid_pfn() from __ioremap_check_ram()
mm: Use for_each_valid_pfn() in memory_hotplug
mm/mm_init: Use for_each_valid_pfn() in init_unavailable_range()
arch/x86/mm/ioremap.c | 7 ++-
include/asm-generic/memory_model.h | 26 ++++++++++-
include/linux/mmzone.h | 88 ++++++++++++++++++++++++++++++++++++++
kernel/power/snapshot.c | 42 +++++++++---------
mm/memory_hotplug.c | 8 +---
mm/mm_init.c | 29 +++++--------
6 files changed, 149 insertions(+), 51 deletions(-)
next reply other threads:[~2025-04-23 8:18 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-23 7:52 David Woodhouse [this message]
2025-04-23 7:52 ` [PATCH v3 1/7] mm: Introduce for_each_valid_pfn() and use it from reserve_bootmem_region() David Woodhouse
2025-04-23 7:52 ` [PATCH v3 2/7] mm: Implement for_each_valid_pfn() for CONFIG_FLATMEM David Woodhouse
2025-04-23 7:52 ` [PATCH v3 3/7] mm: Implement for_each_valid_pfn() for CONFIG_SPARSEMEM David Woodhouse
2025-04-23 11:11 ` Mike Rapoport
2025-04-23 12:05 ` David Woodhouse
2025-04-23 7:52 ` [PATCH v3 4/7] mm, PM: Use for_each_valid_pfn() in kernel/power/snapshot.c David Woodhouse
2025-04-23 11:12 ` Mike Rapoport
2025-04-23 7:52 ` [PATCH v3 5/7] mm, x86: Use for_each_valid_pfn() from __ioremap_check_ram() David Woodhouse
2025-04-23 11:13 ` Mike Rapoport
2025-04-23 7:52 ` [PATCH v3 6/7] mm: Use for_each_valid_pfn() in memory_hotplug David Woodhouse
2025-04-23 11:13 ` Mike Rapoport
2025-04-23 7:52 ` [PATCH v3 7/7] mm/mm_init: Use for_each_valid_pfn() in init_unavailable_range() David Woodhouse
2025-04-23 9:35 ` Ruihan Li
2025-04-23 11:14 ` Mike Rapoport
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250423081828.608422-1-dwmw2@infradead.org \
--to=dwmw2@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=anshuman.khandual@arm.com \
--cc=ardb@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=david@redhat.com \
--cc=dssauerw@amazon.de \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lrh2000@pku.edu.cn \
--cc=mark.rutland@arm.com \
--cc=maz@kernel.org \
--cc=rppt@kernel.org \
--cc=rppt@linux.ibm.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox