From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C9796C369D3 for ; Tue, 22 Apr 2025 12:41:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CB7856B000C; Tue, 22 Apr 2025 08:41:12 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C69436B000D; Tue, 22 Apr 2025 08:41:12 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B2FAC6B000E; Tue, 22 Apr 2025 08:41:12 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 96D376B000C for ; Tue, 22 Apr 2025 08:41:12 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 516DEC1205 for ; Tue, 22 Apr 2025 12:41:13 +0000 (UTC) X-FDA: 83361640026.02.72CF535 Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by imf07.hostedemail.com (Postfix) with ESMTP id 6C5AA40006 for ; Tue, 22 Apr 2025 12:41:11 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=korg header.b=otd6e5Ys; dmarc=pass (policy=none) header.from=linuxfoundation.org; spf=pass (imf07.hostedemail.com: domain of gregkh@linuxfoundation.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=gregkh@linuxfoundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1745325671; a=rsa-sha256; cv=none; b=LFFfzCM2ZMNGYaYj0w1d5JpRuuF2huKWtqs7uxliNvYholwZCMcXxucaygFvp964XFKJ1r MpfS2gt++Mrqk71eolb45Oc7iWCdYpzzDfrPLyEa9jaG2doER1JpivuHBWH9OZE0bXDMgf f3RDSotsoJSFAE+i6NGtxb7zXyAH7g0= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=korg header.b=otd6e5Ys; dmarc=pass (policy=none) header.from=linuxfoundation.org; spf=pass (imf07.hostedemail.com: domain of gregkh@linuxfoundation.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=gregkh@linuxfoundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1745325671; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=85+9uw+DwmxCaSchvTRrmxO1kHAfRFYvz2cRUZ6wB9U=; b=LNAfiNkZpIwA/WnMh21Tm70sB8GGBSmI+0CmBIHgDAFAWeKWD3l9Q/tJjLmiRO6S834yvW 9c3lmJHyEWL79y3iySJMCCJuO7Z9UGxLghYUKJlTLD2N8Q8FHXdCdA7jtev96WuLM8nYu0 CXFV1UDiFYQ1D0qrEscKSkb0+gynhzY= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id 973D5A48BA0; Tue, 22 Apr 2025 12:35:42 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D464BC4CEE9; Tue, 22 Apr 2025 12:41:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1745325670; bh=ENlVpz1R0ydeUX54tZxVjiNShAhqfRuCsAD0fBLLqO0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=otd6e5YsdFfGHc4WlklLQ4brQ93YhU3GwS6bmA8Q8590+XD5u/meJF0cN6FfXMwui k7qMTBJKepEuTkiw6medbAp/W3cyNcknKg5K53GWgFkDBGSK18ibQgOqN/cE+X/IUj OHPeWq06jpk+ir0d1aJe8y/fLZx8AG80KwFfBJuc= Date: Tue, 22 Apr 2025 14:41:07 +0200 From: Greg Kroah-Hartman To: Qingfang Deng Cc: David Hildenbrand , Sasha Levin , stable@vger.kernel.org, linux-mm@kvack.org, Zi Yan , Johannes Weiner , Brendan Jackman , Michal Hocko , Suren Baghdasaryan , Vlastimil Babka , Andrew Morton , Liu Xiang Subject: Re: Please apply d2155fe54ddb to 5.10 and 5.4 Message-ID: <2025042256-unnerve-doorway-7cb7@gregkh> References: <2025042251-energize-preorder-31cd@gregkh> <2025042237-express-coconut-592c@gregkh> <7bf68ddd-7204-4a8c-b7df-03ecb6aa2ad2@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 6C5AA40006 X-Stat-Signature: gcup3qt8x9t1ny9q93npyb4cpkidmt3c X-HE-Tag: 1745325671-369974 X-HE-Meta: U2FsdGVkX188r91X1exn+UjjAB3wvgpPUZvQ7jxfEHfT+KppRw8/PFd54LwRbOVSC9E0AdN14OlHvm6V69LcpOatoFPbaFKc5Lq+kayciB+d+YheXaAAmEOBEQ8oD/kEtv8SZzx1/NV5nQcFj2MglA3YYvP1Ma1FZVIARSRuz4922vWeJgOOgSZynU2+cq6/gHUGy5NpFmwXiGkI8kMlvg7/JWQ4h62NU0x06rMBhWqqdlvZkDoL2OSGK23XQR2IbJliuS3FnrK69xzEVDMvtY1BR/oiF3P0yeWrpdTljxyElJGlYYXftYFveUr9ptB9ROeKXXlCdR7iTwwSzASDdq0b8L3NaOU8wILLV8muxt/7N4spQb0bHKkzXnBYpwHO1NA3hKjh4XCKQAx4t2xLfgfoNOPHIrA/bPvMdGZhuD/SWl/gjeoehl+8RlNWBlju4WK5njE/iWcqJB5tpm14XIOq1VOCnATKIiUpQHtTxNFaSgmEt+W2iDU8oVKMfGWo4cGHWfb/UL/R1AhbfLHeGxqfB6dvE7auXzrEbqwG9MB+H8pjYeC5zZgltQuXO09j7mv8sjRELWbpixgXFO3eFchorzSnKvTtuZ4swCMB1Zjb7oC1FgBKVfaoEw0GRGy/RinKvE35LKPKIIg/VgnuLuZlsd9slBD4VXmZYe0ENRsT/9bA/y8xrhzydIsC/0FHTqoRjypDJhFO1l7RdXzXNxnpG0v90bVJPrn3rkCypUbxz/iRPfn1ctw+UooN7wTPeohx3pVfGMLpEbaILjWYBzsTORIoMQXlk2OppOMaJifkNF5UV096j87lzqp5hX5XwCBQKdD6LNq3s659Jzv8J7jbSPt2iAlcjP1rbyDyeXfiwRX2+QhtNMMRcrQW4ztgkry78lgU8d/dJZejritxZRX+bZNVNRJ6PqHj5saxi06/NQJJiB6NB46INob4IAibCqqwVYqnNxdJUGDF/Re hzZuAFsn XT3F1WHIrAIoterqPofPyJbJEe0P59VMsoLGo1bCFhR4t/OAoNaQ2vhCwbitVKmp0IC6jPfOtua1Uw4lOjxJPpE2TjebqpJNkYj3rtRuIlayeF20jCpeZ4ZPp/zTSZsQ8tgjg34czyKvqdw6HAWFQwtKuBy4CzrvNHpojgYmZ7XIsAF5pKXUUNxblj7R0FgXvqLPjEkL/4ZPmZjGx3PCtgrzGHppKz4b+Z/5AZIHF7bLuB4gaFQtILPf0o/nCXFIXkHN9fIyr9jTF7IYUn5M3YVaWLkHCRnu9tp1whv8fmgW+37lRH4/bHn0l4BPBtGEx2/WHDTJVIIpXEfQBOhvZKE4f631gtF8WA92Zd3PSuUdCMDQXiIKJKs+TwQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Apr 22, 2025 at 05:58:26PM +0800, Qingfang Deng wrote: > Hi David, > > > On Tue, Apr 22, 2025 at 3:04 PM David Hildenbrand wrote: > > > Let me post it again: > > > > > > Please consider applying d2155fe54ddb ("mm: compaction: remove > > > duplicate !list_empty(&sublist) check") to 5.10 and 5.4, as it > > > resolves a -Wdangling-pointer warning in recent GCC versions: > > > > > > In function '__list_cut_position', > > > inlined from 'list_cut_position' at ./include/linux/list.h:400:3, > > > inlined from 'move_freelist_tail' at mm/compaction.c:1241:3: > > > ./include/linux/list.h:370:21: warning: storing the address of local > > > variable 'sublist' in '*&freepage_6(D)->D.15621.D.15566.lru.next' > > > [-Wdangling-pointer=] > > > > The commit looks harmless. But I don't see how it could fix any warning? > > > > I mean, we replace two !list_empty() checks by a single one ... and the > > warning is about list_cut_position() ? > > I have no idea, actually. Maybe the double !list_empty() confuses the > compiler, making it think `sublist` can be referenced out of the > scope? That is odd, are you sure this isn't a compiler bug?