From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5BB8CC369C2 for ; Tue, 22 Apr 2025 08:01:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9F7196B0011; Tue, 22 Apr 2025 04:01:54 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9CC4D6B0012; Tue, 22 Apr 2025 04:01:54 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 86DBC6B0022; Tue, 22 Apr 2025 04:01:54 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 657536B0011 for ; Tue, 22 Apr 2025 04:01:54 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 58180C6200 for ; Tue, 22 Apr 2025 08:01:55 +0000 (UTC) X-FDA: 83360936190.08.69EBB44 Received: from fhigh-b8-smtp.messagingengine.com (fhigh-b8-smtp.messagingengine.com [202.12.124.159]) by imf03.hostedemail.com (Postfix) with ESMTP id 313FF20002 for ; Tue, 22 Apr 2025 08:01:53 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=kroah.com header.s=fm2 header.b=YDbgCm6+; dkim=pass header.d=messagingengine.com header.s=fm2 header.b="bvuw//Zy"; dmarc=pass (policy=none) header.from=kroah.com; spf=pass (imf03.hostedemail.com: domain of greg@kroah.com designates 202.12.124.159 as permitted sender) smtp.mailfrom=greg@kroah.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1745308913; a=rsa-sha256; cv=none; b=A2bZ5SShyO57/49iO94h7BD1mDwtnmTEH9ALRII81t6wTfuTdeBELyzfiHWUcYPJ5WyZPe nXyJLe8dy1VP/6tQIIP6wwlCCb9WXB2ZPQ7A4c7qTiQNhVmktuMZBgQ/duBQnm2dX7fM/O rdK48ZJ63eknjGQDE5nRn2BL47EPDCU= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=kroah.com header.s=fm2 header.b=YDbgCm6+; dkim=pass header.d=messagingengine.com header.s=fm2 header.b="bvuw//Zy"; dmarc=pass (policy=none) header.from=kroah.com; spf=pass (imf03.hostedemail.com: domain of greg@kroah.com designates 202.12.124.159 as permitted sender) smtp.mailfrom=greg@kroah.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1745308913; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=KqQ0xwRJH+edSDFf5TaW+/HsSzh0Lt8XI37stcalce4=; b=3bb1jLbH9ATPLj6tbBtnSnYSC9a6L1P70dS2VAX3w1G2iNpV3k19r9brnxuLSVK3513OPp 1u3JzERGg5fHdiPkTl3SXvjPaLmPjWcMtuJLtsaN7qAeBqOUAyhhhA0eggKQd8hxH9rhxv yG/7T773Pj7jPmr+9vfiVBzKL06qy1c= Received: from phl-compute-04.internal (phl-compute-04.phl.internal [10.202.2.44]) by mailfhigh.stl.internal (Postfix) with ESMTP id E3C8725401F8; Tue, 22 Apr 2025 04:01:51 -0400 (EDT) Received: from phl-mailfrontend-02 ([10.202.2.163]) by phl-compute-04.internal (MEProxy); Tue, 22 Apr 2025 04:01:52 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kroah.com; h=cc :cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:subject :subject:to:to; s=fm2; t=1745308911; x=1745395311; bh=KqQ0xwRJH+ edSDFf5TaW+/HsSzh0Lt8XI37stcalce4=; b=YDbgCm6+wYECGRVGJlHR/44zQZ 3wPb2ql4zEMSiE80mMeMvw6EBNgyg8XXU9uxyN3O0udcSD0vfVIHy5LucRPv1MMS qTNd1iar2jkAGJG4fJF+1spyVF0+Xab08BOlvtilbBWVvF4O28QRqn4y9GODJSHm 5bZvCr/uf2OQ0h3uEMWDo4vKt5zPMK4sMbhfCTTVDwJZDtsG1ysdvLxkTnLeQAwK zF1jjipF+RBCCKjk+10XcdvTybdRT3Auq2DjaPF8HnuLRXvHpwnZN8QZhlhUi8Wg odzYYBQp8aTwFVhgFY+JsA1pwTOBbcEweHLSARwlvsWcZdIUxpMRIebh2+wg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t= 1745308911; x=1745395311; bh=KqQ0xwRJH+edSDFf5TaW+/HsSzh0Lt8XI37 stcalce4=; b=bvuw//ZyoSLI02TAQDKdocsbYfdRrMe+SRS0b9TbTTUusvmZvbD g5F23TqJ4Qd3b/6Rzz6xJXIfWLDvxRyHpJjPPtWE1Z82diIrFKnyXWB1PaRPu3b1 9/fZWE91AiW0sH4aZ8HI9IRITtGvjpsHXMQbUIoU4NMcDizLXBiWqd7u/Ou9qJ7t I4D3ZPsTfA9QPnMpYe/rWgy673tXNFCBvkx13oHRvecZqIF2MF5boTtziz+EDuEg 7WcSS59gF7KQBogNbTuWRpN6bhpcfMbuSxFzNnOaX+KqvRjCuL71oYb/TWaX/ezy wCSLtAQMmIomYJetQLSNr1lu6gn3yAFh9uQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefvddrtddtgddvgeefudelucetufdoteggodetrf dotffvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdggtfgfnhhsuhgsshgtrhhisggv pdfurfetoffkrfgpnffqhgenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpih gvnhhtshculddquddttddmnecujfgurhepfffhvfevuffkfhggtggujgesthdtredttddt vdenucfhrhhomhepifhrvghgucfmjfcuoehgrhgvgheskhhrohgrhhdrtghomheqnecugg ftrfgrthhtvghrnhepgeehueehgfdtledutdelkeefgeejteegieekheefudeiffdvudef feelvedttddvnecuffhomhgrihhnpehkvghrnhgvlhdrohhrghenucevlhhushhtvghruf hiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehgrhgvgheskhhrohgrhhdrtgho mhdpnhgspghrtghpthhtohepudegpdhmohguvgepshhmthhpohhuthdprhgtphhtthhope gtrghrnhhilhesuggvsghirghnrdhorhhgpdhrtghpthhtoheprghlvgigrdifihhllhhi rghmshhonhesrhgvughhrghtrdgtohhmpdhrtghpthhtohepghhmrgiihihlrghnugesgh hmrghilhdrtghomhdprhgtphhtthhopehsthgrsghlvgesvhhgvghrrdhkvghrnhgvlhdr ohhrghdprhgtphhtthhopehlihhnuhigqdhkvghrnhgvlhesvhhgvghrrdhkvghrnhgvlh drohhrghdprhgtphhtthhopehlihhnuhigqdhmmheskhhvrggtkhdrohhrghdprhgtphht thhopehsrghshhgrlheskhgvrhhnvghlrdhorhhg X-ME-Proxy: Feedback-ID: i787e41f1:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 22 Apr 2025 04:01:51 -0400 (EDT) Date: Tue, 22 Apr 2025 10:01:49 +0200 From: Greg KH To: Salvatore Bonaccorso Cc: Alex Williamson , Milan Broz , stable@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Sasha Levin Subject: Re: [PATCH stable 6.1] mm: Fix is_zero_page() usage in try_grab_page() Message-ID: <2025042243-glider-refurbish-c0d1@gregkh> References: <20250416202441.3911142-1-alex.williamson@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 313FF20002 X-Stat-Signature: q3stw67o3iq7x3uptrkymc1t6az3faba X-Rspam-User: X-HE-Tag: 1745308913-879707 X-HE-Meta: U2FsdGVkX19J6rRL8JAedTJfgRUVT9GezfesrxK8XPxOMud1WhCQpKeTUgPNt+FIodxfdZUMGFw5kixz8OLc5MKknMDXpD91sg78vJKckZcv0aGQfjchydTU4LSbRXa9r/qW4+af4exux7/108p33U6ulIgmKj22p57IJi34+HxIubcpMXDTbTB7RHNmratSVsQqsMXNeGSp6FDfRMjUE5FrI6KmInQWk95gM1q4Hu4dhmYdqUuoVGwhnNnQhhmipr76oviPCb3ZZLz175vMScXZniBTMzVvqA4CIlVPvRhdl8UCxoFmYTRe+2lX8uJwp9mKGEVKjKO1mwzUqEoFnAzJpPw0qivA65qL7VXStpW1CSlvgdOfiNYV4hxanLVSuMf/Cb1Q3D+jzcFIX3D3En8KsqRirPGhHh3vYfdsGM77c05LMsCpAnAZ74UDnSRIVgL2ozta+y43aKShK1qGE/3LLiGkGGF3fflE4QUscgLjVy8z/wX7sDjOVHl6XLJI40ttXCa6I+wrDFkAHtw6nu5pahC0xhTBfuinibUQf7uSOSb0hwNGyESr3rd5fBntd78+kG+DeqU9HL8kLK4IcmNl7XnakOWdor/H1/rvDyeajP4phZgrXcmWJTJg5sKe2cP1/O/F72+/HbTH6vunVEsPmR/MZ31RlF3s8BbFqpsr9DHSMjs4q4nrQUNt0iPAfJCV+b2W5k8k4OyNytf9NvJIMiCbzKSesIx6GfysxhvlNraNVNeSj1mks3WxmKgVMLtP1gK71etwc5+zwrWoxy+4C/A3aX6WcFuK58evfOGrEbzD4dL/0CsgzjDPXW+/MIhohYfSQkeDEMoZRePqALHFPPJtfZWRJAA6mCHufn4mueO6CmsNwmi/IupAmSor9JcyMSt4mpurImvG3Qguq2JfSp5oDiNdh9bNJFstDDZnLqI27bwuLf0iueslOgDUIGEt9Rwjm966O2DfAyW 29K5Ic9z vZ6lLIeJa1fjFQy13v4g6+Vz0DPH3doyXps6zvI6tuxYptgfpT9pBgPYc1xz0fHP4UrXNwt16G1/isCrpKYsBu8VzjKb2flqw7Yvv0a4G4Qd00Ht3QiIfeyX4MUlKAvUpSDcNVDVnJyr+70Mos1iFC38DOHrcyfnmxQvYMvHSBfZsLt4NVpl0K/+lh7ZUH1vBBKX0/4LXpBSc/MSCZxajuxlLmDaIzwJ7byv1Rgmvc/BPCU3dW671jppJJyg1f8hz7f9XTJhWC6zY9U//GxFtLEdX0shB4/Ubmb6czNpvgxgnHT/S+X2eL9AaPR2h/G0hZx/suNLq7OqM+UGf2uQgjRuZKK65877BT1Hz7Ln2O8ytDWde64xEv/QUqq4Mnc6AmWonk7vZrnbHCMRziuqu2dzktMjQWaiINLe7W+hcbjS3FLpdzHgw4W9zYTRvXqnxvU4qWFY1nEYnnPxap20dr+AbjcdqFoLY8cK+6duj3Vz9ZHlnWgADLWexMOn5Jl47fVI9sSUk7sfvRCOM/b81hdyUhhP7GOxqo1OITaMHPlZ/qpU= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Apr 16, 2025 at 11:49:24PM +0200, Salvatore Bonaccorso wrote: > Hi Alex, > > On Wed, Apr 16, 2025 at 02:24:39PM -0600, Alex Williamson wrote: > > The backport of upstream commit c8070b787519 ("mm: Don't pin ZERO_PAGE > > in pin_user_pages()") into v6.1.130 noted below in Fixes does not > > account for commit 0f0892356fa1 ("mm: allow multiple error returns in > > try_grab_page()"), which changed the return value of try_grab_page() > > from bool to int. Therefore returning 0, success in the upstream > > version, becomes an error here. Fix the return value. > > > > Fixes: 476c1dfefab8 ("mm: Don't pin ZERO_PAGE in pin_user_pages()") > > Link: https://lore.kernel.org/all/Z_6uhLQjJ7SSzI13@eldamar.lan > > Reported-by: Salvatore Bonaccorso > > Reported-by: Milan Broz > > Cc: stable@vger.kernel.org > > Cc: linux-kernel@vger.kernel.org > > Cc: linux-mm@kvack.org > > Cc: Sasha Levin > > Signed-off-by: Alex Williamson > > --- > > mm/gup.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/mm/gup.c b/mm/gup.c > > index b1daaa9d89aa..76a2b0943e2d 100644 > > --- a/mm/gup.c > > +++ b/mm/gup.c > > @@ -232,7 +232,7 @@ bool __must_check try_grab_page(struct page *page, unsigned int flags) > > * and it is used in a *lot* of places. > > */ > > if (is_zero_page(page)) > > - return 0; > > + return true; > > > > /* > > * Similar to try_grab_folio(): be sure to *also* > > -- > > 2.48.1 > > Thank you, with your patch applied one test VM with a PCI passhtrough > configuration start again. > > Tested-by: Salvatore Bonaccorso Now queued up, thanks. greg k-h