From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 13439C369C2 for ; Tue, 22 Apr 2025 09:02:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2D2F96B000E; Tue, 22 Apr 2025 05:02:31 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2808D6B0010; Tue, 22 Apr 2025 05:02:31 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 146906B0012; Tue, 22 Apr 2025 05:02:31 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id EB46E6B0010 for ; Tue, 22 Apr 2025 05:02:30 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id E18B8121AF6 for ; Tue, 22 Apr 2025 09:02:30 +0000 (UTC) X-FDA: 83361088860.20.2937E4A Received: from sea.source.kernel.org (sea.source.kernel.org [172.234.252.31]) by imf10.hostedemail.com (Postfix) with ESMTP id 00439C0009 for ; Tue, 22 Apr 2025 09:02:28 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=korg header.b="SZ6lwXp/"; spf=pass (imf10.hostedemail.com: domain of gregkh@linuxfoundation.org designates 172.234.252.31 as permitted sender) smtp.mailfrom=gregkh@linuxfoundation.org; dmarc=pass (policy=none) header.from=linuxfoundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1745312549; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=cFqJpYM7EFnXhX9E/eOcYc4ACr5iYOnrUHT8WYI+/hY=; b=rVuS56ZQqhzu32MdQQzEwBIoEtpIZKqxX4V3V8jJvkoFxHSKVHyCnuPfBz5aYhw+RvY88N cTqK5But5hgKkxPVdwTjkOkqcWq6/XJ5VQzcXqngxm2COv835FDQiHsrxl4EzyPSgtgCVS 5mjanGGiidJhkRG7yXtyYb6iOBNlFfE= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=korg header.b="SZ6lwXp/"; spf=pass (imf10.hostedemail.com: domain of gregkh@linuxfoundation.org designates 172.234.252.31 as permitted sender) smtp.mailfrom=gregkh@linuxfoundation.org; dmarc=pass (policy=none) header.from=linuxfoundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1745312549; a=rsa-sha256; cv=none; b=HBYJeW4bNn/QSdX/BAuk42wLozx7hTeRPXO+LCP7743L6JWnAG03v9PmxkKojJ3/ehaskP bHd6Eb9Fri8oEqig3ZGIwhFYbrMGJAPrpXAZdsL7I514G6OG/a3++TPu0YS7+7GXi7bH52 WDaUbaRu9RJd476HYJ/M7yAF/7CuzJc= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id 1C69444D46; Tue, 22 Apr 2025 09:02:26 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 24904C4CEE9; Tue, 22 Apr 2025 09:02:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1745312547; bh=qTr4Ac05LQnHgzizBYQnu49EnPG/qH9ZJjPq3iyD4ns=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=SZ6lwXp/1YWM/2hbYj3MtD8X2ELpfnNblKf6yN1JxucZyiZIHOsKfs8gsio/JLslU Rj1IrbekAZ+vCf/FiktSA9HeyFiMD62TewAjJfU2GrBSsgr6uW5utq0YhNZw+msy4S ofdV3wxYtdfVVrkKkdMFuSWPZUQFos+MH1FWcE2Q= Date: Tue, 22 Apr 2025 11:02:25 +0200 From: Greg KH To: David Hildenbrand Cc: alex.williamson@redhat.com, carnil@debian.org, gmazyland@gmail.com, linux-mm@kvack.org, sashal@kernel.org, stable-commits@vger.kernel.org Subject: Re: Patch "mm: Fix is_zero_page() usage in try_grab_page()" has been added to the 6.1-stable tree Message-ID: <2025042218-convene-heat-a5a8@gregkh> References: <2025042238-applaud-postnasal-ee55@gregkh> <9aee6ca3-1775-40af-88b7-506a94b96fb9@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <9aee6ca3-1775-40af-88b7-506a94b96fb9@redhat.com> X-Rspam-User: X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 00439C0009 X-Stat-Signature: ccutin7qixktwx44h71jtdcdwcwjp496 X-HE-Tag: 1745312548-696256 X-HE-Meta: U2FsdGVkX1/TGViK+PEGyHqbzmnjH6nYbHJaHOVgxbhvi/VDOy+LftZDmTH+imIHviQWlO5YQnVCbNalZb+UHRBrZ9E02ShxLvqXhX+9tuqF7W4lsm3u0mkSxdHkbpIKtNkeBKtKApR34ZY3FC4zNCqVHXzU+uyEBMoU4IySEwNsLSW0UvDH9HbP7R4MthZ0FUerfGLZVN7YUuO3DkgmuLi3+7UXBUuUYLA0jdIcqmHBXlATTVKruI+IHF2h4WPCdcJvOVmvCmuT1acsmWjsapfKi7lrhOV6yc+oFWYyq0qtmTQraUREw19ulL1HuYb5W1B8w/o5j5G2AVRwwzI4LfSyccnvvLVoe7GT4sLIMqZiVCrZo1el1G9SMq6a6DgBZBsx7U5Ycn0C2yljiG/xAZy6xQwpA3DfwqXjclfyD4Oy6raButuPVs2U3b6ZPynOkW7Rj+jaMxVKnIpO/gzW3FjJZUejoT3pk9fXKbdFyjtHs5p08MVFiZJp2ubyvjfwzvAVynylHqK17afu2xs0snVOenJvDf0MsAq/sLRbkJjkUftyXS6+h97DJK5oc6RJZh+D6SRG9+jkqcLRrk4IVY/gRbFzgCRCTY7a9UeTjVmU+zXSTRNV1YYX28lDvgAexFmY7N7ro4DmX0VjKmKpcsdLn0G7otm0mwKA0VgFqe7/HaR/pIKipWPMnzLpcD7AW4rwFh8CSFpsE8etRo+zrT6HGAbHGVluMBDXk3LtALjDq5WmZcjEzoksUakYd2Ge8PbpKB0ltGHBbUiiSzuUCNYKUjH2eXHX7Wn3ov4u44laT1g/6GbO+fy3/Lok+u38UM/UKIxdgzdF3IV1c6PCgD0x/bAnXGLnQU28N0waLHRXAMRuQmPnp6nU7kux0udeOPlQV4W4YCq+D1OCv6uH/cUnZQZjwNPLWaYqgk10KgNgT/bJv5xHfU9gcuL7qFgdoP17kJnRv1Mky21kKN+ wYh3DEYD 2LoehypWbBv1eykPSt1cZ2KdYwzXWDMrJoprA3Yw/LFhOV2CV82442Bwhzy19nKsYCLrMxxzq68OI6TUcyPP5ljWJh994TpY0k0mfucTdA+aRX9d7+ka5z5bhJHd7jtxYyvG/YGsSzvfMcoWqDn4kyZVnFCGSaaLelnrsM1WTQEfrRS5NuW1GNtsraFIe/6mzg/uzt7pHl0q4PVWkcjw0ToSUTwNwQ8i9O3JWum59dfIGwKn4FXC5uM1Ys4bsgGE3nF1o9LifDmej0k8ujXqR0EFfJ0+/9zi3AslhJHr+RVJcp1lE5AioMg7WETIDQt4FkWZOSOXKjFlhwZ0Y+qKybUshBsvqzjF5R58xqW9qiByfiztVcB4zY5AhBF+tHQbsgS3n3OzQe8LMAuAvs6tBfe0++bJK5Yy/8tF5NcM+XFuy+XZIWodBtzAeepfBvbjZib+n/0sbpQhsMu94md3N2h1ajaM1xZHthP+/VfPkbpgcczFMCKPgShnezRx+bO1wXwkQAbjy25L0f3D93bHsCz//U6ye43QgR8IaDj4J9EtB2ChGcVjwaYWjHcrLnOub5+j6nMCW9iX2SWE= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Apr 22, 2025 at 10:47:02AM +0200, David Hildenbrand wrote: > On 22.04.25 10:05, gregkh@linuxfoundation.org wrote: > > > > This is a note to let you know that I've just added the patch titled > > > > mm: Fix is_zero_page() usage in try_grab_page() > > > > to the 6.1-stable tree which can be found at: > > http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary > > > > The filename of the patch is: > > mm-fix-is_zero_page-usage-in-try_grab_page.patch > > and it can be found in the queue-6.1 subdirectory. > > > > If you, or anyone else, feels it should not be added to the stable tree, > > please let know about it. > > > > > > From alex.williamson@redhat.com Tue Apr 22 10:00:53 2025 > > From: Alex Williamson > > Date: Wed, 16 Apr 2025 14:24:39 -0600 > > Subject: mm: Fix is_zero_page() usage in try_grab_page() > > Cc: Alex Williamson , Salvatore Bonaccorso , Milan Broz , stable@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Sasha Levin > > Message-ID: <20250416202441.3911142-1-alex.williamson@redhat.com> > > > > From: Alex Williamson > > > > The backport of upstream commit c8070b787519 ("mm: Don't pin ZERO_PAGE > > in pin_user_pages()") into v6.1.130 noted below in Fixes does not > > account for commit 0f0892356fa1 ("mm: allow multiple error returns in > > try_grab_page()"), which changed the return value of try_grab_page() > > from bool to int. Therefore returning 0, success in the upstream > > version, becomes an error here. Fix the return value. > > > > Fixes: 476c1dfefab8 ("mm: Don't pin ZERO_PAGE in pin_user_pages()") > > Link: https://lore.kernel.org/all/Z_6uhLQjJ7SSzI13@eldamar.lan > > Reported-by: Salvatore Bonaccorso > > Reported-by: Milan Broz > > Cc: stable@vger.kernel.org > > Cc: linux-kernel@vger.kernel.org > > Cc: linux-mm@kvack.org > > Cc: Sasha Levin > > Signed-off-by: Alex Williamson > > Signed-off-by: Greg Kroah-Hartman > > --- > > mm/gup.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > --- a/mm/gup.c > > +++ b/mm/gup.c > > @@ -232,7 +232,7 @@ bool __must_check try_grab_page(struct p > > * and it is used in a *lot* of places. > > */ > > if (is_zero_page(page)) > > - return 0; > > + return true; > > /* > > * Similar to try_grab_folio(): be sure to *also* > > > > > > Patches currently in stable-queue which might be from alex.williamson@redhat.com are > > > > queue-6.1/mm-fix-is_zero_page-usage-in-try_grab_page.patch > > queue-6.1/revert-pci-avoid-reset-when-disabled-via-sysfs.patch > > > > FWIW > > Reviewed-by: David Hildenbrand Thanks!