From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 67879C369C2 for ; Wed, 23 Apr 2025 00:02:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EF71B6B0008; Tue, 22 Apr 2025 20:02:12 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id EA6036B000A; Tue, 22 Apr 2025 20:02:12 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D6F296B000C; Tue, 22 Apr 2025 20:02:12 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id B072A6B0008 for ; Tue, 22 Apr 2025 20:02:12 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 578761D1032 for ; Wed, 23 Apr 2025 00:02:13 +0000 (UTC) X-FDA: 83363356146.07.756D96E Received: from sea.source.kernel.org (sea.source.kernel.org [172.234.252.31]) by imf23.hostedemail.com (Postfix) with ESMTP id 7697C14000A for ; Wed, 23 Apr 2025 00:02:11 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=mf6qzicp; dmarc=none; spf=pass (imf23.hostedemail.com: domain of akpm@linux-foundation.org designates 172.234.252.31 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1745366531; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=eHjU4+GJp20WyG6SwdNuYIhAmppmjMy4D6YK35QaclQ=; b=6kQVRMeZVrB5KWIzIEU7qreyyL6cq+izv2MgHExmimEkJrE3j1h92IntPPWnxbXmYHGqvb ifUzKTz2ZrOu5bGsiPQ7ZHqGqfMK6A1JifM0daj1F5JdcdACqj1FzRUpWmQXSdTH0YxQP3 LkkjIAilzx261Fi665DDwmR6O/Co4Io= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=mf6qzicp; dmarc=none; spf=pass (imf23.hostedemail.com: domain of akpm@linux-foundation.org designates 172.234.252.31 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1745366531; a=rsa-sha256; cv=none; b=urRvhtRD2amTWikHjE7DlppAewc/j1AQ9AAmTs0wTQwOTq2ICxCGiu0I//VtA3QJGiDKPB urtR0R1ioSe8m0fIYB+jr772vi67oKgtipwB8yJWNKJwi2vafIaqYkkBFnkUeovosFaFkl S/edrAKQn+YIClVAEwzYTUSxljxp/Uo= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id CB99D49E95; Wed, 23 Apr 2025 00:02:08 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DC797C4CEE9; Wed, 23 Apr 2025 00:02:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1745366530; bh=eDpmZr/W7abK7TOh4z28CqdS8NP76IJiT9pe9JH2vXI=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=mf6qzicpbC9BTF5qV15mgsETGid3iwB043YrvY5wXyQ3VMQWVvGsxytWIiFFWCnsu f+b5e9vNnD2VJ+4t7WRjmT6Rn6urKLHlv7QQocxdpKXx9fEh6yiDsDOBVXL0r4BhCQ DYPpMaUcC5mnEwgvbCGlBgUQGJrU6jMdV5VaskUs= Date: Tue, 22 Apr 2025 17:02:09 -0700 From: Andrew Morton To: gaoxu Cc: Dennis Zhou , Tejun Heo , Christoph Lameter , "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" , "surenb@google.com" , yipengxiang Subject: Re: mm: percpu: increase PERCPU_MODULE_RESERVE to avoid allocation failure Message-Id: <20250422170209.a8beaa8a3610d2e92421476f@linux-foundation.org> In-Reply-To: References: X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Stat-Signature: pq3tojxyesdff75ryidr4prmf4a4erae X-Rspamd-Queue-Id: 7697C14000A X-Rspam-User: X-Rspamd-Server: rspam05 X-HE-Tag: 1745366531-486127 X-HE-Meta: U2FsdGVkX18DrCixHMHjloI/E737f16o/eYn7FL3NGDODrm6roBk5ybKr6tVinXQN4C/QvYBsapz/7lXixRjJdsms5PNM/Ou5koWLXg3iQN6AFqkFHtV8MZS1IFCzjea5T2CBMzqizZ6E4ayKaR1do/kbNSf3KlREOjOJtTHx4TXSAJi0v7HGYuzCq7i7KgTVNiLRqvap6ggDPAayueqdw3GV4y6iOCeFh5+7AHLXRCQ/zoWKRcyY36lXd/LwzBq1YNPwMx1xVIDDdcEWN8OxhIbbZpp3PWDiZBH9tAUw0wRTSo7OUaJ7tjApHVgh57lnyy4RSdMu4jX5+cKEOu/6MH+2ZT9o3gJ0d+0WbIonl1mOpvI3dg0Y7QCIZ0eoYRoSdgOunHoq3Gejp9yLWlnff/Q5TE72Eovx3gfKy/7fjqb805F6bOH/3opL71OJLtHGzgNKV2pBatYrzL5TGbvu6I2q6KHylkUkgDEZTukI9gpHdhIi/LnPDSUZ16pQ/s2sciX1cGPgGNZpEMY925JLbdQ/32/h9hWtmXae1p4uVv9rhRPk2Qya0L8Luc0nKHYoeUwndqyafIfMp3NxtPQRQSG+RI9ieECeRttcNFwpJwGzw470VgZvoDzNzvd3Q23oQ6UrTXWa5pX7GLHkDS+2e1DcwGFQbkZBrillnDMO4vt182Ql4TUOv8o0ZdiUQsBUJn3Q0rLR6pWMt5CSb+DZ3Ue034kx76qokGDGqLd/HXv3Ba9AjmzACiV5IGwauZsYLtjWWxQsCpBiWXLkrqaKGDFcd4KjwZ/Pwq+cwHp5lIsAxWE3o3w+btmzq8eHS4Grt0+kyr8x0qj2t1Qp8Ynmrg1KOK7mJS9bSvyWZlF2Bn2xOI4STqO4GN8IaNcBhX8MJNk2f5QSRgg8yuCte7+JbgZJJm5sohZrTFzdIhZR3HbQ2BBcz0c1N49ZVPnHSbQiKRSg95q46GlBQ4RHvz UxmK1z6q eK03s76qsBLqOUqSeYzwXKeA83JuIkD3XsLBqlLwxJoKfYUX9KoHzSZMLIw2oLeUk4tCbaYFyO8vvzMK/xEGXx4ClsxDcxZiVySQBGSDASgLp2tlfJQ3eW7UDfb6SJGy4SUgCGX6kNWXYl5MOgWOBNZS574FgF8cTpGN/0oVIMFpIT8zZXJxhUiiDXZ2kusV4z31SVlsr95IG1LXXu19BBGm8ckcpHWU+9C7tSO8OA0cMev2jUBpJQ2C4y6/656vUA0QwkPcl46H5bE3hO9e7aVd0hVv+LCoy1AX2rm2R4DeSBCBQe0CIanXLI8Kike8nH9PLSSzEQ3pTZYdC3ALf1Wtb9GH6icG2POBysOxw7PEyWkXTdAcibaVA433S+oAHxl7fDfMlf3ZgzgQ= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, 22 Apr 2025 11:39:30 +0000 gaoxu wrote: > In android16-6.12, enabling CONFIG_MEM_ALLOC_PROFILING causes some modules > to fail to load during boot because of failed percpu memory allocation. Which modules? If they're in-tree modules then we should fix this issue in -stable kernels also. If they're out-of-tree modules then what argument is there for altering the mainline kernel? > [811:modprobe]percpu: allocation failed, size=5200 align=8 atomic=0, alloc > from reserved chunk failed > [811:modprobe]Call trace: > [811:modprobe] dump_backtrace+0xfc/0x17c > [811:modprobe] show_stack+0x18/0x28 > [811:modprobe] dump_stack_lvl+0x40/0xc0 > [811:modprobe] dump_stack+0x18/0x24 > [811:modprobe] pcpu_alloc_noprof+0x96c/0xb58 > [811:modprobe] percpu_modalloc+0x50/0xec > [811:modprobe] load_module+0x1158/0x153c > [811:modprobe] __arm64_sys_finit_module+0x23c/0x340 > [811:modprobe] invoke_syscall+0x58/0x10c > [811:modprobe] el0_svc_common+0xa8/0xdc > [811:modprobe] do_el0_svc+0x1c/0x28 > [811:modprobe] el0_svc+0x40/0x90 > [811:modprobe] el0t_64_sync_handler+0x70/0xbc > [811:modprobe] el0t_64_sync+0x1a8/0x1ac > [811:modprobe]ipam: Could not allocate 5200 bytes percpu data > > Increase PERCPU_MODULE_RESERVE to resolve this issue. > > ... > > --- a/include/linux/percpu.h > +++ b/include/linux/percpu.h > @@ -16,7 +16,7 @@ > /* enough to cover all DEFINE_PER_CPUs in modules */ > #ifdef CONFIG_MODULES > #ifdef CONFIG_MEM_ALLOC_PROFILING > -#define PERCPU_MODULE_RESERVE (8 << 13) > +#define PERCPU_MODULE_RESERVE (8 << 14) > #else > #define PERCPU_MODULE_RESERVE (8 << 10) > #endif PERCPU_MODULE_RESERVE is a pretty unpleasant thing. It appears that it gives us the choice between either wasting memory or failing module loading. But I expect that something more dynamic would be a ton of work.