From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 09795C369C2 for ; Tue, 22 Apr 2025 23:41:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CBA046B0008; Tue, 22 Apr 2025 19:41:15 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C421A6B000A; Tue, 22 Apr 2025 19:41:15 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AE37C6B000C; Tue, 22 Apr 2025 19:41:15 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 8F4766B0008 for ; Tue, 22 Apr 2025 19:41:15 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id DDB0D82230 for ; Tue, 22 Apr 2025 23:41:15 +0000 (UTC) X-FDA: 83363303310.01.600F0BC Received: from sea.source.kernel.org (sea.source.kernel.org [172.234.252.31]) by imf21.hostedemail.com (Postfix) with ESMTP id E6B101C000A for ; Tue, 22 Apr 2025 23:41:13 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=phfaszqX; dmarc=none; spf=pass (imf21.hostedemail.com: domain of akpm@linux-foundation.org designates 172.234.252.31 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1745365274; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=CnAz3nAOoU5TL9PQbVg0c0+nLfp42VouMfkJtiI5XL0=; b=lQg2x783kJegKQ7Bw2S2HdFTk8bNOv/4nPVMIIw8TuvoHgPm3uFUG655lkk+0TV5ZcKvld mXoq4JX+ji0UJHhdqC4VK7w70NRA8tIDhglEIoUHR43VaL1F5A9Kt0/cTjjs7NhaBZUmPE EWzMPO40sNavBmZ/j98XIvaa6QfDW9c= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=phfaszqX; dmarc=none; spf=pass (imf21.hostedemail.com: domain of akpm@linux-foundation.org designates 172.234.252.31 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1745365274; a=rsa-sha256; cv=none; b=CLbHtQ79Mk5jpq2hzJyplXpojRLJT2d39gmLAVmDsWLMhOissL+y/AojLsDMj74qnadLWe csxzMbqR+4M1OUidQc0mPDKTlhSQbmu0SZ3thfUfY3NZ1sdSFeDEe20FC8YpAe2Lk7YiIQ PBkKCe9bIPNNDiyv3fnfuEdUwtdA7z0= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id 265084A50C; Tue, 22 Apr 2025 23:41:11 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1EE33C4CEE9; Tue, 22 Apr 2025 23:41:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1745365272; bh=Je+XbTDpM7XoCA2l6SPO6P6zZ4dfGXa2/Zffo3Wvq4w=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=phfaszqXOfy+MdNxac3DKdmP1eHQIAZO+lIpb3jy7JpwOyA7AaqfWXkw7Pjous3Uo 8FhqLlTt+/vVJ/3cQfPoCY1HAJTXxmdHkp1TnYOcE9K7fslPg0U6dFmtOm1uoABexm wNjrbaKaDrwJfRhdAWc3qJsQv/flhqcvVq+IJUUk= Date: Tue, 22 Apr 2025 16:41:11 -0700 From: Andrew Morton To: Shivank Garg Cc: , , , , , , , , , , , Subject: Re: [PATCH V4 1/2] mm: add folio_migration_expected_refs() as inline function Message-Id: <20250422164111.f5d3f0756ad94d012180ece5@linux-foundation.org> In-Reply-To: <20250422114000.15003-2-shivankg@amd.com> References: <20250422114000.15003-1-shivankg@amd.com> <20250422114000.15003-2-shivankg@amd.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Stat-Signature: w5rk45wmmsqizpdnpodngpq5bf186wx9 X-Rspamd-Queue-Id: E6B101C000A X-Rspam-User: X-Rspamd-Server: rspam05 X-HE-Tag: 1745365273-944542 X-HE-Meta: U2FsdGVkX185eOGYlohujMIEh1WhvsuwqHaNGKktoPD1kBPZoZf6YQGvTTJAhFc9CZKHomOTwNjkXy9RsRjUooX3pIo9muZKlTe0YPUL9HhJWMVQmK/4qzONm6yJzJLXqEgrKMP/+wiAfiJDU592Z/aS0CoO2wU/RZcEyO1S6UC5iC/CpBHBqyoaVKL6/2T06y1RfrLcfnjQxTI/1gnOjliMBauVHlqG1ZYKirJA4/SBy8oq4dE5FZTwDpEzdm2660HLNh8UsKSMQTry+oOSkH2B8eNNo4x/o9FMyFhQkahinVjukk0WBrNM1OpKXOROB5TwpwOJRQWgumQomSpqa6Jvvf/AfYYTSuhRJX3hYph0UEfSNfZb549rg9yDXT3yoiIADfOgMGKA7IdVA8iN8cG+voxAmv/0fuRO87OVmqF2Q/2MifRjhZy0xJ86C7DmNX6ZQ8e4uGjlDOy4kDGH7zZzFAMKaquWhyE+jbmZ4Lgm2Rwk/lhaZymTwx8TjimyBQ0nHKRaZ1fCl2ar0OSnOQu1YIdCUPASUJjqsknDIX2j73mhG1MBE9b4BVJBSYitZ9ZKJZupoBNCkDcn8PedMvcdWcQczQkIfRjr0C7V5LdaSbstBQqUbRiO+0j1Eg/IsMNV3Sb9QweUzNgM0ki7AtdlMSoGSDuj2qtOjPLCmluaXejnNbUR77+RTe8UMZyQwsYW226uDXh1WSbfvr6RQqys2/ExoEiZfTIKIOWNHRVD8MUXFTVNNXISK5gQVvWwK3H/3M97bnFlDE62nbyi7ojFQ5Lo9xZr+hmrnaUFMuQOnlLuQQdKRQVpKva5e6i4k5ZgxveIDfUH0cinKg5fWiY1umh3/COKEhXk8Tp2iGZ4Qq90IkOyiUACEmo7Z/Z53uyzt9lntUlBeBbYihwpkF6hXPj+tH0g0hOSOtffR8DIzUN7NeU7cK27aHDibLAdIpF6An0s8pm1OaEbiwv GaBZ7SP3 7zPGaTag9S5x3I9xyrsUnPt+NR/p6prXa05aI2eILm7EZjc95/C+mi/eIAlFkn8Kwc0qrb6XKlqKFHTp9WmxSwifnMXYbv+TbY3hbPy3xGpz3dC1B55yiOVL+HtjE0Cg/KRp8xwP+8cGgfJBIjrrAaWrZnFiRK0sUkhOhmn/yokOTvm+aa/q2Z7/qDxa0134gUadUQ8ZbkZHrlNdsXD7nus42Cc0EBBS2piIkEA1k73Y6yS45Nqlb+teYgLAg+CXYRNcAEfTXoPO4z1kKMNpPsSCCufa3qfbhHoVhN/d5JN4ZV3bN+ASfOg/lE6itrD+pjxD2gXnu862aEbFM+svCx5XebsVJzb7gMivE/a0sHybZUzjoFJCx1nQ97snZrH6aA30WT3FyZ2Pwrdl4y5NP8DoeOna0Hv1eGvHJ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, 22 Apr 2025 11:40:03 +0000 Shivank Garg wrote: > Rename the previously static folio_expected_refs() to clarify its > purpose and scope, making it an inline function > folio_migration_expected_refs() to calculate expected folio references > during migration. The function is only suitable for folios unmapped from > page tables. > > ... > > +/** > + * folio_migrate_expected_refs - Count expected references for an unmapped folio. "folio_migration_expected_refs" It's concerning that one particular filesystem needs this - one suspects that it is doing something wrong, or that the present API offerings were misdesigned. It would be helpful if the changelogs were to explain what is special about JFS.