From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 667F6C369C2 for ; Tue, 22 Apr 2025 23:20:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 842BE6B000C; Tue, 22 Apr 2025 19:20:27 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7EE4F6B000D; Tue, 22 Apr 2025 19:20:27 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6B6C76B000E; Tue, 22 Apr 2025 19:20:27 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 4BE806B000C for ; Tue, 22 Apr 2025 19:20:27 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 4BAFB699CB for ; Tue, 22 Apr 2025 23:20:27 +0000 (UTC) X-FDA: 83363250894.19.C8DE0C3 Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by imf22.hostedemail.com (Postfix) with ESMTP id 8DCD2C0007 for ; Tue, 22 Apr 2025 23:20:25 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=hch8Fpkf; dmarc=none; spf=pass (imf22.hostedemail.com: domain of akpm@linux-foundation.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1745364025; a=rsa-sha256; cv=none; b=hg3rp/m5b8u/5G/dfdP6C6bdwZmRfYd7wiiLMnbIjlcs9D/twgWahQKqmPwPt9WaBQz9Ok QKkO/ful6mLTMFSiEDRbtIqW48zvYDREQVnubsdZ+fjfjSgC3CFEphXddS5nLL5fMxz+9J MaCYYTd9ML4nWdt/eJn52DuaGRkQDRA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1745364025; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=NzFKPPobJv9K6gAn+4dYQceDIYp1Rzg5BfkFkdc0uIk=; b=f6PHJAJ2jtrpmGOwmTM8rAsCipLIMX5o5k8RmwW1gcmB93usskh2c/5rhMuo0KZoApeBzg ope/vvi0U4KnioZ1Duhc0v85nhpnUXSuB4sXHrWimbiWgnn+wzkA7WweRhUz4FhzguOrPh kM1KsoOnAA2Bq+gFQErdj1W1/itkjzA= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=hch8Fpkf; dmarc=none; spf=pass (imf22.hostedemail.com: domain of akpm@linux-foundation.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id 8F8A5A49DB0; Tue, 22 Apr 2025 23:14:56 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 11F3BC4CEE9; Tue, 22 Apr 2025 23:20:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1745364024; bh=toNpLN0b4y+5FtmnTAVhVrQg3drpdjrGHUOUalfpdtQ=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=hch8FpkfcH+q0UkBw/Q2FRvIxZrCtNLLRB56Ll6I77rWXDaMbPcEPaUoYDkEEdoZc H19BGn+tcC5UE/InNCz/1CB3yJMwC0/SrajAaLsEZb2Ghu3uPamh0ZUdAftMQ/TdpL hg3zqx374VgtHATFLsTxw5OtHyW6YOjezZblsUeQ= Date: Tue, 22 Apr 2025 16:20:23 -0700 From: Andrew Morton To: David Hildenbrand Cc: Lance Yang , mingzhe.yang@ly.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Lance Yang Subject: Re: [RESEND PATCH v2 1/1] mm/rmap: add CONFIG_MM_ID guard for folio_test_large_maybe_mapped_shared() Message-Id: <20250422162023.55c4899cfa3486b409289efa@linux-foundation.org> In-Reply-To: References: <20250418152228.20545-1-lance.yang@linux.dev> <20250420162925.2c58c018defee9ee192be553@linux-foundation.org> <641755b75b4ecb9c9822e15e707a0ebf1e250788@linux.dev> <20250421122239.710f5d63487853556cb8f57e@linux-foundation.org> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 8DCD2C0007 X-Stat-Signature: q8gfbmho8c3r9w844htgrau84erqxwwd X-Rspam-User: X-HE-Tag: 1745364025-708854 X-HE-Meta: U2FsdGVkX1/OoKJtvIA51UMrKyrWkLG9h6tqbeUzRLpcVqOMKla/7jrdx9vsnSymuNMaimob1ciz2jl5bfL8ZJVbT+EUVOLQfIK+Eff9eayrAmNMCwjbuExjxi1CzTrL3XdSrjt2VhNkqg5ct3Odt8GWp9s372hlp2ehWm2Gdb0bb1jnluVZyJRP0PNyXU/MCfTVvkxJ0hX2Sb4xE+Ep+lLcjxEXwRCvfylvQe+BSQHlIuDvSNrGPL3Izy92tcsjaojJBwStTMifGTW4j3CKuM++WEaKRByzAOla6p6B17YhPxNnAom2dRP//cixPQ3j836DwUuSuHc47wld+/6c+oVxvN4Whe0K+0GvR9HTnMTsrZCWaWJZTFkeCSIW/EMLnfdkcFrdjwgWfva3Sv6kXab+b6fOnX1WNSOEZb2RBhOUdvXRkpzoPlW/WOwneOy7Om8bCZZ4klL19HbDaO+15yMvNt7Qx0tO5Y0GSiTSgp3bnLh0FiTlCyhN4l8gJl9d2Rj5HQU0QnDC/GHFOKaIBYQ9hJAeIEOjLkAwQ72Ab3o4odgy5SEukjjjI2JlKqCbh/9+GkvjRhg4nkde1whuBeQGbCLh3+n/p/WCjXrJXXz0lbvHsjmJJBICjpzmFypj+rLWVqRzkuCqE+EyC6U1yYEZ/30Oj9LdGIROLZrmjfi7EK9pHCJZh2wCZUzibQi8NBoZ/3yqT1StYpo429NhYO5kXy775vu70dQWRQRSJmFy9o88pmijTuG2etoOyE0KmN8gcA8dALJJLvgNllkggjOuuN4fhJK+gkoreBQVxO8NxEtZQVKX15ntkhxhVExjnh1iL2HDvYHNB18JuvrB/MsoHwz2t8tobwnlfIswXPNjAOjxHDksFM8aERLNiTCanpw1ujLoQVqcSk/Zao2rWo4WiS3bTKqCLUWlH1L+3D7E2g2YMGyUPvU9w9Q0HsLC5qCnniFpUM6aYaqZA/H i/t4qYp5 fkAV3zcDrFSJuFQqbQdwf1XgSJmFFDwmlb5dgG8f6VhuldxyxsE0R7iALOpIAS1b8KxN+Jmt9kF2KiBMd6zdSNd3IrPlN8ZhjVJkMyHKqD5uvk7EYEKnrBrx4QxFlD4t3WPgPD5rLgwrgoYYClJeNeXE3xpt3HsnQBAcFqO3WyfArcz7xBJM0TUCp8UIEy6JfWeP1kbMhFHYnkgC+bBlRnIIrw+vw61Jpo8EXwjenGMax7K9I9hWJyUgL2eHi7SqpKOe4v8or+dd7xRlebXLvWbtQIY78F9lU1zBfRfLNpwnd5gklCNAHDV/GJowowFcOullL X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, 22 Apr 2025 09:00:54 +0200 David Hildenbrand wrote: > > --- a/include/linux/page-flags.h > > +++ b/include/linux/page-flags.h > > @@ -1230,10 +1230,15 @@ static inline int folio_has_private(const struct folio *folio) > > return !!(folio->flags & PAGE_FLAGS_PRIVATE); > > } > > > > +#ifdef CONFIG_MM_ID > > static inline bool folio_test_large_maybe_mapped_shared(const struct folio *folio) > > { > > return test_bit(FOLIO_MM_IDS_SHARED_BITNUM, &folio->_mm_ids); > > } > > +#else > > +bool folio_test_large_maybe_mapped_shared(const struct folio *folio); > > +#endif > > Fine with me. At this point, I do prefer inlining the function, though. The above has the advantage that if the compiler unintendedly emits a call to folio_test_large_maybe_mapped_shared(), the link will fail. I do think a little comment which explains this trick is needed.