From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 11C91C369AB for ; Tue, 22 Apr 2025 01:19:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5DB806B0005; Mon, 21 Apr 2025 21:19:11 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5629F6B0007; Mon, 21 Apr 2025 21:19:11 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 402FF6B0008; Mon, 21 Apr 2025 21:19:11 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 227BC6B0005 for ; Mon, 21 Apr 2025 21:19:11 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id B3E3A1615DA for ; Tue, 22 Apr 2025 01:19:11 +0000 (UTC) X-FDA: 83359921302.28.B4811EB Received: from tor.source.kernel.org (tor.source.kernel.org [172.105.4.254]) by imf25.hostedemail.com (Postfix) with ESMTP id 345DAA0002 for ; Tue, 22 Apr 2025 01:19:10 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=I77RryVh; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf25.hostedemail.com: domain of djwong@kernel.org designates 172.105.4.254 as permitted sender) smtp.mailfrom=djwong@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1745284750; a=rsa-sha256; cv=none; b=Il8V/9iqgE6H6V29ZyOiobwyVjvp4wg02fw2GGZRdgwHUQXMmQ0iobfRVMHh73o1zeuZiq 9AatfHuTQTsAzFfHYvpElLd3eV5lYgBNILNaXKbPOWFWLJTcKPudRLnjIfzVlMMihUwVD+ F9omQ/i3nj/U1CqMLTlAwRe/ZJFmSV4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1745284750; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=5jJNBLV9kIwBJv4hbzvYoehauCZ/J/w/iXgdid2EiYw=; b=0A42uPui7PC4tAuw3hZ3UDTu7SX6aRZAD4mocYnv3qN2HE/psUUXmG6E968hqAVlm9cgnB VVd84bmz7JrW+WoEgF4zLLeKidZiMIhnwOco7TW9p/l5exfYd6JQe4MqIcUbijk9MGSzIj IK9vHbYzjW+kvJ8OKyA7d1UfMfdIzFc= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=I77RryVh; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf25.hostedemail.com: domain of djwong@kernel.org designates 172.105.4.254 as permitted sender) smtp.mailfrom=djwong@kernel.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by tor.source.kernel.org (Postfix) with ESMTP id D27B46135E; Tue, 22 Apr 2025 01:18:49 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DC476C4CEE4; Tue, 22 Apr 2025 01:19:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1745284748; bh=eP9ll7giGUWiL/szu57fjosnt0vGjzvon7UdDIRlSyQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=I77RryVhwIKu8+tKW9NNVt3+RfUNmS3w5F0QEe+CcVq3lY+7Fz5LRkwGYBlpEnU09 7/1wDdRtRNrBkt9DPdYSNxjHFzOvSk3/Vc6WuFI118GmNOAqsmlhqHYG6wfqsLHNVZ SZXU2ov+kNxI8DPd/i7IoUHQQLYEDCct+0dCWiDB72Qq2qS3UjTvmzdWh4rxTvRsUY iSttD1+WwC1WJSv9Un0fkfLshs46Xm9a1zVSuVYLyLtpGOmKRAl9w5Tj3x8rS1pQtG oBHV17V5nnYIPDk3zRkmCk2trCS2dDDdq6xdSYXZ0KxEbW4K2F4BuBC3SFypcKiOCk xQSquRSsu5DeA== Date: Mon, 21 Apr 2025 18:19:08 -0700 From: "Darrick J. Wong" To: Jens Axboe Cc: cem@kernel.org, hch@lst.de, shinichiro.kawasaki@wdc.com, linux-mm@kvack.org, mcgrof@kernel.org, linux-fsdevel@vger.kernel.org, linux-xfs@vger.kernel.org, willy@infradead.org, hch@infradead.org, linux-block@vger.kernel.org Subject: Re: [PATCHSET V2] block/xfs: bdev page cache bug fixes for 6.15 Message-ID: <20250422011908.GV25675@frogsfrogsfrogs> References: <174525589013.2138337.16473045486118778580.stgit@frogsfrogsfrogs> <8cb99c46-d362-4158-aa1e-882f7e0c304a@kernel.dk> <98e7e90e-0ebe-4cbc-96f3-ce7f536d8884@kernel.dk> <20250421205116.GF25700@frogsfrogsfrogs> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 345DAA0002 X-Stat-Signature: 98d4k95gomc1e36qfk5pefgbsntx56co X-Rspam-User: X-HE-Tag: 1745284750-234886 X-HE-Meta: U2FsdGVkX18dXpCI8QWF+RVRQ04X5mWeVEhEtNfL8ri6xQMz/LXIJbYmSnAilTZc/a/7ZjRPz9slHg4VZx+b8Rplij2CM820h5S5q3wQWdJreSnofQaFfkxQn8ueBco5tR889FzYw8v6bBfs5Cy5qEQpjnSsOzYSFfuP98aPzJuSutAnAkC7MokmKyWsZc9DG/llgQYSyQ1i/ts30AviVH9r9tKFkhs3072bMLY9iS6TCjGYcCJvnqlNDahVIkMMG2pj5xpV6d3ofX3X1cjBQ2rrl4hNmkpFLPqGNY80wOklBImfXPMyjzJLkWndwkd+jyk45gMCWxS2jWpQBrYG9rfVo1975A9Srx9KHy7Nz/rpo/e8QlS4xGbMKyhQN5/pTQI6v94+dJv0Xhkx7CDuHz0VOETLr83I97jbKvn1UtDPy375drV/bAM+nMpLvekUrIWq+Jdxs/0QQdUhzlc5iUdnfPNy0CUwt2fH2iWPMMaLfJgPfySmkh/nqNJ5p5o251aCU0EpXjkFP8N1faNVjoWoNx9Xj+/X2uWQpVEaNtW9YBxqr5N+1HmyU1oN1k83zCWvQUyQ7AuiVy90vFrL6XPITVSFWMVhc6HHkvNR7eOUfolcPEOVviJVKYNT6n5iHWB3nVpa8LDHonfCAt4cJoB230f4xmvEVZGaR/4pRwF4apj1UXggYxaSBIi4zHdK9xwytGqWehghVCmGlFcjUODlPwX2AbhMtQ5mfQmt6hh5E/ajpaPuJLTtONpR8Ba75CWS1GZKSLz/m8osSk/XVQxd8YxXlVAxo8pkyp1cmlJpEs72vQ+76ebAQ4ha9TSCFPlqFxVCri8fyJ/XnWlPx1O25k7wyZb9JHPkcK4/w8O/sxcfVbWS8fHjq4TgBlxJ2m1lcUlPzD/ujIouuX+gIpFpE8RLVlkPlUNSWOvMcH7Dzf7+95LzHe5SAXqdpRwcsNT+9vl9vcHw8f+rF5n JeKAIQ7O p57vb841ZVZxeYOMsRjS6XwnuTcR+aj1NGRRy/L0fjG5yNmMscMIQWRI2gvYVBgC9svHuvGKGUQ9o4adyQItfbN27Yrbwdd26KY7qtq4IS4LpbjQ0l+bO6iroxBV8CZRgwerWFGcRVaaNxznYcRaLT8uJs9AoE3fzC1DZ3LPoV/eBsgKmggW7NGAE1IMztb0MziryifFgQVpvdG66jnE6kppLNWRQsINb6WfGEhBsQoxsaKsQfxQURmSHXKn2bNxGmi28 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Apr 21, 2025 at 02:53:42PM -0600, Jens Axboe wrote: > On 4/21/25 2:51 PM, Darrick J. Wong wrote: > > On Mon, Apr 21, 2025 at 02:26:54PM -0600, Jens Axboe wrote: > >> On 4/21/25 2:24 PM, Jens Axboe wrote: > >>> On 4/21/25 11:18 AM, Darrick J. Wong wrote: > >>>> Hi all, > >>>> > >>>> Here are a handful of bugfixes for 6.15. The first patch fixes a race > >>>> between set_blocksize and block device pagecache manipulation; the rest > >>>> removes XFS' usage of set_blocksize since it's unnecessary. > >>>> > >>>> If you're going to start using this code, I strongly recommend pulling > >>>> from my git trees, which are linked below. > >>>> > >>>> With a bit of luck, this should all go splendidly. > >>>> Comments and questions are, as always, welcome. > >>> > >>> block changes look good to me - I'll tentatively queue those up. > >> > >> Hmm looks like it's built on top of other changes in your branch, > >> doesn't apply cleanly. > > > > Yeah, I'm still waiting for hch (or anyone) to RVB patches 2 and 3. > > Maybe I wasn't 100% clear, but what I mean is that patches 1 and 2 don't > apply to the upstream kernel, as they are sitting on top of other > patches that block block/bdev.c in your tree. So even if acked, they > can't go in as-is. Well they can, I'd just have to hand apply them. > Which isn't the end of the world, but the dependency wasn't clear (to > me, at least) in the sent out patches. Oh! Silly me, I forgot that there were debug patches. Will attach Luis' review tags, rebase, and resend. Sorry about that. :/ --D > -- > Jens Axboe >