From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C90FEC369AB for ; Mon, 21 Apr 2025 16:55:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5DC396B000C; Mon, 21 Apr 2025 12:55:29 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 562046B000D; Mon, 21 Apr 2025 12:55:29 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 402B56B000E; Mon, 21 Apr 2025 12:55:29 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 1E7F46B000C for ; Mon, 21 Apr 2025 12:55:29 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id D57251608EA for ; Mon, 21 Apr 2025 16:55:30 +0000 (UTC) X-FDA: 83358652020.09.C72470D Received: from tor.source.kernel.org (tor.source.kernel.org [172.105.4.254]) by imf14.hostedemail.com (Postfix) with ESMTP id 8056C100002 for ; Mon, 21 Apr 2025 16:55:29 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=sjOSRuou; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf14.hostedemail.com: domain of sj@kernel.org designates 172.105.4.254 as permitted sender) smtp.mailfrom=sj@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1745254529; a=rsa-sha256; cv=none; b=qRXyrhslklmZciMWfhAEemjmYWCIwtgC3b9PG8uxaTyYYbNnMJSkG2vIp8/mrzkkdFKx7d BhqSnFMwsJVjVENV4QCm8SnduVpry+RawHVH2qYSEnmeRDeDStPsQW+pf/PddOch+gW+g+ f886YIOiAdJXi8Xg4K0Akn5ZNTGfhhs= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=sjOSRuou; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf14.hostedemail.com: domain of sj@kernel.org designates 172.105.4.254 as permitted sender) smtp.mailfrom=sj@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1745254529; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=L4dOy6mKppPIa0D5XKA3477hgf7eX8vbgj+DEQUu3yg=; b=ObeO536JQ4Zg4svKZmNRVLjaCu4rH5r+feGg5n+hYPjK+vg41NZLQPZINApy91rEOCD9Ji 2WKSzKusP2uVDOTu4wX9W/AwNAUEQl4+Zf4f8UH3JgnGKxtO+hZgc1Kup/Vs81L1BwAw6y HDZYu/qTPvbeKWEFj0yXoKvkpJOTQbE= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by tor.source.kernel.org (Postfix) with ESMTP id 0215A61135; Mon, 21 Apr 2025 16:55:10 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8FB46C4CEE4; Mon, 21 Apr 2025 16:55:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1745254528; bh=vCD0XJPVvTQ7ClTvp5r9Reuax/fl3ozWdPhgvSVXChU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=sjOSRuouuzmwWgiGU8sqfl/PplfBlOdCRkzBjjNh0eOPnkuzELNP+l5eHcpDc7aEF 3sHrzCQ00Xhc4ycI/E9jkjYmGvmd72NbV9elTjzVFQxDOT60NU93ZXk2farHeElDwk ZACcCY19ZhALgsHYzwbushwbCoyOAwtX3p+VbgI7gQy5RcOlTw6Xlc8+/juf8SZOAN gShmK2pfq0Rm0DTof3b1N1xwiPvrKu6yrxx9RaKB7sJ/nXzoPwjFTNQklwWndG8qLX LqwRAgOeLH387gkg843zETlDgyVUyO0xeATgLoCW4NqS354XH2fGYiPQmbNcCDtV0x mk6HWJjqCbqsQ== From: SeongJae Park To: Enze Li Cc: SeongJae Park , akpm@linux-foundation.org, damon@lists.linux.dev, linux-mm@kvack.org Subject: Re: [PATCH] mm/damon/core: Initialize sampling_addr in damon_new_region() Date: Mon, 21 Apr 2025 09:55:25 -0700 Message-Id: <20250421165526.8517-1-sj@kernel.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250421033919.404013-1-lienze@kylinos.cn> References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspam-User: X-Rspamd-Queue-Id: 8056C100002 X-Rspamd-Server: rspam04 X-Stat-Signature: xr4415f7knag14fyog54de1rp4ky5gnn X-HE-Tag: 1745254529-106189 X-HE-Meta: U2FsdGVkX1+QsvEbcngjV153jWuktspNH3gby+qFVR4imwYCPkiM8Sir2d+brCn17dBQK1XaO1EftMIRjKFwp91sGx3nbtYctAqVzaApxpkRIK0gKotysXUGA1dJ3AUySxYCxNVJF6ufZG6Re5GyTHDodz0QDUpJggMfriCpGGtTETjU2cyr33+IKr8aToVlyHklJ2klKnNxoA9UuVVLV9bTKL1337rx8SzoLTPQfVBGhWXRWFV3s3WDWvgZKs9y4RSO9iBlBpv96/v5AzgUZ+dEA5l9Ce3twIKImNRygcmDYeNqZRNtp+IZB7/ul1MmBUUGFx7a2r0V6Tq5xq7gm8ms4aLiB/zAkozjNX3yEwwbsoALuZrbnG35yUM10pZjw8pu5gn/XSUR3Wvt2CxkSDQXGx3BVijmgwdIObycoLqGqVB9V3jAy1vEZHKabap9NnmBflRxRNO4Ub1AnoIC5yajik/3AxueDLRpN6yKZNKJzokgpdIpihz8VoFj77+QchSfngc+ZWMqCr8a12yH0EjNmvjkJhAObei+bfxkXNu2QgDDY9JfGkpj75UWI6aPRCVBvlUJd1NWQNu/sSLQbsd2cr0F2Xq1BI/xySMDHg7/6GXaWJS2b3R7t+e0ohxhmZgKfbyb1ffV9Sg/lbdJ2WdyWLb3suy3404bpX8XcQzltih/nv2NT+GXOEB/BTI3BYfmGuxgKM/zdHuZAOWwDwpZZv43mFolxJeyJHvnC+/xiBIUoTRW8gWd45P6qrYh/BZMOVaMWtq6ClNz7jj41qOIXvv0v3WpR/v5hlUXaj/lAI41iWb2U4Se8lvaDgo6Xc0nm0f3oKHTKn8rnN3/rVP3sfrCKbxiIuHxVFsCzwY3iMXRYje7sfrlKlVaj9zxEOXuHpZ5foPMGCiB696biYYW7u8GGVUu7OCmti3RB8dsPBgom2CEN4qOA5i9xEFMD/SmNh8vTqKADJ5G2lU auE2QSFE mPUrQ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, 21 Apr 2025 11:39:19 +0800 Enze Li wrote: > Since sampling_addr is used across vaddr and paddr modules, initialize > it in damon_new_region(). > > Signed-off-by: Enze Li > --- > mm/damon/core.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/mm/damon/core.c b/mm/damon/core.c > index f0c1676f0599..d197a5e3901c 100644 > --- a/mm/damon/core.c > +++ b/mm/damon/core.c > @@ -128,6 +128,7 @@ struct damon_region *damon_new_region(unsigned long start, unsigned long end) > > region->ar.start = start; > region->ar.end = end; > + region->sampling_addr = 0; > region->nr_accesses = 0; > region->nr_accesses_bp = 0; > INIT_LIST_HEAD(®ion->list); I unfortunately cannot find why this is required. Is there a use case that reads uninitialized sampling_addr or any problem that comes from the fact that damon_new_regions() is not initializing the field? Only operations set implementations write and read damon_region->sampling_addr, so I was thinking not initializing the field on the core layer is no problem. I will be happy to be corrected if I'm missing something. Thanks, SJ > > base-commit: 9d7a0577c9db35c4cc52db90bc415ea248446472 > -- > 2.43.0