From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3B4D2C369AB for ; Mon, 21 Apr 2025 16:51:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 349A56B0007; Mon, 21 Apr 2025 12:51:26 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2F6D56B0008; Mon, 21 Apr 2025 12:51:26 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1C1236B000A; Mon, 21 Apr 2025 12:51:26 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id EC9446B0007 for ; Mon, 21 Apr 2025 12:51:25 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 2B6D91607FA for ; Mon, 21 Apr 2025 16:51:27 +0000 (UTC) X-FDA: 83358641814.24.DA69760 Received: from mail-pg1-f181.google.com (mail-pg1-f181.google.com [209.85.215.181]) by imf16.hostedemail.com (Postfix) with ESMTP id 69791180004 for ; Mon, 21 Apr 2025 16:51:25 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=bOqKxghQ; spf=pass (imf16.hostedemail.com: domain of inwardvessel@gmail.com designates 209.85.215.181 as permitted sender) smtp.mailfrom=inwardvessel@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1745254285; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:references:dkim-signature; bh=/+rOR+lHDm1dZmDhSOyaB/VVBVbXjMRl4vE9TaWHktI=; b=zhsSmKg6Y8Perirn5pwbbm9FfiSQWpO/6bSqKlpPTPZ1yjKX/D2I/hJVR/7DQ3AHc8gtkS NKlfU1gGlZqIkpGT4guyCKDWUNb0KrwyH+DWGfwM1ntGbf88M0IHAKruq2Ri/I9/oWys04 Ynhjpbt4arlJOXwhfQdbrp/4iEMLdKk= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=bOqKxghQ; spf=pass (imf16.hostedemail.com: domain of inwardvessel@gmail.com designates 209.85.215.181 as permitted sender) smtp.mailfrom=inwardvessel@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1745254285; a=rsa-sha256; cv=none; b=nHdKPh/V9q+Xo0RTrxu+HRz2m773Yls5iuQghUojhvkcb9LqI0/y8m2I1CzxFrH/Cdr8/G gRmKZV4Tgs/tIg1vusq2ybcnY++e7n4LkpaN4kzgetbSI84mcQA7C6+eTjl7ucKhVTe30m lsaayvzU68B+xWqTpZ/K+A/0R7S+Txg= Received: by mail-pg1-f181.google.com with SMTP id 41be03b00d2f7-af9925bbeb7so2722778a12.3 for ; Mon, 21 Apr 2025 09:51:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1745254284; x=1745859084; darn=kvack.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=/+rOR+lHDm1dZmDhSOyaB/VVBVbXjMRl4vE9TaWHktI=; b=bOqKxghQdbtBat8dW7eT9hIgpRXGSb3CvXyKWHmuOaw7CeYTNCU7i2OrRvnzx6MH1Q uRSijJ+BYWLQRyl6Yz4CXIjrC/hv8QNSbfnWzUpYzF2DMnModkqKTvEJb2++t+R155So s64YL3GL19rvYIIjtvW9mUwzeaD+fvy8sQ/pWvvmm+9aYtOEAkcdpVQF2/H5bJKVfx8B zwRD1HhpwUGw28vYFNoDcTaWcxPiZKWVndAXd+fM9gux+9RxqmBaKSrWhMYurY7xgeYt gV7pI2dg/V3zK6xX+F6QFMlY3MLkOlKvNSdbQBJGJesbZS6zv+Mx0D0Mn57ujpw4OFHy N4fA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745254284; x=1745859084; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=/+rOR+lHDm1dZmDhSOyaB/VVBVbXjMRl4vE9TaWHktI=; b=gSa/hkEmYX6mo+OEF7Q18CjS06x65o2O9pPu2gx5TQEsbYREX2yG2JOfBXe/77vJk+ CzFYGulAZnLnvN0ZM+t/NNNrvSR9eezqwFEp7GBvVs+MA9Hj87xx8pLRpTIOphqUxpCH 2itOTG24WhT76U0A2D80iM3pqcJzTDwtyn22rFE0qNuxTCeGWjdjeW50T2ER6pET4gJc 4CDhXVbKT4VeqKwD+0ErNVmuB0iPeKdglyk+LsJ/XduIE9jCS2txgiNRwEXfAuqYLwBx yAgz52Y1/2aO2VExYgPRhXKallBqiANUbpQeuBhaGP/rvHY7p4KZJLiWPmlhAP0Xg7RP /Ezw== X-Gm-Message-State: AOJu0YxxlilJokdXBBHm0n+POC8UuSJVvmyTY7W+M4jrCCH+/oc/9yHF 2fihk45J8axMOXjA6iSVPORInbTeQs8THLpf2+deEl562u2kuZYcxhM1Vg== X-Gm-Gg: ASbGncsTduE5ZUroqv596qF0WXhenAXKZqx3TAF74BPbMP95apXMhWtB0ompOdQemQK ytSXbeKRUrTkejqVBR+uuOJh8UAM0RglCRzYgQuEmlPhRvIKPqCcUg9SVGdo4a+h1wkSzKcSvgj lZa7UMFB6lib4SS+TJBh2+yPiNStMgnjZNVcp7GWL7Xo05Gw0BUJK5PnW//6KmY+k7k/vvYwZbB uWpoQEb08NuBVqcJNf92Da381wTAMp6zfmKjDzIc8c8/cRdY+8XYs97AqlQJbf5UKeXTlVKqtQe nT1ZMrcQKfublHpHEj2VWljvnz0OJAxMTvUiiMXSlYD9Gmt0y/vuH6khjxg33IWBkybrLn7p4FF v3+M= X-Google-Smtp-Source: AGHT+IGS1bc68NfnosaRr5ityJ1PmW4j2slTAsDqqojz7WBW45NP418vk0eEonKoO76I5e5kIFH2Iw== X-Received: by 2002:a17:902:e5cf:b0:21f:2ded:76ea with SMTP id d9443c01a7336-22c5360dca6mr184886245ad.36.1745254284161; Mon, 21 Apr 2025 09:51:24 -0700 (PDT) Received: from jpkobryn-fedora-PF5CFKNC.thefacebook.com ([2620:10d:c090:500::6:17e0]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-22c50bf1371sm67782375ad.57.2025.04.21.09.51.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 21 Apr 2025 09:51:23 -0700 (PDT) From: JP Kobryn To: tj@kernel.org, shakeel.butt@linux.dev, yosryahmed@google.com, mkoutny@suse.com, hannes@cmpxchg.org, akpm@linux-foundation.org Cc: linux-mm@kvack.org, cgroups@vger.kernel.org Subject: [PATCH] cgroup: fix pointer check in css_rstat_init() Date: Mon, 21 Apr 2025 09:51:17 -0700 Message-ID: <20250421165117.30975-1-inwardvessel@gmail.com> X-Mailer: git-send-email 2.49.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspam-User: X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 69791180004 X-Stat-Signature: 3bxu77ehssern3ujmcwbjbqdwamws37u X-HE-Tag: 1745254285-333462 X-HE-Meta: U2FsdGVkX1/FUeB+0l4nfbVe3DsYxQwos+14GkK1V0xmUmXbEhJD5IAPkyhYCCsiADdm/tY0mwq1DlozGJxHXG13aoPGOKVYMpHzJjJrgV6bbzAjmevdqGT5Lo9/0fr/gfOhXcMsNrE5GmTDJMC3wLXFSW3dWa3vvG8c4aMkoU8Mpo7Yknbt+AELoQHdVskXxaLc9Kk7j/i0RAFrdBufVnQdbe0xfIog5yMV1LwhWijGKgq7B7AKDcKp26I2pJJNfkWfysi4nTebafiDs+EFq8z0+YCX44pSY2VL6qxcswf3KfNiCLfm4+cNBju+LqtcneBZ9rYGEQYAHreKRUPwNYLETqf3uboNip2phh1e38BPWyBnum9VyrAPBZqYcbRdr9vwnSwNZouGzdUcXm+ClE3TgoiJ9VKAVc9l5nYl0I+v5Vlx2pxhV9qlhgU2ENxeHVm+hLP+9R/8xcKQJj7CfPgPNT9VoXn13jpzMW9dUw4J0mATNyPyvvC+GGpEdAAupbT7nNiamWkGpkNfTUjpbaD4HnZjfnGm0XTaTDn2apept8eouCcp3mZHqPBJWszgVaLsgBK+yxNK87djnRQjsmyY8RGM5j/rsu1aLcjTKoIe0EyjyfZraCByzAvvw9s+GOKNA4UW07V5sx7SEOx0bUdkPNU1SoURAlZsw7pKzy4z5+r0mrcOWqS7i16JdsyugD4TxCFT1s4wUg1eIiaqWBfzNOpklnZJiyoLHSw0IuZ0OZzSK+0aXYpUTj3BEco+lhVl2sA3ljgwQbBWGTpbhZaOh5juc2UXVztOAB3x3y9IffSrVJ1Y9lZUJUn88yp3pWU7pZ80fFYGEfbloV85DCald9VCa6KLAfHKuYZlOmP/nB6A6TRewrcREQTv6/DXFWy+BOMnCk/JrDVEc6ZzGLW9Ok8Ao0mQy4ux1A81FEKXxOTM8wb8hb04Yx+fJ1mtwVuIRFLElRPEntdY+Nh AcNcc1dM s47PUThEAEnDlXJ/o7oXCSt/QcZ0qsMFWZGoeLllwtLQt162t8G57bcSUl34Xl3E/dpe6rGfa/ifgsSzqYl6EWGCh4KVF9d61nnNhSZCRJfxoUsHA1IaK1K+AEmJIIjkX+HhNgI7GGRLu1DYf90p+u78NRRZddVUl7+7hcyyexZfLtC3DI5U9Q3sFTO6CprBmHSLFq2shrTdujLXIq13DYhHRtfF99NN7eTM42P2UshymmAdGbxmRSnVXtWIxZplnVUFmewdr9LYWQ9fMpt+QmZElbZxM1yU0cMYpduQ9MqPXR98afrthuCxffTqa5MbvChNbJ7CDxExCV22HM0NU9KHtpVrOdLnZ5HzW1NwO5zDuRQzqgjOhMwo6QoKcJlmllsJVXI+9pQoL2X49AXOuLdsXYVEchQMNkCdx1jFC4cthilE= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: In css_rstat_init() allocations are done for the cgroup's pointers rstat_cpu and rstat_base_cpu. Make sure the allocation checks are consistent with what they are allocating. Signed-off-by: JP Kobryn --- kernel/cgroup/rstat.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/cgroup/rstat.c b/kernel/cgroup/rstat.c index 4a8834a70ca6..4d5fd8d12bdd 100644 --- a/kernel/cgroup/rstat.c +++ b/kernel/cgroup/rstat.c @@ -371,7 +371,7 @@ int css_rstat_init(struct cgroup_subsys_state *css) if (!cgrp->rstat_base_cpu) { cgrp->rstat_base_cpu = alloc_percpu(struct cgroup_rstat_base_cpu); - if (!cgrp->rstat_cpu) { + if (!cgrp->rstat_base_cpu) { free_percpu(cgrp->rstat_cpu); return -ENOMEM; } -- 2.47.1