From: Andrew Morton <akpm@linux-foundation.org>
To: Ye Liu <ye.liu@linux.dev>
Cc: linux-debuggers@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-mm@kvack.org, linux-toolchains@vger.kernel.org,
osandov@osandov.com, paulmck@kernel.org,
sweettea-kernel@dorminy.me, liuye@kylinos.cn
Subject: Re: [PATCH v2] tools/mm: Add script to display page state for a given PID and VADDR
Date: Mon, 21 Apr 2025 12:13:04 -0700 [thread overview]
Message-ID: <20250421121304.8504ae5839e490450029f113@linux-foundation.org> (raw)
In-Reply-To: <20250421080748.114750-1-ye.liu@linux.dev>
On Mon, 21 Apr 2025 16:07:48 +0800 Ye Liu <ye.liu@linux.dev> wrote:
> Output example:
The spacing around the colons is inconsistent and a bit odd, IMO.
> sudo ./show_page_info.py 1 0x7f2c7de4c000
> PID : 1 Comm : systemd mm : 0xffff888116b6d440
PID: 1 Comm: systemd mm: 0xffff888116b6d440
would be more conventional. Or
PID:1 Comm:systemd mm:0xffff888116b6d440
> User Virtual Address : 0x7f2c7de4c000
> Page Address : 0xffffea000b3a4000
> raw: 0017ffffc000416c ffffea00045d1b08 ffffea000456d408 ffff888104521970
> raw: 0000000000000000 ffff8881083fdb60 0000006900000018 ffff888107a41000
> Page Flags : PG_referenced|PG_uptodate|PG_lru|PG_head|PG_active|
> PG_private|PG_reported
> Page Size : 16384
> Page PFN : 0x2ce900
> Page Physical : 0x2ce900000
> Page Virtual : 0xffff8882ce900000
> Page Refcount : 105
> Page Mapcount : 24
> Page Index : 0x0
> Page Memcg Data : 0xffff888107a41000
> Memcg Name : init.scope
> Memcg Path : /sys/fs/cgroup/memory/init.scope
> Page Mapping : 0xffff888104521970
> Page Anon/File : File
> Page VMA : 0xffff888109e135e8
> VMA Start : 0x7f2c7de4c000
> VMA End : 0x7f2c7de58000
> This page is part of a compound page.
> This page is the head page of a compound page.
> Head Page : 0xffffea000b3a4000
> Compound Order : 2
> Number of Pages : 4
I think the style of /proc/meminfo (for example) would be more expected.
prev parent reply other threads:[~2025-04-21 19:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-21 8:07 Ye Liu
2025-04-21 19:13 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250421121304.8504ae5839e490450029f113@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=linux-debuggers@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-toolchains@vger.kernel.org \
--cc=liuye@kylinos.cn \
--cc=osandov@osandov.com \
--cc=paulmck@kernel.org \
--cc=sweettea-kernel@dorminy.me \
--cc=ye.liu@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox